There is a spelling mistake in a nvdev_error error message. Fix it.
Signed-off-by: Colin Ian King
---
drivers/gpu/drm/nouveau/nvkm/engine/device/base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/device/base.c
b/drivers/gpu/drm
There is a statement with two semicolons. Remove the second one, it
is redundant.
Signed-off-by: Colin Ian King
---
drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
b/drivers/gpu
The mutex field has two following semicolons, replace this with just
one semicolon.
Signed-off-by: Colin Ian King
---
drivers/gpu/drm/nouveau/include/nvkm/subdev/gsp.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/include/nvkm/subdev/gsp.h
b
ping?
On 25/11/2018 17:09, Colin King wrote:
> From: Colin Ian King
>
> Currently, the expression for calculating RON is always going to result
> in zero no matter the value of ram->mr[1] because the ! operator has
> higher precedence than the shift >> operator
ping?
On 19/12/2018 15:29, Colin King wrote:
> From: Colin Ian King
>
> Currently the uninitialized values in the array reply are printed out
> when exec is false and nvkm_pmu_send has not updated the array. Avoid
> confusion by only dumping out these values if they have been act
ping?
On 04/09/2018 16:23, Colin King wrote:
> From: Colin Ian King
>
> Don't populate the array vsoff on the stack but instead make it
> static. Makes the object code smaller by 67 bytes:
>
> Before:
>text data bss dec hex filename
>
Hi,
Static Analysis with CoverityScan as detected an issue with the setting
of the RON pull value in function nvkm_gddr3_calc in
drm/nouveau/bios/ramcfg.c
This was introduced by commit: c25bf7b6155cb ("drm/nouveau/bios/ramcfg:
Separate out RON pull value")
CoverityScan reports the issue as follo
es on this.
Colin
>
> 2016-06-02 12:28 GMT+02:00 Colin King :
>> From: Colin Ian King
>>
>> The default sensor->type case leaks memory allocated to rail. Fix
>> this by free'ing rail before we continue with the next loop iteration.
>>
>> Signed-
On 17/08/17 13:21, Emil Velikov wrote:
> On 17 August 2017 at 11:37, Colin King wrote:
>> From: Colin Ian King
>>
>> The check to see if mstm->msto is null is redundant because it is
>> an array and hence can never be null. Remove the redundant check.
>>
>
On 17/08/17 23:07, Ilia Mirkin wrote:
> On Thu, Aug 17, 2017 at 6:03 PM, Colin King wrote:
>> From: Colin Ian King
>>
>> The null check on the array msto is incorrect since msto is never
>> null. The null check should be instead on msto[i] since this is
>>
Don't populate the read-only array on the stack, instead make it static
const.
Signed-off-by: Colin Ian King
---
drivers/gpu/drm/nouveau/nvkm/subdev/bios/therm.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/therm.c
b/dr
:93:17: warning: Opposite
inner 'if' condition leads to a dead code block. [oppositeInnerCondition]
Fixes: e4311ee51d1e ("drm/nouveau/therm: remove ineffective workarounds for
alarm bugs")
Signed-off-by: Colin Ian King
---
drivers/gpu/drm/nouveau/nvkm/subdev/therm/fan.c | 2 -
read from 'ret'
[deadcode.DeadStores]
Signed-off-by: Colin Ian King
---
drivers/gpu/drm/nouveau/nvif/fifo.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvif/fifo.c
b/drivers/gpu/drm/nouveau/nvif/fifo.c
index a463289962b2..e96de14ce87e
u/gsp: support deeper page tables in
COPY_SERVER_RESERVED_PDES")
Signed-off-by: Colin Ian King
---
drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/vmm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/vmm.c
b/drivers/gpu/d
14 matches
Mail list logo
