[PATCH v2][next] drm/nouveau: fifo: Avoid -Wflex-array-member-not-at-end warning

2025-04-04 Thread Gustavo A. R. Silva
-Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally. Adjust heap allocation to account for the flex-array-in-the-middle issue, and refactor the rest of the code accordingly. So, with these changes, fix the following warning: drivers/gpu/drm/no

Re: [PATCH v2] drm/nouveau: Prevent signalled fences in pending list

2025-04-04 Thread Christian König
Am 03.04.25 um 16:40 schrieb Philipp Stanner: >     That looks like a really really awkward approach. The driver basically uses a the DMA fence infrastructure as middle layer and callbacks into itself to cleanup it's own structures.   >>>   >>> What else are callbacks g

Re: [PATCH][next] drm/nouveau: fifo: Avoid -Wflex-array-member-not-at-end warning

2025-04-04 Thread Gustavo A. R. Silva
On 03/04/25 11:41, Gustavo A. R. Silva wrote: -Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally. Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of a flexible structure where the size of the flexible-array member is known at

Re: [PATCH v2] drm/nouveau: Prevent signalled fences in pending list

2025-04-04 Thread Danilo Krummrich
On Thu, Apr 03, 2025 at 12:17:29PM +0200, Philipp Stanner wrote: > On Thu, 2025-04-03 at 12:13 +0200, Philipp Stanner wrote: > > -static int > > -nouveau_fence_signal(struct nouveau_fence *fence) > > +static void > > +nouveau_fence_cleanup_cb(struct dma_fence *dfence, struct > > dma_fence_cb *cb) >

Re: Memory leaks from r535_gsp_oneinit()

2025-04-04 Thread Philipp Stanner
On Fri, 2025-03-21 at 09:56 +0100, Philipp Stanner wrote: > I see two small memory leaks on a Fedora 41 desktop with a custom > built > kernel @ commit: > > 27d4815149ba drm/sched: Group exported prototypes by object type > > GPU is an RTX 5000 Ada > > The leaks are there immediately after booti

Re: [PATCH 2/2] drm/nouveau: DRM_NOUVEAU_SET_ZCULL_CTXSW_BUFFER

2025-04-04 Thread Danilo Krummrich
On Wed, Mar 12, 2025 at 05:36:15PM -0400, Mel Henning wrote: > diff --git a/include/uapi/drm/nouveau_drm.h b/include/uapi/drm/nouveau_drm.h Same here, please split the uAPI change in a separate commit. > index 33361784eb4e..e9638f4dd7e6 100644 > --- a/include/uapi/drm/nouveau_drm.h > +++ b/includ

Re: [PATCH v2] drm/nouveau: Prevent signalled fences in pending list

2025-04-04 Thread Danilo Krummrich
On Thu, Apr 03, 2025 at 02:22:41PM +0200, Christian König wrote: > Am 03.04.25 um 12:25 schrieb Danilo Krummrich: > > On Thu, Apr 03, 2025 at 12:17:29PM +0200, Philipp Stanner wrote: > >> On Thu, 2025-04-03 at 12:13 +0200, Philipp Stanner wrote: > >>> -static int > >>> -nouveau_fence_signal(struct