Re: [PATCH v2][next] drm/nouveau: disp: Avoid -Wflex-array-member-not-at-end warning

2025-04-03 Thread Danilo Krummrich
On Wed, Apr 02, 2025 at 03:58:59PM -0600, Gustavo A. R. Silva wrote: > -Wflex-array-member-not-at-end was introduced in GCC-14, and we are > getting ready to enable it, globally. > > Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of > a flexible structure where the size of the flexi

Re: [PATCH v2][next] drm/nouveau: disp: Avoid -Wflex-array-member-not-at-end warning

2025-04-03 Thread Gustavo A. R. Silva
Applied this one (as well as the svm and fence one) to drm-misc-next, thanks! Awesome. :) Thanks! -- Gustavo

[PATCH][next] drm/nouveau: fifo: Avoid -Wflex-array-member-not-at-end warning

2025-04-03 Thread Gustavo A. R. Silva
-Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally. Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of a flexible structure where the size of the flexible-array member is known at compile-time, and refactor the rest of the code, a

[PATCH][next] drm/nouveau: chan: Avoid -Wflex-array-member-not-at-end warnings

2025-04-03 Thread Gustavo A. R. Silva
-Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally. Use the `DEFINE_RAW_FLEX()` helper for a few on-stack definitions of a flexible structure where the size of the flexible-array member is known at compile-time, and refactor the rest of the cod

[PATCH v2] drm/nouveau: Prevent signalled fences in pending list

2025-04-03 Thread Philipp Stanner
Nouveau currently relies on the assumption that dma_fences will only ever get signalled through nouveau_fence_signal(), which takes care of removing a signalled fence from the list nouveau_fence_chan.pending. This self-imposed rule is violated in nouveau_fence_done(), where dma_fence_is_signaled()

Re: [PATCH v2] drm/nouveau: Prevent signalled fences in pending list

2025-04-03 Thread Christian König
Am 03.04.25 um 14:58 schrieb Philipp Stanner: > On Thu, 2025-04-03 at 14:08 +0200, Christian König wrote: >> Am 03.04.25 um 12:13 schrieb Philipp Stanner: >>> Nouveau currently relies on the assumption that dma_fences will >>> only >>> ever get signalled through nouveau_fence_signal(), which takes

Re: [PATCH v2] drm/nouveau: Prevent signalled fences in pending list

2025-04-03 Thread Christian König
Am 03.04.25 um 12:25 schrieb Danilo Krummrich: > On Thu, Apr 03, 2025 at 12:17:29PM +0200, Philipp Stanner wrote: >> On Thu, 2025-04-03 at 12:13 +0200, Philipp Stanner wrote: >>> -static int >>> -nouveau_fence_signal(struct nouveau_fence *fence) >>> +static void >>> +nouveau_fence_cleanup_cb(struct

Re: [PATCH v2] drm/nouveau: Prevent signalled fences in pending list

2025-04-03 Thread Christian König
Am 03.04.25 um 15:15 schrieb Danilo Krummrich: > On Thu, Apr 03, 2025 at 02:58:13PM +0200, Philipp Stanner wrote: >> On Thu, 2025-04-03 at 14:08 +0200, Christian König wrote: >>> Am 03.04.25 um 12:13 schrieb Philipp Stanner: >>> BTW: nouveau_fence_no_signaling() looks completely broken as well. It

Re: [PATCH v2] drm/nouveau: Prevent signalled fences in pending list

2025-04-03 Thread Christian König
Am 03.04.25 um 12:13 schrieb Philipp Stanner: > Nouveau currently relies on the assumption that dma_fences will only > ever get signalled through nouveau_fence_signal(), which takes care of > removing a signalled fence from the list nouveau_fence_chan.pending. > > This self-imposed rule is violated

Re: [PATCH v2] drm/nouveau: Prevent signalled fences in pending list

2025-04-03 Thread Danilo Krummrich
On Thu, Apr 03, 2025 at 02:58:13PM +0200, Philipp Stanner wrote: > On Thu, 2025-04-03 at 14:08 +0200, Christian König wrote: > > Am 03.04.25 um 12:13 schrieb Philipp Stanner: > > > BTW: nouveau_fence_no_signaling() looks completely broken as well. It > > calls nouveau_fence_is_signaled() and then