Re: [PATCH 1/2] drm/nouveau: Add DRM_IOCTL_NOUVEAU_GET_ZCULL_INFO

2025-03-27 Thread Danilo Krummrich
On Tue, Mar 25, 2025 at 07:40:56PM -0400, M Henning wrote: > Okay, that sounds reasonable since I don't expect this to change very quickly. > > Since I don't fully understand, is the suggestion here to: > 1) add the interface as a function on nvkm_gr using the nvkm_gr_func > vtable and store the a

Re: [PATCH] drm/nouveau: Prevent signalled fences in pending list

2025-03-27 Thread Christian König
Am 27.03.25 um 09:42 schrieb Philipp Stanner: > Nouveau currently relies on the assumption that dma_fences will only > ever get signalled through nouveau_fence_signal(), which takes care of > removing a signalled fence from the list nouveau_fence_chan.pending. > > This self-imposed rule is violated

Re: [PATCH 1/2] drm/nouveau: Add DRM_IOCTL_NOUVEAU_GET_ZCULL_INFO

2025-03-27 Thread Danilo Krummrich
On Fri, Mar 21, 2025 at 06:06:34PM -0400, M Henning wrote: > On Thu, Mar 20, 2025 at 2:18 PM Danilo Krummrich wrote: > > On Wed, Mar 12, 2025 at 05:36:14PM -0400, Mel Henning wrote: > > > + __u32 width_align_pixels; > > > + __u32 height_align_pixels; > > > + __u32 pixel_squares_by_aliq

Re: [PATCH 2/2] drm/nouveau: DRM_NOUVEAU_SET_ZCULL_CTXSW_BUFFER

2025-03-27 Thread Danilo Krummrich
On Fri, Mar 21, 2025 at 07:00:57PM -0400, M Henning wrote: > This is a pointer in the gpu's virtual address space. It must be > aligned according to ctxsw_align and be at least ctxsw_size bytes > (where those values come from the nouveau_abi16_ioctl_get_zcull_info > structure). I'll change the desc

[PATCH] drm/nouveau: Prevent signalled fences in pending list

2025-03-27 Thread Philipp Stanner
Nouveau currently relies on the assumption that dma_fences will only ever get signalled through nouveau_fence_signal(), which takes care of removing a signalled fence from the list nouveau_fence_chan.pending. This self-imposed rule is violated in nouveau_fence_done(), where dma_fence_is_signaled()

Re: [PATCH] drm/nouveau: Prevent signalled fences in pending list

2025-03-27 Thread Danilo Krummrich
On Thu, Mar 27, 2025 at 09:56:01AM +0100, Christian König wrote: > Am 27.03.25 um 09:42 schrieb Philipp Stanner: > > Nouveau currently relies on the assumption that dma_fences will only > > ever get signalled through nouveau_fence_signal(), which takes care of > > removing a signalled fence from th

Re: [PATCH 1/2] drm/nouveau: Add DRM_IOCTL_NOUVEAU_GET_ZCULL_INFO

2025-03-27 Thread M Henning
On Thu, Mar 27, 2025 at 8:56 AM Danilo Krummrich wrote: > > On Tue, Mar 25, 2025 at 07:40:56PM -0400, M Henning wrote: > > Okay, that sounds reasonable since I don't expect this to change very > > quickly. > > > > Since I don't fully understand, is the suggestion here to: > > 1) add the interface

Re: [PATCH 2/2] drm/nouveau: DRM_NOUVEAU_SET_ZCULL_CTXSW_BUFFER

2025-03-27 Thread M Henning
On Thu, Mar 27, 2025 at 9:58 AM Danilo Krummrich wrote: > > On Fri, Mar 21, 2025 at 07:00:57PM -0400, M Henning wrote: > > This is a pointer in the gpu's virtual address space. It must be > > aligned according to ctxsw_align and be at least ctxsw_size bytes > > (where those values come from the no