Re: [PATCH 2/2] drm/nouveau: Don't signal when killing the fence context

2025-05-22 Thread Christian König
On 5/22/25 15:16, Philipp Stanner wrote: > On Thu, 2025-05-22 at 15:09 +0200, Christian König wrote: >> On 5/22/25 14:59, Danilo Krummrich wrote: >>> On Thu, May 22, 2025 at 02:34:33PM +0200, Christian König wrote: See all the functions inside include/linux/dma-fence.h can be used by ever

Re: [PATCH 2/2] drm/nouveau: Don't signal when killing the fence context

2025-05-22 Thread Christian König
On 5/22/25 15:50, Danilo Krummrich wrote: > On Thu, May 22, 2025 at 03:05:02PM +0200, Christian König wrote: >> E.g. when you don't know the implementation side use the defined API and >> don't mess with the internals. If you do know the implementation side then >> it's valid that you check the i

Re: [PATCH 2/2] drm/nouveau: Don't signal when killing the fence context

2025-05-22 Thread Christian König
On 5/22/25 15:43, Philipp Stanner wrote: >> >> Well there is no need to implement it, but when it is implemented the >> caller *must* call it when polling. > > I don't understand. Please elaborate on that a bit more. If there's no > need to implement it, then why can't one have a > __dma_fence_is_

Re: [PATCH 2/2] drm/nouveau: Don't signal when killing the fence context

2025-05-22 Thread Danilo Krummrich
On Thu, May 22, 2025 at 03:05:02PM +0200, Christian König wrote: > E.g. when you don't know the implementation side use the defined API and > don't mess with the internals. If you do know the implementation side then > it's valid that you check the internals. I assume you meant this as "botherin

Re: [PATCH 2/2] drm/nouveau: Don't signal when killing the fence context

2025-05-22 Thread Danilo Krummrich
On Thu, May 22, 2025 at 03:09:49PM +0200, Christian König wrote: > On 5/22/25 14:59, Danilo Krummrich wrote: > > On Thu, May 22, 2025 at 02:34:33PM +0200, Christian König wrote: > >> See all the functions inside include/linux/dma-fence.h can be used by > >> everybody. It's basically the public int

Re: [PATCH 2/2] drm/nouveau: Don't signal when killing the fence context

2025-05-22 Thread Christian König
On 5/22/25 14:57, Tvrtko Ursulin wrote: > > On 22/05/2025 13:34, Christian König wrote: >> On 5/22/25 14:20, Philipp Stanner wrote: >>> On Thu, 2025-05-22 at 14:06 +0200, Christian König wrote: On 5/22/25 13:25, Philipp Stanner wrote: > dma_fence_is_signaled_locked(), which is used in >>>

Re: [PATCH 2/2] drm/nouveau: Don't signal when killing the fence context

2025-05-22 Thread Christian König
On 5/22/25 14:59, Danilo Krummrich wrote: > On Thu, May 22, 2025 at 02:34:33PM +0200, Christian König wrote: >> See all the functions inside include/linux/dma-fence.h can be used by >> everybody. It's basically the public interface of the dma_fence object. > > As you write below, in certain cases

Re: [PATCH 2/2] drm/nouveau: Don't signal when killing the fence context

2025-05-22 Thread Christian König
On 5/22/25 14:42, Philipp Stanner wrote: > On Thu, 2025-05-22 at 14:34 +0200, Christian König wrote: >> On 5/22/25 14:20, Philipp Stanner wrote: >>> On Thu, 2025-05-22 at 14:06 +0200, Christian König wrote: On 5/22/25 13:25, Philipp Stanner wrote: > dma_fence_is_signaled_locked(), which is

Re: [PATCH 2/2] drm/nouveau: Don't signal when killing the fence context

2025-05-22 Thread Danilo Krummrich
On Thu, May 22, 2025 at 02:34:33PM +0200, Christian König wrote: > See all the functions inside include/linux/dma-fence.h can be used by > everybody. It's basically the public interface of the dma_fence object. As you write below, in certain cases it is valid to call this from drivers, so it's no

Re: [PATCH 2/2] drm/nouveau: Don't signal when killing the fence context

2025-05-22 Thread Christian König
On 5/22/25 14:20, Philipp Stanner wrote: > On Thu, 2025-05-22 at 14:06 +0200, Christian König wrote: >> On 5/22/25 13:25, Philipp Stanner wrote: >>> dma_fence_is_signaled_locked(), which is used in >>> nouveau_fence_context_kill(), can signal fences below the surface >>> through a callback. >>> >>>

Re: [PATCH 2/2] drm/nouveau: Don't signal when killing the fence context

2025-05-22 Thread Christian König
On 5/22/25 13:25, Philipp Stanner wrote: > dma_fence_is_signaled_locked(), which is used in > nouveau_fence_context_kill(), can signal fences below the surface > through a callback. > > There is neither need for nor use in doing that when killing a fence > context. > > Replace dma_fence_is_signal