Re: [PATCH] nouveau/fence: handle cross device fences properly. (v3)

2025-01-13 Thread Danilo Krummrich
On 09.01.2025 17:58, Danilo Krummrich wrote: > On Thu, Jan 09, 2025 at 10:55:53AM +1000, Dave Airlie wrote: >> From: Dave Airlie >> >> This is the 3rd iteration of this after talking to Ben and >> Danilo, I think this makes sense now. >> >> The fence sync logic doesn't handle a fence sync across

Re: [PATCH] nouveau/fence: handle cross device fences properly. (v3)

2025-01-09 Thread kernel test robot
Hi Dave, kernel test robot noticed the following build errors: [auto build test ERROR on linus/master] [also build test ERROR on drm-misc/drm-misc-next drm-tip/drm-tip v6.13-rc6 next-20250109] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we s

Re: [PATCH] nouveau/fence: handle cross device fences properly. (v3)

2025-01-09 Thread Danilo Krummrich
On Thu, Jan 09, 2025 at 10:55:53AM +1000, Dave Airlie wrote: > From: Dave Airlie > > This is the 3rd iteration of this after talking to Ben and > Danilo, I think this makes sense now. > > The fence sync logic doesn't handle a fence sync across devices > as it tries to write to a channel offset f

Re: [PATCH] nouveau/fence: handle cross device fences properly. (v3)

2025-01-08 Thread Ben Skeggs
On 9/1/25 13:42, Ben Skeggs wrote: On 9/1/25 10:55, Dave Airlie wrote: From: Dave Airlie This is the 3rd iteration of this after talking to Ben and Danilo, I think this makes sense now. The fence sync logic doesn't handle a fence sync across devices as it tries to write to a channel offset

Re: [PATCH] nouveau/fence: handle cross device fences properly. (v3)

2025-01-08 Thread Ben Skeggs
On 9/1/25 10:55, Dave Airlie wrote: From: Dave Airlie This is the 3rd iteration of this after talking to Ben and Danilo, I think this makes sense now. The fence sync logic doesn't handle a fence sync across devices as it tries to write to a channel offset from one device into the fence bo fro

Re: [PATCH] nouveau/fence: handle cross device fences properly.

2025-01-07 Thread Danilo Krummrich
On Wed, Jan 08, 2025 at 11:04:21AM +1000, Dave Airlie wrote: > On Wed, 8 Jan 2025 at 02:02, Danilo Krummrich wrote: > > > > On Tue, Jan 07, 2025 at 03:58:46PM +1000, Dave Airlie wrote: > > > From: Dave Airlie > > > > > > If we have two nouveau controlled devices and one passes a dma-fence > > > t

Re: [PATCH] nouveau/fence: handle cross device fences properly.

2025-01-07 Thread Ben Skeggs
On 8/1/25 11:04, Dave Airlie wrote: On Wed, 8 Jan 2025 at 02:02, Danilo Krummrich wrote: On Tue, Jan 07, 2025 at 03:58:46PM +1000, Dave Airlie wrote: From: Dave Airlie If we have two nouveau controlled devices and one passes a dma-fence to the other, when we hit the sync path it can cause t

Re: [PATCH] nouveau/fence: handle cross device fences properly.

2025-01-07 Thread Dave Airlie
On Wed, 8 Jan 2025 at 02:02, Danilo Krummrich wrote: > > On Tue, Jan 07, 2025 at 03:58:46PM +1000, Dave Airlie wrote: > > From: Dave Airlie > > > > If we have two nouveau controlled devices and one passes a dma-fence > > to the other, when we hit the sync path it can cause the second device > > t

Re: [PATCH] nouveau/fence: handle cross device fences properly.

2025-01-07 Thread Danilo Krummrich
On Tue, Jan 07, 2025 at 03:58:46PM +1000, Dave Airlie wrote: > From: Dave Airlie > > If we have two nouveau controlled devices and one passes a dma-fence > to the other, when we hit the sync path it can cause the second device > to try and put a sync wait in it's pushbuf for the seqno of the cont