Re: [PATCH v3 02/25] drm/dumb-buffers: Provide helper to set pitch and size

On Fri, Mar 07, 2025 at 09:42:25AM +0100, Simona Vetter wrote: > On Tue, Feb 18, 2025 at 03:23:25PM +0100, Thomas Zimmermann wrote: > > Add drm_modes_size_dumb(), a helper to calculate the dumb-buffer > > scanline pitch and allocation size. Implementations of struct > > drm_driver.dumb_create can c

Re: [PATCH v3 02/25] drm/dumb-buffers: Provide helper to set pitch and size

On Tue, Feb 18, 2025 at 03:23:25PM +0100, Thomas Zimmermann wrote: > Add drm_modes_size_dumb(), a helper to calculate the dumb-buffer > scanline pitch and allocation size. Implementations of struct > drm_driver.dumb_create can call the new helper for their size > computations. > > There is current

Re: [PATCH v3 02/25] drm/dumb-buffers: Provide helper to set pitch and size

Hi Am 25.02.25 um 14:45 schrieb Tomi Valkeinen: Hi, On 21/02/2025 11:19, Thomas Zimmermann wrote: Hi Am 20.02.25 um 11:53 schrieb Tomi Valkeinen: Hi, On 20/02/2025 12:05, Thomas Zimmermann wrote: Hi Am 20.02.25 um 10:18 schrieb Tomi Valkeinen: [...] + * Color modes of 10, 12, 15, 30 and 6

Re: [PATCH v3 02/25] drm/dumb-buffers: Provide helper to set pitch and size

Hi, On 21/02/2025 11:19, Thomas Zimmermann wrote: Hi Am 20.02.25 um 11:53 schrieb Tomi Valkeinen: Hi, On 20/02/2025 12:05, Thomas Zimmermann wrote: Hi Am 20.02.25 um 10:18 schrieb Tomi Valkeinen: [...] + * Color modes of 10, 12, 15, 30 and 64 are only supported for use by + * legacy user s

Re: [PATCH v3 02/25] drm/dumb-buffers: Provide helper to set pitch and size

Hi Am 21.02.25 um 10:57 schrieb Geert Uytterhoeven: Hi Thomas, On Fri, 21 Feb 2025 at 10:19, Thomas Zimmermann wrote: Am 20.02.25 um 11:53 schrieb Tomi Valkeinen: This change also first calls the drm_driver_color_mode_format(), which could change the behavior even more, but afaics at the mom

Re: [PATCH v3 02/25] drm/dumb-buffers: Provide helper to set pitch and size

Hi Thomas, On Fri, 21 Feb 2025 at 10:19, Thomas Zimmermann wrote: > Am 20.02.25 um 11:53 schrieb Tomi Valkeinen: > > This change also first calls the drm_driver_color_mode_format(), which > > could change the behavior even more, but afaics at the moment does not. > > Because currently each driver

Re: [PATCH v3 02/25] drm/dumb-buffers: Provide helper to set pitch and size

Hi Am 20.02.25 um 11:53 schrieb Tomi Valkeinen: Hi, On 20/02/2025 12:05, Thomas Zimmermann wrote: Hi Am 20.02.25 um 10:18 schrieb Tomi Valkeinen: [...] + * Color modes of 10, 12, 15, 30 and 64 are only supported for use by + * legacy user space. Please don't use them in new code. Other modes

Re: [PATCH v3 02/25] drm/dumb-buffers: Provide helper to set pitch and size

Hi, On 20/02/2025 12:05, Thomas Zimmermann wrote: Hi Am 20.02.25 um 10:18 schrieb Tomi Valkeinen: [...] + * Color modes of 10, 12, 15, 30 and 64 are only supported for use by + * legacy user space. Please don't use them in new code. Other modes + * are not support. + * + * Do not attempt to al

Re: [PATCH v3 02/25] drm/dumb-buffers: Provide helper to set pitch and size

Hi Am 20.02.25 um 10:18 schrieb Tomi Valkeinen: [...] + * Color modes of 10, 12, 15, 30 and 64 are only supported for use by + * legacy user space. Please don't use them in new code. Other modes + * are not support. + * + * Do not attempt to allocate anything but linear framebuffer memory + * wi

Re: [PATCH v3 02/25] drm/dumb-buffers: Provide helper to set pitch and size

Hi, On 18/02/2025 16:23, Thomas Zimmermann wrote: Add drm_modes_size_dumb(), a helper to calculate the dumb-buffer scanline pitch and allocation size. Implementations of struct drm_driver.dumb_create can call the new helper for their size computations. There is currently quite a bit of code dup

Re: [PATCH v3 02/25] drm/dumb-buffers: Provide helper to set pitch and size

Hi Am 18.02.25 um 20:32 schrieb Geert Uytterhoeven: [...] +args->bpp); + fallthrough; + case 12: + case 15: + case 30: /* see drm_gem_afbc_get_bpp() */ + case 10: Perhaps keep them sort

Re: [PATCH v3 02/25] drm/dumb-buffers: Provide helper to set pitch and size

Hi Thomas, On Tue, 18 Feb 2025 at 15:26, Thomas Zimmermann wrote: > Add drm_modes_size_dumb(), a helper to calculate the dumb-buffer > scanline pitch and allocation size. Implementations of struct > drm_driver.dumb_create can call the new helper for their size > computations. > > There is current

[PATCH v3 02/25] drm/dumb-buffers: Provide helper to set pitch and size

Add drm_modes_size_dumb(), a helper to calculate the dumb-buffer scanline pitch and allocation size. Implementations of struct drm_driver.dumb_create can call the new helper for their size computations. There is currently quite a bit of code duplication among DRM's memory managers. Each calculates