Re: [PATCH 1/2] drm/nouveau: Add DRM_IOCTL_NOUVEAU_GET_ZCULL_INFO

2025-04-05 Thread M Henning
On Thu, Mar 27, 2025 at 9:51 AM Danilo Krummrich wrote: > > On Fri, Mar 21, 2025 at 06:06:34PM -0400, M Henning wrote: > > On Thu, Mar 20, 2025 at 2:18 PM Danilo Krummrich wrote: > > > On Wed, Mar 12, 2025 at 05:36:14PM -0400, Mel Henning wrote: > > > > + __u32 width_align_pixels; > > > > +

Re: [PATCH 1/2] drm/nouveau: Add DRM_IOCTL_NOUVEAU_GET_ZCULL_INFO

2025-03-28 Thread Danilo Krummrich
Hi Mel, On Wed, Mar 12, 2025 at 05:36:14PM -0400, Mel Henning wrote: > Userspace needs this information to set up zcull correctly. This is a very brief motivation for the commit, please also describe what the commit does using imperative form. > > Signed-off-by: Mel Henning > --- > .../drm/no

Re: [PATCH 1/2] drm/nouveau: Add DRM_IOCTL_NOUVEAU_GET_ZCULL_INFO

2025-03-28 Thread Ben Skeggs
On 21/3/25 04:18, Danilo Krummrich wrote: Hi Mel, On Wed, Mar 12, 2025 at 05:36:14PM -0400, Mel Henning wrote: Userspace needs this information to set up zcull correctly. This is a very brief motivation for the commit, please also describe what the commit does using imperative form. Signed-

Re: [PATCH 1/2] drm/nouveau: Add DRM_IOCTL_NOUVEAU_GET_ZCULL_INFO

2025-03-28 Thread Danilo Krummrich
(CC: Ben, John) On Thu, Mar 27, 2025 at 02:03:21PM -0400, M Henning wrote: > On Thu, Mar 27, 2025 at 9:51 AM Danilo Krummrich wrote: > > > > On Fri, Mar 21, 2025 at 06:06:34PM -0400, M Henning wrote: > > > On Thu, Mar 20, 2025 at 2:18 PM Danilo Krummrich wrote: > > > > On Wed, Mar 12, 2025 at 05

Re: [PATCH 1/2] drm/nouveau: Add DRM_IOCTL_NOUVEAU_GET_ZCULL_INFO

2025-03-28 Thread Danilo Krummrich
On Thu, Mar 27, 2025 at 02:26:09PM -0400, M Henning wrote: > On Thu, Mar 27, 2025 at 8:56 AM Danilo Krummrich wrote: > > > > On Tue, Mar 25, 2025 at 07:40:56PM -0400, M Henning wrote: > > > Okay, that sounds reasonable since I don't expect this to change very > > > quickly. > > > > > > Since I do

Re: [PATCH 1/2] drm/nouveau: Add DRM_IOCTL_NOUVEAU_GET_ZCULL_INFO

2025-03-27 Thread M Henning
On Thu, Mar 27, 2025 at 8:56 AM Danilo Krummrich wrote: > > On Tue, Mar 25, 2025 at 07:40:56PM -0400, M Henning wrote: > > Okay, that sounds reasonable since I don't expect this to change very > > quickly. > > > > Since I don't fully understand, is the suggestion here to: > > 1) add the interface

Re: [PATCH 1/2] drm/nouveau: Add DRM_IOCTL_NOUVEAU_GET_ZCULL_INFO

2025-03-27 Thread Danilo Krummrich
On Fri, Mar 21, 2025 at 06:06:34PM -0400, M Henning wrote: > On Thu, Mar 20, 2025 at 2:18 PM Danilo Krummrich wrote: > > On Wed, Mar 12, 2025 at 05:36:14PM -0400, Mel Henning wrote: > > > + __u32 width_align_pixels; > > > + __u32 height_align_pixels; > > > + __u32 pixel_squares_by_aliq

Re: [PATCH 1/2] drm/nouveau: Add DRM_IOCTL_NOUVEAU_GET_ZCULL_INFO

2025-03-27 Thread Danilo Krummrich
On Tue, Mar 25, 2025 at 07:40:56PM -0400, M Henning wrote: > Okay, that sounds reasonable since I don't expect this to change very quickly. > > Since I don't fully understand, is the suggestion here to: > 1) add the interface as a function on nvkm_gr using the nvkm_gr_func > vtable and store the a

Re: [PATCH 1/2] drm/nouveau: Add DRM_IOCTL_NOUVEAU_GET_ZCULL_INFO

2025-03-25 Thread M Henning
Okay, that sounds reasonable since I don't expect this to change very quickly. Since I don't fully understand, is the suggestion here to: 1) add the interface as a function on nvkm_gr using the nvkm_gr_func vtable and store the actual data on r535_gr or 2) add the interface to NVIF (which IF?) and

Re: [PATCH 1/2] drm/nouveau: Add DRM_IOCTL_NOUVEAU_GET_ZCULL_INFO

2025-03-21 Thread M Henning
On Thu, Mar 20, 2025 at 2:18 PM Danilo Krummrich wrote: > > Hi Mel, Hi, thanks for the review. > On Wed, Mar 12, 2025 at 05:36:14PM -0400, Mel Henning wrote: > > Userspace needs this information to set up zcull correctly. > > This is a very brief motivation for the commit, please also describe w

Re: [PATCH 1/2] drm/nouveau: Add DRM_IOCTL_NOUVEAU_GET_ZCULL_INFO

2025-03-20 Thread Danilo Krummrich
On Fri, Mar 21, 2025 at 05:57:55AM +1000, Ben Skeggs wrote: > On 21/3/25 04:18, Danilo Krummrich wrote: > > > Hi Mel, > > > > On Wed, Mar 12, 2025 at 05:36:14PM -0400, Mel Henning wrote: > > > > @@ -72,6 +75,9 @@ struct nvkm_device { > > > bool armed; > > > bo

Re: [PATCH 1/2] drm/nouveau: Add DRM_IOCTL_NOUVEAU_GET_ZCULL_INFO

2025-03-20 Thread Danilo Krummrich
On Thu, Mar 20, 2025 at 07:18:13PM +0100, Danilo Krummrich wrote: > Hi Mel, > > On Wed, Mar 12, 2025 at 05:36:14PM -0400, Mel Henning wrote: > > +int > > +nouveau_abi16_ioctl_get_zcull_info(ABI16_IOCTL_ARGS) > > +{ > > + struct nouveau_drm *drm = nouveau_drm(dev); > > + struct nvkm_device *dev

[PATCH 1/2] drm/nouveau: Add DRM_IOCTL_NOUVEAU_GET_ZCULL_INFO

2025-03-12 Thread Mel Henning
Userspace needs this information to set up zcull correctly. Signed-off-by: Mel Henning --- .../drm/nouveau/include/nvkm/core/device.h| 6 ++ .../sdk/nvidia/inc/ctrl/ctrl2080/ctrl2080gr.h | 69 +++ drivers/gpu/drm/nouveau/nouveau_abi16.c | 15 drivers/gpu/drm/nouve