[PATCH 3/5] drm/sched: Warn if pending list is not empty

2025-04-09 Thread Philipp Stanner
drm_sched_fini() can leak jobs under certain circumstances. Warn if that happens. Signed-off-by: Philipp Stanner --- drivers/gpu/drm/scheduler/sched_main.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c in

Re: [6.13.6 stable regression?] Nouveau reboot failure in r535_gsp_msg_recv()

2025-04-09 Thread David Woodhouse
On Tue, 2025-04-08 at 16:30 +, Timur Tabi wrote: > On Tue, 2025-04-08 at 17:21 +0100, David Woodhouse wrote: > > If I set the BIOS to use the external display at boot time, that works > > and Linux starts booting using the USB-C monitor — until nouveau inits, > > at which point it stops working

Reminder: Seeking nominations for the 2025 X.Org Board of Directors Elections

2025-04-09 Thread Mark Filion
Hello! The nomination period is currently open for the upcoming election to the X.Org Foundation Board of Directors. All X.Org Foundation members are eligible for election to the board. Nominations for the 2025 election are now open and will remain open until 23:59 UTC on 16 April 2025. The Boar

Re: [PATCH 1/2] dma-fence: Rename dma_fence_is_signaled()

2025-04-09 Thread Christian König
Am 09.04.25 um 16:01 schrieb Philipp Stanner: > On Wed, 2025-04-09 at 15:14 +0200, Christian König wrote: >> Am 09.04.25 um 14:56 schrieb Philipp Stanner: >>> On Wed, 2025-04-09 at 14:51 +0200, Philipp Stanner wrote: On Wed, 2025-04-09 at 14:39 +0200, Boris Brezillon wrote: > Hi Philipp, >

Re: [PATCH 1/2] dma-fence: Rename dma_fence_is_signaled()

2025-04-09 Thread Christian König
Am 09.04.25 um 14:56 schrieb Philipp Stanner: > On Wed, 2025-04-09 at 14:51 +0200, Philipp Stanner wrote: >> On Wed, 2025-04-09 at 14:39 +0200, Boris Brezillon wrote: >>> Hi Philipp, >>> >>> On Wed,  9 Apr 2025 14:06:37 +0200 >>> Philipp Stanner wrote: >>> dma_fence_is_signaled()'s name stron

Re: [PATCH 2/2] dma-fence: Improve docu for dma_fence_check_and_signal()

2025-04-09 Thread Li, Yunxiang (Teddy)
[AMD Official Use Only - AMD Internal Distribution Only] Hi Philipp, I feel like the problem has two parts. The documentation does not make explicit that DMA_FENCE_FLAG_SIGNALED_BIT is "caching" the hardware state when a fence is backed by hardware, so what dma_fence_is_signaled here is doing i

Re: [PATCH 1/2] dma-fence: Rename dma_fence_is_signaled()

2025-04-09 Thread Boris Brezillon
Hi Philipp, On Wed, 9 Apr 2025 14:06:37 +0200 Philipp Stanner wrote: > dma_fence_is_signaled()'s name strongly reads as if this function were > intended for checking whether a fence is already signaled. Also the > boolean it returns hints at that. > > The function's behavior, however, is more

[PATCH 2/2] dma-fence: Improve docu for dma_fence_check_and_signal()

2025-04-09 Thread Philipp Stanner
The documentation of the return value of dma_fence_check_and_signal() and dma_fence_check_and_signal_locked() reads as if the returned boolean only describes whether dma_fence_signal() (or similar) has been called before this function call already. That's not the case, since dma_fence_ops.signaled(

[PATCH 1/2] dma-fence: Rename dma_fence_is_signaled()

2025-04-09 Thread Philipp Stanner
dma_fence_is_signaled()'s name strongly reads as if this function were intended for checking whether a fence is already signaled. Also the boolean it returns hints at that. The function's behavior, however, is more complex: it can check with a driver callback whether the hardware's sequence number

[PATCH 0/2] dma-fence: Rename dma_fence_is_signaled()

2025-04-09 Thread Philipp Stanner
Hi all, I'm currently debugging a Nouveau issue [1] and potentially might want to add a function that just checks whether a fence is signaled already – which then would obviously be called dma_fence_is_signaled(). In any case, I think it is reasonable to rename dma_fence_is_signaled() so that it

Re: [PATCH] drm/nouveau: Remove forgotten TODO

2025-04-09 Thread Danilo Krummrich
(+ Ben) On Wed, Apr 09, 2025 at 11:14:14AM +0200, Philipp Stanner wrote: > commit ebb945a94bba ("drm/nouveau: port all engines to new engine module > format") introduced a TODO to nouveau_chan.h, stating that an > unspecified rework would take place in the "near future". > > Almost 13 years have

[PATCH 1/1] drm/nouveau/disp: Use dev->dev to get the device

2025-04-09 Thread Sakari Ailus
The local variable dev points to drm->dev already, use dev directly. Signed-off-by: Sakari Ailus --- Hi folks, The background is that I'll be using a Coccinelle spatch soon to remove (most) pm_runtime_mark_last_busy() calls. That won't work if the arguments aren't the same. - Sakari drivers/g

[PATCH] drm/nouveau: Remove forgotten TODO

2025-04-09 Thread Philipp Stanner
commit ebb945a94bba ("drm/nouveau: port all engines to new engine module format") introduced a TODO to nouveau_chan.h, stating that an unspecified rework would take place in the "near future". Almost 13 years have passed since this "near future", so it can be safely assumed that the TODO is not ne