[GitHub] [shardingsphere] codecov-commenter commented on pull request #23680: Refactor DistSQL`count single table rule` to `count single table`

2023-01-20 Thread via GitHub
codecov-commenter commented on PR #23680: URL: https://github.com/apache/shardingsphere/pull/23680#issuecomment-1398894163 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23680?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_te

[GitHub] [shardingsphere] Qianyi951015 commented on a diff in pull request #23680: Refactor DistSQL`count single table rule` to `count single table`

2023-01-20 Thread via GitHub
Qianyi951015 commented on code in PR #23680: URL: https://github.com/apache/shardingsphere/pull/23680#discussion_r1083214782 ## docs/document/content/user-manual/shardingsphere-proxy/distsql/syntax/rql/rule-query/single-table/count-single-table.cn.md: ## @@ -31,33 +31,33 @@ data

[GitHub] [shardingsphere] zhaojinchao95 commented on pull request #23685: Implements GENERIC_TABLE_RANDOM_REPLACE mask algorithm

2023-01-20 Thread via GitHub
zhaojinchao95 commented on PR #23685: URL: https://github.com/apache/shardingsphere/pull/23685#issuecomment-1399149904 @lushaorong Hi, there some conflict, please resolved it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [shardingsphere] zhaojinchao95 commented on pull request #23683: Implements UNIFIED_CREDIT_CODE_RANDOM_REPLACE mask algorithm

2023-01-20 Thread via GitHub
zhaojinchao95 commented on PR #23683: URL: https://github.com/apache/shardingsphere/pull/23683#issuecomment-1399150202 @lushaorong Hi, there some conflict, please resolved it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [shardingsphere] codecov-commenter commented on pull request #23685: Implements GENERIC_TABLE_RANDOM_REPLACE mask algorithm

2023-01-20 Thread via GitHub
codecov-commenter commented on PR #23685: URL: https://github.com/apache/shardingsphere/pull/23685#issuecomment-1399171956 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23685?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_te

[GitHub] [shardingsphere] codecov-commenter commented on pull request #23690: TracingJDBCExecutorCallbackAdvice

2023-01-20 Thread via GitHub
codecov-commenter commented on PR #23690: URL: https://github.com/apache/shardingsphere/pull/23690#issuecomment-1399197790 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23690?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_te

[GitHub] [shardingsphere] lushaorong opened a new pull request, #23691: Optimize ShardingStatisticsTableCollector for database openGauss

2023-01-20 Thread via GitHub
lushaorong opened a new pull request, #23691: URL: https://github.com/apache/shardingsphere/pull/23691 Signed-off-by: lushaorong Ref #22902. Changes proposed in this pull request: - Optimize ShardingStatisticsTableCollector for database openGauss --- Before c

[GitHub] [shardingsphere] azrulmSE opened a new issue, #23692: Sharding JDBC didnt manage to release JDBC Connection

2023-01-20 Thread via GitHub
azrulmSE opened a new issue, #23692: URL: https://github.com/apache/shardingsphere/issues/23692 ## Bug Report ### Which version of ShardingSphere did you use? - 4.1.1 ### Which project did you use? ShardingSphere-JDBC or ShardingSphere-Proxy? - ShardingSphere-JDBC **Sha

[GitHub] [shardingsphere] taojintianxia merged pull request #23690: TracingJDBCExecutorCallbackAdvice

2023-01-20 Thread via GitHub
taojintianxia merged PR #23690: URL: https://github.com/apache/shardingsphere/pull/23690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [shardingsphere] codecov-commenter commented on pull request #23691: Optimize ShardingStatisticsTableCollector for database openGauss

2023-01-20 Thread via GitHub
codecov-commenter commented on PR #23691: URL: https://github.com/apache/shardingsphere/pull/23691#issuecomment-1399202316 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23691?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_te

[GitHub] [shardingsphere] RaigorJiang merged pull request #23680: Refactor DistSQL`count single table rule` to `count single table`

2023-01-20 Thread via GitHub
RaigorJiang merged PR #23680: URL: https://github.com/apache/shardingsphere/pull/23680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-uns

[GitHub] [shardingsphere] RaigorJiang commented on issue #23692: Sharding JDBC didnt manage to release JDBC Connection

2023-01-20 Thread via GitHub
RaigorJiang commented on issue #23692: URL: https://github.com/apache/shardingsphere/issues/23692#issuecomment-1399202751 Hi @azrulmSE Thanks for your feedback, but 4.1.1 is no longer maintained, have you tried the latest version and have similar problems? -- This is an automated mes

[GitHub] [shardingsphere] azrulmSE commented on issue #23692: Sharding JDBC didnt manage to release JDBC Connection

2023-01-21 Thread via GitHub
azrulmSE commented on issue #23692: URL: https://github.com/apache/shardingsphere/issues/23692#issuecomment-1399217554 I change to this version since as you @RaigorJiang suggested is no longer maintained ![image](https://user-images.githubusercontent.com/3959366/213859047-9b09b54e-499d-

[GitHub] [shardingsphere] azrulmSE commented on issue #23692: Sharding JDBC didnt manage to release JDBC Connection

2023-01-21 Thread via GitHub
azrulmSE commented on issue #23692: URL: https://github.com/apache/shardingsphere/issues/23692#issuecomment-1399221389 I just update to the latest config for application.properties file: spring.jpa.open-in-view=false spring.jpa.generate-ddl=true spring.jpa.show-sql=true

[GitHub] [shardingsphere-elasticjob] TeslaCN commented on issue #2177: ScheduleJobBootstrap load SimpleJob,what value of elasticJobType to set ?

2023-01-21 Thread via GitHub
TeslaCN commented on issue #2177: URL: https://github.com/apache/shardingsphere-elasticjob/issues/2177#issuecomment-1399237095 `SCRIPT`, `HTTP` are available elasticJob type. You could implement your own type executor by SPI. https://github.com/apache/shardingsphere-elasticjob/blob/

[GitHub] [shardingsphere] taojintianxia merged pull request #23693: Add JaegerSQLParserEngineAdvice

2023-01-21 Thread via GitHub
taojintianxia merged PR #23693: URL: https://github.com/apache/shardingsphere/pull/23693 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [shardingsphere] strongduanmu merged pull request #23694: Remove useless codes for agent module

2023-01-21 Thread via GitHub
strongduanmu merged PR #23694: URL: https://github.com/apache/shardingsphere/pull/23694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-un

[GitHub] [shardingsphere] lushaorong commented on issue #23626: Column "TODO" not found exception occurs when I run integration test with jdbc, Standalone, PostgreSQL and encrypt param

2023-01-21 Thread via GitHub
lushaorong commented on issue #23626: URL: https://github.com/apache/shardingsphere/issues/23626#issuecomment-1399252187 I want to try it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [shardingsphere] TeslaCN merged pull request #23695: Revise javadoc of ExecuteProcessReporter

2023-01-21 Thread via GitHub
TeslaCN merged PR #23695: URL: https://github.com/apache/shardingsphere/pull/23695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

[GitHub] [shardingsphere] zhaojinchao95 merged pull request #23696: Remove useless param in ExecuteProcessEngine

2023-01-21 Thread via GitHub
zhaojinchao95 merged PR #23696: URL: https://github.com/apache/shardingsphere/pull/23696 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [shardingsphere] taojintianxia merged pull request #23697: Refactor AdapterModeEnum and AdapterType

2023-01-21 Thread via GitHub
taojintianxia merged PR #23697: URL: https://github.com/apache/shardingsphere/pull/23697 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [shardingsphere] Qianyi951015 opened a new pull request, #23698: Add integration test cases for DistSQL `mask rule`

2023-01-21 Thread via GitHub
Qianyi951015 opened a new pull request, #23698: URL: https://github.com/apache/shardingsphere/pull/23698 Changes proposed in this pull request: - Add integration test cases for DistSQL `mask rule` --- Before committing this PR, I'm sure that I have checked the following

[GitHub] [shardingsphere] taojintianxia merged pull request #23699: Unify variable name for ifPresent

2023-01-21 Thread via GitHub
taojintianxia merged PR #23699: URL: https://github.com/apache/shardingsphere/pull/23699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [shardingsphere] tristaZero merged pull request #23700: Refactor ExecuteProcessEngine

2023-01-21 Thread via GitHub
tristaZero merged PR #23700: URL: https://github.com/apache/shardingsphere/pull/23700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsu

[GitHub] [shardingsphere] zhaojinchao95 merged pull request #23701: Remove SPI for ExecuteProcessReporter

2023-01-21 Thread via GitHub
zhaojinchao95 merged PR #23701: URL: https://github.com/apache/shardingsphere/pull/23701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [shardingsphere] taojintianxia merged pull request #23702: Remove OptionalSPI

2023-01-22 Thread via GitHub
taojintianxia merged PR #23702: URL: https://github.com/apache/shardingsphere/pull/23702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [shardingsphere] boyjoy1127 opened a new pull request, #23703: Replace filterable with translatable, and add supoort for date …

2023-01-22 Thread via GitHub
boyjoy1127 opened a new pull request, #23703: URL: https://github.com/apache/shardingsphere/pull/23703 Ref #19937. Changes proposed in this pull request: - replace filterable with translatable. - add support for date type column. --- Before committing this PR, I

[GitHub] [shardingsphere] taojintianxia merged pull request #23704: Refactor ExecuteProcessEngine

2023-01-22 Thread via GitHub
taojintianxia merged PR #23704: URL: https://github.com/apache/shardingsphere/pull/23704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [shardingsphere] codecov-commenter commented on pull request #23703: Replace filterable with translatable, and add supoort for date …

2023-01-22 Thread via GitHub
codecov-commenter commented on PR #23703: URL: https://github.com/apache/shardingsphere/pull/23703#issuecomment-1399440894 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23703?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_te

[GitHub] [shardingsphere] taojintianxia merged pull request #23705: Remove useless param in ExecuteProcessEngine.initializeExecution()

2023-01-22 Thread via GitHub
taojintianxia merged PR #23705: URL: https://github.com/apache/shardingsphere/pull/23705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [shardingsphere-on-cloud] mlycore commented on issue #166: [Feat] Introduce new CRD as ComputeNode for better usability

2023-01-22 Thread via GitHub
mlycore commented on issue #166: URL: https://github.com/apache/shardingsphere-on-cloud/issues/166#issuecomment-1399470934 Plan to add a subresource Scale for `kubectl scale ComputeNode xxx --replicas=*` sematics. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [shardingsphere-on-cloud] codecov-commenter commented on pull request #188: feat: add build tag to expose ports to kubectl command results

2023-01-22 Thread via GitHub
codecov-commenter commented on PR #188: URL: https://github.com/apache/shardingsphere-on-cloud/pull/188#issuecomment-1399489541 # [Codecov](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/188?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+co

[GitHub] [shardingsphere] zhfeng commented on pull request #23550: Force to build on JDK 11+

2023-01-22 Thread via GitHub
zhfeng commented on PR #23550: URL: https://github.com/apache/shardingsphere/pull/23550#issuecomment-1399494514 Thanks @linghengqian and I will take care of the conflicts after the Chinese New Year holiday. -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [shardingsphere-on-cloud] tristaZero merged pull request #188: feat: add build tag to expose ports to kubectl command results

2023-01-22 Thread via GitHub
tristaZero merged PR #188: URL: https://github.com/apache/shardingsphere-on-cloud/pull/188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

[GitHub] [shardingsphere-on-cloud] mlycore opened a new pull request, #189: feat: add kubebuild tag for scale subresource

2023-01-22 Thread via GitHub
mlycore opened a new pull request, #189: URL: https://github.com/apache/shardingsphere-on-cloud/pull/189 This pr supports scale ComputeNode with `kubectl scale ComputeNode xxx --replicas=xxx` related to #166 -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [shardingsphere-on-cloud] codecov-commenter commented on pull request #189: feat: add kubebuild tag for scale subresource

2023-01-22 Thread via GitHub
codecov-commenter commented on PR #189: URL: https://github.com/apache/shardingsphere-on-cloud/pull/189#issuecomment-1399516418 # [Codecov](https://codecov.io/gh/apache/shardingsphere-on-cloud/pull/189?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+co

[GitHub] [shardingsphere-on-cloud] strongduanmu merged pull request #189: feat: add kubebuild tag for scale subresource

2023-01-22 Thread via GitHub
strongduanmu merged PR #189: URL: https://github.com/apache/shardingsphere-on-cloud/pull/189 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[GitHub] [shardingsphere] RaigorJiang merged pull request #23698: Add integration test cases for DistSQL `mask rule`

2023-01-22 Thread via GitHub
RaigorJiang merged PR #23698: URL: https://github.com/apache/shardingsphere/pull/23698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-uns

[GitHub] [shardingsphere] zhaojinchao95 merged pull request #23706: Remove useless field for RawExecutor

2023-01-23 Thread via GitHub
zhaojinchao95 merged PR #23706: URL: https://github.com/apache/shardingsphere/pull/23706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [shardingsphere] taojintianxia merged pull request #23707: Refactor QueryContext

2023-01-23 Thread via GitHub
taojintianxia merged PR #23707: URL: https://github.com/apache/shardingsphere/pull/23707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [shardingsphere] terrymanu merged pull request #23709: Remove duplicate assert files

2023-01-23 Thread via GitHub
terrymanu merged PR #23709: URL: https://github.com/apache/shardingsphere/pull/23709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

[GitHub] [shardingsphere] taojintianxia merged pull request #23708: Keep same param sequence with ExecuteProcessEngine and RawExecutor

2023-01-23 Thread via GitHub
taojintianxia merged PR #23708: URL: https://github.com/apache/shardingsphere/pull/23708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [shardingsphere] RaigorJiang commented on issue #22499: Can we provide check for configuration of `server.yaml`?

2023-01-23 Thread via GitHub
RaigorJiang commented on issue #22499: URL: https://github.com/apache/shardingsphere/issues/22499#issuecomment-1400369678 Good suggestion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [shardingsphere] codecov-commenter commented on pull request #23710: Simplify ShardingSphere SPI method

2023-01-23 Thread via GitHub
codecov-commenter commented on PR #23710: URL: https://github.com/apache/shardingsphere/pull/23710#issuecomment-1400363401 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23710?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_te

[GitHub] [shardingsphere] taojintianxia merged pull request #23710: Simplify ShardingSphere SPI method

2023-01-23 Thread via GitHub
taojintianxia merged PR #23710: URL: https://github.com/apache/shardingsphere/pull/23710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [shardingsphere] aryan19926 commented on issue #23425: Add test case for PluginLifecycleServiceManager

2023-01-23 Thread via GitHub
aryan19926 commented on issue #23425: URL: https://github.com/apache/shardingsphere/issues/23425#issuecomment-1400603169 Hello there I want to work on this issue. Could you please guide me how to find this file on intellij idea ? -- This is an automated message from the Apache Git S

[GitHub] [shardingsphere] taojintianxia merged pull request #23711: Add default type logic in TypedSPIRegistry

2023-01-23 Thread via GitHub
taojintianxia merged PR #23711: URL: https://github.com/apache/shardingsphere/pull/23711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [shardingsphere] dilraj-vyas opened a new pull request, #23712: Fixes #23358

2023-01-23 Thread via GitHub
dilraj-vyas opened a new pull request, #23712: URL: https://github.com/apache/shardingsphere/pull/23712 Fixes #ISSUSE_ID. Changes proposed in this pull request: - test cases for YamlPluginsConfigurationSwapper class this pr will fix isssue #23358 --- Before committi

[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #23703: Replace filterable with translatable, and add supoort for date …

2023-01-23 Thread via GitHub
strongduanmu commented on code in PR #23703: URL: https://github.com/apache/shardingsphere/pull/23703#discussion_r1084716982 ## kernel/sql-federation/optimizer/src/main/antlr4/org/apache/shardingsphere/sqlfederation/optimizer/parser/rexnode/Literals.g4: ## @@ -43,3 +47,14 @@ INT

[GitHub] [shardingsphere] strongduanmu commented on issue #23626: Column "TODO" not found exception occurs when I run integration test with jdbc, Standalone, PostgreSQL and encrypt param

2023-01-23 Thread via GitHub
strongduanmu commented on issue #23626: URL: https://github.com/apache/shardingsphere/issues/23626#issuecomment-1401213284 @lushaorong Welcome, I will assign this issue to you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [shardingsphere] codecov-commenter commented on pull request #23713: Remove useless invoke for RequiredSPIRegistry

2023-01-23 Thread via GitHub
codecov-commenter commented on PR #23713: URL: https://github.com/apache/shardingsphere/pull/23713#issuecomment-1401431349 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23713?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_te

[GitHub] [shardingsphere] strongduanmu merged pull request #23713: Remove useless invoke for RequiredSPIRegistry

2023-01-24 Thread via GitHub
strongduanmu merged PR #23713: URL: https://github.com/apache/shardingsphere/pull/23713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-un

[GitHub] [shardingsphere] tristaZero merged pull request #23714: Merge PipelineDistributedBarrier and PipelineDistributedBarrierImpl

2023-01-24 Thread via GitHub
tristaZero merged PR #23714: URL: https://github.com/apache/shardingsphere/pull/23714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsu

[GitHub] [shardingsphere] tristaZero merged pull request #23715: Merge ShardingConditionEngine and DefaultShardingConditionEngine

2023-01-24 Thread via GitHub
tristaZero merged PR #23715: URL: https://github.com/apache/shardingsphere/pull/23715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsu

[GitHub] [shardingsphere] strongduanmu merged pull request #23716: Remove useless ShardingConditionEngineFactory

2023-01-24 Thread via GitHub
strongduanmu merged PR #23716: URL: https://github.com/apache/shardingsphere/pull/23716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-un

[GitHub] [shardingsphere] taojintianxia merged pull request #23717: Rename DefaultShardingConditionEngine to ShardingConditionEngine

2023-01-24 Thread via GitHub
taojintianxia merged PR #23717: URL: https://github.com/apache/shardingsphere/pull/23717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [shardingsphere] taojintianxia merged pull request #23718: Refactor AbstractDataTypeLoader

2023-01-24 Thread via GitHub
taojintianxia merged PR #23718: URL: https://github.com/apache/shardingsphere/pull/23718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [shardingsphere] taojintianxia merged pull request #23719: Move package of DataTypeLoader and DialectSchemaMetaDataLoader

2023-01-24 Thread via GitHub
taojintianxia merged PR #23719: URL: https://github.com/apache/shardingsphere/pull/23719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [shardingsphere] TeslaCN opened a new pull request, #23720: Use multi-platform image in E2E Dockerfile

2023-01-24 Thread via GitHub
TeslaCN opened a new pull request, #23720: URL: https://github.com/apache/shardingsphere/pull/23720 We have migrated E2E image from `openjdk` to `eclipse-temurin` in https://github.com/apache/shardingsphere/issues/23486. But the alpine variant image only support `amd64`. Change the image

[GitHub] [shardingsphere] taojintianxia merged pull request #23721: Update document for DialectSchemaMetaDataLoader

2023-01-24 Thread via GitHub
taojintianxia merged PR #23721: URL: https://github.com/apache/shardingsphere/pull/23721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [shardingsphere] taojintianxia merged pull request #23722: Use StandardDataTypeLoader and DialectDataTypeLoader to instead of AbstractDataTypeLoader

2023-01-24 Thread via GitHub
taojintianxia merged PR #23722: URL: https://github.com/apache/shardingsphere/pull/23722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [shardingsphere] CoderMayhem commented on issue #23457: Remove unused annotation ShardingSphereTransactionType

2023-01-24 Thread via GitHub
CoderMayhem commented on issue #23457: URL: https://github.com/apache/shardingsphere/issues/23457#issuecomment-1402363254 I'd like to take this up if work is stalled on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [shardingsphere] CoderMayhem opened a new pull request, #23724: removes unused file and package

2023-01-24 Thread via GitHub
CoderMayhem opened a new pull request, #23724: URL: https://github.com/apache/shardingsphere/pull/23724 Fixes #ISSUSE_ID. Changes proposed in this pull request: - --- Before committing this PR, I'm sure that I have checked the following options: - [ ] My code fol

[GitHub] [shardingsphere] zhaojinchao95 commented on pull request #23724: removes unused file and package

2023-01-24 Thread via GitHub
zhaojinchao95 commented on PR #23724: URL: https://github.com/apache/shardingsphere/pull/23724#issuecomment-1402927883 @FlyingZC Hi, can you check it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [shardingsphere] azrulmSE commented on issue #23692: Sharding JDBC didnt manage to release JDBC Connection

2023-01-24 Thread via GitHub
azrulmSE commented on issue #23692: URL: https://github.com/apache/shardingsphere/issues/23692#issuecomment-1402997096 Hi, I already update the example code just in case @RaigorJiang wants to simulate the error. Here the [link](https://github.com/azrulmSE/spring-boot-sharding-jdbc) . --

[GitHub] [shardingsphere] FlyingZC commented on pull request #23724: removes unused file and package

2023-01-24 Thread via GitHub
FlyingZC commented on PR #23724: URL: https://github.com/apache/shardingsphere/pull/23724#issuecomment-1403010229 @RaigorJiang Hi, have we removed the integration with Spring using `@ShardingSphereTransactionType`? Could we remove this `@ShardingSphereTransactionType`. -- This is an aut

[GitHub] [shardingsphere] lushaorong commented on issue #23626: Column "TODO" not found exception occurs when I run integration test with jdbc, Standalone, PostgreSQL and encrypt param

2023-01-24 Thread via GitHub
lushaorong commented on issue #23626: URL: https://github.com/apache/shardingsphere/issues/23626#issuecomment-1403053622 I run `AdditionalDMLE2EIT.assertExecuteUpdateWithColumnIndexes` test and I get error message `No tests found matching assertExecuteUpdateWithColumnIndexes with any param

[GitHub] [shardingsphere] RaigorJiang opened a new issue, #23725: Optimize the inheritance structure of ProxyBackendHandler

2023-01-24 Thread via GitHub
RaigorJiang opened a new issue, #23725: URL: https://github.com/apache/shardingsphere/issues/23725 Hi community, I found that the inheritance relationship of ProxyBackendHandler is a bit messy, and there is no good classification, especially the handler related to DistSQL, which need

[GitHub] [shardingsphere] terrymanu closed issue #23457: Remove unused annotation ShardingSphereTransactionType

2023-01-24 Thread via GitHub
terrymanu closed issue #23457: Remove unused annotation ShardingSphereTransactionType URL: https://github.com/apache/shardingsphere/issues/23457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [shardingsphere] terrymanu merged pull request #23724: removes unused file and package

2023-01-24 Thread via GitHub
terrymanu merged PR #23724: URL: https://github.com/apache/shardingsphere/pull/23724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

[GitHub] [shardingsphere] terrymanu commented on pull request #23724: removes unused file and package

2023-01-24 Thread via GitHub
terrymanu commented on PR #23724: URL: https://github.com/apache/shardingsphere/pull/23724#issuecomment-1403095444 > @RaigorJiang Hi, have we removed the integration with Spring using `@ShardingSphereTransactionType`? Could we remove this `@ShardingSphereTransactionType`. The spring

[GitHub] [shardingsphere] RaigorJiang commented on pull request #23724: removes unused file and package

2023-01-24 Thread via GitHub
RaigorJiang commented on PR #23724: URL: https://github.com/apache/shardingsphere/pull/23724#issuecomment-1403095867 Yes, it's useless. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [shardingsphere] zhaojinchao95 opened a new pull request, #23726: Fix NoSuchElementException when use system database

2023-01-25 Thread via GitHub
zhaojinchao95 opened a new pull request, #23726: URL: https://github.com/apache/shardingsphere/pull/23726 Fixes #22183. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [shardingsphere] codecov-commenter commented on pull request #23726: Fix NoSuchElementException when use system database

2023-01-25 Thread via GitHub
codecov-commenter commented on PR #23726: URL: https://github.com/apache/shardingsphere/pull/23726#issuecomment-1403335089 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23726?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_te

[GitHub] [shardingsphere] TeslaCN opened a new issue, #23727: Transaction E2E keep failing after base image changed

2023-01-25 Thread via GitHub
TeslaCN opened a new issue, #23727: URL: https://github.com/apache/shardingsphere/issues/23727 ## Bug Report ### Which version of ShardingSphere did you use? https://github.com/apache/shardingsphere/pull/23720/files ### Expected behavior All tests passed stably.

[GitHub] [shardingsphere] TeslaCN commented on pull request #23720: Use multi-platform image in E2E Dockerfile

2023-01-25 Thread via GitHub
TeslaCN commented on PR #23720: URL: https://github.com/apache/shardingsphere/pull/23720#issuecomment-1403484799 The transaction E2E keep failing. #23727. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [shardingsphere] linghengqian opened a new pull request, #23728: Use GraalVM CE 22.3.1 to fix Nightly Build

2023-01-25 Thread via GitHub
linghengqian opened a new pull request, #23728: URL: https://github.com/apache/shardingsphere/pull/23728 For #21347. Changes proposed in this pull request: - Use GraalVM CE 22.3.1 instead of GraalVM CE 23.0 Dev. Refer to https://github.com/apache/shardingsphere/actions/runs/39980

[GitHub] [shardingsphere] strongduanmu merged pull request #23726: Fix NoSuchElementException when use system database

2023-01-25 Thread via GitHub
strongduanmu merged PR #23726: URL: https://github.com/apache/shardingsphere/pull/23726 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-un

[GitHub] [shardingsphere] strongduanmu closed issue #22183: NPE when select from `shardingsphere.sharding_table_statistics`

2023-01-25 Thread via GitHub
strongduanmu closed issue #22183: NPE when select from `shardingsphere.sharding_table_statistics` URL: https://github.com/apache/shardingsphere/issues/22183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #23685: Implements GENERIC_TABLE_RANDOM_REPLACE mask algorithm

2023-01-25 Thread via GitHub
strongduanmu commented on code in PR #23685: URL: https://github.com/apache/shardingsphere/pull/23685#discussion_r1086584453 ## features/mask/core/src/main/java/org/apache/shardingsphere/mask/algorithm/replace/GenericTableRandomReplaceAlgorithm.java: ## @@ -0,0 +1,92 @@ +/* + *

[GitHub] [shardingsphere] codecov-commenter commented on pull request #23728: Use GraalVM CE 22.3.1 to fix Nightly Build

2023-01-25 Thread via GitHub
codecov-commenter commented on PR #23728: URL: https://github.com/apache/shardingsphere/pull/23728#issuecomment-1403628176 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23728?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_te

[GitHub] [shardingsphere] TeslaCN commented on a diff in pull request #23728: Use GraalVM CE 22.3.1 to fix Nightly Build

2023-01-25 Thread via GitHub
TeslaCN commented on code in PR #23728: URL: https://github.com/apache/shardingsphere/pull/23728#discussion_r1086673973 ## pom.xml: ## @@ -94,14 +94,14 @@ 1.18.20 42.4.1 -3.0.0 +3.1.0-og Review Comment: What's the different between

[GitHub] [shardingsphere] linghengqian commented on a diff in pull request #23728: Use GraalVM CE 22.3.1 to fix Nightly Build

2023-01-25 Thread via GitHub
linghengqian commented on code in PR #23728: URL: https://github.com/apache/shardingsphere/pull/23728#discussion_r1086681383 ## pom.xml: ## @@ -94,14 +94,14 @@ 1.18.20 42.4.1 -3.0.0 +3.1.0-og Review Comment: - I checked at https:/

[GitHub] [shardingsphere] TeslaCN commented on a diff in pull request #23728: Use GraalVM CE 22.3.1 to fix Nightly Build

2023-01-25 Thread via GitHub
TeslaCN commented on code in PR #23728: URL: https://github.com/apache/shardingsphere/pull/23728#discussion_r1086690870 ## pom.xml: ## @@ -94,14 +94,14 @@ 1.18.20 42.4.1 -3.0.0 +3.1.0-og Review Comment: Got it. -- This is an au

[GitHub] [shardingsphere] RaigorJiang opened a new pull request, #23729: Add DistSQLBackendHandler to optimize the inheritance structure of ProxyBackendHandler

2023-01-25 Thread via GitHub
RaigorJiang opened a new pull request, #23729: URL: https://github.com/apache/shardingsphere/pull/23729 For #23725. Changes proposed in this pull request: - Add DistSQLBackendHandler. Note: `DatabaseRequiredBackendHandler` and `RQLBackendHandler` do not conform to the curr

[GitHub] [shardingsphere] linghengqian commented on issue #23558: Snyk vulnerability scanning

2023-01-25 Thread via GitHub
linghengqian commented on issue #23558: URL: https://github.com/apache/shardingsphere/issues/23558#issuecomment-1403838860 - To be honest, I don't know why it points to https://snyk.io/test/github/apache/shardingsphere?targetFile=pom.xml . I can get all the CVE information by importing Apa

[GitHub] [shardingsphere] RaigorJiang commented on issue #23692: Sharding JDBC didnt manage to release JDBC Connection

2023-01-25 Thread via GitHub
RaigorJiang commented on issue #23692: URL: https://github.com/apache/shardingsphere/issues/23692#issuecomment-1403922371 > Hi, I already update the example code just in case @RaigorJiang wants to simulate the error. Here the [link](https://github.com/azrulmSE/spring-boot-sharding-jdbc) .

[GitHub] [shardingsphere] codecov-commenter commented on pull request #23730: Refactor datetime module to time-service module

2023-01-25 Thread via GitHub
codecov-commenter commented on PR #23730: URL: https://github.com/apache/shardingsphere/pull/23730#issuecomment-1404500036 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23730?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_te

[GitHub] [shardingsphere] tristaZero merged pull request #23729: Add DistSQLBackendHandler to optimize the inheritance structure of ProxyBackendHandler

2023-01-25 Thread via GitHub
tristaZero merged PR #23729: URL: https://github.com/apache/shardingsphere/pull/23729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsu

[GitHub] [shardingsphere] RaigorJiang commented on issue #22752: Discuss rename artifactId from shardingsphere-jdbc-core to shardingsphere-jdbc

2023-01-26 Thread via GitHub
RaigorJiang commented on issue #22752: URL: https://github.com/apache/shardingsphere/issues/22752#issuecomment-1404695252 As a dependency entry, `shardingsphere-jdbc` is better than `shardingsphere-jdbc-core`. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [shardingsphere] zhaojinchao95 merged pull request #23730: Refactor datetime module to time-service and move to kernel module

2023-01-26 Thread via GitHub
zhaojinchao95 merged PR #23730: URL: https://github.com/apache/shardingsphere/pull/23730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [shardingsphere] terrymanu merged pull request #23728: Use GraalVM CE 22.3.1 to fix Nightly Build

2023-01-26 Thread via GitHub
terrymanu merged PR #23728: URL: https://github.com/apache/shardingsphere/pull/23728 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

[GitHub] [shardingsphere] zhaojinchao95 merged pull request #23731: Refactor shardingsphere-system-time-service module

2023-01-26 Thread via GitHub
zhaojinchao95 merged PR #23731: URL: https://github.com/apache/shardingsphere/pull/23731 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [shardingsphere] zhaojinchao95 merged pull request #23732: Refactor shardingsphere-database-time-service module

2023-01-26 Thread via GitHub
zhaojinchao95 merged PR #23732: URL: https://github.com/apache/shardingsphere/pull/23732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [shardingsphere] zhaojinchao95 merged pull request #23733: Refactor DatabaseTimeService

2023-01-26 Thread via GitHub
zhaojinchao95 merged PR #23733: URL: https://github.com/apache/shardingsphere/pull/23733 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [shardingsphere] codecov-commenter commented on pull request #23734: Refactor ReadwriteSplittingRule and ShardingRule

2023-01-26 Thread via GitHub
codecov-commenter commented on PR #23734: URL: https://github.com/apache/shardingsphere/pull/23734#issuecomment-1405306122 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23734?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_te

[GitHub] [shardingsphere] zhaojinchao95 merged pull request #23734: Refactor ReadwriteSplittingRule and ShardingRule

2023-01-26 Thread via GitHub
zhaojinchao95 merged PR #23734: URL: https://github.com/apache/shardingsphere/pull/23734 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [shardingsphere] RaigorJiang closed issue #23725: Optimize the inheritance structure of ProxyBackendHandler

2023-01-26 Thread via GitHub
RaigorJiang closed issue #23725: Optimize the inheritance structure of ProxyBackendHandler URL: https://github.com/apache/shardingsphere/issues/23725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [shardingsphere] RaigorJiang opened a new pull request, #23735: Refactor RQLBackendHandler, replace DistSQLResultSet with MergedResult

2023-01-26 Thread via GitHub
RaigorJiang opened a new pull request, #23735: URL: https://github.com/apache/shardingsphere/pull/23735 Changes proposed in this pull request: - Refactor RQLBackendHandler - Replace `StorageUnitResultSet` with `ShowStorageUnitExecutor` - Replace `SingleTableResultSet` with `S

[GitHub] [shardingsphere-on-cloud] mlycore closed issue #166: [Feat] Introduce new CRD as ComputeNode for better usability

2023-01-26 Thread via GitHub
mlycore closed issue #166: [Feat] Introduce new CRD as ComputeNode for better usability URL: https://github.com/apache/shardingsphere-on-cloud/issues/166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

  1   2   3   4   5   6   7   8   9   10   >