[GitHub] [shardingsphere] avalon5666 commented on issue #10274: The primary key is sharding column created the key value by the GeneratedKey config 。 is it okay?

2021-05-07 Thread GitBox
avalon5666 commented on issue #10274: URL: https://github.com/apache/shardingsphere/issues/10274#issuecomment-834990739 Follow step 1 ~ 2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [shardingsphere] strongduanmu commented on issue #10271: PostgreSQL `SHOW xxx` syntax conflicting with DistSQL

2021-05-07 Thread GitBox
strongduanmu commented on issue #10271: URL: https://github.com/apache/shardingsphere/issues/10271#issuecomment-834997974 @tristaZero I tested PG `show statement` parsing, and found that antlr can match invalid content by default, which caused the `show statement` in distsql to fail to be

[GitHub] [shardingsphere] XUZHOUWANG commented on issue #10274: The primary key is sharding column created the key value by the GeneratedKey config 。 is it okay?

2021-05-07 Thread GitBox
XUZHOUWANG commented on issue #10274: URL: https://github.com/apache/shardingsphere/issues/10274#issuecomment-834999874 > Follow step 1 ~ 2 it‘s okay. but i want to the value of the primary key created by the snowflake set by the sharding configuration. while step 1~2,the id is c

[GitHub] [shardingsphere] avalon5666 commented on issue #10274: The primary key is sharding column created the key value by the GeneratedKey config 。 is it okay?

2021-05-07 Thread GitBox
avalon5666 commented on issue #10274: URL: https://github.com/apache/shardingsphere/issues/10274#issuecomment-835001605 How to confirm the id is created by the mybatis-plus framework? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [shardingsphere] avalon5666 commented on issue #10274: The primary key is sharding column created the key value by the GeneratedKey config 。 is it okay?

2021-05-07 Thread GitBox
avalon5666 commented on issue #10274: URL: https://github.com/apache/shardingsphere/issues/10274#issuecomment-835003426 "IdType.AUTO" is created by the database,it will create by shardingsphere database middleware -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [shardingsphere] avalon5666 edited a comment on issue #10274: The primary key is sharding column created the key value by the GeneratedKey config 。 is it okay?

2021-05-07 Thread GitBox
avalon5666 edited a comment on issue #10274: URL: https://github.com/apache/shardingsphere/issues/10274#issuecomment-835003426 "IdType.AUTO" is created by the database,it will create by shardingsphere database middleware,mybatis-plus do nothing. -- This is an automated message from the

[GitHub] [shardingsphere] LikeElephantintheforest opened a new issue #10278: SELECT LAST_INSERT_ID() expect return the self-growth primary key

2021-05-07 Thread GitBox
LikeElephantintheforest opened a new issue #10278: URL: https://github.com/apache/shardingsphere/issues/10278 ## Question At mybatis mapper.xml , I using following code to expect return the self-growth primary key and then hope the model have id value. ```sql

[GitHub] [shardingsphere] XUZHOUWANG commented on issue #10274: The primary key is sharding column created the key value by the GeneratedKey config 。 is it okay?

2021-05-07 Thread GitBox
XUZHOUWANG commented on issue #10274: URL: https://github.com/apache/shardingsphere/issues/10274#issuecomment-835009849 > "IdType.AUTO" is created by the database,it will create by shardingsphere database middleware,mybatis-plus do nothing. it's okay. I try it. it's fine. I know the

[GitHub] [shardingsphere] avalon5666 closed issue #10274: The primary key is sharding column created the key value by the GeneratedKey config 。 is it okay?

2021-05-07 Thread GitBox
avalon5666 closed issue #10274: URL: https://github.com/apache/shardingsphere/issues/10274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [shardingsphere] LikeElephantintheforest commented on issue #10278: SELECT LAST_INSERT_ID() expect return the self-growth primary key

2021-05-07 Thread GitBox
LikeElephantintheforest commented on issue #10278: URL: https://github.com/apache/shardingsphere/issues/10278#issuecomment-835013990 sharding.jdbc.config.sharding.master-slave-rules.ms0.master-data-source-name = value is not empty , i replaced them for ask question; -- This is a

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10277: fix PG show syntax conflicting with DistSQL

2021-05-07 Thread GitBox
codecov-commenter commented on pull request #10277: URL: https://github.com/apache/shardingsphere/pull/10277#issuecomment-835034551 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10277?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[GitHub] [shardingsphere] wang7621422811 opened a new issue #10279: Using asynchronous processing for routing errors

2021-05-07 Thread GitBox
wang7621422811 opened a new issue #10279: URL: https://github.com/apache/shardingsphere/issues/10279 I'm using the JDK `CompletableFuture.supplyAsync()`,Occasionally, however, routing fails ``` Caused by: java.sql.SQLSyntaxErrorException: Table 'It should be "shsc_wms_wgb." Now it is

[GitHub] [shardingsphere] wenjixi opened a new issue #10280: why proxy not support ddl sql in xa transaction

2021-05-07 Thread GitBox
wenjixi opened a new issue #10280: URL: https://github.com/apache/shardingsphere/issues/10280 ```java coordinator.database.communication.jdbc.execute.engine.jdbc.JDBCExecuteEngine @Override public void checkExecutePrerequisites(final ExecutionContext executionContext) {

[GitHub] [shardingsphere] menghaoranss opened a new pull request #10281: Fixes disable data nodes

2021-05-07 Thread GitBox
menghaoranss opened a new pull request #10281: URL: https://github.com/apache/shardingsphere/pull/10281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries ab

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #10277: fix PG show syntax conflicting with DistSQL

2021-05-07 Thread GitBox
codecov-commenter edited a comment on pull request #10277: URL: https://github.com/apache/shardingsphere/pull/10277#issuecomment-835034551 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10277?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=p

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #10277: fix PG show syntax conflicting with DistSQL

2021-05-07 Thread GitBox
codecov-commenter edited a comment on pull request #10277: URL: https://github.com/apache/shardingsphere/pull/10277#issuecomment-835034551 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10277?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=p

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10281: Fixes disable data nodes

2021-05-07 Thread GitBox
codecov-commenter commented on pull request #10281: URL: https://github.com/apache/shardingsphere/pull/10281#issuecomment-835108012 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10281?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[GitHub] [shardingsphere-ui] lovlyhao opened a new issue #86: {"success":false,"errorCode":400,"errorMsg":"rule configuration is invalid.","model":null}

2021-05-07 Thread GitBox
lovlyhao opened a new issue #86: URL: https://github.com/apache/shardingsphere-ui/issues/86 ![image](https://user-images.githubusercontent.com/30038949/117528251-d6332a80-b003-11eb-87c7-0cf17e25c951.png) ![image](https://user-images.githubusercontent.com/30038949/117528253-db907500-b003

[GitHub] [shardingsphere] TeslaCN opened a new pull request #10282: Refactor SQLException handling in PostgreSQL Proxy

2021-05-07 Thread GitBox
TeslaCN opened a new pull request #10282: URL: https://github.com/apache/shardingsphere/pull/10282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10282: Refactor SQLException handling in PostgreSQL Proxy

2021-05-07 Thread GitBox
codecov-commenter commented on pull request #10282: URL: https://github.com/apache/shardingsphere/pull/10282#issuecomment-835149518 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10282?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[GitHub] [shardingsphere] menghaoranss merged pull request #10282: Refactor SQLException handling in PostgreSQL Proxy

2021-05-07 Thread GitBox
menghaoranss merged pull request #10282: URL: https://github.com/apache/shardingsphere/pull/10282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this s

[GitHub] [shardingsphere] arun-prasat commented on issue #10263: getting org.antlr.v4.runtime.tree.ErrorNodeImpl cannot be cast to org.antlr.v4.runtime.ParserRuleContext

2021-05-08 Thread GitBox
arun-prasat commented on issue #10263: URL: https://github.com/apache/shardingsphere/issues/10263#issuecomment-835167015 I tried with the below version which is the latest one found in maven repository but still getting the exception for the same query,(I searched for 5.0.0-alpha which is

[GitHub] [shardingsphere] arun-prasat edited a comment on issue #10263: getting org.antlr.v4.runtime.tree.ErrorNodeImpl cannot be cast to org.antlr.v4.runtime.ParserRuleContext

2021-05-08 Thread GitBox
arun-prasat edited a comment on issue #10263: URL: https://github.com/apache/shardingsphere/issues/10263#issuecomment-835167015 I tried with the below version which is the latest one found in maven repository but still getting the exception for the same query,(I searched for 5.0.0-alpha w

[GitHub] [shardingsphere] arun-prasat edited a comment on issue #10263: getting org.antlr.v4.runtime.tree.ErrorNodeImpl cannot be cast to org.antlr.v4.runtime.ParserRuleContext

2021-05-08 Thread GitBox
arun-prasat edited a comment on issue #10263: URL: https://github.com/apache/shardingsphere/issues/10263#issuecomment-835167015 I tried with the below version which is the latest one found in maven repository but still getting the exception for the same query,(I searched for 5.0.0-alpha w

[GitHub] [shardingsphere] arun-prasat edited a comment on issue #10263: getting org.antlr.v4.runtime.tree.ErrorNodeImpl cannot be cast to org.antlr.v4.runtime.ParserRuleContext

2021-05-08 Thread GitBox
arun-prasat edited a comment on issue #10263: URL: https://github.com/apache/shardingsphere/issues/10263#issuecomment-835167015 I tried with the below version which is the latest one found in the maven repository but still getting the exception for the same query,(I searched for **5.0.0-a

[GitHub] [shardingsphere] NOLouser opened a new issue #10283: In one transaction, two same logic sqls do not work correctly by using hint strategy

2021-05-08 Thread GitBox
NOLouser opened a new issue #10283: URL: https://github.com/apache/shardingsphere/issues/10283 ## Bug Report **For English only**, other languages will not accept. Before report a bug, make sure you have: - Searched open and closed [GitHub issues](https://github.com/apa

[GitHub] [shardingsphere-elasticjob] chiangyn opened a new issue #1889: IpUtils.getIp()方法获取不到ip

2021-05-08 Thread GitBox
chiangyn opened a new issue #1889: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1889 InetAddress..isReachable always false -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [shardingsphere-elasticjob] skaic commented on issue #1445: Support Annotation Job

2021-05-08 Thread GitBox
skaic commented on issue #1445: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1445#issuecomment-835238801 so,Annotation Job Has it stopped? @TeslaCN -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [shardingsphere] huanghao495430759 commented on issue #10252: [Enhancement] Support authority rule governance through different proxies

2021-05-08 Thread GitBox
huanghao495430759 commented on issue #10252: URL: https://github.com/apache/shardingsphere/issues/10252#issuecomment-835250070 Hi @tristaZero ,does `GLOBAL_RULE_NODE` in zk name is `rules` instead of `rule` ? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [shardingsphere] TeslaCN opened a new pull request #10284: Add tests for PostgreSQL Proxy Query/Bind CommandExecutor

2021-05-08 Thread GitBox
TeslaCN opened a new pull request #10284: URL: https://github.com/apache/shardingsphere/pull/10284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [shardingsphere] huanghao495430759 commented on issue #10252: [Enhancement] Support authority rule governance through different proxies

2021-05-08 Thread GitBox
huanghao495430759 commented on issue #10252: URL: https://github.com/apache/shardingsphere/issues/10252#issuecomment-835254774 another question is : now `org.apache.shardingsphere.governance.core.registry.listener.event.rule.RuleConfigurationsChangedEvent` had existed and used for schema

[GitHub] [shardingsphere] huanghao495430759 removed a comment on issue #10252: [Enhancement] Support authority rule governance through different proxies

2021-05-08 Thread GitBox
huanghao495430759 removed a comment on issue #10252: URL: https://github.com/apache/shardingsphere/issues/10252#issuecomment-835250070 Hi @tristaZero ,does `GLOBAL_RULE_NODE` in zk name is `rules` instead of `rule` ? -- This is an automated message from the Apache Git Service. To respon

[GitHub] [shardingsphere] huanghao495430759 edited a comment on issue #10252: [Enhancement] Support authority rule governance through different proxies

2021-05-08 Thread GitBox
huanghao495430759 edited a comment on issue #10252: URL: https://github.com/apache/shardingsphere/issues/10252#issuecomment-835254774 Hi @tristaZero now `org.apache.shardingsphere.governance.core.registry.listener.event.rule.RuleConfigurationsChangedEvent` had existed and used for schema

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10284: Add tests for PostgreSQL Proxy Query/Bind CommandExecutor

2021-05-08 Thread GitBox
codecov-commenter commented on pull request #10284: URL: https://github.com/apache/shardingsphere/pull/10284#issuecomment-835270360 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10284?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[GitHub] [shardingsphere-elasticjob] skaic opened a new pull request #1890: Use a auto increment unique identity to Mysql InnoDB PRIMARY KEY

2021-05-08 Thread GitBox
skaic opened a new pull request #1890: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1890 Fixes #1818. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [shardingsphere-elasticjob] codecov-commenter commented on pull request #1890: Use a auto increment unique identity to Mysql InnoDB PRIMARY KEY

2021-05-08 Thread GitBox
codecov-commenter commented on pull request #1890: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1890#issuecomment-835286165 # [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1890?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&u

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10260: Refactor ChannelThreadExecutorGroup to ConnectionThreadExecutorGroup

2021-05-08 Thread GitBox
codecov-commenter commented on pull request #10260: URL: https://github.com/apache/shardingsphere/pull/10260#issuecomment-835290626 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10260?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[GitHub] [shardingsphere] menghaoranss opened a new pull request #10285: Add alter sharding table rule

2021-05-08 Thread GitBox
menghaoranss opened a new pull request #10285: URL: https://github.com/apache/shardingsphere/pull/10285 For #10156 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10285: Add alter sharding table rule

2021-05-08 Thread GitBox
codecov-commenter commented on pull request #10285: URL: https://github.com/apache/shardingsphere/pull/10285#issuecomment-835326918 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10285?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[GitHub] [shardingsphere] ThanoshanMV opened a new pull request #10286: Fix rule definition in Oracle `ALTER DATABASE`'s `defaultSettingsClauses`

2021-05-08 Thread GitBox
ThanoshanMV opened a new pull request #10286: URL: https://github.com/apache/shardingsphere/pull/10286 Relates #10136 Hi @tristaZero, @Liangda-w. I changed the `defaultSettingsClauses`'s definition, please check it. Changes proposed in this pull request: - In the [default

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10286: Fix rule definition in Oracle `ALTER DATABASE`'s `defaultSettingsClauses`

2021-05-08 Thread GitBox
codecov-commenter commented on pull request #10286: URL: https://github.com/apache/shardingsphere/pull/10286#issuecomment-835371247 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10286?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[GitHub] [shardingsphere] ThanoshanMV commented on pull request #10286: Fix rule definition in Oracle `ALTER DATABASE`'s `defaultSettingsClauses`

2021-05-08 Thread GitBox
ThanoshanMV commented on pull request #10286: URL: https://github.com/apache/shardingsphere/pull/10286#issuecomment-835373838 `defaultSettingsClauses` ![DefaultSettingsClauses](https://user-images.githubusercontent.com/48581379/117541800-2b3a6500-b033-11eb-9f44-af1d0e1a6785.png) --

[GitHub] [shardingsphere] JasonMing commented on pull request #6202: Support local datetime

2021-05-08 Thread GitBox
JasonMing commented on pull request #6202: URL: https://github.com/apache/shardingsphere/pull/6202#issuecomment-835403290 I cannot find any releases on maven central repo. The latest stable version is still 4.1.1. Can anyone release a patch version to fix this issue? -- This is an a

[GitHub] [shardingsphere] Liangda-w commented on pull request #10286: Fix rule definition in Oracle `ALTER DATABASE`'s `defaultSettingsClauses`

2021-05-08 Thread GitBox
Liangda-w commented on pull request #10286: URL: https://github.com/apache/shardingsphere/pull/10286#issuecomment-835406138 Yes, looks good 👍 thanks for fixing! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [shardingsphere-elasticjob] codecov-commenter edited a comment on pull request #1890: Use a auto increment unique identity to Mysql InnoDB PRIMARY KEY

2021-05-08 Thread GitBox
codecov-commenter edited a comment on pull request #1890: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1890#issuecomment-835286165 # [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1890?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=co

[GitHub] [shardingsphere-elasticjob] TeslaCN commented on issue #1445: Support Annotation Job

2021-05-08 Thread GitBox
TeslaCN commented on issue #1445: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1445#issuecomment-835706317 Hi @skaic I think we can finish it in 3.1.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [shardingsphere] cilfm commented on a change in pull request #10217: Update SQLServerDatabaseType.java fix#10126

2021-05-09 Thread GitBox
cilfm commented on a change in pull request #10217: URL: https://github.com/apache/shardingsphere/pull/10217#discussion_r628852915 ## File path: shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/database/type/DatabaseTypeRecognizerTest.java

[GitHub] [shardingsphere] cilfm commented on pull request #10217: Update SQLServerDatabaseType.java fix#10126

2021-05-09 Thread GitBox
cilfm commented on pull request #10217: URL: https://github.com/apache/shardingsphere/pull/10217#issuecomment-835740086 I don't think it's necessary to add the current version. On the one hand, we can use SQL92 parser, on the other hand, it's not common to use other sqlserver drivers --

[GitHub] [shardingsphere] zhujunxxxxx opened a new pull request #10287: move the user configuration to authority rule

2021-05-09 Thread GitBox
zhujunx opened a new pull request #10287: URL: https://github.com/apache/shardingsphere/pull/10287 Fixes #10251 . Changes proposed in this pull request: - move the user configuration to authority rule and fix unit test. -- This is an automated message from the Apache Gi

[GitHub] [shardingsphere] tristaZero merged pull request #10217: Update SQLServerDatabaseType.java fix#10126

2021-05-09 Thread GitBox
tristaZero merged pull request #10217: URL: https://github.com/apache/shardingsphere/pull/10217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this ser

[GitHub] [shardingsphere] tristaZero closed issue #10126: sqlserver row_number() over() faild,Error preparing statement. Cause: org.antlr.v4.runtime.misc.ParseCancellationException

2021-05-09 Thread GitBox
tristaZero closed issue #10126: URL: https://github.com/apache/shardingsphere/issues/10126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [shardingsphere] tristaZero merged pull request #10286: Fix rule definition in Oracle `ALTER DATABASE`'s `defaultSettingsClauses`

2021-05-09 Thread GitBox
tristaZero merged pull request #10286: URL: https://github.com/apache/shardingsphere/pull/10286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this ser

[GitHub] [shardingsphere] tristaZero commented on pull request #10253: Add SQL Definition for `ALTER SYSTEM` of Oracle Database

2021-05-09 Thread GitBox
tristaZero commented on pull request #10253: URL: https://github.com/apache/shardingsphere/pull/10253#issuecomment-835799632 So... Due to #10286, new conflicts arose. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [shardingsphere] tristaZero edited a comment on pull request #10253: Add SQL Definition for `ALTER SYSTEM` of Oracle Database

2021-05-09 Thread GitBox
tristaZero edited a comment on pull request #10253: URL: https://github.com/apache/shardingsphere/pull/10253#issuecomment-835799632 So... Due to #10286, new conflicts arose? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [shardingsphere] tristaZero commented on pull request #6202: Support local datetime

2021-05-09 Thread GitBox
tristaZero commented on pull request #6202: URL: https://github.com/apache/shardingsphere/pull/6202#issuecomment-835800015 Hi 5.0.0-alpha is waiting for you, isn't it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [shardingsphere] tristaZero commented on issue #10252: [Enhancement] Support authority rule governance through different proxies

2021-05-09 Thread GitBox
tristaZero commented on issue #10252: URL: https://github.com/apache/shardingsphere/issues/10252#issuecomment-835801069 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [shardingsphere] tristaZero closed issue #10271: PostgreSQL `SHOW xxx` syntax conflicting with DistSQL

2021-05-09 Thread GitBox
tristaZero closed issue #10271: URL: https://github.com/apache/shardingsphere/issues/10271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [shardingsphere] tristaZero merged pull request #10277: fix PG show syntax conflicting with DistSQL

2021-05-09 Thread GitBox
tristaZero merged pull request #10277: URL: https://github.com/apache/shardingsphere/pull/10277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this ser

[GitHub] [shardingsphere] tristaZero commented on issue #10252: [Enhancement] Support authority rule governance through different proxies

2021-05-09 Thread GitBox
tristaZero commented on issue #10252: URL: https://github.com/apache/shardingsphere/issues/10252#issuecomment-835801466 I just updated this issue. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [shardingsphere] tristaZero commented on issue #10271: PostgreSQL `SHOW xxx` syntax conflicting with DistSQL

2021-05-09 Thread GitBox
tristaZero commented on issue #10271: URL: https://github.com/apache/shardingsphere/issues/10271#issuecomment-835803195 @strongduanmu Bingo, elegant. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [shardingsphere] tristaZero commented on pull request #9967: Issue#9948 refactor TablesContext

2021-05-09 Thread GitBox
tristaZero commented on pull request #9967: URL: https://github.com/apache/shardingsphere/pull/9967#issuecomment-835804846 Hey @MingxingLAI This PR looks plain, just a function name for our consideration. Since we do not prefer an acronym name, could you change it? Is it not knotty, rig

[GitHub] [shardingsphere] tristaZero edited a comment on pull request #9967: Issue#9948 refactor TablesContext

2021-05-09 Thread GitBox
tristaZero edited a comment on pull request #9967: URL: https://github.com/apache/shardingsphere/pull/9967#issuecomment-835804846 Hey @MingxingLAI , Thanks for your update. This PR looks plain, just a function name for our consideration. Since we do not prefer an acronym name, could y

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10287: Move the user configuration to authority rule

2021-05-09 Thread GitBox
codecov-commenter commented on pull request #10287: URL: https://github.com/apache/shardingsphere/pull/10287#issuecomment-835805337 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10287?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[GitHub] [shardingsphere] tristaZero commented on issue #8982: show tables like xxx% can not return correct result

2021-05-09 Thread GitBox
tristaZero commented on issue #8982: URL: https://github.com/apache/shardingsphere/issues/8982#issuecomment-835809084 Hi @MingxingLAI , Thanks for your attention here, sorry for my late coming. Let consider this issue with the following scenario, Suppose here are some tables,

[GitHub] [shardingsphere] ThanoshanMV commented on pull request #10253: Add SQL Definition for `ALTER SYSTEM` of Oracle Database

2021-05-09 Thread GitBox
ThanoshanMV commented on pull request #10253: URL: https://github.com/apache/shardingsphere/pull/10253#issuecomment-835809525 Yes @tristaZero, I'll resolve that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [shardingsphere] tristaZero commented on issue #8982: show tables like xxx% can not return correct result

2021-05-09 Thread GitBox
tristaZero commented on issue #8982: URL: https://github.com/apache/shardingsphere/issues/8982#issuecomment-835810531 Hi @MingxingLAI , Thanks for your attention here, sorry for my late coming. Let consider this issue with the following scenario, Suppose here are some tables,

[GitHub] [shardingsphere] tristaZero edited a comment on issue #8982: show tables like xxx% can not return correct result

2021-05-09 Thread GitBox
tristaZero edited a comment on issue #8982: URL: https://github.com/apache/shardingsphere/issues/8982#issuecomment-835809084 Hi @MingxingLAI , Thanks for your attention here, sorry for my late coming. Let consider this issue with the following scenario, Suppose here are some tab

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #10287: Move the user configuration to authority rule

2021-05-09 Thread GitBox
codecov-commenter edited a comment on pull request #10287: URL: https://github.com/apache/shardingsphere/pull/10287#issuecomment-835805337 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10287?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=p

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #10287: Move the user configuration to authority rule

2021-05-09 Thread GitBox
codecov-commenter edited a comment on pull request #10287: URL: https://github.com/apache/shardingsphere/pull/10287#issuecomment-835805337 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10287?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=p

[GitHub] [shardingsphere] TeslaCN opened a new pull request #10288: Translate performance-test-sysbench.cn.md into English

2021-05-09 Thread GitBox
TeslaCN opened a new pull request #10288: URL: https://github.com/apache/shardingsphere/pull/10288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10288: Translate performance-test-sysbench.cn.md into English

2021-05-09 Thread GitBox
codecov-commenter commented on pull request #10288: URL: https://github.com/apache/shardingsphere/pull/10288#issuecomment-835831401 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10288?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #10287: Move the user configuration to authority rule

2021-05-09 Thread GitBox
codecov-commenter edited a comment on pull request #10287: URL: https://github.com/apache/shardingsphere/pull/10287#issuecomment-835805337 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10287?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=p

[GitHub] [shardingsphere] MingxingLAI commented on pull request #9967: Issue#9948 refactor TablesContext

2021-05-09 Thread GitBox
MingxingLAI commented on pull request #9967: URL: https://github.com/apache/shardingsphere/pull/9967#issuecomment-836039944 got it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [shardingsphere] MingxingLAI closed pull request #9967: Issue#9948 refactor TablesContext

2021-05-09 Thread GitBox
MingxingLAI closed pull request #9967: URL: https://github.com/apache/shardingsphere/pull/9967 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this serv

[GitHub] [shardingsphere] zhujunxxxxx commented on pull request #10287: Move the user configuration to authority rule

2021-05-09 Thread GitBox
zhujunx commented on pull request #10287: URL: https://github.com/apache/shardingsphere/pull/10287#issuecomment-836059120 Hi @tristaZero, this PR need you review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [shardingsphere] tristaZero merged pull request #10288: Translate performance-test-sysbench.cn.md into English

2021-05-09 Thread GitBox
tristaZero merged pull request #10288: URL: https://github.com/apache/shardingsphere/pull/10288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this ser

[GitHub] [shardingsphere] MingxingLAI opened a new pull request #10289: Issue#9948 refactor TablesContext

2021-05-09 Thread GitBox
MingxingLAI opened a new pull request #10289: URL: https://github.com/apache/shardingsphere/pull/10289 Fixes #9948 Replace the previous pull request #9967 Changes proposed in this pull request: - getTableNames function - TablesContext constructor -- This is an au

[GitHub] [shardingsphere] MingxingLAI commented on issue #8982: show tables like xxx% can not return correct result

2021-05-09 Thread GitBox
MingxingLAI commented on issue #8982: URL: https://github.com/apache/shardingsphere/issues/8982#issuecomment-836109658 > @strongduanmu ok, thanks,but,I compare the code above,it is the same with 4.1.1, show tables still only returns the logical table name,my project [https://github.com/yuj

[GitHub] [shardingsphere] yanglangfei commented on issue #805: SUM、IFNULL NOT WORKING CORRECTLY WITH SHARDING!

2021-05-09 Thread GitBox
yanglangfei commented on issue #805: URL: https://github.com/apache/shardingsphere/issues/805#issuecomment-836131868 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [shardingsphere] tristaZero merged pull request #10289: Issue#9948 refactor TablesContext

2021-05-09 Thread GitBox
tristaZero merged pull request #10289: URL: https://github.com/apache/shardingsphere/pull/10289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this ser

[GitHub] [shardingsphere] tristaZero closed issue #9948: refactor TablesContext

2021-05-09 Thread GitBox
tristaZero closed issue #9948: URL: https://github.com/apache/shardingsphere/issues/9948 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [shardingsphere] tristaZero merged pull request #10285: Add alter sharding table rule

2021-05-09 Thread GitBox
tristaZero merged pull request #10285: URL: https://github.com/apache/shardingsphere/pull/10285 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this ser

[GitHub] [shardingsphere] tristaZero merged pull request #10281: Fixes disable data nodes

2021-05-09 Thread GitBox
tristaZero merged pull request #10281: URL: https://github.com/apache/shardingsphere/pull/10281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this ser

[GitHub] [shardingsphere] zexho994 opened a new issue #10290: application run failed for spring-boot-starter 5.0

2021-05-09 Thread GitBox
zexho994 opened a new issue #10290: URL: https://github.com/apache/shardingsphere/issues/10290 ### dependency ``` org.apache.shardingsphere shardingsphere-sharding-spring-boot-starter 5.0.0-alpha ``` ### application ``` spring: shardingsphere:

[GitHub] [shardingsphere] terrymanu opened a new pull request #10291: Add OpenGauss Database type

2021-05-09 Thread GitBox
terrymanu opened a new pull request #10291: URL: https://github.com/apache/shardingsphere/pull/10291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [shardingsphere] terrymanu commented on pull request #10291: Add OpenGauss Database type

2021-05-09 Thread GitBox
terrymanu commented on pull request #10291: URL: https://github.com/apache/shardingsphere/pull/10291#issuecomment-836169191 Incorrect branch, should push to opengauss_adapt branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [shardingsphere] terrymanu closed pull request #10291: Add OpenGauss Database type

2021-05-09 Thread GitBox
terrymanu closed pull request #10291: URL: https://github.com/apache/shardingsphere/pull/10291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this serv

[GitHub] [shardingsphere] terrymanu opened a new pull request #10292: Add OpenGauss Database type

2021-05-09 Thread GitBox
terrymanu opened a new pull request #10292: URL: https://github.com/apache/shardingsphere/pull/10292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [shardingsphere] terrymanu merged pull request #10292: Add OpenGauss Database type

2021-05-09 Thread GitBox
terrymanu merged pull request #10292: URL: https://github.com/apache/shardingsphere/pull/10292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this serv

[GitHub] [shardingsphere] terrymanu opened a new pull request #10293: Update javadoc of MariaDB DatabaseType

2021-05-09 Thread GitBox
terrymanu opened a new pull request #10293: URL: https://github.com/apache/shardingsphere/pull/10293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [shardingsphere] dongzl merged pull request #10293: Update javadoc of MariaDB DatabaseType

2021-05-09 Thread GitBox
dongzl merged pull request #10293: URL: https://github.com/apache/shardingsphere/pull/10293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service

[GitHub] [shardingsphere-elasticjob] skaic commented on issue #1889: IpUtils.getIp()方法获取不到ip

2021-05-09 Thread GitBox
skaic commented on issue #1889: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1889#issuecomment-836244835 this is your problem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [shardingsphere] terrymanu opened a new pull request #10294: Rename name config item form yaml for Readwrite-splitting

2021-05-09 Thread GitBox
terrymanu opened a new pull request #10294: URL: https://github.com/apache/shardingsphere/pull/10294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #10287: Move the user configuration to authority rule

2021-05-10 Thread GitBox
tristaZero commented on a change in pull request #10287: URL: https://github.com/apache/shardingsphere/pull/10287#discussion_r629096519 ## File path: shardingsphere-infra/shardingsphere-infra-context/src/main/java/org/apache/shardingsphere/infra/context/metadata/MetaDataContextsBuilde

[GitHub] [shardingsphere] tristaZero closed issue #10251: [API Change] Move the user configuration to authority rule

2021-05-10 Thread GitBox
tristaZero closed issue #10251: URL: https://github.com/apache/shardingsphere/issues/10251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [shardingsphere] tristaZero merged pull request #10287: Move the user configuration to authority rule

2021-05-10 Thread GitBox
tristaZero merged pull request #10287: URL: https://github.com/apache/shardingsphere/pull/10287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this ser

[GitHub] [shardingsphere] huanghao495430759 opened a new pull request #10295: Add GLOBAL_RULE_NODE in RegistryCenterNode.

2021-05-10 Thread GitBox
huanghao495430759 opened a new pull request #10295: URL: https://github.com/apache/shardingsphere/pull/10295 Fixes #10252. - Add GLOBAL_RULE_NODE in RegistryCenterNode. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [shardingsphere] zexho994 commented on issue #10290: application run failed for spring-boot-starter 5.0

2021-05-10 Thread GitBox
zexho994 commented on issue #10290: URL: https://github.com/apache/shardingsphere/issues/10290#issuecomment-836358628 ## update spring boot version : 2.1.7.RELEASE ss version : 5.0.0-alpha updated dependency ``` org.apache.shardingsphere shardingsphere-jdb

[GitHub] [shardingsphere] zhujunxxxxx commented on a change in pull request #10287: Move the user configuration to authority rule

2021-05-10 Thread GitBox
zhujunx commented on a change in pull request #10287: URL: https://github.com/apache/shardingsphere/pull/10287#discussion_r629153249 ## File path: shardingsphere-infra/shardingsphere-infra-context/src/main/java/org/apache/shardingsphere/infra/context/metadata/MetaDataContextsBuild

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10295: Add GLOBAL_RULE_NODE in RegistryCenterNode.

2021-05-10 Thread GitBox
codecov-commenter commented on pull request #10295: URL: https://github.com/apache/shardingsphere/pull/10295#issuecomment-836374777 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10295?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

<    1   2   3   4   5   6   7   8   9   10   >