[GitHub] [shardingsphere] MingxingLAI opened a new issue #10202: Reduce code complexity and improve readability for ShardingUnicastRoutingEngine

2021-04-26 Thread GitBox
MingxingLAI opened a new issue #10202: URL: https://github.com/apache/shardingsphere/issues/10202 When I read the source code of this project, The code readability of this [file](https://github.com/apache/shardingsphere/blob/master/shardingsphere-features/shardingsphere-sharding/shardingsph

[GitHub] [shardingsphere-elasticjob] kaihekaihe opened a new issue #1882: How do Listeners inject beans in spring?

2021-04-26 Thread GitBox
kaihekaihe opened a new issue #1882: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1882 ## Feature Request **For English only**, other languages will not accept. Please pay attention on issues you submitted, because we maybe need more details. If no respo

[GitHub] [shardingsphere-elasticjob] kaihekaihe commented on issue #1879: If the timeout parameter are set to 0L,then the thread executing some sharding may wait for Long.maxvalue.

2021-04-26 Thread GitBox
kaihekaihe commented on issue #1879: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1879#issuecomment-827288229 `startedTimeoutMilliseconds` and `compltedTimeoutMilliseconds` in class `AbstractDistributeOnceElasticJobListener` -- This is an automated message from the Ap

[GitHub] [shardingsphere] MingxingLAI opened a new pull request #10203: refactor ShardingUnicastRoutingEngine

2021-04-26 Thread GitBox
MingxingLAI opened a new pull request #10203: URL: https://github.com/apache/shardingsphere/pull/10203 Fixes #10202 . Changes proposed in this pull request: - Using stream to reduce forloop - extracting code block to an independent function to reduce the length of route functio

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10203: refactor ShardingUnicastRoutingEngine

2021-04-26 Thread GitBox
codecov-commenter commented on pull request #10203: URL: https://github.com/apache/shardingsphere/pull/10203#issuecomment-827300516 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10203?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[GitHub] [shardingsphere] RaigorJiang commented on issue #10202: Reduce code complexity and improve readability for ShardingUnicastRoutingEngine

2021-04-26 Thread GitBox
RaigorJiang commented on issue #10202: URL: https://github.com/apache/shardingsphere/issues/10202#issuecomment-827306512 Good idea 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [shardingsphere] menghaoranss opened a new pull request #10204: Add switch for ddl lock

2021-04-26 Thread GitBox
menghaoranss opened a new pull request #10204: URL: https://github.com/apache/shardingsphere/pull/10204 Fixes #10180 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [shardingsphere] tristaZero merged pull request #10204: Add switch for ddl lock

2021-04-26 Thread GitBox
tristaZero merged pull request #10204: URL: https://github.com/apache/shardingsphere/pull/10204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this ser

[GitHub] [shardingsphere] tristaZero closed issue #10180: Add a switch for DDL lock

2021-04-26 Thread GitBox
tristaZero closed issue #10180: URL: https://github.com/apache/shardingsphere/issues/10180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [shardingsphere] menghaoranss opened a new issue #10205: The metadata of the tables without sharding rule is not refreshed after ddl executed

2021-04-26 Thread GitBox
menghaoranss opened a new issue #10205: URL: https://github.com/apache/shardingsphere/issues/10205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [shardingsphere] laravelshao closed issue #10095: How sharding-jdbc config complex & hint sharding strategy together for same table

2021-04-26 Thread GitBox
laravelshao closed issue #10095: URL: https://github.com/apache/shardingsphere/issues/10095 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service

[GitHub] [shardingsphere] 243006306 commented on issue #10196: The following problems are found in the project transformation sharding-jdbc 4.1.1 scheme

2021-04-26 Thread GitBox
243006306 commented on issue #10196: URL: https://github.com/apache/shardingsphere/issues/10196#issuecomment-827352268 Force routing does not work, do not enter 'HintShardingAlgorithm` -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [shardingsphere] cherrylzhao closed issue #10150: reduce memory used of GroupByStreamMergeResult

2021-04-26 Thread GitBox
cherrylzhao closed issue #10150: URL: https://github.com/apache/shardingsphere/issues/10150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service

[GitHub] [shardingsphere] tristaZero commented on issue #10111: [SQL Definition Collation][Oracle]Collate the SQL definition of alter session

2021-04-27 Thread GitBox
tristaZero commented on issue #10111: URL: https://github.com/apache/shardingsphere/issues/10111#issuecomment-827420182 @ThanoshanMV Go ahead. BTW, your GSoC 2021 application is approved now. Let us wait its timeline moving. -- This is an automated message from the Apache Git Service

[GitHub] [shardingsphere] tristaZero commented on issue #10199: Striongly suggest to add new config for setting whether all tables are default sharded or not, then simplifying this kind of configurati

2021-04-27 Thread GitBox
tristaZero commented on issue #10199: URL: https://github.com/apache/shardingsphere/issues/10199#issuecomment-827422440 So you think the `defaultDatabaseStrategy` and `defaultTableStrategy` is not enough for your case? -- This is an automated message from the Apache Git Service. To re

[GitHub] [shardingsphere] tristaZero commented on issue #10105: rewrite sql error when using keyGenerator and encrypt together

2021-04-27 Thread GitBox
tristaZero commented on issue #10105: URL: https://github.com/apache/shardingsphere/issues/10105#issuecomment-827426579 Hi @huanghao495430759 I am curious whether you can give this issue a look? The detailed log from @wangkang09 budges me on our master branch. From your nice work,

[GitHub] [shardingsphere] tristaZero commented on pull request #10195: Fix exception message missing format in JDBCLockEngine

2021-04-27 Thread GitBox
tristaZero commented on pull request #10195: URL: https://github.com/apache/shardingsphere/pull/10195#issuecomment-827430936 @RaigorJiang Nice. @DreamSaddle Thanks for this PR, hope to see it merged later. -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [shardingsphere] tristaZero closed issue #10202: Reduce code complexity and improve readability for ShardingUnicastRoutingEngine

2021-04-27 Thread GitBox
tristaZero closed issue #10202: URL: https://github.com/apache/shardingsphere/issues/10202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [shardingsphere] tristaZero merged pull request #10203: refactor ShardingUnicastRoutingEngine

2021-04-27 Thread GitBox
tristaZero merged pull request #10203: URL: https://github.com/apache/shardingsphere/pull/10203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this ser

[GitHub] [shardingsphere] menghaoranss opened a new pull request #10206: Load metadata for tables without table rule

2021-04-27 Thread GitBox
menghaoranss opened a new pull request #10206: URL: https://github.com/apache/shardingsphere/pull/10206 Fixes #10205 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [shardingsphere] menghaoranss commented on issue #10198: 读写分离配合分表,分表失效

2021-04-27 Thread GitBox
menghaoranss commented on issue #10198: URL: https://github.com/apache/shardingsphere/issues/10198#issuecomment-827462976 For English only, other languages will not accept. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [shardingsphere] menghaoranss closed issue #10198: 读写分离配合分表,分表失效

2021-04-27 Thread GitBox
menghaoranss closed issue #10198: URL: https://github.com/apache/shardingsphere/issues/10198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [shardingsphere] menghaoranss commented on issue #10194: 期望有rust语言的shardingsphere

2021-04-27 Thread GitBox
menghaoranss commented on issue #10194: URL: https://github.com/apache/shardingsphere/issues/10194#issuecomment-827463377 For English only, other languages will not accept. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [shardingsphere] menghaoranss closed issue #10194: 期望有rust语言的shardingsphere

2021-04-27 Thread GitBox
menghaoranss closed issue #10194: URL: https://github.com/apache/shardingsphere/issues/10194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [shardingsphere] redesperado commented on issue #8382: Configuration property name 'spring.shardingsphere.rules.sharding.sharding-algorithms.database_inline.props' is not valid

2021-04-27 Thread GitBox
redesperado commented on issue #8382: URL: https://github.com/apache/shardingsphere/issues/8382#issuecomment-827465582 > @lly835 I have the same issue, have you resolved it? Is it resolved? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [shardingsphere-elasticjob] seeger12138 opened a new issue #1883: LiteJobFacade#isExecuteMisfired方法是先从zk获取是否需要分, 再判断misfired是否开启

2021-04-27 Thread GitBox
seeger12138 opened a new issue #1883: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1883 ## Feature Request **The LiteJobFacade#isExecuteMisfired method first obtains whether points are needed from zk`(!isNeedSharding())`, and then judges whether misfired is enable

[GitHub] [shardingsphere] leonTuT opened a new issue #10207: After using shardingJDBC, there is a problem with the processing of the date format

2021-04-27 Thread GitBox
leonTuT opened a new issue #10207: URL: https://github.com/apache/shardingsphere/issues/10207 ## After using shardingJDBC, there is a problem with the processing of the date format A field type in mysql is datetime (ex: 2021.04.27 16:20:00) Used tkmybatis, String used in the entit

[GitHub] [shardingsphere] menghaoranss opened a new pull request #10208: refactor document for governance

2021-04-27 Thread GitBox
menghaoranss opened a new pull request #10208: URL: https://github.com/apache/shardingsphere/pull/10208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries ab

[GitHub] [shardingsphere] menghaoranss commented on issue #10192: seata1.4+ShardingJdbc4.1+mybatisplus3.1 集成 分库分表,数据回滚了,undo_log表日志无法清除

2021-04-27 Thread GitBox
menghaoranss commented on issue #10192: URL: https://github.com/apache/shardingsphere/issues/10192#issuecomment-827479593 @chenchenggen007 please change the title to Englise -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #10206: Load metadata for tables without table rule

2021-04-27 Thread GitBox
tristaZero commented on a change in pull request #10206: URL: https://github.com/apache/shardingsphere/pull/10206#discussion_r621064913 ## File path: shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/metadata/schema/refresher/type/CreateTab

[GitHub] [shardingsphere] tristaZero merged pull request #10208: refactor document for governance

2021-04-27 Thread GitBox
tristaZero merged pull request #10208: URL: https://github.com/apache/shardingsphere/pull/10208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this ser

[GitHub] [shardingsphere] RaigorJiang commented on issue #10196: The following problems are found in the project transformation sharding-jdbc 4.1.1 scheme

2021-04-27 Thread GitBox
RaigorJiang commented on issue #10196: URL: https://github.com/apache/shardingsphere/issues/10196#issuecomment-827489397 Hi @243006306 Could you please provide a configuration and SQL, so we can reproduce it. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [shardingsphere] yang-7777 edited a comment on issue #650: Welcome to leave your article link(欢迎留下关于ShardingSphere的文章链接)

2021-04-27 Thread GitBox
yang- edited a comment on issue #650: URL: https://github.com/apache/shardingsphere/issues/650#issuecomment-682290385 ## 文章汇总 *** 版本迭代 - [Sharding-Sphere 3.X今日瞩目登场&如约而至!](https://mp.weixin.qq.com/s/TE8jFj2jQIlI7Gi3q_8Ulg) - [Sharding-Sphere 3.0.0.M2 我们来了!](https://m

[GitHub] [shardingsphere] RaigorJiang commented on issue #10207: After using shardingJDBC, there is a problem with the processing of the date format

2021-04-27 Thread GitBox
RaigorJiang commented on issue #10207: URL: https://github.com/apache/shardingsphere/issues/10207#issuecomment-827491610 Hi @leonTuT Thanks for your report. which version do you use? please give more details. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [shardingsphere] menghaoranss opened a new issue #10209: Metadata refresh failed when ddl executed with lock

2021-04-27 Thread GitBox
menghaoranss opened a new issue #10209: URL: https://github.com/apache/shardingsphere/issues/10209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [shardingsphere] menghaoranss opened a new pull request #10210: Fixes#10209 refactor governance lock for metadata refresh

2021-04-27 Thread GitBox
menghaoranss opened a new pull request #10210: URL: https://github.com/apache/shardingsphere/pull/10210 Fixes #10209 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [shardingsphere-elasticjob] TeslaCN merged pull request #1877: Use a random port for Spring Boot testcases

2021-04-27 Thread GitBox
TeslaCN merged pull request #1877: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1877 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about th

[GitHub] [shardingsphere-elasticjob] TeslaCN opened a new pull request #1884: Correct Maven Status badges' URL

2021-04-27 Thread GitBox
TeslaCN opened a new pull request #1884: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1884 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For querie

[GitHub] [shardingsphere-elasticjob] TeslaCN merged pull request #1884: Correct Maven Status badges' URL

2021-04-27 Thread GitBox
TeslaCN merged pull request #1884: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1884 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about th

[GitHub] [shardingsphere-elasticjob] TeslaCN commented on issue #1881: Specify an ip when job instance application deployed on a multi-ip server.

2021-04-27 Thread GitBox
TeslaCN commented on issue #1881: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1881#issuecomment-827588387 Hi @gonedays You may specify an interface by `-Delasticjob.preferred.network.interface=eth0` -- This is an automated message from the Apache Git Service. To

[GitHub] [shardingsphere] menghaoranss commented on a change in pull request #10206: Load metadata for tables without table rule

2021-04-27 Thread GitBox
menghaoranss commented on a change in pull request #10206: URL: https://github.com/apache/shardingsphere/pull/10206#discussion_r621188235 ## File path: shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/metadata/schema/refresher/type/CreateT

[GitHub] [shardingsphere] menghaoranss commented on a change in pull request #10206: Load metadata for tables without table rule

2021-04-27 Thread GitBox
menghaoranss commented on a change in pull request #10206: URL: https://github.com/apache/shardingsphere/pull/10206#discussion_r621189515 ## File path: shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/metadata/schema/refresher/type/CreateT

[GitHub] [shardingsphere-elasticjob] TeslaCN commented on issue #1883: LiteJobFacade#isExecuteMisfired method is to first obtain the need for points from zk, and then determine whether misfired is tur

2021-04-27 Thread GitBox
TeslaCN commented on issue #1883: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1883#issuecomment-827593070 Hi @seeger12138 Thanks for your feedback! Are you interested in submitting a PR to fix this issue? -- This is an automated message from the Apache Git Servic

[GitHub] [shardingsphere-elasticjob] TeslaCN commented on issue #1882: How do elasticjob listeners inject beans in spring?

2021-04-27 Thread GitBox
TeslaCN commented on issue #1882: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1882#issuecomment-827601067 Hi @kaihekaihe The listener doesn't support inject spring beans for now. Consider lazily retrieving beans by some static context holder. We're thinking about

[GitHub] [shardingsphere-elasticjob] seeger12138 commented on issue #1883: LiteJobFacade#isExecuteMisfired method is to first obtain the need for points from zk, and then determine whether misfired is

2021-04-27 Thread GitBox
seeger12138 commented on issue #1883: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1883#issuecomment-827618182 I am very happy to do this. Recently, I will take a detailed look at other places that can be optimized like this issue, and then make a summary and raise a PR

[GitHub] [shardingsphere] huanghao495430759 commented on issue #10105: rewrite sql error when using keyGenerator and encrypt together

2021-04-27 Thread GitBox
huanghao495430759 commented on issue #10105: URL: https://github.com/apache/shardingsphere/issues/10105#issuecomment-827639654 > Hi @huanghao495430759 > I am curious whether you can give this issue a look? > The detailed log from @wangkang09 budges me on our master branch. > From y

[GitHub] [shardingsphere-elasticjob] songxiaosheng edited a comment on issue #1854: Welcome to leave your article link (欢迎留下关于 ElasticJob 的文章链接)

2021-04-27 Thread GitBox
songxiaosheng edited a comment on issue #1854: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1854#issuecomment-804078668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [shardingsphere-elasticjob] songxiaosheng edited a comment on issue #1854: Welcome to leave your article link (欢迎留下关于 ElasticJob 的文章链接)

2021-04-27 Thread GitBox
songxiaosheng edited a comment on issue #1854: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1854#issuecomment-804078668 大家好 在这里为大家持续分享下调度系统源码设计,使用原理,文章发布自公众号:**中间件源码** 感兴趣可以关注下一起交流!!! # [Elastic-Job2.1.5源码-分布式弹性调度系统的简介](https://mp.weixin.qq.com/s/EuSqNzCHxjKU-w1k9va9V

[GitHub] [shardingsphere-elasticjob] songxiaosheng edited a comment on issue #1854: Welcome to leave your article link (欢迎留下关于 ElasticJob 的文章链接)

2021-04-27 Thread GitBox
songxiaosheng edited a comment on issue #1854: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1854#issuecomment-804078668 大家好 在这里为大家持续分享下分布式调度系统源码设计,使用原理系列教程,文章发布自公众号:**中间件源码** 感兴趣可以关注下 # [Elastic-Job2.1.5源码-分布式弹性调度系统的简介](https://mp.weixin.qq.com/s/EuSqNzCHxjKU-w1k9va9V

[GitHub] [shardingsphere-elasticjob] songxiaosheng edited a comment on issue #1854: Welcome to leave your article link (欢迎留下关于 ElasticJob 的文章链接)

2021-04-27 Thread GitBox
songxiaosheng edited a comment on issue #1854: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1854#issuecomment-804078668 大家好,在这里为大家持续分享下分布式调度系统源码设计,使用原理系列教程,文章发布自公众号:**中间件源码** 感兴趣可以关注下 # [Elastic-Job2.1.5源码-分布式弹性调度系统的简介](https://mp.weixin.qq.com/s/EuSqNzCHxjKU-w1k9va9V

[GitHub] [shardingsphere] tristaZero merged pull request #10210: Fixes#10209 refactor governance lock for metadata refresh

2021-04-27 Thread GitBox
tristaZero merged pull request #10210: URL: https://github.com/apache/shardingsphere/pull/10210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this ser

[GitHub] [shardingsphere] tristaZero closed issue #10209: Metadata refresh failed when ddl executed with lock

2021-04-27 Thread GitBox
tristaZero closed issue #10209: URL: https://github.com/apache/shardingsphere/issues/10209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [shardingsphere] TeslaCN opened a new pull request #10211: Refactor PostgreSQLAuthenticationOKPacket

2021-04-27 Thread GitBox
TeslaCN opened a new pull request #10211: URL: https://github.com/apache/shardingsphere/pull/10211 Refer to https://www.postgresql.org/docs/12/protocol-message-formats.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10211: Refactor PostgreSQLAuthenticationOKPacket

2021-04-27 Thread GitBox
codecov-commenter commented on pull request #10211: URL: https://github.com/apache/shardingsphere/pull/10211#issuecomment-828094099 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10211?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[GitHub] [shardingsphere] zhonghuali commented on issue #10199: Striongly suggest to add new config for setting whether all tables are default sharded or not, then simplifying this kind of configurati

2021-04-27 Thread GitBox
zhonghuali commented on issue #10199: URL: https://github.com/apache/shardingsphere/issues/10199#issuecomment-828098420 > So you think the `defaultDatabaseStrategy` and `defaultTableStrategy` is not enough for your case? I think the `defaultDatabaseStrategy` and `defaultTableStrategy` d

[GitHub] [shardingsphere] hanxu00920 commented on issue #10197: use orchestration for springboot can't work

2021-04-27 Thread GitBox
hanxu00920 commented on issue #10197: URL: https://github.com/apache/shardingsphere/issues/10197#issuecomment-828104265 somebody can help? I really need your help please. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [shardingsphere] 243006306 commented on issue #10196: The following problems are found in the project transformation sharding-jdbc 4.1.1 scheme

2021-04-27 Thread GitBox
243006306 commented on issue #10196: URL: https://github.com/apache/shardingsphere/issues/10196#issuecomment-828107404 SQL is like this `SELECT x.column_1,x.column_2 FROM( SELECT a.column_1,o.column_2 FROM A a INNER JOIN b b ON b.id = a.order_id AND b.mof_id = 'xx' WHERE a.xxx='xx

[GitHub] [shardingsphere] 243006306 commented on issue #10196: The following problems are found in the project transformation sharding-jdbc 4.1.1 scheme

2021-04-27 Thread GitBox
243006306 commented on issue #10196: URL: https://github.com/apache/shardingsphere/issues/10196#issuecomment-828108524 Configuration is like this : `spring.shardingsphere.sharding.binding-tables[0]=A,B spring.shardingsphere.sharding.tables.A.actual-data-nodes= spring.shardingsphere

[GitHub] [shardingsphere] 243006306 commented on issue #10196: The following problems are found in the project transformation sharding-jdbc 4.1.1 scheme

2021-04-27 Thread GitBox
243006306 commented on issue #10196: URL: https://github.com/apache/shardingsphere/issues/10196#issuecomment-828110459 My debug test found that the interpretation of SQL failed, so I chose the route of the random data source, just like the route of the Ping SQL test sent after starting th

[GitHub] [shardingsphere] 243006306 commented on issue #10196: The following problems are found in the project transformation sharding-jdbc 4.1.1 scheme

2021-04-27 Thread GitBox
243006306 commented on issue #10196: URL: https://github.com/apache/shardingsphere/issues/10196#issuecomment-828110932 我DEBUG测试发现解释SQL失败,所以选择了随机数据源的路由,就像未指定默认数据源启动项目后发送的ping SQL测试所走的路由一样,我想`HINT`模式不经过解析,直接走向我的`HintAlgorithm`类,因为我只需要分库,我测试发现去除最外层包裹的`SELECT X.X FROM `,就可以解析成功并走向自定义的`HintAlg

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10206: Load metadata for tables without table rule

2021-04-27 Thread GitBox
codecov-commenter commented on pull request #10206: URL: https://github.com/apache/shardingsphere/pull/10206#issuecomment-828125120 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10206?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #10206: Load metadata for tables without table rule

2021-04-27 Thread GitBox
tristaZero commented on a change in pull request #10206: URL: https://github.com/apache/shardingsphere/pull/10206#discussion_r62180 ## File path: shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/metadata/schema/refresher/type/AlterTabl

[GitHub] [shardingsphere] DreamSaddle commented on pull request #10195: Fix exception message missing format in JDBCLockEngine

2021-04-27 Thread GitBox
DreamSaddle commented on pull request #10195: URL: https://github.com/apache/shardingsphere/pull/10195#issuecomment-828164379 @tristaZero Ok! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [shardingsphere] tristaZero commented on issue #10199: Striongly suggest to add new config for setting whether all tables are default sharded or not, then simplifying this kind of configurati

2021-04-27 Thread GitBox
tristaZero commented on issue #10199: URL: https://github.com/apache/shardingsphere/issues/10199#issuecomment-828187875 Hi we have to distinguish which part of the configuration is shared and which one is not. `defaultDatabaseStrategy` and `defaultTableStrategy` are shared for each

[GitHub] [shardingsphere] November22 opened a new issue #10212: JdbcUtil#getSchema Compatibility problem of database connection driver

2021-04-27 Thread GitBox
November22 opened a new issue #10212: URL: https://github.com/apache/shardingsphere/issues/10212 ## Question net.sf.log4jdbc.ConnectionSpy not implemented java.sql.Connection#getSchema ,So throw an exception when getting metadata ![image](https://user-images.githubusercontent.c

[GitHub] [shardingsphere] leeey111 commented on issue #6693: information_schema and sys relevant SQLs can't parse or route

2021-04-28 Thread GitBox
leeey111 commented on issue #6693: URL: https://github.com/apache/shardingsphere/issues/6693#issuecomment-828229712 Any news? Without this feature support,it is inconvenienced to use "SQL complement" in some SQL clients like DBeaver. -- This is an automated message from the Apache Gi

[GitHub] [shardingsphere] MingxingLAI opened a new pull request #10213: Add more test cases for ShardingTableBroadcastRoutingEngine

2021-04-28 Thread GitBox
MingxingLAI opened a new pull request #10213: URL: https://github.com/apache/shardingsphere/pull/10213 Fixes #9411 Changes proposed in this pull request: - make test coverage up to 100% for ShardingTableBroadcastRoutingEngine -- This is an automated message from the Apache Git

[GitHub] [shardingsphere] MingxingLAI commented on pull request #9967: Issue#9948 refactor TablesContext

2021-04-28 Thread GitBox
MingxingLAI commented on pull request #9967: URL: https://github.com/apache/shardingsphere/pull/9967#issuecomment-828234518 Any suggestion or question ? @tristaZero @terrymanu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [shardingsphere] tristaZero merged pull request #10211: Refactor PostgreSQLAuthenticationOKPacket

2021-04-28 Thread GitBox
tristaZero merged pull request #10211: URL: https://github.com/apache/shardingsphere/pull/10211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this ser

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10213: Add more test cases for ShardingTableBroadcastRoutingEngine

2021-04-28 Thread GitBox
codecov-commenter commented on pull request #10213: URL: https://github.com/apache/shardingsphere/pull/10213#issuecomment-828258267 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10213?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[GitHub] [shardingsphere-elasticjob] seeger12138 opened a new pull request #1885: fix performance loss for the misfired configuration that is not turned on(#1883)

2021-04-28 Thread GitBox
seeger12138 opened a new pull request #1885: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1885 Fixes https://github.com/apache/shardingsphere-elasticjob/issues/1883 Changes proposed in this pull request: - Reverse order !isNeedSharding() && configService.load(true)

[GitHub] [shardingsphere-elasticjob] TeslaCN merged pull request #1885: #1883 fix performance loss for the misfired configuration that is not turned on

2021-04-28 Thread GitBox
TeslaCN merged pull request #1885: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about th

[GitHub] [shardingsphere-elasticjob] TeslaCN closed issue #1883: LiteJobFacade#isExecuteMisfired method is to first obtain the need for points from zk, and then determine whether misfired is turned on

2021-04-28 Thread GitBox
TeslaCN closed issue #1883: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1883 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [shardingsphere-elasticjob] TeslaCN commented on issue #1746: Investigate resource leak in restful module

2021-04-28 Thread GitBox
TeslaCN commented on issue #1746: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1746#issuecomment-828468391 We're going to make big changes to the ElasticJob Cloud. The Restful module may be refactored. -- This is an automated message from the Apache Git Service. To re

[GitHub] [shardingsphere-elasticjob] TeslaCN opened a new pull request #1886: Support configuring Mail SMTP SSL trust

2021-04-28 Thread GitBox
TeslaCN opened a new pull request #1886: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1886 Fixes #1880 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [shardingsphere-elasticjob] codecov-commenter commented on pull request #1886: Support configuring Mail SMTP SSL trust

2021-04-28 Thread GitBox
codecov-commenter commented on pull request #1886: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1886#issuecomment-828504103 # [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1886?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&u

[GitHub] [shardingsphere-elasticjob] codecov-commenter edited a comment on pull request #1886: Support configuring Mail SMTP SSL trust

2021-04-28 Thread GitBox
codecov-commenter edited a comment on pull request #1886: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1886#issuecomment-828504103 # [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1886?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=co

[GitHub] [shardingsphere-elasticjob] TeslaCN closed issue #1880: Support configuring Mail SMTP SSL trusted

2021-04-28 Thread GitBox
TeslaCN closed issue #1880: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1880 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [shardingsphere-elasticjob] TeslaCN merged pull request #1886: Support configuring Mail SMTP SSL trust

2021-04-28 Thread GitBox
TeslaCN merged pull request #1886: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about th

[GitHub] [shardingsphere] zhujunxxxxx opened a new pull request #10214: [feat] support alter database grammar

2021-04-28 Thread GitBox
zhujunx opened a new pull request #10214: URL: https://github.com/apache/shardingsphere/pull/10214 relate issues #10136. Changes proposed in this pull request: - support oracle alter database grammar - add test case -- This is an automated message from the Apache Git

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10214: Support alter database grammar

2021-04-28 Thread GitBox
codecov-commenter commented on pull request #10214: URL: https://github.com/apache/shardingsphere/pull/10214#issuecomment-828546318 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10214?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[GitHub] [shardingsphere] weiyue888999 opened a new pull request #10215: fix miss shardingsphere-encrypt-api dependency in example pom.xml

2021-04-28 Thread GitBox
weiyue888999 opened a new pull request #10215: URL: https://github.com/apache/shardingsphere/pull/10215 Fixes #ISSUSE_ID. Changes proposed in this pull request: - - - example模块的TestQueryAssistedShardingEncryptAlgorithm类依赖了org.apache.shardingsphere.encrypt.spi.QueryAssiste

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10215: fix miss shardingsphere-encrypt-api dependency in example pom.xml

2021-04-28 Thread GitBox
codecov-commenter commented on pull request #10215: URL: https://github.com/apache/shardingsphere/pull/10215#issuecomment-828850205 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10215?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[GitHub] [shardingsphere] wgy8283335 commented on pull request #10201: Fix Oracle addColumnSpecification grammar

2021-04-28 Thread GitBox
wgy8283335 commented on pull request #10201: URL: https://github.com/apache/shardingsphere/pull/10201#issuecomment-828859943 @tristaZero shall we merge the request or retry the CI? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [shardingsphere] wgy8283335 closed pull request #10168: 10104 oracle antlr transfer tool

2021-04-28 Thread GitBox
wgy8283335 closed pull request #10168: URL: https://github.com/apache/shardingsphere/pull/10168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this ser

[GitHub] [shardingsphere] strongduanmu commented on a change in pull request #10193: fix bad rewritten result for foreign key SQL

2021-04-28 Thread GitBox
strongduanmu commented on a change in pull request #10193: URL: https://github.com/apache/shardingsphere/pull/10193#discussion_r622667824 ## File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-route/src/main/java/org/apache/shardingsphere/sharding/route/

[GitHub] [shardingsphere] strongduanmu commented on a change in pull request #10193: fix bad rewritten result for foreign key SQL

2021-04-28 Thread GitBox
strongduanmu commented on a change in pull request #10193: URL: https://github.com/apache/shardingsphere/pull/10193#discussion_r622667824 ## File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-route/src/main/java/org/apache/shardingsphere/sharding/route/

[GitHub] [shardingsphere] November22 closed issue #10212: JdbcUtil#getSchema Compatibility problem of database connection driver

2021-04-28 Thread GitBox
November22 closed issue #10212: URL: https://github.com/apache/shardingsphere/issues/10212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [shardingsphere] hanxu00920 opened a new issue #10216: ShardingSphere-JDBC orchestration for Spring boot not available

2021-04-28 Thread GitBox
hanxu00920 opened a new issue #10216: URL: https://github.com/apache/shardingsphere/issues/10216 ### Which version of ShardingSphere did you use? 4.1.1 ### Which project did you use? ShardingSphere-JDBC or ShardingSphere-Proxy? ShardingSphere-JDBC ### Expected behavior zookeep

[GitHub] [shardingsphere] hanxu00920 closed issue #10197: use orchestration for springboot can't work

2021-04-28 Thread GitBox
hanxu00920 closed issue #10197: URL: https://github.com/apache/shardingsphere/issues/10197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [shardingsphere] strongduanmu commented on a change in pull request #10193: fix bad rewritten result for foreign key SQL

2021-04-28 Thread GitBox
strongduanmu commented on a change in pull request #10193: URL: https://github.com/apache/shardingsphere/pull/10193#discussion_r622667824 ## File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-route/src/main/java/org/apache/shardingsphere/sharding/route/

[GitHub] [shardingsphere] strongduanmu commented on a change in pull request #10193: fix bad rewritten result for foreign key SQL

2021-04-28 Thread GitBox
strongduanmu commented on a change in pull request #10193: URL: https://github.com/apache/shardingsphere/pull/10193#discussion_r622667824 ## File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-route/src/main/java/org/apache/shardingsphere/sharding/route/

[GitHub] [shardingsphere] leonTuT commented on issue #10207: After using shardingJDBC, there is a problem with the processing of the date format

2021-04-28 Thread GitBox
leonTuT commented on issue #10207: URL: https://github.com/apache/shardingsphere/issues/10207#issuecomment-828906158 sharding-jdbc => 4.0.0-RC2 tk.mybatis=> 2.0.4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [shardingsphere] hanxu00920 commented on issue #10216: ShardingSphere-JDBC orchestration for Spring boot not available

2021-04-28 Thread GitBox
hanxu00920 commented on issue #10216: URL: https://github.com/apache/shardingsphere/issues/10216#issuecomment-828918784 Did you really test and use a hybrid architecture? I googled other people's examples, and tried to use the 4.0.1 version of the dependency, and excluded many of the de

[GitHub] [shardingsphere] terrymanu closed issue #9411: Add more test cases for ShardingTableBroadcastRoutingEngineTest

2021-04-28 Thread GitBox
terrymanu closed issue #9411: URL: https://github.com/apache/shardingsphere/issues/9411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pl

[GitHub] [shardingsphere] terrymanu merged pull request #10213: Add more test cases for ShardingTableBroadcastRoutingEngine

2021-04-28 Thread GitBox
terrymanu merged pull request #10213: URL: https://github.com/apache/shardingsphere/pull/10213 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this serv

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #10206: Load metadata for tables without table rule

2021-04-28 Thread GitBox
tristaZero commented on a change in pull request #10206: URL: https://github.com/apache/shardingsphere/pull/10206#discussion_r622721481 ## File path: shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/metadata/schema/refresher/type/CreateTab

[GitHub] [shardingsphere] zhujunxxxxx commented on pull request #10214: Support alter database grammar

2021-04-28 Thread GitBox
zhujunx commented on pull request #10214: URL: https://github.com/apache/shardingsphere/pull/10214#issuecomment-828934469 @tristaZero please review this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [shardingsphere] MingxingLAI commented on issue #8982: show tables like xxx% can not return correct result

2021-04-28 Thread GitBox
MingxingLAI commented on issue #8982: URL: https://github.com/apache/shardingsphere/issues/8982#issuecomment-828984155 Hi @tristaZero, May I try this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [shardingsphere-elasticjob] SkyMoreStars commented on issue #1881: Specify an ip when job instance application deployed on a multi-ip server.

2021-04-29 Thread GitBox
SkyMoreStars commented on issue #1881: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1881#issuecomment-829002535 Your computer's firewall Settings in stealth mode may cause this problem. -- This is an automated message from the Apache Git Service. To respond to

<    1   2   3   4   5   6   7   8   9   10   >