[GitHub] [shardingsphere] xiaojingkai commented on issue #10107: (sharding-proxy)The value of character_set is transformed between utf8 and utf8mb4

2021-04-19 Thread GitBox
xiaojingkai commented on issue #10107: URL: https://github.com/apache/shardingsphere/issues/10107#issuecomment-822247775 When I use Navicat to connect sharding proxy, the value of character queried by SQL will change between utf8 and utf8mb4 -- This is an automated message from the Apac

[GitHub] [shardingsphere] enoera00 opened a new issue #10127: read-write-splitting doesn't work

2021-04-19 Thread GitBox
enoera00 opened a new issue #10127: URL: https://github.com/apache/shardingsphere/issues/10127 I use spring-boot 2.2.9.RELEASE , mybatis 2.1.3 and sharding-sphere 5.0.0-alpha, below is my config file: **application.yml** ``` server: port: 8080 spring: profiles:

[GitHub] [shardingsphere] 17602541404 opened a new issue #10128: field 'text'

2021-04-19 Thread GitBox
17602541404 opened a new issue #10128: URL: https://github.com/apache/shardingsphere/issues/10128 Is 'text' a keyword? The field name of a table is 'text', and an error occurs when SQL is executed. If so, is there any other solution besides changing the field name? -- This is an autom

[GitHub] [shardingsphere] menghaoranss opened a new pull request #10129: Add CREATE SHARDING BINDING TABLE RULES

2021-04-19 Thread GitBox
menghaoranss opened a new pull request #10129: URL: https://github.com/apache/shardingsphere/pull/10129 refer #10123 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10129: Add CREATE SHARDING BINDING TABLE RULES

2021-04-19 Thread GitBox
codecov-commenter commented on pull request #10129: URL: https://github.com/apache/shardingsphere/pull/10129#issuecomment-822312293 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10129?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[GitHub] [shardingsphere] RaigorJiang commented on issue #10128: field 'text'

2021-04-19 Thread GitBox
RaigorJiang commented on issue #10128: URL: https://github.com/apache/shardingsphere/issues/10128#issuecomment-822326048 @17602541404 Yes, 'TEXT' is a keyword. please see https://dev.mysql.com/doc/refman/5.7/en/keywords.html You can write the SQL with '`' as '`text`' -- This

[GitHub] [shardingsphere] RaigorJiang edited a comment on issue #10128: field 'text'

2021-04-19 Thread GitBox
RaigorJiang edited a comment on issue #10128: URL: https://github.com/apache/shardingsphere/issues/10128#issuecomment-822326048 @17602541404 Yes, 'TEXT' is a keyword. please see https://dev.mysql.com/doc/refman/5.7/en/keywords.html You can write the SQL with (`) as (`text`) -

[GitHub] [shardingsphere] RaigorJiang edited a comment on issue #10128: field 'text'

2021-04-19 Thread GitBox
RaigorJiang edited a comment on issue #10128: URL: https://github.com/apache/shardingsphere/issues/10128#issuecomment-822326048 @17602541404 Yes, 'TEXT' is a keyword. please see https://dev.mysql.com/doc/refman/5.7/en/keywords.html You can write the SQL with "`" as "`text`" -

[GitHub] [shardingsphere] RaigorJiang edited a comment on issue #10128: field 'text'

2021-04-19 Thread GitBox
RaigorJiang edited a comment on issue #10128: URL: https://github.com/apache/shardingsphere/issues/10128#issuecomment-822326048 @17602541404 Yes, 'TEXT' is a keyword. please see https://dev.mysql.com/doc/refman/5.7/en/keywords.html You can write the SQL with quote as "`text`"

[GitHub] [shardingsphere] RaigorJiang edited a comment on issue #10128: field 'text'

2021-04-19 Thread GitBox
RaigorJiang edited a comment on issue #10128: URL: https://github.com/apache/shardingsphere/issues/10128#issuecomment-822326048 @17602541404 Yes, 'TEXT' is a keyword. please see https://dev.mysql.com/doc/refman/5.7/en/keywords.html You can write the SQL with quote as "\`text\`"

[GitHub] [shardingsphere] RaigorJiang edited a comment on issue #10128: field 'text'

2021-04-19 Thread GitBox
RaigorJiang edited a comment on issue #10128: URL: https://github.com/apache/shardingsphere/issues/10128#issuecomment-822326048 @17602541404 Yes, 'TEXT' is a keyword. please see https://dev.mysql.com/doc/refman/5.7/en/keywords.html You can write the SQL with quote as \`text\`

[GitHub] [shardingsphere] menghaoranss opened a new pull request #10130: Verify duplicate sharding table names

2021-04-19 Thread GitBox
menghaoranss opened a new pull request #10130: URL: https://github.com/apache/shardingsphere/pull/10130 refer #10123 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [shardingsphere] huanghao495430759 closed pull request #10116: refactor AbstractSQLBuilder

2021-04-19 Thread GitBox
huanghao495430759 closed pull request #10116: URL: https://github.com/apache/shardingsphere/pull/10116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about t

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10130: Verify duplicate sharding table names for CREATE SHARDING TABLE RULE

2021-04-19 Thread GitBox
codecov-commenter commented on pull request #10130: URL: https://github.com/apache/shardingsphere/pull/10130#issuecomment-822392817 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10130?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[GitHub] [shardingsphere] TeslaCN opened a new issue #10131: Exception occurred when inserting values into a table with varchar primary key

2021-04-19 Thread GitBox
TeslaCN opened a new issue #10131: URL: https://github.com/apache/shardingsphere/issues/10131 ## Bug Report ### Which version of ShardingSphere did you use? master branch. But I think this issue exists in previous versions. ### Which project did you use? ShardingSphere-JD

[GitHub] [shardingsphere] TeslaCN opened a new pull request #10132: Get generated key only if column type is integer

2021-04-19 Thread GitBox
TeslaCN opened a new pull request #10132: URL: https://github.com/apache/shardingsphere/pull/10132 Fixes #10131 Changes proposed in this pull request: - Check key column type before get value. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [shardingsphere] xsong123 opened a new issue #10133: shardingjdbc 4.1.1 insert...select NullPointerException

2021-04-19 Thread GitBox
xsong123 opened a new issue #10133: URL: https://github.com/apache/shardingsphere/issues/10133 java.lang.NullPointerException at org.antlr.v4.runtime.tree.AbstractParseTreeVisitor.visit(AbstractParseTreeVisitor.java:18) at org.apache.shardingsphere.sql.parser.mysql.vi

[GitHub] [shardingsphere] xsong123 commented on issue #10133: shardingjdbc 4.1.1 insert...select NullPointerException

2021-04-19 Thread GitBox
xsong123 commented on issue #10133: URL: https://github.com/apache/shardingsphere/issues/10133#issuecomment-822444595 once in a while throw NPE(as above), not always. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10132: Get generated key only if column type is integer

2021-04-19 Thread GitBox
codecov-commenter commented on pull request #10132: URL: https://github.com/apache/shardingsphere/pull/10132#issuecomment-822447003 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10132?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[GitHub] [shardingsphere] poxiao1266 opened a new issue #10134: Shardingscaling does not support mysql 5.5.38;

2021-04-19 Thread GitBox
poxiao1266 opened a new issue #10134: URL: https://github.com/apache/shardingsphere/issues/10134 Shardingscaling does not support mysql 5.5.38;an error is reported when used; the error message is as follows: org.apache.shardingsphere.scaling.core.exception.PrepareFailedException:

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #10130: Verify duplicate sharding table names for CREATE SHARDING TABLE RULE

2021-04-19 Thread GitBox
tristaZero commented on a change in pull request #10130: URL: https://github.com/apache/shardingsphere/pull/10130#discussion_r615839577 ## File path: shardingsphere-db-protocol/shardingsphere-db-protocol-core/src/main/java/org/apache/shardingsphere/db/protocol/error/CommonErrorCode.ja

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #10132: Get generated key only if column type is integer

2021-04-19 Thread GitBox
tristaZero commented on a change in pull request #10132: URL: https://github.com/apache/shardingsphere/pull/10132#discussion_r615845420 ## File path: shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/executor/cal

[GitHub] [shardingsphere] Liangda-w commented on pull request #10052: Complete Oracle drop table partition grammar

2021-04-19 Thread GitBox
Liangda-w commented on pull request #10052: URL: https://github.com/apache/shardingsphere/pull/10052#issuecomment-822469483 Hi, I think since we can't let `physicalAttributesClause` contains an empty String, we can indicate the possibility of empty String at a higher level (in the clauses

[GitHub] [shardingsphere] TeslaCN commented on a change in pull request #10132: Get generated key only if column type is integer

2021-04-19 Thread GitBox
TeslaCN commented on a change in pull request #10132: URL: https://github.com/apache/shardingsphere/pull/10132#discussion_r615867797 ## File path: shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/executor/callba

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10052: Complete Oracle drop table partition grammar

2021-04-19 Thread GitBox
codecov-commenter commented on pull request #10052: URL: https://github.com/apache/shardingsphere/pull/10052#issuecomment-822490830 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10052?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[GitHub] [shardingsphere] TeslaCN commented on a change in pull request #10132: Get generated key only if column type is integer

2021-04-19 Thread GitBox
TeslaCN commented on a change in pull request #10132: URL: https://github.com/apache/shardingsphere/pull/10132#discussion_r615876833 ## File path: shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/executor/callba

[GitHub] [shardingsphere] TeslaCN commented on issue #9089: an error occurred when using shrding proxy

2021-04-19 Thread GitBox
TeslaCN commented on issue #9089: URL: https://github.com/apache/shardingsphere/issues/9089#issuecomment-822498224 I had the same problem. The option `-A` works for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [shardingsphere] tristaZero merged pull request #10129: Add CREATE SHARDING BINDING TABLE RULES

2021-04-19 Thread GitBox
tristaZero merged pull request #10129: URL: https://github.com/apache/shardingsphere/pull/10129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this ser

[shardingsphere] branch master updated (ae1cda0 -> ff59a77)

2021-04-19 Thread panjuan
This is an automated email from the ASF dual-hosted git repository. panjuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere.git. from ae1cda0 Move authority into infra module (#10124) add ff59a77 Add CREATE SHARDING BINDING TABLE RULES

[GitHub] [shardingsphere] sandynz commented on a change in pull request #10121: Report execution process from one proxy for running SQLs by RQL

2021-04-19 Thread GitBox
sandynz commented on a change in pull request #10121: URL: https://github.com/apache/shardingsphere/pull/10121#discussion_r615893420 ## File path: shardingsphere-infra/shardingsphere-infra-executor/src/main/java/org/apache/shardingsphere/infra/executor/sql/process/spi/ExecuteProcessRe

[GitHub] [shardingsphere-elasticjob] songxiaosheng edited a comment on issue #1854: Welcome to leave your article link (欢迎留下关于 ElasticJob 的文章链接)

2021-04-19 Thread GitBox
songxiaosheng edited a comment on issue #1854: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1854#issuecomment-804078668 文章来源-公众号:**中间件源码** # [Elastic-Job2.1.5源码-分布式弹性调度系统的简介](https://mp.weixin.qq.com/s/EuSqNzCHxjKU-w1k9va9Vg) ## 1 Elastic-Job2.1.5源码-分布式弹性调度系统的简介

[GitHub] [shardingsphere-elasticjob] songxiaosheng edited a comment on issue #1854: Welcome to leave your article link (欢迎留下关于 ElasticJob 的文章链接)

2021-04-19 Thread GitBox
songxiaosheng edited a comment on issue #1854: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1854#issuecomment-804078668 文章来源-公众号:**中间件源码** # [Elastic-Job2.1.5源码-分布式弹性调度系统的简介](https://mp.weixin.qq.com/s/EuSqNzCHxjKU-w1k9va9Vg) ## 1 Elastic-Job2.1.5源码-分布式弹性调度系统的简介

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #10052: Complete Oracle drop table partition grammar

2021-04-19 Thread GitBox
codecov-commenter edited a comment on pull request #10052: URL: https://github.com/apache/shardingsphere/pull/10052#issuecomment-822490830 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10052?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=p

[GitHub] [shardingsphere] wangkang09 commented on issue #10105: rewrite sql error when using keyGenerator and encrypt together

2021-04-19 Thread GitBox
wangkang09 commented on issue #10105: URL: https://github.com/apache/shardingsphere/issues/10105#issuecomment-822554620 alpha version can be used in production? could you give same related information to help me persuade my leader -- This is an automated message from the Apache Git Ser

[GitHub] [shardingsphere] terrymanu commented on a change in pull request #10132: Get generated key only if column type is integer

2021-04-19 Thread GitBox
terrymanu commented on a change in pull request #10132: URL: https://github.com/apache/shardingsphere/pull/10132#discussion_r615943958 ## File path: shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/executor/call

[GitHub] [shardingsphere] wangkang09 removed a comment on issue #10105: rewrite sql error when using keyGenerator and encrypt together

2021-04-19 Thread GitBox
wangkang09 removed a comment on issue #10105: URL: https://github.com/apache/shardingsphere/issues/10105#issuecomment-822554620 alpha version can be used in production? could you give same related information to help me persuade my leader -- This is an automated message from the Apache

[GitHub] [shardingsphere] wangkang09 commented on issue #10105: rewrite sql error when using keyGenerator and encrypt together

2021-04-19 Thread GitBox
wangkang09 commented on issue #10105: URL: https://github.com/apache/shardingsphere/issues/10105#issuecomment-822555145 > Could you try the 5.0.0-alpha? I suppose we fixed it already. alpha version can be used in production? could you give same related information to help me persuad

[GitHub] [shardingsphere] dmsolr opened a new pull request #10135: Support governance for JDBC scenario

2021-04-19 Thread GitBox
dmsolr opened a new pull request #10135: URL: https://github.com/apache/shardingsphere/pull/10135 Fixes #ISSUSE_ID. Changes proposed in this pull request: - - - -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [shardingsphere] dmsolr closed pull request #10120: [WIP] Support governance for JDBC scenario

2021-04-19 Thread GitBox
dmsolr closed pull request #10120: URL: https://github.com/apache/shardingsphere/pull/10120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service

[GitHub] [shardingsphere] tristaZero closed issue #10131: Exception occurred when inserting values into a table with varchar primary key

2021-04-19 Thread GitBox
tristaZero closed issue #10131: URL: https://github.com/apache/shardingsphere/issues/10131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[shardingsphere] branch master updated (ff59a77 -> b44e2f6)

2021-04-19 Thread panjuan
This is an automated email from the ASF dual-hosted git repository. panjuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere.git. from ff59a77 Add CREATE SHARDING BINDING TABLE RULES (#10129) add b44e2f6 Get generated key only if column

[GitHub] [shardingsphere] tristaZero merged pull request #10132: Get generated key only if column type is integer

2021-04-19 Thread GitBox
tristaZero merged pull request #10132: URL: https://github.com/apache/shardingsphere/pull/10132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this ser

[GitHub] [shardingsphere] tristaZero commented on pull request #9967: Issue#9948 refactor TablesContext

2021-04-19 Thread GitBox
tristaZero commented on pull request #9967: URL: https://github.com/apache/shardingsphere/pull/9967#issuecomment-822863845 Hi any progress? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #10115: Implement PostgreSQLPrivilegeHandler and add unit test

2021-04-19 Thread GitBox
tristaZero commented on a change in pull request #10115: URL: https://github.com/apache/shardingsphere/pull/10115#discussion_r616253396 ## File path: shardingsphere-features/shardingsphere-authority/shardingsphere-authority-common/src/main/java/org/apache/shardingsphere/authority/prov

[GitHub] [shardingsphere] tristaZero commented on issue #10105: rewrite sql error when using keyGenerator and encrypt together

2021-04-19 Thread GitBox
tristaZero commented on issue #10105: URL: https://github.com/apache/shardingsphere/issues/10105#issuecomment-822869415 Hi we suggest users to try 5.0.0-alpha, since it fixed many issues of 4.x releases and supported more complex SQLs. Besides, more maintenance work will be done on this

[GitHub] [shardingsphere] tristaZero merged pull request #10121: Report execution process from one proxy for running SQLs by RQL

2021-04-19 Thread GitBox
tristaZero merged pull request #10121: URL: https://github.com/apache/shardingsphere/pull/10121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this ser

[shardingsphere] branch master updated (b44e2f6 -> 69f5753)

2021-04-19 Thread panjuan
This is an automated email from the ASF dual-hosted git repository. panjuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere.git. from b44e2f6 Get generated key only if column type is integer (#10132) add 69f5753 Report execution proces

[GitHub] [shardingsphere] wgy8283335 commented on pull request #10052: Complete Oracle drop table partition grammar

2021-04-19 Thread GitBox
wgy8283335 commented on pull request #10052: URL: https://github.com/apache/shardingsphere/pull/10052#issuecomment-822876695 > Hi, I think since we can't let `physicalAttributesClause` contains an empty String, we can indicate the possibility of empty String at a higher level (in the claus

[GitHub] [shardingsphere] tristaZero commented on issue #10092: Subquery does not support as

2021-04-19 Thread GitBox
tristaZero commented on issue #10092: URL: https://github.com/apache/shardingsphere/issues/10092#issuecomment-822882284 Hey, welcome. :) The beta release is under preparation now. WeChat ID `ss_assistant_1` will guide you to enter WeChat group. -- This is an automated message from the A

[GitHub] [shardingsphere] tristaZero commented on issue #10086: Is there a better way to cofig sharding properties

2021-04-19 Thread GitBox
tristaZero commented on issue #10086: URL: https://github.com/apache/shardingsphere/issues/10086#issuecomment-822888502 Hi I mean once `default-database-strategy` and `t_order.database-strategy` exist, `t_order.database-strategy` will override the default one. So if you want default st

[GitHub] [shardingsphere] tristaZero commented on issue #10106: bug, emoji cant save(insert) or update, update is work shardingsphere-5.0.0-alpha

2021-04-19 Thread GitBox
tristaZero commented on issue #10106: URL: https://github.com/apache/shardingsphere/issues/10106#issuecomment-822888980 Hi which client did you use? Sharding Proxy or Sharding JDBC? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [shardingsphere] tristaZero commented on issue #10118: why sharding-jdbc-spring-boot-starter still in 4.1.1 ?

2021-04-19 Thread GitBox
tristaZero commented on issue #10118: URL: https://github.com/apache/shardingsphere/issues/10118#issuecomment-822889257 @RaigorJiang Nice. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [shardingsphere] tristaZero opened a new issue #10136: [SQL Definition Collation][Oracle]Collate the SQL definition of ALTER SYNONYM

2021-04-19 Thread GitBox
tristaZero opened a new issue #10136: URL: https://github.com/apache/shardingsphere/issues/10136 This issue is the subsequent one from [#9603](https://github.com/apache/shardingsphere/pull/9603#issuecomment-796600731). Oracle Ref -> https://docs.oracle.com/en/database/oracle/ora

[GitHub] [shardingsphere] wgy8283335 commented on a change in pull request #10117: Add SQL Definition for `ALTER SESSION` of Oracle Database

2021-04-19 Thread GitBox
wgy8283335 commented on a change in pull request #10117: URL: https://github.com/apache/shardingsphere/pull/10117#discussion_r616266104 ## File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle/DDLStatemen

[GitHub] [shardingsphere] tristaZero commented on pull request #9603: [SQL Definition Collation][Oracle]Collate the SQL definition of SET ROLE

2021-04-19 Thread GitBox
tristaZero commented on pull request #9603: URL: https://github.com/apache/shardingsphere/pull/9603#issuecomment-822890436 Hi @zhujunx Sorry for for so-late reply but please have my welcome here. #10136 is waiting for your comment. :) -- This is an automated message from the Apach

[GitHub] [shardingsphere] wgy8283335 commented on a change in pull request #10117: Add SQL Definition for `ALTER SESSION` of Oracle Database

2021-04-19 Thread GitBox
wgy8283335 commented on a change in pull request #10117: URL: https://github.com/apache/shardingsphere/pull/10117#discussion_r616269858 ## File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle/DDLStatemen

[GitHub] [shardingsphere] tristaZero commented on issue #10136: [SQL Definition Collation][Oracle]Collate the SQL definition of ALTER SYNONYM

2021-04-19 Thread GitBox
tristaZero commented on issue #10136: URL: https://github.com/apache/shardingsphere/issues/10136#issuecomment-822891076 @zhujunx will take it over. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [shardingsphere] tristaZero commented on issue #8571: Cannot invoke method mod() on null object] with root cause

2021-04-19 Thread GitBox
tristaZero commented on issue #8571: URL: https://github.com/apache/shardingsphere/issues/8571#issuecomment-822893185 Hi the log showed us the potential reason that there are some null or unqualified values for the sharding column. -- This is an automated message from the Apache Git Serv

[GitHub] [shardingsphere] totalo commented on a change in pull request #10115: Implement PostgreSQLPrivilegeHandler and add unit test

2021-04-19 Thread GitBox
totalo commented on a change in pull request #10115: URL: https://github.com/apache/shardingsphere/pull/10115#discussion_r616272125 ## File path: shardingsphere-features/shardingsphere-authority/shardingsphere-authority-common/src/main/java/org/apache/shardingsphere/authority/provider

[GitHub] [shardingsphere] tristaZero commented on issue #10127: read-write-splitting doesn't work

2021-04-19 Thread GitBox
tristaZero commented on issue #10127: URL: https://github.com/apache/shardingsphere/issues/10127#issuecomment-822894086 Hi could you set `sql-show` = `true`? That way, we can get the routing details. BTW, what's your query SQL? -- This is an automated message from the Apache Git Service

[GitHub] [shardingsphere] wgy8283335 commented on a change in pull request #10052: Complete Oracle drop table partition grammar

2021-04-19 Thread GitBox
wgy8283335 commented on a change in pull request #10052: URL: https://github.com/apache/shardingsphere/pull/10052#discussion_r616276547 ## File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle/DDLStatemen

[GitHub] [shardingsphere] wgy8283335 edited a comment on pull request #10052: Complete Oracle drop table partition grammar

2021-04-19 Thread GitBox
wgy8283335 edited a comment on pull request #10052: URL: https://github.com/apache/shardingsphere/pull/10052#issuecomment-822876695 > Hi, I think since we can't let `physicalAttributesClause` contains an empty String, we can indicate the possibility of empty String at a higher level (in th

[GitHub] [shardingsphere] wgy8283335 commented on a change in pull request #10052: Complete Oracle drop table partition grammar

2021-04-19 Thread GitBox
wgy8283335 commented on a change in pull request #10052: URL: https://github.com/apache/shardingsphere/pull/10052#discussion_r616276547 ## File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle/DDLStatemen

[GitHub] [shardingsphere] tristaZero commented on issue #10108: Using Oracle database, the program starts to check the table that has not been created

2021-04-19 Thread GitBox
tristaZero commented on issue #10108: URL: https://github.com/apache/shardingsphere/issues/10108#issuecomment-822901747 Hi @strongduanmu could you look at this one? My impression that `INDEX` metadata loading was in your charge? -- This is an automated message from the Apache Git Servic

[GitHub] [shardingsphere] tristaZero commented on issue #10109: AopConfigException

2021-04-19 Thread GitBox
tristaZero commented on issue #10109: URL: https://github.com/apache/shardingsphere/issues/10109#issuecomment-822903488 Sorry? I did not see any valuable log on the exception inner ShardingSphere. Could you provide more? -- This is an automated message from the Apache Git Service. To re

[GitHub] [shardingsphere] tristaZero commented on issue #10119: RangeShardingAlgorithm Generic problem, specified as Date, actually a string

2021-04-19 Thread GitBox
tristaZero commented on issue #10119: URL: https://github.com/apache/shardingsphere/issues/10119#issuecomment-822903487 Hi as @RaigorJiang said, we have fixed this one from 5.x release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [shardingsphere] tristaZero commented on issue #10126: sqlserver row_number() over() faild,Error preparing statement. Cause: org.antlr.v4.runtime.misc.ParseCancellationException

2021-04-19 Thread GitBox
tristaZero commented on issue #10126: URL: https://github.com/apache/shardingsphere/issues/10126#issuecomment-822903733 @dongzl Hi could you give it a check whether our new release or branch has supported this SQL? -- This is an automated message from the Apache Git Service. To respond

[GitHub] [shardingsphere] 726411951 commented on issue #10086: Is there a better way to cofig sharding properties

2021-04-19 Thread GitBox
726411951 commented on issue #10086: URL: https://github.com/apache/shardingsphere/issues/10086#issuecomment-822906345 > > You can consider using the `default-table-strategy` and `default-database-strategy`. > > hi, @tristaZero ,I tried to use the `default-database-strategy` like

[GitHub] [shardingsphere] 726411951 edited a comment on issue #10086: Is there a better way to cofig sharding properties

2021-04-19 Thread GitBox
726411951 edited a comment on issue #10086: URL: https://github.com/apache/shardingsphere/issues/10086#issuecomment-822906345 > > You can consider using the `default-table-strategy` and `default-database-strategy`. > > hi, @tristaZero ,I tried to use the `default-database-strategy`

[GitHub] [shardingsphere-elasticjob] TeslaCN commented on pull request #1873: Make sure supporting the case that job instances are crashed while ex…

2021-04-19 Thread GitBox
TeslaCN commented on pull request #1873: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1873#issuecomment-822922371 Hi @sucg Thanks for your contribution! Before merging this PR, I'll make some tests about failover. -- This is an automated message from the Apache Git

[GitHub] [shardingsphere-elasticjob] TeslaCN commented on pull request #1873: Make sure supporting the case that job instances are crashed while ex…

2021-04-19 Thread GitBox
TeslaCN commented on pull request #1873: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1873#issuecomment-822927794 I deployed 3 nodes in Docker. Killed one when the job was running. But NPE occurred and the failover didn't worked. My Job: ```java @Slf4j publ

[GitHub] [shardingsphere-elasticjob] TeslaCN edited a comment on pull request #1873: Make sure supporting the case that job instances are crashed while ex…

2021-04-19 Thread GitBox
TeslaCN edited a comment on pull request #1873: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1873#issuecomment-822927794 I deployed 3 nodes in Docker. Killed one when the job was running. But NPE occurred and the failover didn't worked. Did I missed something? My Jo

[GitHub] [shardingsphere] menghaoranss commented on a change in pull request #10130: Verify duplicate sharding table names for CREATE SHARDING TABLE RULE

2021-04-19 Thread GitBox
menghaoranss commented on a change in pull request #10130: URL: https://github.com/apache/shardingsphere/pull/10130#discussion_r616323659 ## File path: shardingsphere-db-protocol/shardingsphere-db-protocol-core/src/main/java/org/apache/shardingsphere/db/protocol/error/CommonErrorCode.

[GitHub] [shardingsphere] ThanoshanMV commented on a change in pull request #10117: Add SQL Definition for `ALTER SESSION` of Oracle Database

2021-04-19 Thread GitBox
ThanoshanMV commented on a change in pull request #10117: URL: https://github.com/apache/shardingsphere/pull/10117#discussion_r616324236 ## File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle/DDLStateme

[GitHub] [shardingsphere] ThanoshanMV commented on a change in pull request #10117: Add SQL Definition for `ALTER SESSION` of Oracle Database

2021-04-19 Thread GitBox
ThanoshanMV commented on a change in pull request #10117: URL: https://github.com/apache/shardingsphere/pull/10117#discussion_r616339372 ## File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle/DDLStateme

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #10130: Verify duplicate sharding table names for CREATE SHARDING TABLE RULE

2021-04-19 Thread GitBox
codecov-commenter edited a comment on pull request #10130: URL: https://github.com/apache/shardingsphere/pull/10130#issuecomment-822392817 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10130?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=p

[GitHub] [shardingsphere] menghaoranss commented on issue #10134: Shardingscaling does not support mysql 5.5.38;

2021-04-19 Thread GitBox
menghaoranss commented on issue #10134: URL: https://github.com/apache/shardingsphere/issues/10134#issuecomment-822998990 which version of ShardingSphere do you use, and have you tried other versions of mysql? -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [shardingsphere] strongduanmu commented on issue #10108: Using Oracle database, the program starts to check the table that has not been created

2021-04-19 Thread GitBox
strongduanmu commented on issue #10108: URL: https://github.com/apache/shardingsphere/issues/10108#issuecomment-823001092 > Hi @strongduanmu could you look at this one? My impression that `INDEX` metadata loading was in your charge? Hi @ljwps, thank you very much for your feedback.

[GitHub] [shardingsphere] strongduanmu edited a comment on issue #10108: Using Oracle database, the program starts to check the table that has not been created

2021-04-19 Thread GitBox
strongduanmu edited a comment on issue #10108: URL: https://github.com/apache/shardingsphere/issues/10108#issuecomment-823001092 > Hi @strongduanmu could you look at this one? My impression that `INDEX` metadata loading was in your charge? Hi @ljwps, thank you very much for your fee