Re: [PR] Enhance the support for Oracle SQL parsing [shardingsphere]

2024-04-02 Thread via GitHub
strongduanmu merged PR #30742: URL: https://github.com/apache/shardingsphere/pull/30742 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-un

Re: [PR] Enhance the support for Oracle SQL parsing [shardingsphere]

2024-04-02 Thread via GitHub
zhuruixuan commented on code in PR #30742: URL: https://github.com/apache/shardingsphere/pull/30742#discussion_r1547244037 ## test/it/parser/src/main/resources/sql/supported/ddl/create-trigger.xml: ## @@ -50,4 +50,47 @@ BEGIN :NEW.ID := Contacts_Seq.NEXTVAL

Re: [PR] Enhance the support for Oracle SQL parsing [shardingsphere]

2024-04-01 Thread via GitHub
strongduanmu commented on code in PR #30742: URL: https://github.com/apache/shardingsphere/pull/30742#discussion_r1547183642 ## test/it/parser/src/main/resources/sql/supported/ddl/create-trigger.xml: ## @@ -50,4 +50,47 @@ BEGIN :NEW.ID := Contacts_Seq.NEXTV

Re: [PR] Enhance the support for Oracle SQL parsing [shardingsphere]

2024-03-26 Thread via GitHub
tuichenchuxin merged PR #30663: URL: https://github.com/apache/shardingsphere/pull/30663 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

Re: [PR] Enhance the support for Oracle SQL parsing [shardingsphere]

2024-03-20 Thread via GitHub
strongduanmu merged PR #30557: URL: https://github.com/apache/shardingsphere/pull/30557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-un

Re: [PR] Enhance the support for Oracle SQL parsing [shardingsphere]

2024-03-18 Thread via GitHub
strongduanmu merged PR #30526: URL: https://github.com/apache/shardingsphere/pull/30526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-un

Re: [PR] Enhance the support for Oracle SQL parsing [shardingsphere]

2024-03-18 Thread via GitHub
zhuruixuan closed pull request #30526: Enhance the support for Oracle SQL parsing URL: https://github.com/apache/shardingsphere/pull/30526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Enhance the support for Oracle SQL parsing [shardingsphere]

2024-03-17 Thread via GitHub
strongduanmu commented on code in PR #30526: URL: https://github.com/apache/shardingsphere/pull/30526#discussion_r1527894357 ## parser/sql/dialect/oracle/src/main/antlr4/imports/oracle/DDLStatement.g4: ## @@ -1030,7 +1030,7 @@ externalTableClause ; externalTableDataProps