Re: [PR] Added unit tests for TableMetadataReviseEngine (#28535) [shardingsphere]

2023-12-02 Thread via GitHub
strongduanmu merged PR #28627: URL: https://github.com/apache/shardingsphere/pull/28627 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-un

Re: [PR] Added unit tests for TableMetadataReviseEngine (#28535) [shardingsphere]

2023-11-30 Thread via GitHub
gagan-gv commented on PR #28627: URL: https://github.com/apache/shardingsphere/pull/28627#issuecomment-183719 Hi, @strongduanmu can you review PR. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Added unit tests for TableMetadataReviseEngine (#28535) [shardingsphere]

2023-11-20 Thread via GitHub
gagan-gv commented on PR #28627: URL: https://github.com/apache/shardingsphere/pull/28627#issuecomment-1818935640 Hey @strongduanmu , can you please review the PR. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Added unit tests for TableMetadataReviseEngine (#28535) [shardingsphere]

2023-11-14 Thread via GitHub
gagan-gv commented on PR #28627: URL: https://github.com/apache/shardingsphere/pull/28627#issuecomment-1810366052 Hi, Can someone review this PR? Thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Added unit tests for TableMetadataReviseEngine (#28535) [shardingsphere]

2023-11-02 Thread via GitHub
gagan-gv commented on PR #28627: URL: https://github.com/apache/shardingsphere/pull/28627#issuecomment-1790356966 Hi, @strongduanmu, I have made the changes asked. Can you re-review the PR? Thank you! -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Added unit tests for TableMetadataReviseEngine (#28535) [shardingsphere]

2023-10-27 Thread via GitHub
gagan-gv commented on code in PR #28627: URL: https://github.com/apache/shardingsphere/pull/28627#discussion_r1374511009 ## infra/common/src/test/java/org/apache/shardingsphere/infra/metadata/database/schema/reviser/table/TableMetadataReviseEngineTest.java: ## @@ -0,0 +1,117 @@

Re: [PR] Added unit tests for TableMetadataReviseEngine (#28535) [shardingsphere]

2023-10-27 Thread via GitHub
gagan-gv commented on code in PR #28627: URL: https://github.com/apache/shardingsphere/pull/28627#discussion_r1374510457 ## infra/common/src/test/java/org/apache/shardingsphere/infra/metadata/database/schema/reviser/table/TableMetadataReviseEngineTest.java: ## @@ -0,0 +1,117 @@

Re: [PR] Added unit tests for TableMetadataReviseEngine (#28535) [shardingsphere]

2023-10-27 Thread via GitHub
gagan-gv commented on code in PR #28627: URL: https://github.com/apache/shardingsphere/pull/28627#discussion_r1374510798 ## infra/common/src/test/java/org/apache/shardingsphere/infra/metadata/database/schema/reviser/table/TableMetadataReviseEngineTest.java: ## @@ -0,0 +1,117 @@

Re: [PR] Added unit tests for TableMetadataReviseEngine (#28535) [shardingsphere]

2023-10-26 Thread via GitHub
strongduanmu commented on code in PR #28627: URL: https://github.com/apache/shardingsphere/pull/28627#discussion_r1373972825 ## infra/common/src/test/java/org/apache/shardingsphere/infra/metadata/database/schema/reviser/table/TableMetadataReviseEngineTest.java: ## @@ -0,0 +1,117

Re: [PR] Added unit tests for TableMetadataReviseEngine (#28535) [shardingsphere]

2023-10-17 Thread via GitHub
gagan-gv commented on PR #28627: URL: https://github.com/apache/shardingsphere/pull/28627#issuecomment-1766718263 Hey @zhaojinchao95, I've made the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Added unit tests for TableMetadataReviseEngine (#28535) [shardingsphere]

2023-10-16 Thread via GitHub
gagan-gv commented on code in PR #28627: URL: https://github.com/apache/shardingsphere/pull/28627#discussion_r1361513224 ## infra/common/src/test/java/org/apache/shardingsphere/infra/metadata/database/schema/reviser/table/TableMetadataReviseEngineTest.java: ## @@ -0,0 +1,135 @@

Re: [PR] Added unit tests for TableMetadataReviseEngine (#28535) [shardingsphere]

2023-10-16 Thread via GitHub
gagan-gv commented on code in PR #28627: URL: https://github.com/apache/shardingsphere/pull/28627#discussion_r1361512800 ## infra/common/src/test/java/org/apache/shardingsphere/infra/metadata/database/schema/reviser/table/TableMetadataReviseEngineTest.java: ## @@ -0,0 +1,135 @@

Re: [PR] Added unit tests for TableMetadataReviseEngine (#28535) [shardingsphere]

2023-10-15 Thread via GitHub
zhaojinchao95 commented on code in PR #28627: URL: https://github.com/apache/shardingsphere/pull/28627#discussion_r1360140152 ## infra/common/src/test/java/org/apache/shardingsphere/infra/metadata/database/schema/reviser/table/TableMetadataReviseEngineTest.java: ## @@ -0,0 +1,13

Re: [PR] Added unit tests for TableMetadataReviseEngine (#28535) [shardingsphere]

2023-10-15 Thread via GitHub
zhaojinchao95 commented on code in PR #28627: URL: https://github.com/apache/shardingsphere/pull/28627#discussion_r1360140016 ## infra/common/src/test/java/org/apache/shardingsphere/infra/metadata/database/schema/reviser/table/TableMetadataReviseEngineTest.java: ## @@ -0,0 +1,13

Re: [PR] Added unit tests for TableMetadataReviseEngine (#28535) [shardingsphere]

2023-10-15 Thread via GitHub
zhaojinchao95 commented on code in PR #28627: URL: https://github.com/apache/shardingsphere/pull/28627#discussion_r1360139897 ## infra/common/src/test/java/org/apache/shardingsphere/infra/metadata/database/schema/reviser/table/TableMetadataReviseEngineTest.java: ## @@ -0,0 +1,13

Re: [PR] Added unit tests for TableMetadataReviseEngine (#28535) [shardingsphere]

2023-10-07 Thread via GitHub
gagan-gv commented on PR #28627: URL: https://github.com/apache/shardingsphere/pull/28627#issuecomment-1751686701 Hi, I've run all the pre-build checks and have updated the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[PR] Added unit tests for TableMetadataReviseEngine (#28535) [shardingsphere]

2023-10-03 Thread via GitHub
gagan-gv opened a new pull request, #28627: URL: https://github.com/apache/shardingsphere/pull/28627 Fixes #28535. Changes proposed in this pull request: - Added UT for TableMetadataReviseEngine w.r.t #28535 --- Before committing this PR, I'm sure that I have checke

Re: [PR] Added unit tests for TableMetadataReviseEngine (#28535) [shardingsphere]

2023-10-03 Thread via GitHub
gagan-gv closed pull request #28626: Added unit tests for TableMetadataReviseEngine (#28535) URL: https://github.com/apache/shardingsphere/pull/28626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to