strongduanmu merged PR #28627:
URL: https://github.com/apache/shardingsphere/pull/28627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-un
gagan-gv commented on PR #28627:
URL: https://github.com/apache/shardingsphere/pull/28627#issuecomment-183719
Hi,
@strongduanmu can you review PR.
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
gagan-gv commented on PR #28627:
URL: https://github.com/apache/shardingsphere/pull/28627#issuecomment-1818935640
Hey @strongduanmu , can you please review the PR.
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
gagan-gv commented on PR #28627:
URL: https://github.com/apache/shardingsphere/pull/28627#issuecomment-1810366052
Hi,
Can someone review this PR?
Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
gagan-gv commented on PR #28627:
URL: https://github.com/apache/shardingsphere/pull/28627#issuecomment-1790356966
Hi,
@strongduanmu, I have made the changes asked. Can you re-review the PR?
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the
gagan-gv commented on code in PR #28627:
URL: https://github.com/apache/shardingsphere/pull/28627#discussion_r1374511009
##
infra/common/src/test/java/org/apache/shardingsphere/infra/metadata/database/schema/reviser/table/TableMetadataReviseEngineTest.java:
##
@@ -0,0 +1,117 @@
gagan-gv commented on code in PR #28627:
URL: https://github.com/apache/shardingsphere/pull/28627#discussion_r1374510457
##
infra/common/src/test/java/org/apache/shardingsphere/infra/metadata/database/schema/reviser/table/TableMetadataReviseEngineTest.java:
##
@@ -0,0 +1,117 @@
gagan-gv commented on code in PR #28627:
URL: https://github.com/apache/shardingsphere/pull/28627#discussion_r1374510798
##
infra/common/src/test/java/org/apache/shardingsphere/infra/metadata/database/schema/reviser/table/TableMetadataReviseEngineTest.java:
##
@@ -0,0 +1,117 @@
strongduanmu commented on code in PR #28627:
URL: https://github.com/apache/shardingsphere/pull/28627#discussion_r1373972825
##
infra/common/src/test/java/org/apache/shardingsphere/infra/metadata/database/schema/reviser/table/TableMetadataReviseEngineTest.java:
##
@@ -0,0 +1,117
gagan-gv commented on PR #28627:
URL: https://github.com/apache/shardingsphere/pull/28627#issuecomment-1766718263
Hey @zhaojinchao95, I've made the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
gagan-gv commented on code in PR #28627:
URL: https://github.com/apache/shardingsphere/pull/28627#discussion_r1361513224
##
infra/common/src/test/java/org/apache/shardingsphere/infra/metadata/database/schema/reviser/table/TableMetadataReviseEngineTest.java:
##
@@ -0,0 +1,135 @@
gagan-gv commented on code in PR #28627:
URL: https://github.com/apache/shardingsphere/pull/28627#discussion_r1361512800
##
infra/common/src/test/java/org/apache/shardingsphere/infra/metadata/database/schema/reviser/table/TableMetadataReviseEngineTest.java:
##
@@ -0,0 +1,135 @@
zhaojinchao95 commented on code in PR #28627:
URL: https://github.com/apache/shardingsphere/pull/28627#discussion_r1360140152
##
infra/common/src/test/java/org/apache/shardingsphere/infra/metadata/database/schema/reviser/table/TableMetadataReviseEngineTest.java:
##
@@ -0,0 +1,13
zhaojinchao95 commented on code in PR #28627:
URL: https://github.com/apache/shardingsphere/pull/28627#discussion_r1360140016
##
infra/common/src/test/java/org/apache/shardingsphere/infra/metadata/database/schema/reviser/table/TableMetadataReviseEngineTest.java:
##
@@ -0,0 +1,13
zhaojinchao95 commented on code in PR #28627:
URL: https://github.com/apache/shardingsphere/pull/28627#discussion_r1360139897
##
infra/common/src/test/java/org/apache/shardingsphere/infra/metadata/database/schema/reviser/table/TableMetadataReviseEngineTest.java:
##
@@ -0,0 +1,13
gagan-gv commented on PR #28627:
URL: https://github.com/apache/shardingsphere/pull/28627#issuecomment-1751686701
Hi, I've run all the pre-build checks and have updated the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
gagan-gv opened a new pull request, #28627:
URL: https://github.com/apache/shardingsphere/pull/28627
Fixes #28535.
Changes proposed in this pull request:
- Added UT for TableMetadataReviseEngine w.r.t #28535
---
Before committing this PR, I'm sure that I have checke
gagan-gv closed pull request #28626: Added unit tests for
TableMetadataReviseEngine (#28535)
URL: https://github.com/apache/shardingsphere/pull/28626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
18 matches
Mail list logo