Re: [PR] Added Support for SQL Server INSERT INTO Parsing [shardingsphere]

strongduanmu closed pull request #29230: Added Support for SQL Server INSERT INTO Parsing URL: https://github.com/apache/shardingsphere/pull/29230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Added Support for SQL Server INSERT INTO Parsing [shardingsphere]

strongduanmu commented on PR #29230: URL: https://github.com/apache/shardingsphere/pull/29230#issuecomment-1956073134 Since this pr has long time no response, I will close it. You can submit new pr when you are free. -- This is an automated message from the Apache Git Service. To

Re: [PR] Added Support for SQL Server INSERT INTO Parsing [shardingsphere]

BykaWF commented on PR #29230: URL: https://github.com/apache/shardingsphere/pull/29230#issuecomment-1892568151 Hi @strongduanmu, yes I can -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Added Support for SQL Server INSERT INTO Parsing [shardingsphere]

strongduanmu commented on PR #29230: URL: https://github.com/apache/shardingsphere/pull/29230#issuecomment-1891229516 Hi @BykaWF, can you solve the latest code conflict? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Added Support for SQL Server INSERT INTO Parsing [shardingsphere]

BykaWF commented on PR #29230: URL: https://github.com/apache/shardingsphere/pull/29230#issuecomment-1868372948 I've addressed the issues pointed out in the previous review. Could you please review this updated version? Thank you! -- This is an automated message from the Apache Git Servic

Re: [PR] Added Support for SQL Server INSERT INTO Parsing [shardingsphere]

BykaWF closed pull request #29230: Added Support for SQL Server INSERT INTO Parsing URL: https://github.com/apache/shardingsphere/pull/29230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] Added Support for SQL Server INSERT INTO Parsing [shardingsphere]

strongduanmu commented on PR #29230: URL: https://github.com/apache/shardingsphere/pull/29230#issuecomment-1867383399 Hi @BykaWF, can you solve code conflict? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] Added Support for SQL Server INSERT INTO Parsing [shardingsphere]

BykaWF commented on PR #29230: URL: https://github.com/apache/shardingsphere/pull/29230#issuecomment-1854526843 @TherChenYang thanks for helping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Added Support for SQL Server INSERT INTO Parsing [shardingsphere]

TherChenYang commented on PR #29230: URL: https://github.com/apache/shardingsphere/pull/29230#issuecomment-1853449392 @strongduanmu @BykaWF ` org.apache.shardingsphere.sql.parser.exception.SQLParsingException: You have an error in your SQL syntax: SELECT Test1Col = x FROM #t, no viable

Re: [PR] Added Support for SQL Server INSERT INTO Parsing [shardingsphere]

TherChenYang commented on PR #29230: URL: https://github.com/apache/shardingsphere/pull/29230#issuecomment-1853360923 > I've encountered an issue during testing where I consistently receive the following error: > > ``` > org.apache.shardingsphere.sql.parser.exception.SQLParsingEx

Re: [PR] Added Support for SQL Server INSERT INTO Parsing [shardingsphere]

strongduanmu commented on PR #29230: URL: https://github.com/apache/shardingsphere/pull/29230#issuecomment-1837470154 > @strongduanmu In SQL Server, the # symbol means temporary tables, which are session-specific and automatically dropped when the session ends. @BykaWF Thank you for y

Re: [PR] Added Support for SQL Server INSERT INTO Parsing [shardingsphere]

BykaWF commented on PR #29230: URL: https://github.com/apache/shardingsphere/pull/29230#issuecomment-1837465508 @strongduanmu In SQL Server, the # symbol means temporary tables, which are session-specific and automatically dropped when the session ends. -- This is an automated message fro

Re: [PR] Added Support for SQL Server INSERT INTO Parsing [shardingsphere]

strongduanmu commented on PR #29230: URL: https://github.com/apache/shardingsphere/pull/29230#issuecomment-1837460457 > IDENTIFIER_ Hi @BykaWF, What does `#` mean in SQLServer dialect? -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Added Support for SQL Server INSERT INTO Parsing [shardingsphere]

BykaWF commented on PR #29230: URL: https://github.com/apache/shardingsphere/pull/29230#issuecomment-1837210941 I've encountered an issue during testing where I consistently receive the following error: org.apache.shardingsphere.sql.parser.exception.SQLParsingException: You hav

Re: [PR] Added Support for SQL Server INSERT INTO Parsing [shardingsphere]

BykaWF commented on PR #29230: URL: https://github.com/apache/shardingsphere/pull/29230#issuecomment-1837209500 I've encountered an issue during testing where I consistently receive the following error: -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] Added Support for SQL Server INSERT INTO Parsing [shardingsphere]

strongduanmu commented on code in PR #29230: URL: https://github.com/apache/shardingsphere/pull/29230#discussion_r1408603319 ## test/it/parser/src/main/resources/case/dml/insert.xml: ## @@ -2900,4 +2900,36 @@ + Review Comment: Where is the o

[PR] Added Support for SQL Server INSERT INTO Parsing [shardingsphere]

BykaWF opened a new pull request, #29230: URL: https://github.com/apache/shardingsphere/pull/29230 Fixes #29194. Changes proposed in this pull request: It adds support for parsing the following SQL Server INSERT INTO statements: INSERT INTO #MyTempTable VALUES (1)