[GitHub] [shardingsphere]: Workflow run "E2E - Agent" is working again!

2023-10-03 Thread GitBox
The GitHub Actions job "E2E - Agent" on shardingsphere.git has succeeded. Run started by GitHub user terrymanu (triggered by terrymanu). Head commit for run: 194f58347ec9f64a38d7e21e1cf8c0c1029fd106 / zhangliang Refactor StorageUnitMetaData.dataSourcePoolProperties Report URL: https://github.c

[PR] Refactor StorageUnitMetaData.dataSourcePoolProperties [shardingsphere]

2023-10-03 Thread via GitHub
terrymanu opened a new pull request, #28633: URL: https://github.com/apache/shardingsphere/pull/28633 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [shardingsphere]: Workflow run "E2E - Agent" failed!

2023-10-03 Thread GitBox
The GitHub Actions job "E2E - Agent" on shardingsphere.git has failed. Run started by GitHub user terrymanu (triggered by terrymanu). Head commit for run: 2e88835dfb68e7cbdbd665542d151bc7136a01df / zhangliang Refactor StorageUnitMetaData.dataSource Report URL: https://github.com/apache/shardin

[shardingsphere] branch master updated: Refactor StorageUnitMetaData.dataSource (#28632)

2023-10-03 Thread duanzhengqiang
This is an automated email from the ASF dual-hosted git repository. duanzhengqiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere.git The following commit(s) were added to refs/heads/master by this push: new eb3c984da0b Refactor StorageUnit

Re: [PR] Refactor StorageUnitMetaData.dataSource [shardingsphere]

2023-10-03 Thread via GitHub
strongduanmu merged PR #28632: URL: https://github.com/apache/shardingsphere/pull/28632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-un

[PR] Refactor StorageUnitMetaData.dataSource [shardingsphere]

2023-10-03 Thread via GitHub
terrymanu opened a new pull request, #28632: URL: https://github.com/apache/shardingsphere/pull/28632 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [I] Support parsing openGauss ALTER sql [shardingsphere]

2023-10-03 Thread via GitHub
akashpambhar commented on issue #27859: URL: https://github.com/apache/shardingsphere/issues/27859#issuecomment-1746126000 @strongduanmu can you please guide me on this. I'm trying to add parsing support for > ALTER TEXT SEARCH CONFIGURATION joe.ngram2 RENAME TO ngram_2; For t

[GitHub] [shardingsphere]: Workflow run "Required - Check" is working again!

2023-10-03 Thread GitBox
The GitHub Actions job "Required - Check" on shardingsphere.git has succeeded. Run started by GitHub user zihaoAK47 (triggered by zihaoAK47). Head commit for run: bc375b9dac648a001c95bb5a9eae8876a9cf / niu niu Format code Report URL: https://github.com/apache/shardingsphere/actions/runs/64

[GitHub] [shardingsphere]: Workflow run "Required - Check" failed!

2023-10-03 Thread GitBox
The GitHub Actions job "Required - Check" on shardingsphere.git has failed. Run started by GitHub user zihaoAK47 (triggered by zihaoAK47). Head commit for run: fd025522ac42bf9c696a69a10af395458990e2f2 / niu niu Change sql federation insert statement conversion Report URL: https://github.com/ap

[PR] Change sql federation insert statement conversion [shardingsphere]

2023-10-03 Thread via GitHub
zihaoAK47 opened a new pull request, #28631: URL: https://github.com/apache/shardingsphere/pull/28631 Fixes #ISSUSE_ID. Changes proposed in this pull request: - Change sql federation insert statement conversion - Fix conversion sql case --- Before committing thi

Re: [PR] Add oracle alter table modifylobStorageClause parse rule [shardingsphere]

2023-10-03 Thread via GitHub
zihaoAK47 commented on code in PR #28628: URL: https://github.com/apache/shardingsphere/pull/28628#discussion_r1345080922 ## test/it/parser/src/main/resources/case/ddl/alter-table.xml: ## @@ -1600,11 +1590,6 @@ - Review Comment: Define incorrect

Re: [I] Support parsing Oracle ALTER TABLE sql [shardingsphere]

2023-10-03 Thread via GitHub
strongduanmu commented on issue #26990: URL: https://github.com/apache/shardingsphere/issues/26990#issuecomment-1745992147 @zihaoAK47 Assigned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Add oracle alter table modifylobStorageClause parse rule [shardingsphere]

2023-10-03 Thread via GitHub
strongduanmu commented on code in PR #28628: URL: https://github.com/apache/shardingsphere/pull/28628#discussion_r1345050814 ## test/it/parser/src/main/resources/case/ddl/alter-table.xml: ## @@ -1600,11 +1590,6 @@ - Review Comment: Why remove `m

Re: [I] Support parsing Oracle CREATE OR sql [shardingsphere]

2023-10-03 Thread via GitHub
strongduanmu commented on issue #27080: URL: https://github.com/apache/shardingsphere/issues/27080#issuecomment-1745990275 If you are interested, you can try to finish this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [shardingsphere]: Workflow run "Nightly - E2E Operation" failed!

2023-10-03 Thread GitBox
The GitHub Actions job "Nightly - E2E Operation" on shardingsphere.git has failed. Run started by GitHub user taojintianxia (triggered by taojintianxia). Head commit for run: 166a16e73a1255ef3fde1acee126e6090d545744 / yx9o Rename return parameter to result (#28630) Report URL: https://github.

[GitHub] [shardingsphere]: Workflow run "Nightly - Check" failed!

2023-10-03 Thread GitBox
The GitHub Actions job "Nightly - Check" on shardingsphere.git has failed. Run started by GitHub user terrymanu (triggered by terrymanu). Head commit for run: 166a16e73a1255ef3fde1acee126e6090d545744 / yx9o Rename return parameter to result (#28630) Report URL: https://github.com/apache/shardi

[GitHub] [shardingsphere]: Workflow run "Nightly - CI" failed!

2023-10-03 Thread GitBox
The GitHub Actions job "Nightly - CI" on shardingsphere.git has failed. Run started by GitHub user taojintianxia (triggered by taojintianxia). Head commit for run: 166a16e73a1255ef3fde1acee126e6090d545744 / yx9o Rename return parameter to result (#28630) Report URL: https://github.com/apache/s

[GitHub] [shardingsphere]: Workflow run "Nightly - Build" failed!

2023-10-03 Thread GitBox
The GitHub Actions job "Nightly - Build" on shardingsphere.git has failed. Run started by GitHub user zhaojinchao95 (triggered by zhaojinchao95). Head commit for run: 5157ed08d5ed6cc60ee862733a907f3c172c4bb0 / Liang Zhang Remove ResourceMetaData.storageUnitMetaData (#28629) * Remove ResourceMe

[shardingsphere] branch master updated: Rename return parameter to result (#28630)

2023-10-03 Thread wuweijie
This is an automated email from the ASF dual-hosted git repository. wuweijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere.git The following commit(s) were added to refs/heads/master by this push: new 166a16e73a1 Rename return parameter to

Re: [PR] Rename return parameter to result [shardingsphere]

2023-10-03 Thread via GitHub
TeslaCN merged PR #28630: URL: https://github.com/apache/shardingsphere/pull/28630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Remove ResourceMetaData.storageUnitMetaData [shardingsphere]

2023-10-03 Thread via GitHub
yx9o merged PR #28629: URL: https://github.com/apache/shardingsphere/pull/28629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr..

[shardingsphere] branch master updated (29defea3b82 -> 5157ed08d5e)

2023-10-03 Thread yx9o
This is an automated email from the ASF dual-hosted git repository. yx9o pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere.git from 29defea3b82 Fix import test case config files (#28624) add 5157ed08d5e Remove ResourceMetaData.storageUnitM

[PR] Rename return parameter to result [shardingsphere]

2023-10-03 Thread via GitHub
yx9o opened a new pull request, #28630: URL: https://github.com/apache/shardingsphere/pull/28630 Rename return parameter to result. --- Before committing this PR, I'm sure that I have checked the following options: - [ ] My code follows the [code of conduct](https://shardin

[PR] Remove ResourceMetaData.storageUnitMetaData [shardingsphere]

2023-10-03 Thread via GitHub
terrymanu opened a new pull request, #28629: URL: https://github.com/apache/shardingsphere/pull/28629 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[PR] Add oracle alter table modifylobStorageClause parse rule [shardingsphere]

2023-10-03 Thread via GitHub
zihaoAK47 opened a new pull request, #28628: URL: https://github.com/apache/shardingsphere/pull/28628 Ref #26990. Changes proposed in this pull request: - Add oracle alter table modifylobStorageClause parse rule - Add test sql --- Before committing this PR, I'm

Re: [I] Support parsing Oracle ALTER TABLE sql [shardingsphere]

2023-10-03 Thread via GitHub
zihaoAK47 commented on issue #26990: URL: https://github.com/apache/shardingsphere/issues/26990#issuecomment-1744801812 Please assign the questions to me. Thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] Add more unit tests for TableMetaDataReviseEngine [shardingsphere]

2023-10-03 Thread via GitHub
gagan-gv commented on issue #28535: URL: https://github.com/apache/shardingsphere/issues/28535#issuecomment-1744702999 Please find the PR link below: https://github.com/apache/shardingsphere/pull/28627 -- This is an automated message from the Apache Git Service. To respond to the messa

[PR] Added unit tests for TableMetadataReviseEngine (#28535) [shardingsphere]

2023-10-03 Thread via GitHub
gagan-gv opened a new pull request, #28627: URL: https://github.com/apache/shardingsphere/pull/28627 Fixes #28535. Changes proposed in this pull request: - Added UT for TableMetadataReviseEngine w.r.t #28535 --- Before committing this PR, I'm sure that I have checke

Re: [I] Add more unit tests for TableMetaDataReviseEngine [shardingsphere]

2023-10-03 Thread via GitHub
gagan-gv commented on issue #28535: URL: https://github.com/apache/shardingsphere/issues/28535#issuecomment-1744674199 Hey, just forgot to add the licence before the code, so, raising a new PR. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Added unit tests for TableMetadataReviseEngine (#28535) [shardingsphere]

2023-10-03 Thread via GitHub
gagan-gv closed pull request #28626: Added unit tests for TableMetadataReviseEngine (#28535) URL: https://github.com/apache/shardingsphere/pull/28626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] Add more unit tests for TableMetaDataReviseEngine [shardingsphere]

2023-10-03 Thread via GitHub
gagan-gv commented on issue #28535: URL: https://github.com/apache/shardingsphere/issues/28535#issuecomment-1744656064 Hey, I've added the test cases and have raised a PR: https://github.com/apache/shardingsphere/pull/28626 -- This is an automated message from the Apache Git Service. To

[PR] Added unit tests for TableMetadataReviseEngine (#28487) [shardingsphere]

2023-10-03 Thread via GitHub
gagan-gv opened a new pull request, #28626: URL: https://github.com/apache/shardingsphere/pull/28626 Fixes #28487. Changes proposed in this pull request: Have added unit tests w.r.t the issue ##28535 --- Before committing this PR, I'm sure that I have checked the foll