[GitHub] [shardingsphere] RaigorJiang commented on pull request #16579: encrypt-spring-boot-jpa-example

2022-05-21 Thread GitBox
RaigorJiang commented on PR #16579: URL: https://github.com/apache/shardingsphere/pull/16579#issuecomment-1133832109 Sorry, there are a lot of affected files (some test cases) that don't seem to be related to example, can you update the PR after merging master locally? -- This is an autom

[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #17838: Refactor ExportableConstant

2022-05-21 Thread GitBox
RaigorJiang commented on code in PR #17838: URL: https://github.com/apache/shardingsphere/pull/17838#discussion_r878805493 ## shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/distsql/constant/ExportableConstants.java: ## @@ -26,19 +2

[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #17838: Refactor ExportableConstant

2022-05-21 Thread GitBox
RaigorJiang commented on code in PR #17838: URL: https://github.com/apache/shardingsphere/pull/17838#discussion_r878805147 ## shardingsphere-features/shardingsphere-db-discovery/shardingsphere-db-discovery-distsql/shardingsphere-db-discovery-distsql-handler/src/test/java/org/apache/shar

[GitHub] [shardingsphere] codecov-commenter commented on pull request #17855: Add spotless XML formatting rule

2022-05-21 Thread GitBox
codecov-commenter commented on PR #17855: URL: https://github.com/apache/shardingsphere/pull/17855#issuecomment-1133830842 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17855?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_te

[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #17820: Rename schema to database

2022-05-21 Thread GitBox
RaigorJiang commented on code in PR #17820: URL: https://github.com/apache/shardingsphere/pull/17820#discussion_r878804722 ## shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/distsql/rql/impl/rule/Coun

[GitHub] [shardingsphere] longtai-cn opened a new pull request, #17855: Add spotless XML formatting rule

2022-05-21 Thread GitBox
longtai-cn opened a new pull request, #17855: URL: https://github.com/apache/shardingsphere/pull/17855 Changes proposed in this pull request: - Add spotless XML formatting rule. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [shardingsphere] tuyendev commented on issue #17779: Graalvm native image cause with Groovy 4

2022-05-21 Thread GitBox
tuyendev commented on issue #17779: URL: https://github.com/apache/shardingsphere/issues/17779#issuecomment-1133821586 @linghengqian Sorry for lately reply. I will continue checking on Monday next week, I’m currently in my days off 🌝 -- This is an automated message from the Apache Git Se

[shardingsphere] branch master updated: Rename backendDatabaseType to storageType (#17854)

2022-05-21 Thread menghaoran
This is an automated email from the ASF dual-hosted git repository. menghaoran pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere.git The following commit(s) were added to refs/heads/master by this push: new 55c26fbe247 Rename backendDatabaseTy

[GitHub] [shardingsphere] menghaoranss merged pull request #17854: Rename backendDatabaseType to storageType

2022-05-21 Thread GitBox
menghaoranss merged PR #17854: URL: https://github.com/apache/shardingsphere/pull/17854 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-un

[shardingsphere] branch master updated: feat: disable indication of mvn install in CI (#17851)

2022-05-21 Thread zhangliang
This is an automated email from the ASF dual-hosted git repository. zhangliang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere.git The following commit(s) were added to refs/heads/master by this push: new 4a73c43c093 feat: disable indication

[GitHub] [shardingsphere] terrymanu merged pull request #17851: Disable indication of mvn install in CI

2022-05-21 Thread GitBox
terrymanu merged PR #17851: URL: https://github.com/apache/shardingsphere/pull/17851 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

[shardingsphere] branch master updated (b6784ae40e6 -> 5223fdb42f3)

2022-05-21 Thread panjuan
This is an automated email from the ASF dual-hosted git repository. panjuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere.git from b6784ae40e6 update pom.xml and LICENSE. (#17785) add 5223fdb42f3 Rename frontendDatabaseType to protocol

[GitHub] [shardingsphere] linghengqian commented on issue #17779: Graalvm native image cause with Groovy 4

2022-05-21 Thread GitBox
linghengqian commented on issue #17779: URL: https://github.com/apache/shardingsphere/issues/17779#issuecomment-1133818928 I've started a discussion on dropping Groovy 3 support on Graalvm's Slack community's Polygolt channel, and I welcome comments. -- This is an automated message from

[GitHub] [shardingsphere] tristaZero merged pull request #17852: Rename frontendDatabaseType to protocolType

2022-05-21 Thread GitBox
tristaZero merged PR #17852: URL: https://github.com/apache/shardingsphere/pull/17852 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsu

[GitHub] [shardingsphere] terrymanu merged pull request #17853: Spotless format XML file format

2022-05-21 Thread GitBox
terrymanu merged PR #17853: URL: https://github.com/apache/shardingsphere/pull/17853 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

[GitHub] [shardingsphere] codecov-commenter commented on pull request #17853: Spotless format XML file format

2022-05-21 Thread GitBox
codecov-commenter commented on PR #17853: URL: https://github.com/apache/shardingsphere/pull/17853#issuecomment-1133818225 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17853?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_te

[GitHub] [shardingsphere] codecov-commenter commented on pull request #17852: Rename frontendDatabaseType to protocolType

2022-05-21 Thread GitBox
codecov-commenter commented on PR #17852: URL: https://github.com/apache/shardingsphere/pull/17852#issuecomment-1133817358 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17852?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_te

[GitHub] [shardingsphere] codecov-commenter commented on pull request #17851: Disable indication of mvn install in CI

2022-05-21 Thread GitBox
codecov-commenter commented on PR #17851: URL: https://github.com/apache/shardingsphere/pull/17851#issuecomment-1133816015 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17851?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_te

[GitHub] [shardingsphere] complone commented on issue #17619: Add SQL dialect translator module

2022-05-21 Thread GitBox
complone commented on issue #17619: URL: https://github.com/apache/shardingsphere/issues/17619#issuecomment-1133815111 > > 目前实现的方言转换支持内置jooq, > > jooq实现方言转换的原理是根据基于DSL上下文的anltr4规则和标准,将对一个数据库的请求转移到另一个数据库 > > 如果我们现在想实现本地方言 > > 我有个主意 > > > > 1. 基于anltr4的PostgreSQL方言https://githu

[GitHub] [shardingsphere] strongduanmu commented on issue #17848: [ GSoC 2022 ] Solve unsupported Postgres sql about alter statement for ShardingSphere Parser

2022-05-21 Thread GitBox
strongduanmu commented on issue #17848: URL: https://github.com/apache/shardingsphere/issues/17848#issuecomment-1133814838 @everly-gif Assigned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [shardingsphere] codecov-commenter commented on pull request #17842: Bump gson from 2.8.6 to 2.8.9

2022-05-21 Thread GitBox
codecov-commenter commented on PR #17842: URL: https://github.com/apache/shardingsphere/pull/17842#issuecomment-1133814788 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17842?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_te

[GitHub] [shardingsphere] longtai-cn opened a new pull request, #17853: Spotless format XML file format

2022-05-21 Thread GitBox
longtai-cn opened a new pull request, #17853: URL: https://github.com/apache/shardingsphere/pull/17853 Changes proposed in this pull request: - Spotless format XML file format; - Remove extra quotes. -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [shardingsphere] Jacob953 opened a new pull request, #17851: feat: disable indication of mvn install in CI

2022-05-21 Thread GitBox
Jacob953 opened a new pull request, #17851: URL: https://github.com/apache/shardingsphere/pull/17851 Follows #17014. Changes proposed in this pull request: - speed up CI workflow. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [shardingsphere] terrymanu commented on a diff in pull request #17782: Database discovery type support `string`.

2022-05-21 Thread GitBox
terrymanu commented on code in PR #17782: URL: https://github.com/apache/shardingsphere/pull/17782#discussion_r878787966 ## shardingsphere-features/shardingsphere-db-discovery/shardingsphere-db-discovery-distsql/shardingsphere-db-discovery-distsql-parser/src/main/antlr4/imports/db-disco

[shardingsphere] branch dependabot/maven/com.google.code.gson-gson-2.8.9 updated (913da05f114 -> a465bb354af)

2022-05-21 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.google.code.gson-gson-2.8.9 in repository https://gitbox.apache.org/repos/asf/shardingsphere.git discard 913da05f114 Bump gson from 2.8.6 to 2.8.9 add 576d425bea8

[shardingsphere] branch master updated: update pom.xml and LICENSE. (#17785)

2022-05-21 Thread zhangliang
This is an automated email from the ASF dual-hosted git repository. zhangliang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere.git The following commit(s) were added to refs/heads/master by this push: new b6784ae40e6 update pom.xml and LICEN

[GitHub] [shardingsphere] terrymanu merged pull request #17785: Update Groovy to 4.0.2 to help locate GraalVM problems

2022-05-21 Thread GitBox
terrymanu merged PR #17785: URL: https://github.com/apache/shardingsphere/pull/17785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

[shardingsphere] branch master updated: Support base-seata transaction for jdbc (#17846)

2022-05-21 Thread zhangliang
This is an automated email from the ASF dual-hosted git repository. zhangliang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere.git The following commit(s) were added to refs/heads/master by this push: new a5d12f96884 Support base-seata trans

[GitHub] [shardingsphere] terrymanu merged pull request #17846: Support base-seata transaction for jdbc

2022-05-21 Thread GitBox
terrymanu merged PR #17846: URL: https://github.com/apache/shardingsphere/pull/17846 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

[shardingsphere] branch master updated: Add PostgreSQL CALL Statement (#17847)

2022-05-21 Thread totalo
This is an automated email from the ASF dual-hosted git repository. totalo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere.git The following commit(s) were added to refs/heads/master by this push: new e89b6977421 Add PostgreSQL CALL Statemen

[GitHub] [shardingsphere] totalo merged pull request #17847: Add PostgreSQL CALL Statement

2022-05-21 Thread GitBox
totalo merged PR #17847: URL: https://github.com/apache/shardingsphere/pull/17847 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

[GitHub] [shardingsphere] Swastyy commented on pull request #16579: encrypt-spring-boot-jpa-example

2022-05-21 Thread GitBox
Swastyy commented on PR #16579: URL: https://github.com/apache/shardingsphere/pull/16579#issuecomment-1133806158 > Hi @Swastyy Sorry, there are some file conflicts, please fix them. Hi @RaigorJiang , the option for resolve conflicts is not working -- This is an automated message fro

[GitHub] [shardingsphere] linghengqian commented on pull request #16819: Eliminate the log of Auto Proxying in Spring's log

2022-05-21 Thread GitBox
linghengqian commented on PR #16819: URL: https://github.com/apache/shardingsphere/pull/16819#issuecomment-1133651043 Close this issue because of the missing means of verification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [shardingsphere] menghaoranss commented on pull request #17843: make assistedEncryptorName effect

2022-05-21 Thread GitBox
menghaoranss commented on PR #17843: URL: https://github.com/apache/shardingsphere/pull/17843#issuecomment-1133650189 @cheese8 please fix ci errors -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[shardingsphere] branch master updated: Move scaling doc into proxy (#17850)

2022-05-21 Thread menghaoran
This is an automated email from the ASF dual-hosted git repository. menghaoran pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere.git The following commit(s) were added to refs/heads/master by this push: new 61226675641 Move scaling doc into pr

[GitHub] [shardingsphere] menghaoranss merged pull request #17850: Move scaling doc into proxy

2022-05-21 Thread GitBox
menghaoranss merged PR #17850: URL: https://github.com/apache/shardingsphere/pull/17850 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-un

[GitHub] [shardingsphere] sandynz opened a new pull request, #17850: Move scaling doc into proxy

2022-05-21 Thread GitBox
sandynz opened a new pull request, #17850: URL: https://github.com/apache/shardingsphere/pull/17850 Changes proposed in this pull request: - Move scaling doc into proxy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [shardingsphere] codecov-commenter commented on pull request #17847: Add PostgreSQL CALL Statement

2022-05-21 Thread GitBox
codecov-commenter commented on PR #17847: URL: https://github.com/apache/shardingsphere/pull/17847#issuecomment-1133627459 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17847?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_te

[GitHub] [shardingsphere] sandynz opened a new issue, #17849: Scaling incremental task fail but not report error when MySQL primary node is switched

2022-05-21 Thread GitBox
sandynz opened a new issue, #17849: URL: https://github.com/apache/shardingsphere/issues/17849 ## Bug Report ### Which version of ShardingSphere did you use? master branch ### Which project did you use? ShardingSphere-JDBC or ShardingSphere-Proxy? Proxy, scaling enabled

[GitHub] [shardingsphere] everly-gif commented on issue #17848: [ GSOC 22 ] Solve unsupported Postgres sql about alter statement for ShardingSphere Parser

2022-05-21 Thread GitBox
everly-gif commented on issue #17848: URL: https://github.com/apache/shardingsphere/issues/17848#issuecomment-1133610608 Hi @strongduanmu , please assign this issue to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [shardingsphere] everly-gif opened a new issue, #17848: [ GSOC 22 ] Solve unsupported Postgres sql about alter statement for ShardingSphere Parser

2022-05-21 Thread GitBox
everly-gif opened a new issue, #17848: URL: https://github.com/apache/shardingsphere/issues/17848 This issue is created to better track my PRs for GSOC. You can view more about my project [here](https://summerofcode.withgoogle.com/programs/2022/projects/ajDT1hjj) ## Background

[GitHub] [shardingsphere] ThanoshanMV opened a new pull request, #17847: Add PostgreSQL CALL Statement

2022-05-21 Thread GitBox
ThanoshanMV opened a new pull request, #17847: URL: https://github.com/apache/shardingsphere/pull/17847 For #17844 Changes proposed in this pull request: - Add PostgreSQL [CALL statement](https://www.postgresql.org/docs/current/sql-call.html). - Add test cases. - I think, an

[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #17432: Support oracle multi insert (but only one insert)

2022-05-21 Thread GitBox
strongduanmu commented on code in PR #17432: URL: https://github.com/apache/shardingsphere/pull/17432#discussion_r878673527 ## shardingsphere-infra/shardingsphere-infra-binder/src/main/java/org/apache/shardingsphere/infra/binder/statement/dml/InsertStatementContext.java: ## @@ -

[GitHub] [shardingsphere] yuzhiping95 closed issue #17443: How to use skywalking monitor sharding-jdbc 5.0?

2022-05-21 Thread GitBox
yuzhiping95 closed issue #17443: How to use skywalking monitor sharding-jdbc 5.0? URL: https://github.com/apache/shardingsphere/issues/17443 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [shardingsphere] codecov-commenter commented on pull request #17846: Support base-seata transaction for jdbc

2022-05-21 Thread GitBox
codecov-commenter commented on PR #17846: URL: https://github.com/apache/shardingsphere/pull/17846#issuecomment-1133563668 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17846?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_te

[GitHub] [shardingsphere] totalo opened a new pull request, #17846: Support base-seata transaction for jdbc

2022-05-21 Thread GitBox
totalo opened a new pull request, #17846: URL: https://github.com/apache/shardingsphere/pull/17846 For #12366. Changes proposed in this pull request: - support base-seata transaction for jdbc - add transaction example scenario -- This is an automated message from the Apach