[GitHub] [shardingsphere] cherrylzhao closed issue #10150: reduce memory used of GroupByStreamMergeResult

2021-04-26 Thread GitBox
cherrylzhao closed issue #10150: URL: https://github.com/apache/shardingsphere/issues/10150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service

[GitHub] [shardingsphere] 243006306 commented on issue #10196: The following problems are found in the project transformation sharding-jdbc 4.1.1 scheme

2021-04-26 Thread GitBox
243006306 commented on issue #10196: URL: https://github.com/apache/shardingsphere/issues/10196#issuecomment-827352268 Force routing does not work, do not enter 'HintShardingAlgorithm` -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [shardingsphere] laravelshao closed issue #10095: How sharding-jdbc config complex & hint sharding strategy together for same table

2021-04-26 Thread GitBox
laravelshao closed issue #10095: URL: https://github.com/apache/shardingsphere/issues/10095 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service

[GitHub] [shardingsphere] menghaoranss opened a new issue #10205: The metadata of the tables without sharding rule is not refreshed after ddl executed

2021-04-26 Thread GitBox
menghaoranss opened a new issue #10205: URL: https://github.com/apache/shardingsphere/issues/10205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[shardingsphere] branch master updated: Add lock switch (#10204)

2021-04-26 Thread panjuan
This is an automated email from the ASF dual-hosted git repository. panjuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere.git The following commit(s) were added to refs/heads/master by this push: new c5b86fa Add lock switch (#10204) c5b86

[GitHub] [shardingsphere] tristaZero closed issue #10180: Add a switch for DDL lock

2021-04-26 Thread GitBox
tristaZero closed issue #10180: URL: https://github.com/apache/shardingsphere/issues/10180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [shardingsphere] tristaZero merged pull request #10204: Add switch for ddl lock

2021-04-26 Thread GitBox
tristaZero merged pull request #10204: URL: https://github.com/apache/shardingsphere/pull/10204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this ser

[GitHub] [shardingsphere] menghaoranss opened a new pull request #10204: Add switch for ddl lock

2021-04-26 Thread GitBox
menghaoranss opened a new pull request #10204: URL: https://github.com/apache/shardingsphere/pull/10204 Fixes #10180 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [shardingsphere] RaigorJiang commented on issue #10202: Reduce code complexity and improve readability for ShardingUnicastRoutingEngine

2021-04-26 Thread GitBox
RaigorJiang commented on issue #10202: URL: https://github.com/apache/shardingsphere/issues/10202#issuecomment-827306512 Good idea 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10203: refactor ShardingUnicastRoutingEngine

2021-04-26 Thread GitBox
codecov-commenter commented on pull request #10203: URL: https://github.com/apache/shardingsphere/pull/10203#issuecomment-827300516 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10203?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[GitHub] [shardingsphere] MingxingLAI opened a new pull request #10203: refactor ShardingUnicastRoutingEngine

2021-04-26 Thread GitBox
MingxingLAI opened a new pull request #10203: URL: https://github.com/apache/shardingsphere/pull/10203 Fixes #10202 . Changes proposed in this pull request: - Using stream to reduce forloop - extracting code block to an independent function to reduce the length of route functio

[GitHub] [shardingsphere-elasticjob] kaihekaihe commented on issue #1879: If the timeout parameter are set to 0L,then the thread executing some sharding may wait for Long.maxvalue.

2021-04-26 Thread GitBox
kaihekaihe commented on issue #1879: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1879#issuecomment-827288229 `startedTimeoutMilliseconds` and `compltedTimeoutMilliseconds` in class `AbstractDistributeOnceElasticJobListener` -- This is an automated message from the Ap

[GitHub] [shardingsphere-elasticjob] kaihekaihe opened a new issue #1882: How do Listeners inject beans in spring?

2021-04-26 Thread GitBox
kaihekaihe opened a new issue #1882: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1882 ## Feature Request **For English only**, other languages will not accept. Please pay attention on issues you submitted, because we maybe need more details. If no respo

[GitHub] [shardingsphere] MingxingLAI opened a new issue #10202: Reduce code complexity and improve readability for ShardingUnicastRoutingEngine

2021-04-26 Thread GitBox
MingxingLAI opened a new issue #10202: URL: https://github.com/apache/shardingsphere/issues/10202 When I read the source code of this project, The code readability of this [file](https://github.com/apache/shardingsphere/blob/master/shardingsphere-features/shardingsphere-sharding/shardingsph

[GitHub] [shardingsphere-elasticjob] gonedays opened a new issue #1881: Specify an ip when job instance application deployed on a multi-ip server.

2021-04-26 Thread GitBox
gonedays opened a new issue #1881: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1881 ## Feature Request **For English only**, other languages will not accept. Please pay attention on issues you submitted, because we maybe need more details. If no respons

[GitHub] [shardingsphere] Liangda-w opened a new pull request #10201: Fix Oracle addColumnSpecification grammar

2021-04-26 Thread GitBox
Liangda-w opened a new pull request #10201: URL: https://github.com/apache/shardingsphere/pull/10201 Relates #9694. Changes proposed in this pull request: - Fix Oracle `addColumnSpecification` grammar of [ALTER TABLE](https://docs.oracle.com/en/database/oracle/oracle-database/19/s

[GitHub] [shardingsphere] LutzWeischerFujitsu commented on issue #9710: build fails on AArch64, Fedora 33

2021-04-26 Thread GitBox
LutzWeischerFujitsu commented on issue #9710: URL: https://github.com/apache/shardingsphere/issues/9710#issuecomment-826863152 [jw@cn05 shardingsphere]$ ./mvnw clean install -Prelease -DskipTests ... [INFO] [I

[GitHub] [shardingsphere] RaigorJiang commented on issue #10133: shardingjdbc 4.1.1 insert...select NullPointerException

2021-04-26 Thread GitBox
RaigorJiang commented on issue #10133: URL: https://github.com/apache/shardingsphere/issues/10133#issuecomment-826854771 Hi @xsong123 Is the exception still exists? Because you did not provide your SQL and configuration, we can not say anything. -- This is an automated m

[GitHub] [shardingsphere] ThanoshanMV commented on issue #10111: [SQL Definition Collation][Oracle]Collate the SQL definition of alter session

2021-04-26 Thread GitBox
ThanoshanMV commented on issue #10111: URL: https://github.com/apache/shardingsphere/issues/10111#issuecomment-826850523 Hi @tristaZero, next, I'll try [ALTER SYSTEM](https://docs.oracle.com/en/database/oracle/oracle-database/19/sqlrf/ALTER-SYSTEM.html#GUID-2C638517-D73A-41CA-9D8E-A62D1A0B

[GitHub] [shardingsphere] RaigorJiang commented on pull request #10195: Fix exception message missing format in JDBCLockEngine

2021-04-26 Thread GitBox
RaigorJiang commented on pull request #10195: URL: https://github.com/apache/shardingsphere/pull/10195#issuecomment-826846247 @DreamSaddle Hi, please see `Files changed`, there are still lots of format changes. ![image](https://user-images.githubusercontent.com/5668787/116092382-57bb

[GitHub] [shardingsphere] RaigorJiang commented on issue #10194: 期望有rust语言的shardingsphere

2021-04-26 Thread GitBox
RaigorJiang commented on issue #10194: URL: https://github.com/apache/shardingsphere/issues/10194#issuecomment-826835931 Hello, for English only, please translate, thank you. By the way, Sharding-Proxy supports standard SQL protocols and can be language free. -- This is an automa

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #10193: fix bad rewritten result for foreign key SQL

2021-04-26 Thread GitBox
tristaZero commented on a change in pull request #10193: URL: https://github.com/apache/shardingsphere/pull/10193#discussion_r620295127 ## File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-route/src/main/java/org/apache/shardingsphere/sharding/route/en

[GitHub] [shardingsphere] RaigorJiang commented on issue #10190: java.lang.ClassNotFoundException: org.apache.shardingsphere.spring.boot.util.PropertyUtil

2021-04-26 Thread GitBox
RaigorJiang commented on issue #10190: URL: https://github.com/apache/shardingsphere/issues/10190#issuecomment-826829298 @chenchen1008 Hi, I have tested with version `5.0.0-alpha`, and there was no problem. But, the starter should be `shardingsphere-jdbc-core-spring-boot-starter`,

[GitHub] [shardingsphere-elasticjob] TeslaCN commented on issue #1879: If the timeout parameter are set to 0L,then the thread executing some sharding may wait for Long.maxvalue.

2021-04-26 Thread GitBox
TeslaCN commented on issue #1879: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1879#issuecomment-826746450 Hi @kaihekaihe Do you mean the timeout of `DistributeOnceElasticJobListener`? -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [shardingsphere-elasticjob] TeslaCN closed issue #1872: job触发有延迟

2021-04-26 Thread GitBox
TeslaCN closed issue #1872: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1872 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [shardingsphere-elasticjob] TeslaCN commented on issue #1872: job触发有延迟

2021-04-26 Thread GitBox
TeslaCN commented on issue #1872: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1872#issuecomment-826744254 **For English only** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [shardingsphere-elasticjob] TeslaCN closed issue #1876: 任务执行后重启服务增加tracing功能不生效

2021-04-26 Thread GitBox
TeslaCN closed issue #1876: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1876 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [shardingsphere-elasticjob] TeslaCN commented on issue #1876: 任务执行后重启服务增加tracing功能不生效

2021-04-26 Thread GitBox
TeslaCN commented on issue #1876: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1876#issuecomment-826743795 **For English only** You may set `overwrite` to `true` to overwrite the configurations in Zookeeper. -- This is an automated message from the Apache Git S

[GitHub] [shardingsphere] yudonghua closed issue #10200: 第一次执行慢

2021-04-26 Thread GitBox
yudonghua closed issue #10200: URL: https://github.com/apache/shardingsphere/issues/10200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [shardingsphere-elasticjob] TeslaCN opened a new issue #1880: Support configuring Mail SMTP SSL trusted

2021-04-26 Thread GitBox
TeslaCN opened a new issue #1880: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1880 ## Feature Request ### Is your feature request related to a problem? Our SMTP server using self-signed certificate. There is no way to configure trusted host for now. ###

[GitHub] [shardingsphere] yudonghua opened a new issue #10200: 第一次执行慢

2021-04-26 Thread GitBox
yudonghua opened a new issue #10200: URL: https://github.com/apache/shardingsphere/issues/10200 在项目刚启动时,第一次查询由于加载大量类,导致正常执行只需要20ms~30ms左右的查询执行了2000ms~3000ms -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [shardingsphere] DreamSaddle commented on a change in pull request #10195: Fix exception message missing format in JDBCLockEngine

2021-04-26 Thread GitBox
DreamSaddle commented on a change in pull request #10195: URL: https://github.com/apache/shardingsphere/pull/10195#discussion_r620121238 ## File path: shardingsphere-jdbc/shardingsphere-jdbc-core/src/main/java/org/apache/shardingsphere/driver/executor/JDBCLockEngine.java ## @@

[GitHub] [shardingsphere] zhonghuali edited a comment on issue #7196: In multi-tenant mode database sharding invalid

2021-04-26 Thread GitBox
zhonghuali edited a comment on issue #7196: URL: https://github.com/apache/shardingsphere/issues/7196#issuecomment-826602578 Strongly suggest to add new config for setting whether all tables are default sharded or not, then simplifying this kind of configuration -- This is an automated m

[GitHub] [shardingsphere] zhonghuali opened a new issue #10199: Striongly suggest to add new config for setting whether all tables are default sharded or not, then simplifying this kind of configurati

2021-04-26 Thread GitBox
zhonghuali opened a new issue #10199: URL: https://github.com/apache/shardingsphere/issues/10199 Striongly suggest to add new config for setting whether all tables are default sharded or not, then simplifying this kind of configuration _Originally posted by @zhonghuali in https://gi

[GitHub] [shardingsphere] RaigorJiang commented on a change in pull request #10195: Fix exception message missing format in JDBCLockEngine

2021-04-26 Thread GitBox
RaigorJiang commented on a change in pull request #10195: URL: https://github.com/apache/shardingsphere/pull/10195#discussion_r620091075 ## File path: shardingsphere-jdbc/shardingsphere-jdbc-core/src/main/java/org/apache/shardingsphere/driver/executor/JDBCLockEngine.java ## @@

[GitHub] [shardingsphere] RaigorJiang commented on pull request #10195: Fix exception message missing format in JDBCLockEngine

2021-04-26 Thread GitBox
RaigorJiang commented on pull request #10195: URL: https://github.com/apache/shardingsphere/pull/10195#issuecomment-826635878 @DreamSaddle Hi, DreamSaddle, please check code style, do not format the code. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [shardingsphere] Victoryli opened a new issue #10198: 读写分离配合分表,分表失效

2021-04-26 Thread GitBox
Victoryli opened a new issue #10198: URL: https://github.com/apache/shardingsphere/issues/10198 ## Bug Report **For English only**, other languages will not accept. Before report a bug, make sure you have: - Searched open and closed [GitHub issues](https://github.com/ap

[GitHub] [shardingsphere-elasticjob] kaihekaihe opened a new issue #1879: If the timeout parameter are set to 0L,then the thread executing some sharding may wait for Long.maxvalue.

2021-04-26 Thread GitBox
kaihekaihe opened a new issue #1879: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1879 ## Bug Report **For English only**, other languages will not accept. Before report a bug, make sure you have: - Searched open and closed [GitHub issues](https://git

[GitHub] [shardingsphere] zhonghuali commented on issue #7196: In multi-tenant mode database sharding invalid

2021-04-26 Thread GitBox
zhonghuali commented on issue #7196: URL: https://github.com/apache/shardingsphere/issues/7196#issuecomment-826602578 Striongly suggest to add new config for setting whether all tables are default sharded or not, then simplifying this kind of configuration -- This is an automated message

[GitHub] [shardingsphere] hanxu00920 opened a new issue #10197: use orchestration for springboot can't work

2021-04-26 Thread GitBox
hanxu00920 opened a new issue #10197: URL: https://github.com/apache/shardingsphere/issues/10197 ##maven dependencies: org.apache.shardingsphere sharding-jdbc-orchestration-spring-boot-starter ${shardingsphere.version} org.apache.shardingsphere

[GitHub] [shardingsphere-elasticjob] TeslaCN commented on pull request #1874: Update elastic.cn.md

2021-04-26 Thread GitBox
TeslaCN commented on pull request #1874: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1874#issuecomment-826521770 Hi @yuanrengu Thanks for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [shardingsphere-elasticjob] TeslaCN merged pull request #1874: Update elastic.cn.md

2021-04-26 Thread GitBox
TeslaCN merged pull request #1874: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1874 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about th

[GitHub] [shardingsphere-elasticjob] TeslaCN merged pull request #1878: Update elastic.en.md

2021-04-26 Thread GitBox
TeslaCN merged pull request #1878: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1878 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about th

[GitHub] [shardingsphere] RaigorJiang edited a comment on issue #10190: java.lang.ClassNotFoundException: org.apache.shardingsphere.spring.boot.util.PropertyUtil

2021-04-26 Thread GitBox
RaigorJiang edited a comment on issue #10190: URL: https://github.com/apache/shardingsphere/issues/10190#issuecomment-826327968 Hi @chenchen1008 Thanks for your report, I will make a check. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [shardingsphere] DreamSaddle commented on issue #10191: Throw exception message error

2021-04-26 Thread GitBox
DreamSaddle commented on issue #10191: URL: https://github.com/apache/shardingsphere/issues/10191#issuecomment-826482306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. Fo

[GitHub] [shardingsphere] terrymanu closed issue #10102: Implement SQLServerPrivilegeHandler and add unit test

2021-04-26 Thread GitBox
terrymanu closed issue #10102: URL: https://github.com/apache/shardingsphere/issues/10102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [shardingsphere] menghaoranss merged pull request #10176: Refactor PostgreSQLAuthenticationEngine

2021-04-26 Thread GitBox
menghaoranss merged pull request #10176: URL: https://github.com/apache/shardingsphere/pull/10176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this s

[GitHub] [shardingsphere] TeslaCN commented on a change in pull request #10189: Revise #10186

2021-04-26 Thread GitBox
TeslaCN commented on a change in pull request #10189: URL: https://github.com/apache/shardingsphere/pull/10189#discussion_r619769360 ## File path: shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-core/src/main/java/org/apache/shardingsphere/proxy/fronte

[GitHub] [shardingsphere] tristaZero commented on issue #10126: sqlserver row_number() over() faild,Error preparing statement. Cause: org.antlr.v4.runtime.misc.ParseCancellationException

2021-04-26 Thread GitBox
tristaZero commented on issue #10126: URL: https://github.com/apache/shardingsphere/issues/10126#issuecomment-826314099 @cilfm Thank for your feedback. Are you interested raising a PR to fix this bug in the master branch? -- This is an automated message from the Apache Git Service.

[GitHub] [shardingsphere-elasticjob] TeslaCN merged pull request #1846: Adding code maintainability badge

2021-04-26 Thread GitBox
TeslaCN merged pull request #1846: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1846 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about th

[GitHub] [shardingsphere-elasticjob-ui] TeslaCN commented on issue #113: Registry Center can`t connect zookeeper

2021-04-26 Thread GitBox
TeslaCN commented on issue #113: URL: https://github.com/apache/shardingsphere-elasticjob-ui/issues/113#issuecomment-826474011 Hi @Pudge-T I cannot reproduce your problem in my environment. Could you show me what you have typed in the page? -- This is an automated message from the A

[GitHub] [shardingsphere] 726411951 closed issue #10086: Is there a better way to cofig sharding properties

2021-04-26 Thread GitBox
726411951 closed issue #10086: URL: https://github.com/apache/shardingsphere/issues/10086 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [shardingsphere] tristaZero merged pull request #10182: Revise #10163 and complete testcases

2021-04-26 Thread GitBox
tristaZero merged pull request #10182: URL: https://github.com/apache/shardingsphere/pull/10182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this ser

[GitHub] [shardingsphere] RaigorJiang commented on issue #10191: Throw exception message error

2021-04-26 Thread GitBox
RaigorJiang commented on issue #10191: URL: https://github.com/apache/shardingsphere/issues/10191#issuecomment-826455935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. Fo

[GitHub] [shardingsphere] sangewuxie commented on issue #10106: bug, emoji cant save(insert) or update, update is work shardingsphere-5.0.0-alpha

2021-04-26 Thread GitBox
sangewuxie commented on issue #10106: URL: https://github.com/apache/shardingsphere/issues/10106#issuecomment-826439916 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10195: Fix exception message missing format in JDBCLockEngine

2021-04-26 Thread GitBox
codecov-commenter commented on pull request #10195: URL: https://github.com/apache/shardingsphere/pull/10195#issuecomment-826538241 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10195?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10181: fix error of encrypt alter table when drop columns.

2021-04-26 Thread GitBox
codecov-commenter commented on pull request #10181: URL: https://github.com/apache/shardingsphere/pull/10181#issuecomment-826092639 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10181?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[GitHub] [shardingsphere] avalon5666 merged pull request #10188: Remove timeout limit with unregister PostgreSQLBinaryStatementRegistry

2021-04-26 Thread GitBox
avalon5666 merged pull request #10188: URL: https://github.com/apache/shardingsphere/pull/10188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this ser

[GitHub] [shardingsphere] wangkang09 edited a comment on issue #10105: rewrite sql error when using keyGenerator and encrypt together

2021-04-26 Thread GitBox
wangkang09 edited a comment on issue #10105: URL: https://github.com/apache/shardingsphere/issues/10105#issuecomment-826070317 > Hi 5.0.0-alpha has been released for a long time. Maybe you have no interests on Scaling etc. But this issue was fixed from 5.x release. Actual SQL: db1 ::: I

[GitHub] [shardingsphere-elasticjob] SkyMoreStars commented on a change in pull request #1069: Consider about improvement of get IP address inaccurate

2021-04-26 Thread GitBox
SkyMoreStars commented on a change in pull request #1069: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1069#discussion_r619995613 ## File path: elasticjob-infra/elasticjob-infra-common/src/main/java/org/apache/shardingsphere/elasticjob/infra/env/IpUtils.java

[GitHub] [shardingsphere] strongduanmu merged pull request #10187: Fix test case for PostgreSQLFrontendEngineTest

2021-04-26 Thread GitBox
strongduanmu merged pull request #10187: URL: https://github.com/apache/shardingsphere/pull/10187 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this s

[GitHub] [shardingsphere] terrymanu commented on a change in pull request #10189: Revise #10186

2021-04-26 Thread GitBox
terrymanu commented on a change in pull request #10189: URL: https://github.com/apache/shardingsphere/pull/10189#discussion_r619768636 ## File path: shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-core/src/main/java/org/apache/shardingsphere/proxy/fron

[GitHub] [shardingsphere] tristaZero edited a comment on issue #10119: RangeShardingAlgorithm Generic problem, specified as Date, actually a string

2021-04-26 Thread GitBox
tristaZero edited a comment on issue #10119: URL: https://github.com/apache/shardingsphere/issues/10119#issuecomment-826314458 Hi please try the released one, i.e., 5.0.0-alpha -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [shardingsphere] menghaoranss merged pull request #10179: support parsing vacuum sql

2021-04-26 Thread GitBox
menghaoranss merged pull request #10179: URL: https://github.com/apache/shardingsphere/pull/10179 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this s

[GitHub] [shardingsphere-elasticjob] TeslaCN closed issue #1868: I can't find the branch which includes the code from Bug fix for Failover #714

2021-04-26 Thread GitBox
TeslaCN closed issue #1868: URL: https://github.com/apache/shardingsphere-elasticjob/issues/1868 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [shardingsphere] DreamSaddle removed a comment on issue #10191: Throw exception message error

2021-04-26 Thread GitBox
DreamSaddle removed a comment on issue #10191: URL: https://github.com/apache/shardingsphere/issues/10191#issuecomment-826482306 Yes, it would be my pleasure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [shardingsphere] menghaoranss merged pull request #10173: fix error of mysql alter table drop column visitor.

2021-04-26 Thread GitBox
menghaoranss merged pull request #10173: URL: https://github.com/apache/shardingsphere/pull/10173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this s

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10193: fix bad rewritten result for foreign key SQL

2021-04-26 Thread GitBox
codecov-commenter commented on pull request #10193: URL: https://github.com/apache/shardingsphere/pull/10193#issuecomment-826483708 # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10193?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[GitHub] [shardingsphere-elasticjob-ui] TeslaCN edited a comment on issue #113: Registry Center can`t connect zookeeper

2021-04-26 Thread GitBox
TeslaCN edited a comment on issue #113: URL: https://github.com/apache/shardingsphere-elasticjob-ui/issues/113#issuecomment-826474011 Hi @Pudge-T I cannot reproduce your problem in my environment. Could you show me what have you typed in the page? -- This is an automated message fro

[GitHub] [shardingsphere] tristaZero commented on issue #10119: RangeShardingAlgorithm Generic problem, specified as Date, actually a string

2021-04-26 Thread GitBox
tristaZero commented on issue #10119: URL: https://github.com/apache/shardingsphere/issues/10119#issuecomment-826314458 Hi please try the release one, i.e., 5.0.0-alpha -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [shardingsphere] tristaZero commented on pull request #10148: Implement OraclePrivilegeHandler and add unit test

2021-04-26 Thread GitBox
tristaZero commented on pull request #10148: URL: https://github.com/apache/shardingsphere/pull/10148#issuecomment-826309876 @Liangda-w Thanks, Hi @zhujunx Could you give a look one more? -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [shardingsphere] tristaZero commented on issue #10127: read-write-splitting doesn't work

2021-04-26 Thread GitBox
tristaZero commented on issue #10127: URL: https://github.com/apache/shardingsphere/issues/10127#issuecomment-826314279 Thanks for your comment @hilton1977 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo