Re: [PR] feat: Add required reflection/resource metadata for native image generation [pekko]

2024-12-18 Thread via GitHub
pjfanning commented on code in PR #1612: URL: https://github.com/apache/pekko/pull/1612#discussion_r1890580929 ## slf4j/src/main/resources/META-INF/native-image/ch.qos.logback/logback-classic/reflect-config.json: ## @@ -0,0 +1,194 @@ +[ Review Comment: Why would Pekko need t

Re: [PR] feat: Add required reflection/resource metadata for native image generation [pekko]

2024-12-18 Thread via GitHub
pjfanning commented on code in PR #1612: URL: https://github.com/apache/pekko/pull/1612#discussion_r1890584906 ## slf4j/src/main/resources/META-INF/native-image/ch.qos.logback/logback-classic/reflect-config.json: ## @@ -0,0 +1,194 @@ +[ Review Comment: logback-classic is an

Re: [PR] feat: Add required reflection/resource metadata for native image generation [pekko]

2024-12-18 Thread via GitHub
pjfanning commented on code in PR #1612: URL: https://github.com/apache/pekko/pull/1612#discussion_r1890594141 ## actor-typed/src/main/resources/META-INF/native-image/org.apache.pekko/pekko-actor-typed/native-image.properties: ## @@ -0,0 +1 @@ +Args = --enable-monitoring=jfr Re

Re: [PR] feat: Add required reflection/resource metadata for native image generation [pekko]

2024-12-18 Thread via GitHub
He-Pin commented on PR #1612: URL: https://github.com/apache/pekko/pull/1612#issuecomment-2551891778 the file is generated with tools, but it's hard to cover every code paths, i think this better be a plug in for automatic generating instead of a static file -- This is an automated mes

Re: [I] `ServerBinding` termination does not close HTTP/2 connections [pekko-http]

2024-12-18 Thread via GitHub
jrudolph commented on issue #638: URL: https://github.com/apache/pekko-http/issues/638#issuecomment-2552027233 In theory, it should work. It was implemented in https://github.com/apache/pekko-http/commit/4d162245529128d6594fc3206e9f52b17819c9, so it might be a bug or an edge case? A reprodu

Re: [I] `ServerBinding` termination does not close HTTP/2 connections [pekko-http]

2024-12-18 Thread via GitHub
pjfanning commented on issue #638: URL: https://github.com/apache/pekko-http/issues/638#issuecomment-2551969371 @bdmendes if you have the code you used to reproduce this can you share it? Helps avoid having someone write the test case from scratch. I suspect that the Unirest client is

Re: [PR] feat: Add required reflection/resource metadata for native image generation [pekko]

2024-12-18 Thread via GitHub
pjfanning commented on PR #1612: URL: https://github.com/apache/pekko/pull/1612#issuecomment-2551491722 Fair enough about adding regression tests in a 2nd pass. Could you write up how to generate these JSON files? Ideally someone else would be able to generate them too. We may even ne

Re: [PR] feat: Add required reflection/resource metadata for native image generation [pekko]

2024-12-18 Thread via GitHub
raboof commented on PR #1612: URL: https://github.com/apache/pekko/pull/1612#issuecomment-2551333106 > The Akka counterparts of the artifacts already had these in place, so the contents were trivial. Does that mean you derived these artifacts from the Akka artifacts? What license wer

Re: [PR] feat: Add required reflection/resource metadata for native image generation [pekko]

2024-12-18 Thread via GitHub
utkuaydn commented on PR #1612: URL: https://github.com/apache/pekko/pull/1612#issuecomment-2551464290 About the contents of the changes, they are simply JSON files that were generated via the [native image agent](https://www.graalvm.org/latest/reference-manual/native-image/metadata/Automat

[I] `ServerBinding` termination does not close HTTP/2 connections [pekko-http]

2024-12-18 Thread via GitHub
bdmendes opened a new issue, #638: URL: https://github.com/apache/pekko-http/issues/638 Calling the `ServerBinding` `terminate()` method appears to not close open HTTP/2 connections reused by a client for different requests, even after the `hardDeadline` timeout is exceeded. In fact

[GH] (pekko-projection): Workflow run "Publish Nightly" failed!

2024-12-18 Thread GitBox
The GitHub Actions job "Publish Nightly" on pekko-projection.git has failed. Run started by GitHub user mdedetrich (triggered by mdedetrich). Head commit for run: dfac188506112a4c0ba71a7916e1144f901b94be / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.noreply.github.com> Update

[GH] (pekko): Workflow run "github_actions in /. - Update #935212473" failed!

2024-12-18 Thread GitBox
The GitHub Actions job "github_actions in /. - Update #935212473" on pekko.git has failed. Run started by GitHub user dependabot[bot] (triggered by dependabot[bot]). Head commit for run: 7184dadf4a1d57ac07cd4eb26b67b3f8b5ccf47d / He-Pin(kerr) chore: Fix flaky test in unsafeOptionalDataVia (#16

[GH] (pekko): Workflow run "Nightly Builds" is working again!

2024-12-18 Thread GitBox
The GitHub Actions job "Nightly Builds" on pekko.git has succeeded. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 7184dadf4a1d57ac07cd4eb26b67b3f8b5ccf47d / He-Pin(kerr) chore: Fix flaky test in unsafeOptionalDataVia (#1611) Report URL: https://github.com/

Re: [PR] feat: Add required reflection/resource metadata for native image generation [pekko]

2024-12-18 Thread via GitHub
pjfanning commented on code in PR #1612: URL: https://github.com/apache/pekko/pull/1612#discussion_r1890591279 ## serialization-jackson/src/main/resources/META-INF/native-image/org.apache.pekko/pekko-serialization-jackson/reflect-config.json: ## @@ -0,0 +1,234 @@ +[ Review Comm

Re: [I] `ServerBinding` termination does not close HTTP/2 connections [pekko-http]

2024-12-18 Thread via GitHub
bdmendes commented on issue #638: URL: https://github.com/apache/pekko-http/issues/638#issuecomment-2551935163 Yes, everything behaves as expected with HTTP 1.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] `ServerBinding` termination does not close HTTP/2 connections [pekko-http]

2024-12-18 Thread via GitHub
He-Pin commented on issue #638: URL: https://github.com/apache/pekko-http/issues/638#issuecomment-2551980971 is it by designed ? @jrudolph cc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GH] (pekko-projection): Workflow run "Nightly Integration Tests for JDBC (Pekko 1.0.x)" is working again!

2024-12-18 Thread GitBox
The GitHub Actions job "Nightly Integration Tests for JDBC (Pekko 1.0.x)" on pekko-projection.git has succeeded. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: dfac188506112a4c0ba71a7916e1144f901b94be / scala-steward-asf[bot] <147768647+scala-steward-asf[bo

[PR] feat: Add required reflection/resource metadata for native image generation [pekko]

2024-12-18 Thread via GitHub
utkuaydn opened a new pull request, #1612: URL: https://github.com/apache/pekko/pull/1612 I hope the title is self-explanatory. Providing reflection metadata to Graal's native image generation would be a nice addition to the library. The Akka counterparts of the artifacts already had these

Re: [I] `ServerBinding` termination does not close HTTP/2 connections [pekko-http]

2024-12-18 Thread via GitHub
pjfanning commented on issue #638: URL: https://github.com/apache/pekko-http/issues/638#issuecomment-2551562552 And http 1.1 behaves ok? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] feat: Add required reflection/resource metadata for native image generation [pekko]

2024-12-18 Thread via GitHub
pjfanning commented on PR #1612: URL: https://github.com/apache/pekko/pull/1612#issuecomment-2551426211 I guess the idea is that Graal users want these files included in our jars. And an outside group can still repackage the Pekko jars and add these files independently. I haven't don

[GH] (pekko-persistence-cassandra): Workflow run "Unit Tests" failed!

2024-12-18 Thread GitBox
The GitHub Actions job "Unit Tests" on pekko-persistence-cassandra.git has failed. Run started by GitHub user mdedetrich (triggered by mdedetrich). Head commit for run: ce514f76cc762be3075d76853347db1750c6ae09 / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.noreply.github.com>

[GH] (pekko-http): Workflow run "Nightly Builds" is working again!

2024-12-18 Thread GitBox
The GitHub Actions job "Nightly Builds" on pekko-http.git has succeeded. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: 4554337dd2e96cb0dd14c5b30e2a572344e0cd0f / David Sheynkman Optimized Uri.withQuery (#637) * Optimized Uri.withQuery * Improved UriSpec percen

[GH] (pekko-management): Workflow run "Nightly Tests" failed!

2024-12-18 Thread GitBox
The GitHub Actions job "Nightly Tests" on pekko-management.git has failed. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 7ef5fd3d0547ce761fcea183c70ec9caf613019f / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.noreply.github.com> Update log

[GH] (pekko-connectors): Workflow run "Nightly Pekko 1.0 Builds" failed!

2024-12-18 Thread GitBox
The GitHub Actions job "Nightly Pekko 1.0 Builds" on pekko-connectors.git has failed. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 6981eaa8a855999c39eb9006671d26c4a7280c3c / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.noreply.github.com

[GH] (pekko-persistence-r2dbc): Workflow run "Nightly Tests (Pekko 1.0.x)" is working again!

2024-12-18 Thread GitBox
The GitHub Actions job "Nightly Tests (Pekko 1.0.x)" on pekko-persistence-r2dbc.git has succeeded. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 553752fc82c15695e52c8db7627a48b1ec14bd3c / PJ Fanning release notes for 1.1.0-M1 (#179) * release notes for 1