Re: [PR] add missing commas in .scala-steward.conf [pekko]

2024-12-17 Thread via GitHub
raboof merged PR #1597: URL: https://github.com/apache/pekko/pull/1597 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.a

Re: [PR] run link-validator once a day (not per PR commit) [pekko]

2024-12-17 Thread via GitHub
raboof commented on code in PR #1609: URL: https://github.com/apache/pekko/pull/1609#discussion_r1888123379 ## .github/workflows/link-validator.yml: ## @@ -3,10 +3,9 @@ name: Link Validator permissions: {} on: - pull_request: Review Comment: :+1: ## .github/

[I] SourceWithContextSpec test that fails intermittently [pekko]

2024-12-17 Thread via GitHub
pjfanning opened a new issue, #1610: URL: https://github.com/apache/pekko/issues/1610 * Recently spotted in a Java 8 CI run. * Was part of a 'Nightly Build' but one that was temporarily enabled to run for PRs. ``` [12-17 12:13:48.607] [info] - must Apply a viaFlow with optional

Re: [I] SourceWithContextSpec test that fails intermittently [pekko]

2024-12-17 Thread via GitHub
He-Pin commented on issue #1610: URL: https://github.com/apache/pekko/issues/1610#issuecomment-2548382626 I will look into this weekend -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[PR] chore: Fix flaky test in unsafeOptionalDataVia [pekko]

2024-12-17 Thread via GitHub
He-Pin opened a new pull request, #1611: URL: https://github.com/apache/pekko/pull/1611 refs: https://github.com/apache/pekko/issues/1610 Motivation: Fix flaky test in unsafeOptionalDataVia Modification: 1. change to `expectNextN`, where merge is been used ,so order is und

[GH] (pekko): Workflow run "Link Validator" is working again!

2024-12-17 Thread GitBox
The GitHub Actions job "Link Validator" on pekko.git has succeeded. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 61e466e32a8c86704658066ff922bdd2efbf4db3 / PJ Fanning Update ClusterDaemon.scala Report URL: https://github.com/apache/pekko/actions/runs/123

[GH] (pekko): Workflow run "Nightly Builds" failed!

2024-12-17 Thread GitBox
The GitHub Actions job "Nightly Builds" on pekko.git has failed. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 61e466e32a8c86704658066ff922bdd2efbf4db3 / PJ Fanning Update ClusterDaemon.scala Report URL: https://github.com/apache/pekko/actions/runs/123697

[GH] (pekko): Workflow run "Nightly Builds" failed!

2024-12-17 Thread GitBox
The GitHub Actions job "Nightly Builds" on pekko.git has failed. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 52a17697c5ebbcf3e055efa0237450f0dbe9de31 / PJ Fanning try to fix issue in Remoting Report URL: https://github.com/apache/pekko/actions/runs/1237

Re: [PR] try to find issue with akka/pekko cluster change [pekko]

2024-12-17 Thread via GitHub
He-Pin commented on PR #1594: URL: https://github.com/apache/pekko/pull/1594#issuecomment-2548401324 I have not look into the details, but will it replay the akka node with akka protocol ?otherwise, it will not work. can a akka node sending ping-pong after joined? And there are

Re: [PR] chore: Fix flaky test in unsafeOptionalDataVia [pekko]

2024-12-17 Thread via GitHub
mdedetrich commented on PR #1611: URL: https://github.com/apache/pekko/pull/1611#issuecomment-2548791975 > @mdedetrich Can you give some more context of the current design? So the context is primarily when using kafka cursors with FlowWithContext/SourceWithContext. This feature lets y

Re: [PR] chore: Fix flaky test in unsafeOptionalDataVia [pekko]

2024-12-17 Thread via GitHub
He-Pin commented on PR #1611: URL: https://github.com/apache/pekko/pull/1611#issuecomment-2548777114 @raboof That's what's I'm wondering, because the current design ,it can not keep order, not sure if that's how @mdedetrich expected it works. -- This is an automated message from the Apach

Re: [PR] chore: Fix flaky test in unsafeOptionalDataVia [pekko]

2024-12-17 Thread via GitHub
He-Pin commented on PR #1611: URL: https://github.com/apache/pekko/pull/1611#issuecomment-2548785586 @mdedetrich Can you give some more context of the current design? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] chore: Fix flaky test in unsafeOptionalDataVia [pekko]

2024-12-17 Thread via GitHub
mdedetrich commented on PR #1611: URL: https://github.com/apache/pekko/pull/1611#issuecomment-2548784515 Let me retract my approval, I didn't pay attention to the change. Indeed the ordering of the elements should not change, @raboof is correct where the unsafe part pertains to the fa

Re: [PR] chore: Fix flaky test in unsafeOptionalDataVia [pekko]

2024-12-17 Thread via GitHub
He-Pin commented on PR #1611: URL: https://github.com/apache/pekko/pull/1611#issuecomment-2548792994 Let me update it, I can workout a solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [I] stop running link validator on every PR commit [pekko]

2024-12-17 Thread via GitHub
raboof commented on issue #1595: URL: https://github.com/apache/pekko/issues/1595#issuecomment-2547810163 > The job is so brittle. We can afford to miss an occasional broken link. > > We are really stressing repository.apache.org. #1585 (I'm not convinced it's us that's causing

Re: [I] stop running link validator on every PR commit [pekko]

2024-12-17 Thread via GitHub
pjfanning commented on issue #1595: URL: https://github.com/apache/pekko/issues/1595#issuecomment-2547818476 closing as duplicate of #1309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[PR] run link-validator once a day (not per PR commit) [pekko]

2024-12-17 Thread via GitHub
pjfanning opened a new pull request, #1609: URL: https://github.com/apache/pekko/pull/1609 see #1309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

Re: [I] SourceWithContextSpec test that fails intermittently [pekko]

2024-12-17 Thread via GitHub
He-Pin commented on issue #1610: URL: https://github.com/apache/pekko/issues/1610#issuecomment-2548612853 ![image](https://github.com/user-attachments/assets/fa8933ce-d62f-4899-898a-ee8a7521f49c) I looked into it, the current implementation is using a `Merge` which will not keep the orgi

Re: [PR] run link-validator once a day (not per PR commit) [pekko]

2024-12-17 Thread via GitHub
pjfanning merged PR #1609: URL: https://github.com/apache/pekko/pull/1609 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekk

Re: [PR] try to find issue with akka/pekko cluster change [pekko]

2024-12-17 Thread via GitHub
pjfanning commented on PR #1594: URL: https://github.com/apache/pekko/pull/1594#issuecomment-2548447080 @He-Pin this PR is based on #1567 but makes extra changes because the nightly tests failed with the 1567 changes. Specifically, the some nightly tests use pekko.tcp/akka.tcp transports. 1

Re: [PR] try to find issue with akka/pekko cluster change [pekko]

2024-12-17 Thread via GitHub
pjfanning commented on PR #1594: URL: https://github.com/apache/pekko/pull/1594#issuecomment-2548358620 @raboof @He-Pin @sadekmunawar I think I have all the tests passing now. I will check again later. If these changes are approved, I can remove the temp change to run the nightly tests duri

[GH] (pekko): Workflow run "Nightly Builds" failed!

2024-12-17 Thread GitBox
The GitHub Actions job "Nightly Builds" on pekko.git has failed. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 53761e549aa4775065a8435402b11dc96981a0f9 / PJ Fanning run link-validator once a day (not per PR commit) (#1609) Report URL: https://github.com/a

[GH] (pekko-projection): Workflow run "Nightly Integration Tests for JDBC (Pekko 1.0.x)" failed!

2024-12-17 Thread GitBox
The GitHub Actions job "Nightly Integration Tests for JDBC (Pekko 1.0.x)" on pekko-projection.git has failed. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: dfac188506112a4c0ba71a7916e1144f901b94be / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@

[GH] (pekko-persistence-dynamodb): Workflow run "Publish nightly artifacts" is working again!

2024-12-17 Thread GitBox
The GitHub Actions job "Publish nightly artifacts" on pekko-persistence-dynamodb.git has succeeded. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: b99511d553c335695f7c97e1ce508c55717d5627 / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.nore

[GH] (pekko-persistence-cassandra): Workflow run "Publish 1.0 jars nightly" is working again!

2024-12-17 Thread GitBox
The GitHub Actions job "Publish 1.0 jars nightly" on pekko-persistence-cassandra.git has succeeded. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: ce514f76cc762be3075d76853347db1750c6ae09 / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.nore

[GH] (pekko-management): Workflow run "Publish" is working again!

2024-12-17 Thread GitBox
The GitHub Actions job "Publish" on pekko-management.git has succeeded. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 7ef5fd3d0547ce761fcea183c70ec9caf613019f / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.noreply.github.com> Update log4j-

[GH] (pekko-management): Workflow run "Nightly Tests" failed!

2024-12-17 Thread GitBox
The GitHub Actions job "Nightly Tests" on pekko-management.git has failed. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 7ef5fd3d0547ce761fcea183c70ec9caf613019f / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.noreply.github.com> Update log

Re: [PR] bug: fix occasional ordering issue in result in unsafeOptionalDataVia [pekko]

2024-12-17 Thread via GitHub
He-Pin merged PR #1611: URL: https://github.com/apache/pekko/pull/1611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.a

Re: [PR] bug: fix occasional ordering issue in result in unsafeOptionalDataVia [pekko]

2024-12-17 Thread via GitHub
He-Pin commented on PR #1611: URL: https://github.com/apache/pekko/pull/1611#issuecomment-2550188774 Thanks for the review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GH] (pekko-connectors-kafka): Workflow run "Nightly Build and Test" is working again!

2024-12-17 Thread GitBox
The GitHub Actions job "Nightly Build and Test" on pekko-connectors-kafka.git has succeeded. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 22d647333ecc7b29a31528bbdd19f098902e1fbe / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.noreply.git

Re: [I] SourceWithContextSpec test that fails intermittently [pekko]

2024-12-17 Thread via GitHub
He-Pin closed issue #1610: SourceWithContextSpec test that fails intermittently URL: https://github.com/apache/pekko/issues/1610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GH] (pekko-connectors): Workflow run "Nightly Pekko 1.0 Builds" is working again!

2024-12-17 Thread GitBox
The GitHub Actions job "Nightly Pekko 1.0 Builds" on pekko-connectors.git has succeeded. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 6981eaa8a855999c39eb9006671d26c4a7280c3c / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.noreply.github.

[GH] (pekko-connectors): Workflow run "Publish Nightly" is working again!

2024-12-17 Thread GitBox
The GitHub Actions job "Publish Nightly" on pekko-connectors.git has succeeded. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 6981eaa8a855999c39eb9006671d26c4a7280c3c / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.noreply.github.com> Updat

[GH] (pekko-http): Workflow run "Nightly Builds" failed!

2024-12-17 Thread GitBox
The GitHub Actions job "Nightly Builds" on pekko-http.git has failed. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: 4554337dd2e96cb0dd14c5b30e2a572344e0cd0f / David Sheynkman Optimized Uri.withQuery (#637) * Optimized Uri.withQuery * Improved UriSpec percent e

[GH] (pekko-persistence-r2dbc): Workflow run "Nightly Tests (Pekko 1.0.x)" failed!

2024-12-17 Thread GitBox
The GitHub Actions job "Nightly Tests (Pekko 1.0.x)" on pekko-persistence-r2dbc.git has failed. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 553752fc82c15695e52c8db7627a48b1ec14bd3c / PJ Fanning release notes for 1.1.0-M1 (#179) * release notes for 1.1.

Re: [I] Configuring persistence plugins at runtime [pekko-persistence-r2dbc]

2024-12-17 Thread via GitHub
pjfanning commented on issue #181: URL: https://github.com/apache/pekko-persistence-r2dbc/issues/181#issuecomment-2549448547 We recently released 1.1.0-M1 as a preview. It has been suggested that the changes are already big enough to justify us calling it 2.0.0 when it gets around to a ful

Re: [PR] bug: fix occasional ordering issue in result in unsafeOptionalDataVia [pekko]

2024-12-17 Thread via GitHub
He-Pin commented on code in PR #1611: URL: https://github.com/apache/pekko/pull/1611#discussion_r1889086396 ## stream/src/main/scala/org/apache/pekko/stream/scaladsl/SourceWithContext.scala: ## @@ -57,36 +57,44 @@ object SourceWithContext { SourceWithContext.fromTuples(Sour

Re: [PR] chore: Fix flaky test in unsafeOptionalDataVia [pekko]

2024-12-17 Thread via GitHub
He-Pin commented on PR #1611: URL: https://github.com/apache/pekko/pull/1611#issuecomment-2549266012 @raboof @mdedetrich @pjfanning I think it should be OK now, it now track the origin order with an index and then merge back with the same index. -- This is an automated message from the Ap

Re: [PR] chore: Fix flaky test in unsafeOptionalDataVia [pekko]

2024-12-17 Thread via GitHub
He-Pin commented on code in PR #1611: URL: https://github.com/apache/pekko/pull/1611#discussion_r1889022056 ## stream/src/main/scala/org/apache/pekko/stream/scaladsl/SourceWithContext.scala: ## @@ -57,36 +57,44 @@ object SourceWithContext { SourceWithContext.fromTuples(Sour

Re: [PR] bug: fix occasional ordering issue in result in unsafeOptionalDataVia [pekko]

2024-12-17 Thread via GitHub
pjfanning commented on PR #1611: URL: https://github.com/apache/pekko/pull/1611#issuecomment-2549386650 > Do we know if the test runs in PR CI builds? I did a quick check of the test logs and didn't find a match. I found `must Apply a viaFlow with optional elements using unsafeOptiona

Re: [I] Configuring persistence plugins at runtime [pekko-persistence-r2dbc]

2024-12-17 Thread via GitHub
ptrdom commented on issue #181: URL: https://github.com/apache/pekko-persistence-r2dbc/issues/181#issuecomment-2549472313 Sounds great! Looking at the version history and the state of code it feels like `1.0.0` releases for both Akka and Pekko versions of this project were about lice

Re: [PR] bug: fix occasional ordering issue in result in unsafeOptionalDataVia [pekko]

2024-12-17 Thread via GitHub
pjfanning commented on PR #1611: URL: https://github.com/apache/pekko/pull/1611#issuecomment-2549383095 Do we know if the test runs in PR CI builds? I did a quick check of the test logs and didn't find a match. -- This is an automated message from the Apache Git Service. To respond to the

[I] Configuring persistence plugins at runtime [pekko-persistence-r2dbc]

2024-12-17 Thread via GitHub
ptrdom opened a new issue, #181: URL: https://github.com/apache/pekko-persistence-r2dbc/issues/181 Follow up on https://github.com/apache/pekko/issues/1513. Implementing persistence plugin configuration at runtime for this project will require changes to implementation and configurati