Re: [PR] handle invalid accept-charset in requests - default to utf-8 [pekko-http]

2024-08-13 Thread via GitHub
raboof commented on code in PR #584: URL: https://github.com/apache/pekko-http/pull/584#discussion_r1714829003 ## http-tests/src/test/scala/org/apache/pekko/http/scaladsl/server/directives/MarshallingDirectivesSpec.scala: ## @@ -275,4 +275,23 @@ class MarshallingDirectivesSpec e

Re: [PR] handle invalid accept-charset in requests - default to utf-8 [pekko-http]

2024-08-13 Thread via GitHub
raboof commented on code in PR #584: URL: https://github.com/apache/pekko-http/pull/584#discussion_r1714829003 ## http-tests/src/test/scala/org/apache/pekko/http/scaladsl/server/directives/MarshallingDirectivesSpec.scala: ## @@ -275,4 +275,23 @@ class MarshallingDirectivesSpec e

Re: [I] Random occasional `SubscriptionWithCancelException$NoMoreElementsNeeded` after migrating from Akka to Pekko [pekko-http]

2024-08-13 Thread via GitHub
Tvaroh commented on issue #422: URL: https://github.com/apache/pekko-http/issues/422#issuecomment-2285807735 @djjorjinho it's mysterious but after adding retries those exceptions eventually went away by themselves, perhaps something changed externally, so I'm afraid I have no answer to that

Re: [I] Random occasional `SubscriptionWithCancelException$NoMoreElementsNeeded` after migrating from Akka to Pekko [pekko-http]

2024-08-13 Thread via GitHub
djjorjinho commented on issue #422: URL: https://github.com/apache/pekko-http/issues/422#issuecomment-2285819367 @Tvaroh no worries, thanks for the reply. Can you share if you made any changes to any config inside `pekko.http.host-connection-pool` or `pekko.http.client`, like `stream

Re: [I] Random occasional `SubscriptionWithCancelException$NoMoreElementsNeeded` after migrating from Akka to Pekko [pekko-http]

2024-08-13 Thread via GitHub
Tvaroh commented on issue #422: URL: https://github.com/apache/pekko-http/issues/422#issuecomment-2285823521 @djjorjinho good point, sure, here what we ended up with: ```hocon pekko { loggers = ["org.apache.pekko.event.slf4j.Slf4jLogger"] loglevel = "DEBUG" http {

Re: [PR] handle invalid accept-charset in requests - default to utf-8 [pekko-http]

2024-08-13 Thread via GitHub
pjfanning commented on code in PR #584: URL: https://github.com/apache/pekko-http/pull/584#discussion_r1715101867 ## http-tests/src/test/scala/org/apache/pekko/http/scaladsl/server/directives/MarshallingDirectivesSpec.scala: ## @@ -275,4 +275,23 @@ class MarshallingDirectivesSpe

Re: [PR] handle invalid accept-charset in requests - default to utf-8 [pekko-http]

2024-08-13 Thread via GitHub
pjfanning commented on code in PR #584: URL: https://github.com/apache/pekko-http/pull/584#discussion_r1715101867 ## http-tests/src/test/scala/org/apache/pekko/http/scaladsl/server/directives/MarshallingDirectivesSpec.scala: ## @@ -275,4 +275,23 @@ class MarshallingDirectivesSpe

[GH] (pekko): Workflow run "Nightly Builds (1.0)" is working again!

2024-08-13 Thread GitBox
The GitHub Actions job "Nightly Builds (1.0)" on pekko.git has succeeded. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: d737c44b8f5bc954aa4204c02693bd2216632186 / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.noreply.github.com> Update sbt-

[GH] (pekko-management): Workflow run "Nightly Tests" failed!

2024-08-13 Thread GitBox
The GitHub Actions job "Nightly Tests" on pekko-management.git has failed. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: f4d1800acd20d733770ea6193a47624dbfe24abb / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.noreply.github.com> Update slf

[GH] (pekko-connectors-kafka): Workflow run "Nightly Build and Test" failed!

2024-08-13 Thread GitBox
The GitHub Actions job "Nightly Build and Test" on pekko-connectors-kafka.git has failed. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 7e7817d3a9733097bb2fff0ad78a6dbd0d097408 / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.noreply.github

Re: [PR] run extra tests that need Java 9+ [pekko]

2024-08-13 Thread via GitHub
Roiocam commented on PR #1434: URL: https://github.com/apache/pekko/pull/1434#issuecomment-2287929222 Thanks for this, It looks like a new case that we didn't cover it. we haven't jdk9 test before, only exists in documentation. -- This is an automated message from the Apache Git Servic

Re: [PR] Add test for virtual thread support [pekko]

2024-08-13 Thread via GitHub
Roiocam commented on code in PR #1436: URL: https://github.com/apache/pekko/pull/1436#discussion_r1716359215 ## actor-tests/src/test/scala-jdk21-only/org/apache/pekko/dispatch/VirtualThreadPoolDispatcherSpec.scala: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foun