[I] Uncaught NPE when parsing a header value [pekko-http]

2024-07-09 Thread via GitHub
nigredo-tori opened a new issue, #574: URL: https://github.com/apache/pekko-http/issues/574 I'm using Akka 10.2.9, but the issue doesn't seem to have been fixed in Pekko as well. Sorry I don't have a reproduction example at this moment, I'm creating this issue to have something to reference

Re: [I] Uncaught NPE when parsing a header value [pekko-http]

2024-07-09 Thread via GitHub
jrudolph commented on issue #574: URL: https://github.com/apache/pekko-http/issues/574#issuecomment-2216897099 Thanks for the report. `HeaderParser.failure` tries exactly to convert exceptions into an `Either`-like error but misses the fact that exception messages can be null. We could eith

Re: [I] SubFlow's don't correctly propagate `Supervision.resumeStrategy` [pekko]

2024-07-09 Thread via GitHub
gwak commented on issue #1205: URL: https://github.com/apache/pekko/issues/1205#issuecomment-2216939178 Hi @mdedetrich, @pjfanning and I just tested the 1.1 milestone release with **[playframework](https://github.com/playframework/playframework/pull/12662)**. We followed the migratio

Re: [I] SubFlow's don't correctly propagate `Supervision.resumeStrategy` [pekko]

2024-07-09 Thread via GitHub
mdedetrich commented on issue #1205: URL: https://github.com/apache/pekko/issues/1205#issuecomment-2216967944 Re-opening this as it needs to be solved -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [I] SubFlow's don't correctly propagate `Supervision.resumeStrategy` [pekko]

2024-07-09 Thread via GitHub
mdedetrich commented on issue #1205: URL: https://github.com/apache/pekko/issues/1205#issuecomment-2216967386 @gwak So I still need to work on this, in the meantime I would recommend using the deprecated method as you described. I just skimmed through the issue to recover some context

[I] SubFlow's don't correctly propagate `Supervision.resumeStrategy` [pekko]

2024-07-09 Thread via GitHub
mdedetrich opened a new issue, #1205: URL: https://github.com/apache/pekko/issues/1205 In https://github.com/apache/incubator-pekko/pull/252 I made it so that we can set `SupervisionStrategy` rather than using `SubStreamCancelStrategy`. It turns out there is an existing test which was writt

Re: [PR] Support Supervision.restart for SubFlow's [pekko]

2024-07-09 Thread via GitHub
pjfanning commented on PR #981: URL: https://github.com/apache/pekko/pull/981#issuecomment-2216978085 Is this related to #1205 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [I] SubFlow's don't correctly propagate `Supervision.resumeStrategy` [pekko]

2024-07-09 Thread via GitHub
mdedetrich commented on issue #1205: URL: https://github.com/apache/pekko/issues/1205#issuecomment-2217266375 @gwak So I am diving into this now and I think that I fixed this issue in https://github.com/apache/pekko/pull/1207 so things should be working as expected. Reading your code

Re: [PR] Support Supervision.restart for SubFlow's [pekko]

2024-07-09 Thread via GitHub
mdedetrich commented on PR #981: URL: https://github.com/apache/pekko/pull/981#issuecomment-2217343761 No this is something else, its a new feature change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] ignore datastax link issues [pekko-projection]

2024-07-09 Thread via GitHub
pjfanning merged PR #183: URL: https://github.com/apache/pekko-projection/pull/183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [I] Link validator fails on datastax pages [pekko-projection]

2024-07-09 Thread via GitHub
pjfanning commented on issue #178: URL: https://github.com/apache/pekko-projection/issues/178#issuecomment-2217399210 #183 merged Feel free to reopen if you feel we need to do a deep dive into why link validator reports issues even though the links in the web pages work. -- This i

Re: [I] Link validator fails on datastax pages [pekko-projection]

2024-07-09 Thread via GitHub
pjfanning closed issue #178: Link validator fails on datastax pages URL: https://github.com/apache/pekko-projection/issues/178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [I] SubFlow's don't correctly propagate `Supervision.resumeStrategy` [pekko]

2024-07-09 Thread via GitHub
gwak commented on issue #1205: URL: https://github.com/apache/pekko/issues/1205#issuecomment-2217489299 @mdedetrich You were right, @pjfanning tried your suggestion in https://github.com/playframework/playframework/pull/12794 and tests are passing. Thanks! So the final flow is someth

Re: [I] SubFlow's don't correctly propagate `Supervision.resumeStrategy` [pekko]

2024-07-09 Thread via GitHub
mdedetrich closed issue #1205: SubFlow's don't correctly propagate `Supervision.resumeStrategy` URL: https://github.com/apache/pekko/issues/1205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [I] SubFlow's don't correctly propagate `Supervision.resumeStrategy` [pekko]

2024-07-09 Thread via GitHub
mdedetrich commented on issue #1205: URL: https://github.com/apache/pekko/issues/1205#issuecomment-2217507712 Perfect! Closing ticket -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] SubFlow's don't correctly propagate `Supervision.resumeStrategy` [pekko]

2024-07-09 Thread via GitHub
pjfanning commented on issue #1205: URL: https://github.com/apache/pekko/issues/1205#issuecomment-2217538499 @mdedetrich would you have time to review the Pekko 1.1 migration docs? Would it make sense to suggest that the SupervisionStrategy should be be defined after the concatSubstreams ca

Re: [I] SubFlow's don't correctly propagate `Supervision.resumeStrategy` [pekko]

2024-07-09 Thread via GitHub
mdedetrich commented on issue #1205: URL: https://github.com/apache/pekko/issues/1205#issuecomment-2217645710 Sure, I'll do this today -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Uncaught NPE when parsing a header value [pekko-http]

2024-07-09 Thread via GitHub
laglangyue commented on issue #574: URL: https://github.com/apache/pekko-http/issues/574#issuecomment-2217849651 https://github.com/apache/pekko-http/assets/35491928/c9a59c73-55fd-4d17-a4d9-3c1b9ca9a290";> we should add case -- This is an automated message from the Apache Git Servic

Re: [I] Uncaught NPE when parsing a header value [pekko-http]

2024-07-09 Thread via GitHub
pjfanning commented on issue #574: URL: https://github.com/apache/pekko-http/issues/574#issuecomment-2217857911 > https://private-user-images.githubusercontent.com/35491928/346989795-c9a59c73-55fd-4d17-a4d9-3c1b9ca9a290.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwi

Re: [I] Uncaught NPE when parsing a header value [pekko-http]

2024-07-09 Thread via GitHub
laglangyue commented on issue #574: URL: https://github.com/apache/pekko-http/issues/574#issuecomment-2217868061 @pjfanning yes, I am designing some tests to reproduce errors and make modifications -- This is an automated message from the Apache Git Service. To respond to the message, pl

[PR] Fix migration notes for SubstreamCancelStrategy deprecation [pekko]

2024-07-09 Thread via GitHub
mdedetrich opened a new pull request, #1391: URL: https://github.com/apache/pekko/pull/1391 @pjfanning @raboof @He-Pin @Roiocam @jxnu-liguobin Can you have a look into this just to confirm I didn't say anything wrong. Related to https://github.com/apache/pekko/issues/1205#issuecommen

Re: [I] SubFlow's don't correctly propagate `Supervision.resumeStrategy` [pekko]

2024-07-09 Thread via GitHub
mdedetrich commented on issue #1205: URL: https://github.com/apache/pekko/issues/1205#issuecomment-2217928455 PR created at https://github.com/apache/pekko/pull/1391 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] Uncaught NPE when parsing a header value [pekko-http]

2024-07-09 Thread via GitHub
laglangyue commented on issue #574: URL: https://github.com/apache/pekko-http/issues/574#issuecomment-2217993262 Although I added a check that can fix it, the message of NPE is not null on Java17. I dig deep again, https://github.com/apache/pekko-http/assets/35491928/9a4c7686-260b-

Re: [I] Uncaught NPE when parsing a header value [pekko-http]

2024-07-09 Thread via GitHub
pjfanning commented on issue #574: URL: https://github.com/apache/pekko-http/issues/574#issuecomment-2218004201 Use the getMessage if is not null even if NullPointerException has changed in Java 17. We support Java 8+. Text cases may not to be handle supporting different behaviour dependi

[PR] fix parse broken when header value is null [pekko-http]

2024-07-09 Thread via GitHub
laglangyue opened a new pull request, #575: URL: https://github.com/apache/pekko-http/pull/575 ## motivation fix 574 ## test by ci -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GH] (pekko-http): Workflow run "Scalafmt" failed!

2024-07-09 Thread GitBox
The GitHub Actions job "Scalafmt" on pekko-http.git has failed. Run started by GitHub user laglangyue (triggered by laglangyue). Head commit for run: 51dceebe23ba00d161158ba5d233f7a719a75f0c / tangjiafu fix parse broken when header value is null Report URL: https://github.com/apache/pekko-http

[GH] (pekko-http): Workflow run "Scalafmt" failed!

2024-07-09 Thread GitBox
The GitHub Actions job "Scalafmt" on pekko-http.git has failed. Run started by GitHub user laglangyue (triggered by laglangyue). Head commit for run: f8f77b4e929b32f95378f24c98371c48a6eff11c / tangjiafu fix style Report URL: https://github.com/apache/pekko-http/actions/runs/9859910566 With re

[GH] (pekko-http): Workflow run "Scalafmt" failed!

2024-07-09 Thread GitBox
The GitHub Actions job "Scalafmt" on pekko-http.git has failed. Run started by GitHub user laglangyue (triggered by laglangyue). Head commit for run: 34c0086871c36f5f4e1041ebe75c8f551861aa70 / tangjiafu revert not need change Report URL: https://github.com/apache/pekko-http/actions/runs/985993

Re: [PR] fix parse broken when header value is null [pekko-http]

2024-07-09 Thread via GitHub
pjfanning commented on code in PR #575: URL: https://github.com/apache/pekko-http/pull/575#discussion_r1670760122 ## http-core/src/main/scala/org/apache/pekko/http/scaladsl/model/HttpHeader.scala: ## @@ -99,10 +99,11 @@ object HttpHeader { case HeaderParser.RuleNotF

[I] reproducible builds: proto files in google-cloud artifacts [pekko-connectors]

2024-07-09 Thread via GitHub
raboof opened a new issue, #738: URL: https://github.com/apache/pekko-connectors/issues/738 while checking the v1.1.0-M1-RC1 artifacts, in both `pekko-connectors-google-cloud-pub-sub-grpc_2.13-1.1.0-M1-RC1.jar` and `pekko-connectors-google-cloud-bigquery-storage_2.13-1.1.0-M1-RC1.jar`, I e

[I] reproducible builds: TASTY differences [pekko-connectors]

2024-07-09 Thread via GitHub
raboof opened a new issue, #739: URL: https://github.com/apache/pekko-connectors/issues/739 Similar to pekko-http#566 * In `pekko-connectors-google-fcm_3-1.1.0-M1-RC1.jar` in `org/apache/pekko/stream/connectors/google/firebase/fcm/v1/models/FcmOption` (begin and and of the .tasty fil

Re: [I] reproducible builds: TASTY differences [pekko-connectors]

2024-07-09 Thread via GitHub
raboof commented on issue #739: URL: https://github.com/apache/pekko-connectors/issues/739#issuecomment-2218752754 OK, so interestingly `FcmOption` is really small, so that is a good start for a reproducer. `FcmOption` has 3 `@Child` annotations, one for each class extending `FcmOpt

[GH] (pekko): Workflow run "Nightly Builds (1.0)" failed!

2024-07-09 Thread GitBox
The GitHub Actions job "Nightly Builds (1.0)" on pekko.git has failed. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 684fec989e6f99204b2f1ab02dcfe56c13a014db / Arnout Engelen feat: publish SBOMs (#1380) While clearly not perfect, I think we should start gr

[GH] (pekko): Workflow run "Nightly Builds" failed!

2024-07-09 Thread GitBox
The GitHub Actions job "Nightly Builds" on pekko.git has failed. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 684fec989e6f99204b2f1ab02dcfe56c13a014db / Arnout Engelen feat: publish SBOMs (#1380) While clearly not perfect, I think we should start growing

[GH] (pekko-management): Workflow run "Nightly Tests" is working again!

2024-07-09 Thread GitBox
The GitHub Actions job "Nightly Tests" on pekko-management.git has succeeded. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: fe287db8ee7f0a8dffd0212a72c0f3245e36966b / Arnout Engelen chore: avoid multiple scala-steward jetty PRs (#275) Like #273 Report URL

[GH] (pekko-connectors-kafka): Workflow run "Nightly Build and Test" failed!

2024-07-09 Thread GitBox
The GitHub Actions job "Nightly Build and Test" on pekko-connectors-kafka.git has failed. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 558d368b1d1e7b10c827cd769fb4d4c6447927cd / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.noreply.github

[GH] (pekko-http): Workflow run "Scalafmt" is working again!

2024-07-09 Thread GitBox
The GitHub Actions job "Scalafmt" on pekko-http.git has succeeded. Run started by GitHub user laglangyue (triggered by laglangyue). Head commit for run: 99cba4d3a8d8625c3d87484e97853d4470fb029d / tangjiafu improve match case Report URL: https://github.com/apache/pekko-http/actions/runs/9867752

Re: [PR] fix parse broken when header value is null [pekko-http]

2024-07-09 Thread via GitHub
laglangyue commented on code in PR #575: URL: https://github.com/apache/pekko-http/pull/575#discussion_r1671566513 ## http-core/src/main/scala/org/apache/pekko/http/scaladsl/model/HttpHeader.scala: ## @@ -99,10 +99,11 @@ object HttpHeader { case HeaderParser.RuleNot