Re: [I] link validator fails due to changed url [incubator-pekko]

2024-02-22 Thread via GitHub
raboof commented on issue #1138: URL: https://github.com/apache/incubator-pekko/issues/1138#issuecomment-1958934107 Are we sure that was intentional? That doesn't seem like an improvement and perhaps something they'll rollback? -- This is an automated message from the Apache Git Service.

Re: [PR] add security headers [incubator-pekko-site]

2024-02-22 Thread via GitHub
raboof commented on code in PR #86: URL: https://github.com/apache/incubator-pekko-site/pull/86#discussion_r1498860684 ## content/.htaccess: ## @@ -55,3 +55,11 @@ RewriteRule ^japi/([^/]+)/1.0.2/(.*)$ https://nightlies.apache.org/pekko/docs/$1 RewriteRule ^docs/([^/]+)/1.0/(.

Re: [I] link validator fails due to changed url [incubator-pekko]

2024-02-22 Thread via GitHub
nvollmar commented on issue #1138: URL: https://github.com/apache/incubator-pekko/issues/1138#issuecomment-1958956826 Not sure, at least it changed for all licenses: https://opensource.org/licenses -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [I] link validator fails due to changed url [incubator-pekko]

2024-02-22 Thread via GitHub
raboof commented on issue #1138: URL: https://github.com/apache/incubator-pekko/issues/1138#issuecomment-1958962760 asked on https://merveilles.town/@raboof/111974245965562026 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [I] link validator fails due to changed url [incubator-pekko]

2024-02-22 Thread via GitHub
nvollmar commented on issue #1138: URL: https://github.com/apache/incubator-pekko/issues/1138#issuecomment-1958970731 I will open an issue on https://github.com/OpenSourceOrg/dotOrg maybe we get an answer there -- This is an automated message from the Apache Git Service. To respond to th

Re: [I] link validator fails due to changed url [incubator-pekko]

2024-02-22 Thread via GitHub
raboof commented on issue #1138: URL: https://github.com/apache/incubator-pekko/issues/1138#issuecomment-1958976614 a found it at https://github.com/OpenSourceOrg/dotOrg/issues/60, great -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] scala3 support for slick [incubator-pekko-connectors]

2024-02-22 Thread via GitHub
raboof commented on PR #223: URL: https://github.com/apache/incubator-pekko-connectors/pull/223#issuecomment-1958975082 Ideally I think releases should not depend on snapshot/RC dependencies, and the main branch should always be in a release-able state. I guess we can deviate from that if

Re: [PR] scala3 support for slick [incubator-pekko-connectors]

2024-02-22 Thread via GitHub
pjfanning commented on PR #223: URL: https://github.com/apache/incubator-pekko-connectors/pull/223#issuecomment-1958987553 I agree that it is too time consuming for us to do releases to test non-ASF jars. If someone really wanted to test this, they could build pekko-connectors-slick jars t

Re: [PR] scala3 support for slick [incubator-pekko-connectors]

2024-02-22 Thread via GitHub
mdedetrich commented on PR #223: URL: https://github.com/apache/incubator-pekko-connectors/pull/223#issuecomment-1958997035 > Alternatively, would it be possible to set up our GitHub Actions so that we can publish a snapshot built off a branch/PR? I wanted to do this at some point I

Re: [I] Avoid hitting the GitHub API [incubator-pekko-sbt-paradox]

2024-02-22 Thread via GitHub
mdedetrich commented on issue #110: URL: https://github.com/apache/incubator-pekko-sbt-paradox/issues/110#issuecomment-1958999636 I think we can prevent this by propagating the `GITHUB_TOKEN` (which is provided to the github CI runners) to the REST calls -- This is an automated message f

Re: [I] Avoid hitting the GitHub API [incubator-pekko-sbt-paradox]

2024-02-22 Thread via GitHub
raboof commented on issue #110: URL: https://github.com/apache/incubator-pekko-sbt-paradox/issues/110#issuecomment-1959003019 This is about the client-side javascript, not the build process -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Adds ignore for opensource.org due to changed path [incubator-pekko]

2024-02-22 Thread via GitHub
nvollmar closed pull request #1139: Adds ignore for opensource.org due to changed path URL: https://github.com/apache/incubator-pekko/pull/1139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [I] link validator fails due to changed url [incubator-pekko]

2024-02-22 Thread via GitHub
nvollmar closed issue #1138: link validator fails due to changed url URL: https://github.com/apache/incubator-pekko/issues/1138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] link validator fails due to changed url [incubator-pekko]

2024-02-22 Thread via GitHub
nvollmar commented on issue #1138: URL: https://github.com/apache/incubator-pekko/issues/1138#issuecomment-1959004997 They will revert back to the original URL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] add security headers [incubator-pekko-site]

2024-02-22 Thread via GitHub
raboof merged PR #86: URL: https://github.com/apache/incubator-pekko-site/pull/86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

Re: [I] Avoid hitting the GitHub API [incubator-pekko-sbt-paradox]

2024-02-22 Thread via GitHub
mdedetrich commented on issue #110: URL: https://github.com/apache/incubator-pekko-sbt-paradox/issues/110#issuecomment-1959039867 > This is about the client-side javascript, not the build process Oh I see, nvm then. -- This is an automated message from the Apache Git Service. To re

Re: [PR] scala3 support for slick [incubator-pekko-connectors]

2024-02-22 Thread via GitHub
mdedetrich commented on PR #223: URL: https://github.com/apache/incubator-pekko-connectors/pull/223#issuecomment-1959051742 Replied at https://github.com/slick/slick/discussions/2891#discussioncomment-8554394 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]

2024-02-22 Thread via GitHub
mdedetrich commented on PR #44: URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#issuecomment-1959052545 Marking PR as draft again, see https://github.com/slick/slick/discussions/2891#discussioncomment-8554394 -- This is an automated message from the Apache Git Ser

Re: [PR] slightly better support for Solr 9 client - (but full support won't be possible until we use Java 11 to build) [incubator-pekko-connectors]

2024-02-22 Thread via GitHub
pjfanning merged PR #481: URL: https://github.com/apache/incubator-pekko-connectors/pull/481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Update jcl-over-slf4j, log4j-over-slf4j to 2.0.11 [incubator-pekko-connectors]

2024-02-22 Thread via GitHub
pjfanning closed pull request #386: Update jcl-over-slf4j, log4j-over-slf4j to 2.0.11 URL: https://github.com/apache/incubator-pekko-connectors/pull/386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Rework PhiAccrualFailureDetector to enable monitoring of interval [incubator-pekko]

2024-02-22 Thread via GitHub
He-Pin commented on code in PR #1137: URL: https://github.com/apache/incubator-pekko/pull/1137#discussion_r1499416393 ## remote/src/main/scala/org/apache/pekko/remote/FailureDetector.scala: ## @@ -40,6 +40,16 @@ trait FailureDetector { } +trait FailureDetectorWithAddress {

[I] NullPointerException when overriding testKit from ScalaTestWithActorTestKit [incubator-pekko]

2024-02-22 Thread via GitHub
ccerbusca opened a new issue, #1140: URL: https://github.com/apache/incubator-pekko/issues/1140 While migrating a project to Pekko, I noticed that some of the tests started failing with `NullPointerException`s. On further investigation, it was because I was overriding the TestKit insi

Re: [PR] Rework PhiAccrualFailureDetector to enable monitoring of interval [incubator-pekko]

2024-02-22 Thread via GitHub
jxnu-liguobin commented on code in PR #1137: URL: https://github.com/apache/incubator-pekko/pull/1137#discussion_r1499425160 ## remote/src/main/scala/org/apache/pekko/remote/FailureDetector.scala: ## @@ -40,6 +40,16 @@ trait FailureDetector { } +trait FailureDetectorWithAdd

Re: [I] Requests with Large POST Body Immediately Goes into Delay Cancellation Right After the Server Received the Request [incubator-pekko-http]

2024-02-22 Thread via GitHub
mkurz commented on issue #460: URL: https://github.com/apache/incubator-pekko-http/issues/460#issuecomment-1959700748 I can reproduce this in Play, it's because we have HTTP pipelining enabled be default, see - https://github.com/playframework/playframework/issues/12351#issuecomment-19

Re: [I] NullPointerException when overriding testKit from ScalaTestWithActorTestKit [incubator-pekko]

2024-02-22 Thread via GitHub
mdedetrich commented on issue #1140: URL: https://github.com/apache/incubator-pekko/issues/1140#issuecomment-1959726961 I don't think this is generally solvable due to how trait initialization works in Scala 2, long story short trait composition in Scala 2 is not commutative which means th

Re: [I] Discussion about restoring statefulMapConcat [incubator-pekko]

2024-02-22 Thread via GitHub
He-Pin commented on issue #1141: URL: https://github.com/apache/incubator-pekko/issues/1141#issuecomment-1959913383 I know the problem, the only problem of the current implementation is the extra allocation of tuple, which is the same as mapAccumlate in fs2 and zio. I would like to a

Re: [I] Requests with Large POST Body Immediately Goes into Delay Cancellation Right After the Server Received the Request [incubator-pekko-http]

2024-02-22 Thread via GitHub
pjfanning commented on issue #460: URL: https://github.com/apache/incubator-pekko-http/issues/460#issuecomment-1959937166 @mkurz does this work with Akka HTTP, ie have we broken this in Pekko HTTP? -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [I] Discussion about restoring statefulMapConcat [incubator-pekko]

2024-02-22 Thread via GitHub
JD557 commented on issue #1141: URL: https://github.com/apache/incubator-pekko/issues/1141#issuecomment-1960037460 For reference, here are some benchmarks (based on the original ZIO Streams benchmarks): https://gist.github.com/JD557/251467aac30860dca88dc3e697dfb381 You can quickly ru

Re: [I] Discussion about restoring statefulMapConcat [incubator-pekko]

2024-02-22 Thread via GitHub
He-Pin commented on issue #1141: URL: https://github.com/apache/incubator-pekko/issues/1141#issuecomment-1960055388 I will take care of it this weekend, we will definitely come up with a solution 😀 -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [I] Requests with Large POST Body Immediately Goes into Delay Cancellation Right After the Server Received the Request [incubator-pekko-http]

2024-02-22 Thread via GitHub
mkurz commented on issue #460: URL: https://github.com/apache/incubator-pekko-http/issues/460#issuecomment-1960058145 @pjfanning Behaviour in Akka HTTP 10.2.x and Pekko HTTP v1 is the same, so you did not break anything. -- This is an automated message from the Apache Git Service. To res

Re: [PR] [jms] close sessions when exceptions happen [incubator-pekko-connectors]

2024-02-22 Thread via GitHub
pjfanning commented on PR #485: URL: https://github.com/apache/incubator-pekko-connectors/pull/485#issuecomment-1960250942 I'll try to add some test coverage. https://github.com/pjfanning/JmsWrapper is WIP -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] Rework PhiAccrualFailureDetector to enable monitoring of interval [incubator-pekko]

2024-02-22 Thread via GitHub
nvollmar commented on PR #1137: URL: https://github.com/apache/incubator-pekko/pull/1137#issuecomment-1960370682 The use case would be to intercept or override the call to `recordInterval` -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Rework PhiAccrualFailureDetector to enable monitoring of interval [incubator-pekko]

2024-02-22 Thread via GitHub
nvollmar commented on code in PR #1137: URL: https://github.com/apache/incubator-pekko/pull/1137#discussion_r1499974924 ## remote/src/main/scala/org/apache/pekko/remote/FailureDetector.scala: ## @@ -40,6 +40,16 @@ trait FailureDetector { } +trait FailureDetectorWithAddress

Re: [PR] [jms] close sessions when exceptions happen [incubator-pekko-connectors]

2024-02-22 Thread via GitHub
pjfanning commented on PR #485: URL: https://github.com/apache/incubator-pekko-connectors/pull/485#issuecomment-1960377127 @mdedetrich the test change sin JmsProducerRetrySpec fail with the existing code and pass with the new code that closes the JMS sessions in the retriableException code

Re: [PR] [jms] close sessions when exceptions happen [incubator-pekko-connectors]

2024-02-22 Thread via GitHub
pjfanning merged PR #485: URL: https://github.com/apache/incubator-pekko-connectors/pull/485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] [jms] close sessions when exceptions happen [incubator-pekko-connectors]

2024-02-22 Thread via GitHub
pjfanning commented on PR #485: URL: https://github.com/apache/incubator-pekko-connectors/pull/485#issuecomment-1960453817 I'll keep an eye on the tests because I suspect that the closes could be asynch and may need eventually blocks. -- This is an automated message from the Apache Git S

Re: [I] jms consumer leak when exceptions occur [incubator-pekko-connectors]

2024-02-22 Thread via GitHub
pjfanning commented on issue #484: URL: https://github.com/apache/incubator-pekko-connectors/issues/484#issuecomment-1960454510 https://github.com/apache/incubator-pekko-connectors/pull/485 merged - I'll keep an eye on the tests as they might be brittle -- This is an automated message fr

Re: [I] Discussion about restoring statefulMapConcat [incubator-pekko]

2024-02-22 Thread via GitHub
He-Pin commented on issue #1141: URL: https://github.com/apache/incubator-pekko/issues/1141#issuecomment-1960821673 So the quick fix seems just remove the deprecation, and add more detail log in 1.0.x. And will need a new building block for this which will not introduce any allocation.

Re: [PR] kinesis: use stage materializer with IODispatcher instead of injected EC [incubator-pekko-connectors]

2024-02-22 Thread via GitHub
mdedetrich commented on PR #226: URL: https://github.com/apache/incubator-pekko-connectors/pull/226#issuecomment-1960859849 Going to go ahead and merge this, if there are any issues we can always patch them up later (there will be many milestones for connectors). Many thanks @jtjefer

Re: [PR] kinesis: use stage materializer with IODispatcher instead of injected EC [incubator-pekko-connectors]

2024-02-22 Thread via GitHub
mdedetrich merged PR #226: URL: https://github.com/apache/incubator-pekko-connectors/pull/226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificati