Re: [PR] chore: Make use of statefulMap instead. [incubator-pekko-connectors]

He-Pin closed pull request #329: chore: Make use of statefulMap instead. URL: https://github.com/apache/incubator-pekko-connectors/pull/329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[PR] chore: Make use of statefulMap instead. [incubator-pekko-connectors]

He-Pin opened a new pull request, #330: URL: https://github.com/apache/incubator-pekko-connectors/pull/330 Motivation: Make use of statefulMap -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] rework symlink test [incubator-pekko-http]

pjfanning commented on code in PR #445: URL: https://github.com/apache/incubator-pekko-http/pull/445#discussion_r1468417397 ## http-tests/src/test/scala/org/apache/pekko/http/scaladsl/server/directives/FileAndResourceDirectivesSymlinkSpec.scala: ## @@ -0,0 +1,73 @@ +/* + * Lice

Re: [PR] rework symlink test [incubator-pekko-http]

pjfanning commented on code in PR #445: URL: https://github.com/apache/incubator-pekko-http/pull/445#discussion_r1468417701 ## http-tests/src/test/scala/org/apache/pekko/http/scaladsl/server/directives/FileAndResourceDirectivesSymlinkSpec.scala: ## @@ -0,0 +1,73 @@ +/* + * Lice

Re: [PR] chore: Make use of statefulMap instead. [incubator-pekko-connectors]

He-Pin commented on code in PR #330: URL: https://github.com/apache/incubator-pekko-connectors/pull/330#discussion_r1468432464 ## google-common/src/main/scala/org/apache/pekko/stream/connectors/google/util/AnnotateLast.scala: ## @@ -47,18 +47,13 @@ private[google] object Annota

Re: [PR] chore: Add Flow#flattenMerge operator. [incubator-pekko]

He-Pin merged PR #1045: URL: https://github.com/apache/incubator-pekko/pull/1045 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

Re: [PR] rework symlink test [incubator-pekko-http]

pjfanning commented on code in PR #445: URL: https://github.com/apache/incubator-pekko-http/pull/445#discussion_r1468436477 ## http-tests/src/test/scala/org/apache/pekko/http/scaladsl/server/directives/FileAndResourceDirectivesSymlinkSpec.scala: ## @@ -0,0 +1,73 @@ +/* + * Lice

Re: [PR] chore: Make use of statefulMap instead. [incubator-pekko-connectors]

He-Pin commented on code in PR #330: URL: https://github.com/apache/incubator-pekko-connectors/pull/330#discussion_r1468432464 ## google-common/src/main/scala/org/apache/pekko/stream/connectors/google/util/AnnotateLast.scala: ## @@ -47,18 +47,13 @@ private[google] object Annota

Re: [PR] feat: Add AutoCloseable shortcut on mapWithResource [incubator-pekko]

injae-kim commented on PR #1053: URL: https://github.com/apache/incubator-pekko/pull/1053#issuecomment-1913109773 (I'm fixing format and checkStyle~) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] feat: Add AutoCloseable shortcut on mapWithResource [incubator-pekko]

injae-kim commented on PR #1053: URL: https://github.com/apache/incubator-pekko/pull/1053#issuecomment-1913109962 FYI) it's my first time to use `scala` so feel free to share any suggestion~! I really newbie on `scala`😅 -- This is an automated message from the Apache Git Service. To respo

Re: [PR] feat: Add AutoCloseable shortcut on mapWithResource [incubator-pekko]

He-Pin commented on PR #1053: URL: https://github.com/apache/incubator-pekko/pull/1053#issuecomment-1913110142 Thank you. 1. We will need an apache cla before we can merge this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] feat: Add AutoCloseable shortcut on mapWithResource [incubator-pekko]

injae-kim commented on PR #1053: URL: https://github.com/apache/incubator-pekko/pull/1053#issuecomment-1913110566 aha~ I checked it on contributing.md and I'll submit cla~! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] feat: Add AutoCloseable shortcut on mapWithResource [incubator-pekko]

He-Pin commented on PR #1053: URL: https://github.com/apache/incubator-pekko/pull/1053#issuecomment-1913111342 Can't wait to use this on may daily job -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] feat: Add AutoCloseable shortcut on mapWithResource [incubator-pekko]

injae-kim commented on PR #1053: URL: https://github.com/apache/incubator-pekko/pull/1053#issuecomment-1913116339 I submitted cls agreement PDF by email~ I'll share you when I got reply. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] feat: Add AutoCloseable shortcut on mapWithResource [incubator-pekko]

He-Pin commented on code in PR #1053: URL: https://github.com/apache/incubator-pekko/pull/1053#discussion_r1468442521 ## stream-tests/src/test/java/org/apache/pekko/stream/javadsl/FlowTest.java: ## @@ -237,6 +238,22 @@ public void mustBeAbleToUseMapWithResource() { Assert.a

Re: [PR] feat: Add AutoCloseable shortcut on mapWithResource [incubator-pekko]

He-Pin commented on code in PR #1053: URL: https://github.com/apache/incubator-pekko/pull/1053#discussion_r1468442521 ## stream-tests/src/test/java/org/apache/pekko/stream/javadsl/FlowTest.java: ## @@ -237,6 +238,22 @@ public void mustBeAbleToUseMapWithResource() { Assert.a

Re: [PR] feat: Add AutoCloseable shortcut on mapWithResource [incubator-pekko]

He-Pin commented on code in PR #1053: URL: https://github.com/apache/incubator-pekko/pull/1053#discussion_r1468442746 ## stream/src/main/scala/org/apache/pekko/stream/javadsl/Flow.scala: ## @@ -828,6 +828,44 @@ final class Flow[In, Out, Mat](delegate: scaladsl.Flow[In, Out, Mat

Re: [PR] feat: Add AutoCloseable shortcut on mapWithResource [incubator-pekko]

He-Pin commented on code in PR #1053: URL: https://github.com/apache/incubator-pekko/pull/1053#discussion_r1468442746 ## stream/src/main/scala/org/apache/pekko/stream/javadsl/Flow.scala: ## @@ -828,6 +828,44 @@ final class Flow[In, Out, Mat](delegate: scaladsl.Flow[In, Out, Mat

Re: [PR] feat: Add AutoCloseable shortcut on mapWithResource [incubator-pekko]

pjfanning commented on code in PR #1053: URL: https://github.com/apache/incubator-pekko/pull/1053#discussion_r1468443645 ## stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/FlowMapWithResourceSpec.scala: ## @@ -410,6 +410,24 @@ class FlowMapWithResourceSpec extends

Re: [PR] feat: Add AutoCloseable shortcut on mapWithResource [incubator-pekko]

injae-kim commented on PR #1053: URL: https://github.com/apache/incubator-pekko/pull/1053#issuecomment-1913121640 Thanks for quick review! I'm struggling with build failure on my local env, so I'll update this PR based on your review after build&run test on my local env~! thanks! 🙇 --

Re: [PR] feat: Add AutoCloseable shortcut on mapWithResource [incubator-pekko]

pjfanning commented on code in PR #1053: URL: https://github.com/apache/incubator-pekko/pull/1053#discussion_r1468444576 ## stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/FlowMapWithResourceSpec.scala: ## @@ -410,6 +410,24 @@ class FlowMapWithResourceSpec extends

Re: [PR] feat: Add Sink#forall operator. [incubator-pekko]

pjfanning commented on code in PR #989: URL: https://github.com/apache/incubator-pekko/pull/989#discussion_r1468444778 ## docs/src/main/paradox/stream/operators/Sink/forall.md: ## @@ -0,0 +1,47 @@ +# Sink.forall + +A `Sink` that will test the given predicate `p` for every receiv

Re: [PR] feat: Add AutoCloseable shortcut on mapWithResource [incubator-pekko]

He-Pin commented on PR #1053: URL: https://github.com/apache/incubator-pekko/pull/1053#issuecomment-1913123543 @injae-kim I think you can update the `mapWithResource.md` too, you can do a local preview with `sbt paradoxBrowse` ,have a nice weekend. -- This is an automated message from the

Re: [PR] chore:test paradox failing [incubator-pekko]

He-Pin commented on PR #1050: URL: https://github.com/apache/incubator-pekko/pull/1050#issuecomment-1913123773  -- This is an automated message from the Apache Git Service. To respond

Re: [PR] feat: Add AutoCloseable shortcut on mapWithResource [incubator-pekko]

injae-kim commented on PR #1053: URL: https://github.com/apache/incubator-pekko/pull/1053#issuecomment-1913123914 oh~ I'm not sure should I update doc. I'll update `mapWithResource.md` doc too and update PR~! thanks! -- This is an automated message from the Apache Git Service. To respond

Re: [PR] chore:test paradox failing [incubator-pekko]

He-Pin commented on PR #1050: URL: https://github.com/apache/incubator-pekko/pull/1050#issuecomment-1913125468 It can now check the error code in Java 9 folder, and for Java 21 I will do in another PR. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] chore:test paradox failing [incubator-pekko]

He-Pin commented on PR #1050: URL: https://github.com/apache/incubator-pekko/pull/1050#issuecomment-1913128086 @pjfanning I'm mean the file is been compiled in the doc. Check the JDK9+ classes generated is not a target of this PR. Why do you always like to block a PR? you can just leave a c

Re: [PR] chore: Run JDK9Test compiling to validate syntax. [incubator-pekko]

pjfanning commented on code in PR #1050: URL: https://github.com/apache/incubator-pekko/pull/1050#discussion_r1468447996 ## .github/workflows/generate-paradox-check.yml: ## @@ -0,0 +1,48 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor lice

Re: [PR] chore: Run JDK9Test compiling to validate syntax. [incubator-pekko]

He-Pin commented on code in PR #1050: URL: https://github.com/apache/incubator-pekko/pull/1050#discussion_r1468448424 ## .github/workflows/generate-paradox-check.yml: ## @@ -0,0 +1,48 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

Re: [PR] chore: Run JDK9Test compiling to validate syntax. [incubator-pekko]

pjfanning commented on PR #1050: URL: https://github.com/apache/incubator-pekko/pull/1050#issuecomment-1913134133 > @pjfanning I mean the file is been compiled in the doc. Check the JDK9+ classes generated is not a target of this PR. Why do you always like to block a PR? you can just leave

Re: [PR] chore: Run JDK9Test compiling to validate syntax. [incubator-pekko]

He-Pin commented on PR #1050: URL: https://github.com/apache/incubator-pekko/pull/1050#issuecomment-1913134736 @pjfanning I'm preparing a PR for https://github.com/apache/incubator-pekko/issues/1039, separately. -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] chore: Run JDK9Test compiling to validate syntax. [incubator-pekko]

pjfanning commented on PR #1050: URL: https://github.com/apache/incubator-pekko/pull/1050#issuecomment-1913136813 > Motivation: > Fix #1040 I don't understand this PR at all. #1040 relates to #1039. How is this a fix for #1040? -- This is an automated message from the Apache Git

Re: [PR] chore: Run JDK9Test compiling to validate syntax. [incubator-pekko]

He-Pin commented on PR #1050: URL: https://github.com/apache/incubator-pekko/pull/1050#issuecomment-1913138446 @pjfanning Because you forgot https://github.com/apache/incubator-pekko/pull/958 -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] chore: Run JDK9Test compiling to validate syntax. [incubator-pekko]

pjfanning commented on PR #1050: URL: https://github.com/apache/incubator-pekko/pull/1050#issuecomment-1913139820 > @pjfanning Because you forgot #958 It is the duty of the PR writer to explain their PR. You made no mention of #958 and claimed this is to be a fix for #1040 - which it

Re: [PR] chore: Run JDK9Test compiling to validate syntax. [incubator-pekko]

He-Pin commented on PR #1050: URL: https://github.com/apache/incubator-pekko/pull/1050#issuecomment-1913140117 > ![image](https://private-user-images.githubusercontent.com/501740/300174670-4bfe4b27-d2d2-4fb1-8b43-010e5e1bb614.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY

Re: [PR] protect 1.0.x branch [incubator-pekko-connectors]

pjfanning commented on PR #325: URL: https://github.com/apache/incubator-pekko-connectors/pull/325#issuecomment-1913142497 @mdedetrich could you re-review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] protect 1.0.x branch [incubator-pekko-connectors]

pjfanning merged PR #325: URL: https://github.com/apache/incubator-pekko-connectors/pull/325 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] chore: Make use of statefulMap instead. [incubator-pekko-connectors]

pjfanning commented on PR #330: URL: https://github.com/apache/incubator-pekko-connectors/pull/330#issuecomment-1913144704 v1.1 commits are now allowed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Update amqp-client to 5.20.0 [incubator-pekko-connectors]

pjfanning merged PR #285: URL: https://github.com/apache/incubator-pekko-connectors/pull/285 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[PR] mima compare version [incubator-pekko-connectors]

pjfanning opened a new pull request, #331: URL: https://github.com/apache/incubator-pekko-connectors/pull/331 we are getting issues in `main` branch builds with mima checks - since the v1.1.0-M0 git tag was added see https://github.com/apache/incubator-pekko-connectors/actions/runs/7

Re: [PR] chore: Run JDK9Test compiling to validate syntax. [incubator-pekko]

Roiocam commented on PR #1050: URL: https://github.com/apache/incubator-pekko/pull/1050#issuecomment-1913152907 @pjfanning @He-Pin I have created an issue tracker for those build problems: #1052 I think this issue only related to #959 And #1039 has been fixed by #1047

Re: [PR] chore: Run JDK9Test compiling to validate syntax. [incubator-pekko]

Roiocam commented on code in PR #1050: URL: https://github.com/apache/incubator-pekko/pull/1050#discussion_r1468464710 ## .github/workflows/generate-doc-check.yml: ## @@ -48,5 +48,5 @@ jobs: run: |- sudo apt-get install graphviz - - name: Compile docs

Re: [I] add CI check for the Java 9+ classes [incubator-pekko]

Roiocam commented on issue #1040: URL: https://github.com/apache/incubator-pekko/issues/1040#issuecomment-1913154875 @pjfanning I think this has been solve by #1047 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] 1.1.x pekko snapshots are no longer including the java 9+ classes [incubator-pekko]

Roiocam commented on issue #1039: URL: https://github.com/apache/incubator-pekko/issues/1039#issuecomment-1913154992 @pjfanning I think this has been solve by #1047 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] feat: Add Sink#forall operator. [incubator-pekko]

Roiocam commented on code in PR #989: URL: https://github.com/apache/incubator-pekko/pull/989#discussion_r1468469688 ## docs/src/test/java/jdocs/stream/operators/sink/ForAll.java: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [I] 1.1.x pekko snapshots are no longer including the java 9+ classes [incubator-pekko]

pjfanning commented on issue #1039: URL: https://github.com/apache/incubator-pekko/issues/1039#issuecomment-191316 > @pjfanning I think this has been solve by #1047 I disagree - #1040 is to test #1039 and #1039 is not even fixed yet. There is zero proof that this is a fix for #10

Re: [I] 1.1.x pekko snapshots are no longer including the java 9+ classes [incubator-pekko]

Roiocam commented on issue #1039: URL: https://github.com/apache/incubator-pekko/issues/1039#issuecomment-1913169217 > I disagree - #1040 is to test #1039 and #1039 is not even fixed yet. There is zero proof that this is a fix for #1040. My last repeated comment was published in the

Re: [PR] chore: Run JDK9Test compiling to validate syntax. [incubator-pekko]

He-Pin merged PR #1050: URL: https://github.com/apache/incubator-pekko/pull/1050 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

[I] support Windows build [incubator-pekko-http]

pjfanning opened a new issue, #446: URL: https://github.com/apache/incubator-pekko-http/issues/446 Unfortunately, the existing build and tests are based on Linux and this works well for Posix users (Mac, Unix, Linux, etc). Our CI only runs on ubuntu VMs. This can be said of basically all Pe

Re: [PR] rework symlink test [incubator-pekko-http]

pjfanning commented on code in PR #445: URL: https://github.com/apache/incubator-pekko-http/pull/445#discussion_r1468491333 ## http-tests/src/test/scala/org/apache/pekko/http/scaladsl/server/directives/FileAndResourceDirectivesSymlinkSpec.scala: ## @@ -0,0 +1,73 @@ +/* + * Lice

Re: [PR] upgrade to testcontainers 0.41.0 [incubator-pekko-connectors]

pjfanning merged PR #286: URL: https://github.com/apache/incubator-pekko-connectors/pull/286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[PR] feat: Add multi java lts support. [incubator-pekko]

He-Pin opened a new pull request, #1054: URL: https://github.com/apache/incubator-pekko/pull/1054 Motivation： Add support to test JDK 11, JDK 17, and JDK 21 related code and just add the code when the runtime version matches. This will help us to detect LTS version-related issues a

Re: [PR] feat: Add multi java lts support. [incubator-pekko]

pjfanning commented on code in PR #1054: URL: https://github.com/apache/incubator-pekko/pull/1054#discussion_r1468497205 ## docs/src/main/java-jdk21/docs/actors/classical/OptimizedActorWithJava21.java: ## @@ -0,0 +1,38 @@ +package docs.actors.classical; Review Comment: -1 on

Re: [PR] feat: Add multi java lts support. [incubator-pekko]

He-Pin commented on PR #1054: URL: https://github.com/apache/incubator-pekko/pull/1054#issuecomment-1913179130 Updating~~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] feat: Add multi java lts support. [incubator-pekko]

He-Pin commented on code in PR #1054: URL: https://github.com/apache/incubator-pekko/pull/1054#discussion_r1468500397 ## docs/src/main/java-jdk21/docs/actors/classical/OptimizedActorWithJava21.java: ## @@ -0,0 +1,38 @@ +package docs.actors.classical; Review Comment: -1 for w

Re: [PR] feat: Add multi java lts support. [incubator-pekko]

He-Pin commented on code in PR #1054: URL: https://github.com/apache/incubator-pekko/pull/1054#discussion_r1468500650 ## docs/src/main/java-jdk21/docs/actors/classical/OptimizedActorWithJava21.java: ## @@ -0,0 +1,38 @@ +package docs.actors.classical; Review Comment: I see, I

[PR] 1.0.3-M1 release notes [incubator-pekko]

pjfanning opened a new pull request, #1055: URL: https://github.com/apache/incubator-pekko/pull/1055 migration notes are also needed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] in pom files, set name to have 'Apache Pekko ...' [incubator-pekko]

pjfanning closed issue #1006: in pom files, set name to have 'Apache Pekko ...' URL: https://github.com/apache/incubator-pekko/issues/1006 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] in pom files, set name to have 'Apache Pekko ...' [incubator-pekko]

pjfanning commented on issue #1006: URL: https://github.com/apache/incubator-pekko/issues/1006#issuecomment-1913182912 changes made -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] feat: Add multi java lts support. [incubator-pekko]

He-Pin commented on PR #1054: URL: https://github.com/apache/incubator-pekko/pull/1054#issuecomment-1913182964  @pjfanning Actually we currently how two style :( -- This is an automate

[I] add docs describing the Akka cluster support [incubator-pekko]

pjfanning opened a new issue, #1056: URL: https://github.com/apache/incubator-pekko/issues/1056 see #765 @mdedetrich -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] feat: Add multi java lts support. [incubator-pekko]

He-Pin commented on PR #1054: URL: https://github.com/apache/incubator-pekko/pull/1054#issuecomment-1913184955 @pjfanning I think it should be fine now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] feat: Add multi java lts support. [incubator-pekko]

He-Pin commented on code in PR #1054: URL: https://github.com/apache/incubator-pekko/pull/1054#discussion_r1468504518 ## docs/src/main/java-jdk-21/docs/actors/classical/OptimizedActorWithJava21.java: ## @@ -1,33 +1,38 @@ - +package docs.actors.classical; // #pattern-matching

Re: [PR] feat: Add AutoCloseable shortcut on mapWithResource [incubator-pekko]

injae-kim commented on code in PR #1053: URL: https://github.com/apache/incubator-pekko/pull/1053#discussion_r1468506714 ## stream-tests/src/test/java/org/apache/pekko/stream/javadsl/FlowTest.java: ## @@ -237,6 +238,22 @@ public void mustBeAbleToUseMapWithResource() { Asser

Re: [PR] feat: Add AutoCloseable shortcut on mapWithResource [incubator-pekko]

injae-kim commented on code in PR #1053: URL: https://github.com/apache/incubator-pekko/pull/1053#discussion_r1468506922 ## stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/FlowMapWithResourceSpec.scala: ## @@ -410,6 +410,24 @@ class FlowMapWithResourceSpec extends

Re: [PR] feat: Add multi java lts support. [incubator-pekko]

pjfanning commented on code in PR #1054: URL: https://github.com/apache/incubator-pekko/pull/1054#discussion_r1468507480 ## project/Jdk9.scala: ## @@ -11,36 +11,87 @@ * Copyright (C) 2017-2022 Lightbend Inc. */ -import sbt._ import sbt.Keys._ +

Re: [PR] feat: Add multi java lts support. [incubator-pekko]

pjfanning commented on code in PR #1054: URL: https://github.com/apache/incubator-pekko/pull/1054#discussion_r1468507480 ## project/Jdk9.scala: ## @@ -11,36 +11,87 @@ * Copyright (C) 2017-2022 Lightbend Inc. */ -import sbt._ import sbt.Keys._ +

Re: [PR] chore: Make use of pattern matching on singleton type instead. [incubator-pekko]

He-Pin merged PR #1026: URL: https://github.com/apache/incubator-pekko/pull/1026 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

Re: [PR] feat: Add AutoCloseable shortcut on mapWithResource [incubator-pekko]

He-Pin commented on code in PR #1053: URL: https://github.com/apache/incubator-pekko/pull/1053#discussion_r1468508664 ## stream-tests/src/test/java/org/apache/pekko/stream/javadsl/FlowTest.java: ## @@ -237,6 +238,22 @@ public void mustBeAbleToUseMapWithResource() { Assert.a

Re: [PR] feat: Add AutoCloseable shortcut on mapWithResource [incubator-pekko]

He-Pin commented on code in PR #1053: URL: https://github.com/apache/incubator-pekko/pull/1053#discussion_r1468508781 ## stream-tests/src/test/java/org/apache/pekko/stream/javadsl/SourceTest.java: ## @@ -815,6 +816,19 @@ public void mustBeAbleToUseMapWithResource() { Assert

Re: [PR] feat: Add AutoCloseable shortcut on mapWithResource [incubator-pekko]

He-Pin commented on code in PR #1053: URL: https://github.com/apache/incubator-pekko/pull/1053#discussion_r1468510931 ## stream-tests/src/test/java/org/apache/pekko/stream/javadsl/FlowTest.java: ## @@ -237,6 +238,22 @@ public void mustBeAbleToUseMapWithResource() { Assert.a

Re: [PR] feat: Add AutoCloseable shortcut on mapWithResource [incubator-pekko]

He-Pin commented on code in PR #1053: URL: https://github.com/apache/incubator-pekko/pull/1053#discussion_r1468511471 ## stream/src/main/scala/org/apache/pekko/stream/javadsl/Source.scala: ## @@ -2541,6 +2541,45 @@ final class Source[Out, Mat](delegate: scaladsl.Source[Out, Mat

Re: [PR] feat: Add AutoCloseable shortcut on mapWithResource [incubator-pekko]

He-Pin commented on code in PR #1053: URL: https://github.com/apache/incubator-pekko/pull/1053#discussion_r1468511471 ## stream/src/main/scala/org/apache/pekko/stream/javadsl/Source.scala: ## @@ -2541,6 +2541,45 @@ final class Source[Out, Mat](delegate: scaladsl.Source[Out, Mat

Re: [PR] feat: Add AutoCloseable shortcut on mapWithResource [incubator-pekko]

He-Pin commented on PR #1053: URL: https://github.com/apache/incubator-pekko/pull/1053#issuecomment-1913199139 @injae-kim In very good shape, just need another update, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] feat: Add multi java lts support. [incubator-pekko]

He-Pin commented on code in PR #1054: URL: https://github.com/apache/incubator-pekko/pull/1054#discussion_r1468512997 ## project/Jdk9.scala: ## @@ -11,36 +11,87 @@ * Copyright (C) 2017-2022 Lightbend Inc. */ -import sbt._ import sbt.Keys._ +imp

Re: [PR] feat: Add multi java lts support. [incubator-pekko]

He-Pin commented on code in PR #1054: URL: https://github.com/apache/incubator-pekko/pull/1054#discussion_r1468512997 ## project/Jdk9.scala: ## @@ -11,36 +11,87 @@ * Copyright (C) 2017-2022 Lightbend Inc. */ -import sbt._ import sbt.Keys._ +imp

Re: [PR] feat: Add multi java lts support. [incubator-pekko]

He-Pin commented on code in PR #1054: URL: https://github.com/apache/incubator-pekko/pull/1054#discussion_r1468513193 ## project/Jdk9.scala: ## @@ -11,36 +11,87 @@ * Copyright (C) 2017-2022 Lightbend Inc. */ -import sbt._ import sbt.Keys._ +imp

Re: [PR] feat: Add multi java lts support. [incubator-pekko]

pjfanning commented on code in PR #1054: URL: https://github.com/apache/incubator-pekko/pull/1054#discussion_r1468513412 ## project/Jdk9.scala: ## @@ -11,36 +11,87 @@ * Copyright (C) 2017-2022 Lightbend Inc. */ -import sbt._ import sbt.Keys._ +

Re: [PR] feat: Add multi java lts support. [incubator-pekko]

He-Pin commented on code in PR #1054: URL: https://github.com/apache/incubator-pekko/pull/1054#discussion_r1468513595 ## project/Jdk9.scala: ## @@ -11,36 +11,87 @@ * Copyright (C) 2017-2022 Lightbend Inc. */ -import sbt._ import sbt.Keys._ +imp

Re: [PR] feat: Add multi java lts support. [incubator-pekko]

pjfanning commented on code in PR #1054: URL: https://github.com/apache/incubator-pekko/pull/1054#discussion_r1468513954 ## project/Jdk9.scala: ## @@ -11,36 +11,87 @@ * Copyright (C) 2017-2022 Lightbend Inc. */ -import sbt._ import sbt.Keys._ +

Re: [PR] feat: Add multi java lts support. [incubator-pekko]

He-Pin commented on code in PR #1054: URL: https://github.com/apache/incubator-pekko/pull/1054#discussion_r1468514062 ## project/Jdk9.scala: ## @@ -11,36 +11,87 @@ * Copyright (C) 2017-2022 Lightbend Inc. */ -import sbt._ import sbt.Keys._ +imp

Re: [PR] feat: Add Sink#forall operator. [incubator-pekko]

He-Pin commented on code in PR #989: URL: https://github.com/apache/incubator-pekko/pull/989#discussion_r1468515300 ## docs/src/test/java/jdocs/stream/operators/sink/ForAll.java: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * c

Re: [PR] feat: Add AutoCloseable shortcut on mapWithResource [incubator-pekko]

injae-kim commented on code in PR #1053: URL: https://github.com/apache/incubator-pekko/pull/1053#discussion_r1468516012 ## stream-tests/src/test/java/org/apache/pekko/stream/javadsl/FlowTest.java: ## @@ -237,6 +238,22 @@ public void mustBeAbleToUseMapWithResource() { Asser

Re: [PR] feat: Add AutoCloseable shortcut on mapWithResource [incubator-pekko]

injae-kim commented on code in PR #1053: URL: https://github.com/apache/incubator-pekko/pull/1053#discussion_r1468516343 ## stream-tests/src/test/java/org/apache/pekko/stream/javadsl/FlowTest.java: ## @@ -237,6 +238,22 @@ public void mustBeAbleToUseMapWithResource() { Asser

Re: [PR] feat: Add AutoCloseable shortcut on mapWithResource [incubator-pekko]

injae-kim commented on code in PR #1053: URL: https://github.com/apache/incubator-pekko/pull/1053#discussion_r1468516459 ## stream/src/main/scala/org/apache/pekko/stream/javadsl/Source.scala: ## @@ -2541,6 +2541,45 @@ final class Source[Out, Mat](delegate: scaladsl.Source[Out,

Re: [PR] feat: Add AutoCloseable shortcut on mapWithResource [incubator-pekko]

injae-kim commented on PR #1053: URL: https://github.com/apache/incubator-pekko/pull/1053#issuecomment-1913227732 Now I can build&run test on my local 😃 thanks a lot for your help~! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] feat: Add Sink#forall operator. [incubator-pekko]

He-Pin commented on code in PR #989: URL: https://github.com/apache/incubator-pekko/pull/989#discussion_r1468516915 ## docs/src/main/paradox/stream/operators/Sink/forall.md: ## @@ -0,0 +1,47 @@ +# Sink.forall + +A `Sink` that will test the given predicate `p` for every received

Re: [PR] feat: Add AutoCloseable shortcut on mapWithResource [incubator-pekko]

pjfanning commented on code in PR #1053: URL: https://github.com/apache/incubator-pekko/pull/1053#discussion_r1468516974 ## stream/src/main/scala/org/apache/pekko/stream/javadsl/Source.scala: ## @@ -2541,6 +2541,45 @@ final class Source[Out, Mat](delegate: scaladsl.Source[Out,

[PR] fix bug in docs that uses akka names for configs [incubator-pekko]

pjfanning opened a new pull request, #1057: URL: https://github.com/apache/incubator-pekko/pull/1057 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] feat: Add AutoCloseable shortcut on mapWithResource [incubator-pekko]

pjfanning commented on code in PR #1053: URL: https://github.com/apache/incubator-pekko/pull/1053#discussion_r1468517708 ## stream/src/main/scala/org/apache/pekko/stream/javadsl/Source.scala: ## @@ -2541,6 +2541,45 @@ final class Source[Out, Mat](delegate: scaladsl.Source[Out,

Re: [PR] feat: Add multi java lts support. [incubator-pekko]

Roiocam commented on code in PR #1054: URL: https://github.com/apache/incubator-pekko/pull/1054#discussion_r1468517117 ## project/Jdk9.scala: ## @@ -11,36 +11,87 @@ * Copyright (C) 2017-2022 Lightbend Inc. */ -import sbt._ import sbt.Keys._ +im

Re: [PR] feat: Add Sink#forall operator. [incubator-pekko]

He-Pin commented on PR #989: URL: https://github.com/apache/incubator-pekko/pull/989#issuecomment-1913243521 @pjfanning I'm still working on it... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] feat: Add AutoCloseable shortcut on mapWithResource [incubator-pekko]

He-Pin commented on code in PR #1053: URL: https://github.com/apache/incubator-pekko/pull/1053#discussion_r1468525630 ## stream-tests/src/test/java/org/apache/pekko/stream/javadsl/FlowTest.java: ## @@ -237,6 +238,22 @@ public void mustBeAbleToUseMapWithResource() { Assert.a

Re: [PR] feat: Add AutoCloseable shortcut on mapWithResource [incubator-pekko]

injae-kim commented on code in PR #1053: URL: https://github.com/apache/incubator-pekko/pull/1053#discussion_r1468526428 ## stream/src/main/scala/org/apache/pekko/stream/javadsl/Source.scala: ## @@ -2541,6 +2541,45 @@ final class Source[Out, Mat](delegate: scaladsl.Source[Out,

Re: [PR] fix bug in docs that uses akka names for configs [incubator-pekko]

He-Pin merged PR #1057: URL: https://github.com/apache/incubator-pekko/pull/1057 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

Re: [PR] feat: Add AutoCloseable shortcut on mapWithResource [incubator-pekko]

He-Pin commented on code in PR #1053: URL: https://github.com/apache/incubator-pekko/pull/1053#discussion_r1468527434 ## stream/src/main/scala/org/apache/pekko/stream/javadsl/Source.scala: ## @@ -2541,6 +2541,45 @@ final class Source[Out, Mat](delegate: scaladsl.Source[Out, Mat

Re: [PR] feat: Add AutoCloseable shortcut on mapWithResource [incubator-pekko]

He-Pin commented on code in PR #1053: URL: https://github.com/apache/incubator-pekko/pull/1053#discussion_r1468530877 ## stream-tests/src/test/java/org/apache/pekko/stream/javadsl/SourceTest.java: ## @@ -815,6 +816,18 @@ public void mustBeAbleToUseMapWithResource() { Assert

Re: [PR] feat: Add AutoCloseable shortcut on mapWithResource [incubator-pekko]

He-Pin commented on code in PR #1053: URL: https://github.com/apache/incubator-pekko/pull/1053#discussion_r1468531103 ## stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/FlowMapWithResourceSpec.scala: ## @@ -410,6 +410,114 @@ class FlowMapWithResourceSpec extends St

Re: [PR] feat: Add AutoCloseable shortcut on mapWithResource [incubator-pekko]

injae-kim commented on code in PR #1053: URL: https://github.com/apache/incubator-pekko/pull/1053#discussion_r1468532511 ## stream/src/main/scala/org/apache/pekko/stream/javadsl/Source.scala: ## @@ -2541,6 +2541,45 @@ final class Source[Out, Mat](delegate: scaladsl.Source[Out,

Re: [PR] feat: Add AutoCloseable shortcut on mapWithResource [incubator-pekko]

injae-kim commented on code in PR #1053: URL: https://github.com/apache/incubator-pekko/pull/1053#discussion_r1468532759 ## stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/FlowMapWithResourceSpec.scala: ## @@ -410,6 +410,114 @@ class FlowMapWithResourceSpec extends

  1   2   3   >