mdedetrich commented on PR #1034:
URL: https://github.com/apache/incubator-pekko/pull/1034#issuecomment-1907629502
> is there a demo of the result `pom.xml`?
There is a test for it
https://github.com/mdedetrich/sbt-apache-sonatype/pull/31/files#diff-899556541f4c8f24264ebd0aa1e206513b1
GitHub user AnastasiiaZu added a comment to the discussion: Using Pekko with
Application Insights for logs and telemetry
The code to this feature can be found
[here](https://github.com/microsoft/ApplicationInsights-Java/blob/bd91f620189d797bee62541a532740d25c8c46e4/agent/agent-tooling/src/main
GitHub user AnastasiiaZu added a comment to the discussion: Using Pekko with
Application Insights for logs and telemetry
Hi @pjfanning, I opened an
[issue](https://github.com/microsoft/ApplicationInsights-Java/issues/3512) with
Microsoft as well, will let you know how it goes
GitHub link:
He-Pin commented on issue #829:
URL:
https://github.com/apache/incubator-pekko/issues/829#issuecomment-1907652159
I'm developing on windows 11, I think it works now. but a window CI should
be nice.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
mdedetrich commented on issue #829:
URL:
https://github.com/apache/incubator-pekko/issues/829#issuecomment-1907654835
> I'm developing on windows 11, I think it works now. but a window/ARM(where
concurrency code matters) CI should be nice.
The critical distinction here is the src dis
samueleresca commented on PR #72:
URL:
https://github.com/apache/incubator-pekko-site/pull/72#issuecomment-1907676646
Hey @Roiocam, thanks for the the help here. I think you need to change the
`group.js` file
[here](https://github.com/apache/incubator-pekko-site/blob/main/src/main/paradox
gmethvin commented on PR #1035:
URL: https://github.com/apache/incubator-pekko/pull/1035#issuecomment-1907682177
> interestingly it appears that sbt and other build tools were designed
around name being the machine representation of the project name (which is why
for example, in sbt, the na
mdedetrich commented on PR #1035:
URL: https://github.com/apache/incubator-pekko/pull/1035#issuecomment-1907717255
> Yeah that's interesting, sbt actually has a `normalizedName` that it
generates based on the `name`, so if you did set your `name` to `Pekko Streams`
then it would generate `p
Roiocam opened a new pull request, #73:
URL: https://github.com/apache/incubator-pekko-site/pull/73
## Improvement
- Cancel the hover animation of the card to avoid guiding users that the
card is clickable.
- Explicitly guide the user, the links are clickable.
- Improve card sty
Roiocam commented on PR #72:
URL:
https://github.com/apache/incubator-pekko-site/pull/72#issuecomment-1907758066
> I think you need to change the `group.js` file
[here](https://github.com/apache/incubator-pekko-site/blob/main/src/main/paradox/_template/assets/javascripts/groups.js).
samueleresca commented on PR #73:
URL:
https://github.com/apache/incubator-pekko-site/pull/73#issuecomment-1907760970
Thanks the changes looks good 😄 . Few notes:
- You will need to run the [manual publishing
process](https://github.com/apache/incubator-pekko-site/wiki/Manual-Publishing)
Roiocam commented on PR #73:
URL:
https://github.com/apache/incubator-pekko-site/pull/73#issuecomment-1907815300
> * Could you please check the changes work on a mobile resolution
I just verified everything is ok on the mobile device, and working well on
the responsive mode too.
He-Pin commented on code in PR #73:
URL:
https://github.com/apache/incubator-pekko-site/pull/73#discussion_r1464677625
##
content/assets/stylesheets/home.css:
##
@@ -179,16 +179,22 @@ h1 {
}
.row > ul > li {
- background-color: #f0f0f0;
+ border: 1px solid rgba(0,0,0,0.2)
He-Pin commented on code in PR #73:
URL:
https://github.com/apache/incubator-pekko-site/pull/73#discussion_r1464677871
##
content/assets/stylesheets/home.css:
##
@@ -200,3 +206,33 @@ h1 {
.md-header-nav__button.md-icon--menu {
display: none;
}
+
+
+@media (max-width: 768px
pjfanning merged PR #72:
URL: https://github.com/apache/incubator-pekko-site/pull/72
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsub
He-Pin opened a new issue, #74:
URL: https://github.com/apache/incubator-pekko-site/issues/74
The issue is when you type something like `actor` and click `enter` nothing
happen
pjfanning commented on issue #74:
URL:
https://github.com/apache/incubator-pekko-site/issues/74#issuecomment-1907836509
unfortunately, the search only works when you use docs in the right area -
the search data is built by all our different doc builds - each repo has its
own doc build
mdedetrich commented on PR #1035:
URL: https://github.com/apache/incubator-pekko/pull/1035#issuecomment-1907873342
Given the latest info, I believe I was overthinking this a bit and it does
appear that `name` should indeed be human readable. I have updated the
[PR](https://github.com/mdedet
pjfanning closed pull request #1035: [DRAFT] try to centralise pom name change
logic
URL: https://github.com/apache/incubator-pekko/pull/1035
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
pjfanning commented on PR #1035:
URL: https://github.com/apache/incubator-pekko/pull/1035#issuecomment-1907878984
to be clear, this PR is not a solution - I raised it to highlight how it
causes compile issues for the Pekko runtime code
--
This is an automated message from the Apache Git S
samueleresca commented on issue #74:
URL:
https://github.com/apache/incubator-pekko-site/issues/74#issuecomment-1907867630
I think the root cause it is the error on the js execution of the page:
```
application.583bbe55.js:6 Uncaught ReferenceError
at new e (application.583b
pjfanning merged PR #73:
URL: https://github.com/apache/incubator-pekko-site/pull/73
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsub
GitHub user pjfanning added a comment to the discussion: Using Pekko with
Application Insights for logs and telemetry
Thanks @AnastasiiaZu - just to cross-post here but it looks like Microsoft lib
just wraps https://github.com/open-telemetry/opentelemetry-java-instrumentation
and that lib sup
mdedetrich opened a new pull request, #1036:
URL: https://github.com/apache/incubator-pekko/pull/1036
Simple QOL change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
mdedetrich commented on PR #1034:
URL: https://github.com/apache/incubator-pekko/pull/1034#issuecomment-1907947653
@pjfanning I think this can be closed, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
mdedetrich opened a new pull request, #1037:
URL: https://github.com/apache/incubator-pekko/pull/1037
Updates sbt-pekko-build to 0.3.1 which brings in the pom.xml `name` field fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
mdedetrich opened a new pull request, #440:
URL: https://github.com/apache/incubator-pekko-http/pull/440
Updates sbt-pekko-build to 0.3.1 which brings in the pom.xml `name` field fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
mdedetrich opened a new pull request, #323:
URL: https://github.com/apache/incubator-pekko-connectors/pull/323
Updates sbt-pekko-build to 0.3.1 which brings in the pom.xml `name` field fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
mdedetrich opened a new pull request, #157:
URL: https://github.com/apache/incubator-pekko-management/pull/157
Updates sbt-pekko-build to 0.3.1 which brings in the pom.xml `name` field fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
mdedetrich commented on PR #89:
URL:
https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/89#issuecomment-1907971004
@pjfanning Is this done?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
mdedetrich merged PR #157:
URL: https://github.com/apache/incubator-pekko-management/pull/157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificati
pjfanning commented on PR #89:
URL:
https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/89#issuecomment-1907981228
@mdedetrich you can push your changes to this PR branch if you want
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
mdedetrich commented on PR #89:
URL:
https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/89#issuecomment-1907982792
Sure will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
pjfanning closed pull request #1034: [DRAFT] set Apache name in Pekko poms
URL: https://github.com/apache/incubator-pekko/pull/1034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
mdedetrich commented on PR #89:
URL:
https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/89#issuecomment-1907989952
@pjfanning Pushed commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
mdedetrich merged PR #323:
URL: https://github.com/apache/incubator-pekko-connectors/pull/323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificati
pjfanning commented on PR #157:
URL:
https://github.com/apache/incubator-pekko-management/pull/157#issuecomment-1907992566
https://repository.apache.org/content/groups/snapshots/org/apache/pekko/pekko-management_2.13/1.0.0+28-ac0f2055-SNAPSHOT/pekko-management_2.13-1.0.0+28-ac0f2055-SNAPSHO
mdedetrich merged PR #440:
URL: https://github.com/apache/incubator-pekko-http/pull/440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-un
pjfanning commented on PR #89:
URL:
https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/89#issuecomment-1908000497
@mdedetrich lgtm but I can't approve a PR that I own
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mdedetrich commented on PR #89:
URL:
https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/89#issuecomment-1908004650
Also remember to cherry pick after merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
mdedetrich opened a new pull request, #441:
URL: https://github.com/apache/incubator-pekko-http/pull/441
(cherry picked from commit c502c212e5cb5ab2562ee491b8eb2206905e3234)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
mdedetrich merged PR #98:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/98
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: no
pjfanning merged PR #89:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/89
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: not
pjfanning opened a new pull request, #99:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/99
cherry pick f4db9c71116629b288572c8c33237d1d4a6c3e8e #89
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
pjfanning commented on PR #99:
URL:
https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/99#issuecomment-1908012045
@mdedetrich I added `pekkoInlineEnabled := false` to this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
mdedetrich commented on PR #99:
URL:
https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/99#issuecomment-1908014400
> @mdedetrich I added `pekkoInlineEnabled := false` to this PR
Yup I noticed, thanks for catching this
--
This is an automated message from the Apache
pjfanning merged PR #99:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/99
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: not
mdedetrich merged PR #441:
URL: https://github.com/apache/incubator-pekko-http/pull/441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-un
mdedetrich opened a new pull request, #213:
URL: https://github.com/apache/incubator-pekko-grpc/pull/213
Updates sbt-pekko-build to 0.3.1 which brings in the pom.xml `name` field fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
mdedetrich merged PR #1037:
URL: https://github.com/apache/incubator-pekko/pull/1037
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsub
mdedetrich merged PR #1036:
URL: https://github.com/apache/incubator-pekko/pull/1036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsub
He-Pin commented on code in PR #213:
URL:
https://github.com/apache/incubator-pekko-grpc/pull/213#discussion_r1464849474
##
gradle-plugin/build.gradle:
##
@@ -44,7 +44,7 @@ gradlePlugin {
publishing {
publications.withType(MavenPublication) {
pom {
-n
mdedetrich opened a new pull request, #1038:
URL: https://github.com/apache/incubator-pekko/pull/1038
(cherry picked from commit 639d5ad8ee48a8ac5c151df6370af426dd1b3c07)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
mdedetrich commented on code in PR #213:
URL:
https://github.com/apache/incubator-pekko-grpc/pull/213#discussion_r1464854853
##
gradle-plugin/build.gradle:
##
@@ -44,7 +44,7 @@ gradlePlugin {
publishing {
publications.withType(MavenPublication) {
pom {
-
mdedetrich commented on code in PR #213:
URL:
https://github.com/apache/incubator-pekko-grpc/pull/213#discussion_r1464854853
##
gradle-plugin/build.gradle:
##
@@ -44,7 +44,7 @@ gradlePlugin {
publishing {
publications.withType(MavenPublication) {
pom {
-
mdedetrich commented on code in PR #213:
URL:
https://github.com/apache/incubator-pekko-grpc/pull/213#discussion_r1464854853
##
gradle-plugin/build.gradle:
##
@@ -44,7 +44,7 @@ gradlePlugin {
publishing {
publications.withType(MavenPublication) {
pom {
-
mdedetrich merged PR #213:
URL: https://github.com/apache/incubator-pekko-grpc/pull/213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-un
mdedetrich opened a new pull request, #214:
URL: https://github.com/apache/incubator-pekko-grpc/pull/214
Self explanatory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
mdedetrich merged PR #214:
URL: https://github.com/apache/incubator-pekko-grpc/pull/214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-un
mdedetrich opened a new pull request, #215:
URL: https://github.com/apache/incubator-pekko-grpc/pull/215
Should improve the sbt build speed a little bit by avoiding unnecessary
computation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
pjfanning opened a new pull request, #216:
URL: https://github.com/apache/incubator-pekko-grpc/pull/216
use `gRPC` to match the usual style
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
mdedetrich merged PR #215:
URL: https://github.com/apache/incubator-pekko-grpc/pull/215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-un
mdedetrich merged PR #1038:
URL: https://github.com/apache/incubator-pekko/pull/1038
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsub
mdedetrich opened a new pull request, #217:
URL: https://github.com/apache/incubator-pekko-grpc/pull/217
This is redundant because sbt-license-info automatically generates a report
with all of the license information from the dependency tree
--
This is an automated message from the Apache
pjfanning opened a new pull request, #89:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/89
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
mdedetrich commented on PR #214:
URL:
https://github.com/apache/incubator-pekko-grpc/pull/214#issuecomment-1908147774
Yeah I just realized that after, in any case its harmless either way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Roiocam commented on issue #1032:
URL:
https://github.com/apache/incubator-pekko/issues/1032#issuecomment-1908150803
Don't know why, but this only spent 2s on my laptop(M1 macOs).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
He-Pin commented on code in PR #216:
URL:
https://github.com/apache/incubator-pekko-grpc/pull/216#discussion_r1464936101
##
gradle-plugin/build.gradle:
##
@@ -47,7 +47,7 @@ gradlePlugin {
publishing {
publications.withType(MavenPublication) {
pom {
-n
mdedetrich commented on issue #1032:
URL:
https://github.com/apache/incubator-pekko/issues/1032#issuecomment-1908153869
> Don't know why, but this only spent 2s on my laptop(M1 macOs).
I don't even notice it, and [caching was recently
added](https://github.com/sbt/sbt-osgi/pull/100)
mdedetrich merged PR #217:
URL: https://github.com/apache/incubator-pekko-grpc/pull/217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-un
pjfanning commented on PR #216:
URL:
https://github.com/apache/incubator-pekko-grpc/pull/216#issuecomment-1908156664
I understand that we don't want to complicate the sbt plugin to cover the
case issue but there is no absolute requirement that this gradle-plugin pom
needs to match the othe
pjfanning merged PR #89:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/89
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notification
He-Pin commented on code in PR #216:
URL:
https://github.com/apache/incubator-pekko-grpc/pull/216#discussion_r1464943362
##
gradle-plugin/build.gradle:
##
@@ -47,7 +47,7 @@ gradlePlugin {
publishing {
publications.withType(MavenPublication) {
pom {
-n
He-Pin commented on code in PR #216:
URL:
https://github.com/apache/incubator-pekko-grpc/pull/216#discussion_r1464944675
##
gradle-plugin/build.gradle:
##
@@ -47,7 +47,7 @@ gradlePlugin {
publishing {
publications.withType(MavenPublication) {
pom {
-n
mdedetrich commented on PR #216:
URL:
https://github.com/apache/incubator-pekko-grpc/pull/216#issuecomment-1908164307
> I understand that we don't want to complicate the sbt plugin to cover the
case issue but there is no absolute requirement that this gradle-plugin pom
needs to match the o
He-Pin commented on issue #1032:
URL:
https://github.com/apache/incubator-pekko/issues/1032#issuecomment-1908168387
@mdedetrich @Roiocam Trigger an JMH bench you will notice it.
And
Roiocam commented on code in PR #1026:
URL: https://github.com/apache/incubator-pekko/pull/1026#discussion_r1464945900
##
stream/src/main/scala/org/apache/pekko/stream/impl/fusing/CollectWhile.scala:
##
@@ -43,18 +44,17 @@ private[pekko] final class CollectWhile[In, Out](pf:
Pa
Roiocam commented on issue #1032:
URL:
https://github.com/apache/incubator-pekko/issues/1032#issuecomment-1908182579
> Trigger an JMH bench you will notice it.
Run JMH after clean up, it only costs 3s when executing `stream osgiBundle`
--
This is an automated message from t
pjfanning opened a new pull request, #75:
URL: https://github.com/apache/incubator-pekko-site/pull/75
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
pjfanning commented on PR #485:
URL: https://github.com/apache/incubator-pekko/pull/485#issuecomment-1908192427
@mdedetrich He Pin wants this in v1.1.0. I'm neutral on this. Is it ok to
use MethodHandles like this and rewrite later when we have Multi-Release jar
support?
--
This is an au
He-Pin commented on issue #1032:
URL:
https://github.com/apache/incubator-pekko/issues/1032#issuecomment-1908196527
`
Jmh/run -i 10 -wi 10 -f1 -t1 .*CollectBenchmark.*
`
Have no idea :(
![image](https://github.com/apache/incubator-pekko/assets/501740/046ed527-1b8c-4508-92c2-8a
pjfanning merged PR #75:
URL: https://github.com/apache/incubator-pekko-site/pull/75
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsub
He-Pin commented on PR #485:
URL: https://github.com/apache/incubator-pekko/pull/485#issuecomment-1908205574
@pjfanning I want this because it will dress some issue especially when user
is blocking the actors.
![image](https://github.com/apache/incubator-pekko/assets/501740/5fc16f4e-e7f0
He-Pin commented on code in PR #485:
URL: https://github.com/apache/incubator-pekko/pull/485#discussion_r1464980504
##
actor/src/main/resources/reference.conf:
##
@@ -482,6 +482,10 @@ pekko {
# Setting to "FIFO" to use queue like peeking mode which "poll" or
"LIFO" to
pjfanning commented on code in PR #485:
URL: https://github.com/apache/incubator-pekko/pull/485#discussion_r1464994713
##
actor/src/main/resources/reference.conf:
##
@@ -482,6 +482,10 @@ pekko {
# Setting to "FIFO" to use queue like peeking mode which "poll" or
"LIFO"
He-Pin commented on code in PR #485:
URL: https://github.com/apache/incubator-pekko/pull/485#discussion_r1464997701
##
actor/src/main/resources/reference.conf:
##
@@ -482,6 +482,10 @@ pekko {
# Setting to "FIFO" to use queue like peeking mode which "poll" or
"LIFO" to
He-Pin commented on code in PR #485:
URL: https://github.com/apache/incubator-pekko/pull/485#discussion_r146400
##
actor/src/main/scala/org/apache/pekko/dispatch/ForkJoinPoolConstants.scala:
##
@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
He-Pin commented on code in PR #485:
URL: https://github.com/apache/incubator-pekko/pull/485#discussion_r1465012802
##
actor/src/main/scala/org/apache/pekko/dispatch/ForkJoinExecutorConfigurator.scala:
##
@@ -84,12 +85,28 @@ class ForkJoinExecutorConfigurator(config: Config,
pr
He-Pin commented on code in PR #485:
URL: https://github.com/apache/incubator-pekko/pull/485#discussion_r1465012802
##
actor/src/main/scala/org/apache/pekko/dispatch/ForkJoinExecutorConfigurator.scala:
##
@@ -84,12 +85,28 @@ class ForkJoinExecutorConfigurator(config: Config,
pr
He-Pin commented on PR #989:
URL: https://github.com/apache/incubator-pekko/pull/989#issuecomment-1908323418
I have contacted with @laglangyue ,and will take care of this pr now, will
update it in this pr.
--
This is an automated message from the Apache Git Service.
To respond to the mess
pjfanning commented on PR #485:
URL: https://github.com/apache/incubator-pekko/pull/485#issuecomment-1908356365
> lgtm at the first round , just a little nitpick , I think we should enable
run test on JDK 21 too, if the code is target to higher JDK version.
We do test with java 21. Ch
pjfanning commented on code in PR #485:
URL: https://github.com/apache/incubator-pekko/pull/485#discussion_r1465094381
##
actor/src/main/scala/org/apache/pekko/dispatch/ForkJoinExecutorConfigurator.scala:
##
@@ -84,12 +85,28 @@ class ForkJoinExecutorConfigurator(config: Config,
pjfanning commented on code in PR #485:
URL: https://github.com/apache/incubator-pekko/pull/485#discussion_r1465279734
##
actor/src/main/scala/org/apache/pekko/dispatch/ForkJoinExecutorConfigurator.scala:
##
@@ -84,12 +85,28 @@ class ForkJoinExecutorConfigurator(config: Config,
He-Pin commented on code in PR #989:
URL: https://github.com/apache/incubator-pekko/pull/989#discussion_r1465359580
##
stream/src/main/scala/org/apache/pekko/stream/scaladsl/Sink.scala:
##
@@ -447,6 +440,28 @@ object Sink {
def foldAsync[U, T](zero: U)(f: (U, T) => Future[U])
He-Pin commented on code in PR #990:
URL: https://github.com/apache/incubator-pekko/pull/990#discussion_r1460791095
##
stream-tests/src/test/scala/org/apache/pekko/stream/DslConsistencySpec.scala:
##
@@ -70,6 +70,8 @@ class DslConsistencySpec extends AnyWordSpec with Matchers {
He-Pin commented on code in PR #990:
URL: https://github.com/apache/incubator-pekko/pull/990#discussion_r1465360502
##
stream-tests/src/test/scala/org/apache/pekko/stream/DslConsistencySpec.scala:
##
@@ -70,6 +70,8 @@ class DslConsistencySpec extends AnyWordSpec with Matchers {
He-Pin commented on code in PR #1026:
URL: https://github.com/apache/incubator-pekko/pull/1026#discussion_r1465365412
##
stream/src/main/scala/org/apache/pekko/stream/impl/fusing/CollectWhile.scala:
##
@@ -43,18 +44,17 @@ private[pekko] final class CollectWhile[In, Out](pf:
Par
He-Pin commented on code in PR #990:
URL: https://github.com/apache/incubator-pekko/pull/990#discussion_r1465369034
##
project/StreamOperatorsIndexGenerator.scala:
##
@@ -111,7 +112,8 @@ object StreamOperatorsIndexGenerator extends AutoPlugin {
"fromGraph",
"actorS
pjfanning commented on code in PR #485:
URL: https://github.com/apache/incubator-pekko/pull/485#discussion_r1465432075
##
actor/src/main/scala/org/apache/pekko/dispatch/ForkJoinPoolConstants.scala:
##
@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
pjfanning commented on code in PR #485:
URL: https://github.com/apache/incubator-pekko/pull/485#discussion_r1465433618
##
actor/src/main/scala/org/apache/pekko/dispatch/ForkJoinExecutorConfigurator.scala:
##
@@ -84,12 +85,28 @@ class ForkJoinExecutorConfigurator(config: Config,
1 - 100 of 134 matches
Mail list logo
