Re: [PR] perf: optmize NettyChannelHandlerAdapter with explict extends. [pekko]

2025-01-09 Thread via GitHub
pjfanning commented on PR #1667: URL: https://github.com/apache/pekko/pull/1667#issuecomment-2580015776 I don't want to pre-empt anything. If Flink team want to test the 1.2.0 snapshot and find that works better for them - we could then consider backporting this. -- This is an automated

Re: [PR] perf: optmize NettyChannelHandlerAdapter with explict extends. [pekko]

2025-01-09 Thread via GitHub
He-Pin commented on PR #1667: URL: https://github.com/apache/pekko/pull/1667#issuecomment-2580003426 @raboof @pjfanning Do you think we should backport this? as Flink will use this pekko too. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] perf: optmize NettyChannelHandlerAdapter with explict extends. [pekko]

2025-01-03 Thread via GitHub
He-Pin merged PR #1667: URL: https://github.com/apache/pekko/pull/1667 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.a

Re: [PR] perf: optmize NettyChannelHandlerAdapter with explict extends. [pekko]

2025-01-03 Thread via GitHub
He-Pin commented on PR #1667: URL: https://github.com/apache/pekko/pull/1667#issuecomment-2569447186 I ran the cluster test locally and it passed too, we are using this kind of trick at work. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] perf: optmize NettyChannelHandlerAdapter with explict extends. [pekko]

2025-01-03 Thread via GitHub
He-Pin commented on code in PR #1667: URL: https://github.com/apache/pekko/pull/1667#discussion_r1901761929 ## remote/src/main/scala/org/apache/pekko/remote/transport/netty/NettyHelpers.scala: ## @@ -53,10 +53,19 @@ private[netty] trait NettyHelpers { /** * INTERNAL API */