Re: [PR] perf: Reduce loops in when clean queue in BroadcastHub (#1628) [pekko]

2024-12-30 Thread via GitHub
He-Pin commented on PR #1643: URL: https://github.com/apache/pekko/pull/1643#issuecomment-2565215008 @pjfanning Btw, this is a kind of bug too, because the loop can take seconds. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] perf: Reduce loops in when clean queue in BroadcastHub (#1628) [pekko]

2024-12-30 Thread via GitHub
He-Pin commented on PR #1643: URL: https://github.com/apache/pekko/pull/1643#issuecomment-2565222824 Okay, let me close it, anyway ,ship it in next version will be safer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] perf: Reduce loops in when clean queue in BroadcastHub (#1628) [pekko]

2024-12-30 Thread via GitHub
He-Pin closed pull request #1643: perf: Reduce loops in when clean queue in BroadcastHub (#1628) URL: https://github.com/apache/pekko/pull/1643 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] perf: Reduce loops in when clean queue in BroadcastHub (#1628) [pekko]

2024-12-30 Thread via GitHub
pjfanning commented on PR #1643: URL: https://github.com/apache/pekko/pull/1643#issuecomment-2565218005 bad performance is not necessarily a bug -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] perf: Reduce loops in when clean queue in BroadcastHub (#1628) [pekko]

2024-12-30 Thread via GitHub
He-Pin closed pull request #1643: perf: Reduce loops in when clean queue in BroadcastHub (#1628) URL: https://github.com/apache/pekko/pull/1643 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] perf: Reduce loops in when clean queue in BroadcastHub (#1628) [pekko]

2024-12-30 Thread via GitHub
He-Pin commented on PR #1643: URL: https://github.com/apache/pekko/pull/1643#issuecomment-2565214287 Ok, let's only get it in the next release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] perf: Reduce loops in when clean queue in BroadcastHub (#1628) [pekko]

2024-12-30 Thread via GitHub
pjfanning commented on PR #1643: URL: https://github.com/apache/pekko/pull/1643#issuecomment-2565185439 I don't think we should backport this. It is not semver friendly to be putting so many changes in patch releases. We are taking too many risks in the patch releases as it is. -- This