He-Pin merged PR #1658:
URL: https://github.com/apache/pekko/pull/1658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.a
He-Pin commented on PR #1658:
URL: https://github.com/apache/pekko/pull/1658#issuecomment-2660790655
@pjfanning I have updated the code with test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
pjfanning commented on PR #1658:
URL: https://github.com/apache/pekko/pull/1658#issuecomment-2618743929
I am uncomfortable with adding this in M1. There will be an M2 in a month or
2 and hopefully this can be added with some tests.
--
This is an automated message from the Apache Git Servi
He-Pin commented on PR #1658:
URL: https://github.com/apache/pekko/pull/1658#issuecomment-2614070378
Feel free to add it to m2, but actually the current fix not harm even
without test.
It will cause problem when using in graphdsl as the zipwithIndex was
implemented.
--
This is an
pjfanning commented on PR #1658:
URL: https://github.com/apache/pekko/pull/1658#issuecomment-2614069854
Is there any way to add test coverage? Something like
https://github.com/apache/pekko/blob/main/stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/FlowZipWithIndexSpec.scala#L60-
He-Pin commented on PR #1658:
URL: https://github.com/apache/pekko/pull/1658#issuecomment-2614063235
@pjfanning I think we should have this in 1.2.0-M1 , it's some kind of bug
fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
