Re: [PR] chore: Require parallelism >= 1 in MapAsync and MapAsyncUnordered [pekko]

2025-01-10 Thread via GitHub
He-Pin merged PR #1700: URL: https://github.com/apache/pekko/pull/1700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.a

Re: [PR] chore: Require parallelism >= 1 in MapAsync and MapAsyncUnordered [pekko]

2025-01-10 Thread via GitHub
He-Pin commented on PR #1700: URL: https://github.com/apache/pekko/pull/1700#issuecomment-2582697165 @pjfanning Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] chore: Require parallelism >= 1 in MapAsync and MapAsyncUnordered [pekko]

2025-01-10 Thread via GitHub
pjfanning commented on PR #1700: URL: https://github.com/apache/pekko/pull/1700#issuecomment-2582612861 > @pjfanning The code is the same as it is in `MapAsyncPartitioned` this is still a change that reduces performance by adding a check that needs evaluation -- This is an automate

Re: [PR] chore: Require parallelism >= 1 in MapAsync and MapAsyncUnordered [pekko]

2025-01-10 Thread via GitHub
He-Pin commented on PR #1700: URL: https://github.com/apache/pekko/pull/1700#issuecomment-2582503217 @pjfanning The code is the same as it is in `MapAsyncPartitioned` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] chore: Require parallelism >= 1 in MapAsync and MapAsyncUnordered [pekko]

2025-01-10 Thread via GitHub
pjfanning commented on PR #1700: URL: https://github.com/apache/pekko/pull/1700#issuecomment-2582479338 * is it really possible to end up in a position where the requirement fails? * if so, can we add a test? * also, what would users of older versions see in this case? an exception, a