Re: [PR] chore: Add identity function. [pekko]

2025-01-06 Thread via GitHub
He-Pin merged PR #1671: URL: https://github.com/apache/pekko/pull/1671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.a

Re: [PR] chore: Add identity function. [pekko]

2025-01-06 Thread via GitHub
He-Pin commented on PR #1671: URL: https://github.com/apache/pekko/pull/1671#issuecomment-2572839825 @mdedetrich Would you like to unblock this, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] chore: Add identity function. [pekko]

2025-01-04 Thread via GitHub
He-Pin commented on PR #1671: URL: https://github.com/apache/pekko/pull/1671#issuecomment-2571482766 @mdedetrich would you like talking another look, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] chore: Add identity function. [pekko]

2025-01-04 Thread via GitHub
He-Pin commented on code in PR #1671: URL: https://github.com/apache/pekko/pull/1671#discussion_r1903032497 ## actor-tests/src/test/java/org/apache/pekko/util/ConstantFunJavaTest.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] chore: Add identity function. [pekko]

2025-01-04 Thread via GitHub
pjfanning commented on PR #1671: URL: https://github.com/apache/pekko/pull/1671#issuecomment-2571116715 I'm ok with adding this if it helps. I would like to still have some of tests use `ConstantFun.javaIdentityFunction()` for regression purposed though. -- This is an automated message fr

Re: [PR] chore: Add identity function. [pekko]

2025-01-04 Thread via GitHub
He-Pin commented on PR #1671: URL: https://github.com/apache/pekko/pull/1671#issuecomment-2571087989 Sorry, the `java.util.function.Function#identity` returns a `java.util.function.Function`, even these methods share the same name, but returns two different types. -- This is an automate

Re: [PR] chore: Add identity function. [pekko]

2025-01-04 Thread via GitHub
pjfanning commented on PR #1671: URL: https://github.com/apache/pekko/pull/1671#issuecomment-2571049639 Can you translate the IDE issue into English? I prefer not to have images - if you paste the text, I can get a tool to translate it. If you paste images, I need an OCR tool and I don't ha

Re: [PR] chore: Add identity function. [pekko]

2025-01-04 Thread via GitHub
He-Pin commented on PR #1671: URL: https://github.com/apache/pekko/pull/1671#issuecomment-2571033530 @mdedetrich Yes and no, see below: https://github.com/user-attachments/assets/0707f631-84d8-4494-a031-b2911ed0f83c"; /> -- This is an automated message from the Apache Git Service.