Re: [PR] add jakartams to sbt project list [pekko-connectors]

2024-07-03 Thread via GitHub
pjfanning commented on PR #718: URL: https://github.com/apache/pekko-connectors/pull/718#issuecomment-2207478473 @samueleresca I think this PR fixes the issues. The main build issue was the fact this new module wasn't added to the project list in build.sbt. This means that non-scoped sbt co

Re: [PR] add jakartams to sbt project list [pekko-connectors]

2024-07-03 Thread via GitHub
samueleresca commented on PR #718: URL: https://github.com/apache/pekko-connectors/pull/718#issuecomment-2207448067 > @samueleresca the new #674 classes are breaking the doc build. See the checks for this PR. > > It looks hard to fix. Paradox has built-in support for having 2 classes

Re: [PR] add jakartams to sbt project list [pekko-connectors]

2024-07-03 Thread via GitHub
pjfanning merged PR #718: URL: https://github.com/apache/pekko-connectors/pull/718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] add jakartams to sbt project list [pekko-connectors]

2024-07-03 Thread via GitHub
pjfanning commented on code in PR #718: URL: https://github.com/apache/pekko-connectors/pull/718#discussion_r1664850837 ## jakartams/src/main/scala/org/apache/pekko/stream/connectors/jakartams/impl/JmsInternalMatValues.scala: ## @@ -14,10 +14,10 @@ package org.apache.pekko.stre

Re: [PR] add jakartams to sbt project list [pekko-connectors]

2024-07-03 Thread via GitHub
He-Pin commented on code in PR #718: URL: https://github.com/apache/pekko-connectors/pull/718#discussion_r1664847348 ## jakartams/src/main/scala/org/apache/pekko/stream/connectors/jakartams/impl/JmsInternalMatValues.scala: ## @@ -14,10 +14,10 @@ package org.apache.pekko.stream.

Re: [PR] add jakartams to sbt project list [pekko-connectors]

2024-07-03 Thread via GitHub
pjfanning commented on PR #718: URL: https://github.com/apache/pekko-connectors/pull/718#issuecomment-2206861960 @samueleresca I think I have found a way to fix the doc issue - just testing it locally right now -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] add jakartams to sbt project list [pekko-connectors]

2024-07-03 Thread via GitHub
pjfanning commented on PR #718: URL: https://github.com/apache/pekko-connectors/pull/718#issuecomment-2206115336 @samueleresca the new #674 classes are breaking the doc build. See the checks for this PR. It looks hard to fix. Paradox has built-in support for having 2 classes of the s