Re: [PR] Enhance virtual thread support [pekko]

2025-01-18 Thread via GitHub
He-Pin commented on PR #1724: URL: https://github.com/apache/pekko/pull/1724#issuecomment-2599665210 @pjfanning If you are worried about the `--add-opens`, I can add a JPMS util for it, and then the support is out of the box. -- This is an automated message from the Apache Git Service. To

Re: [PR] Enhance virtual thread support [pekko]

2025-01-17 Thread via GitHub
He-Pin commented on PR #1724: URL: https://github.com/apache/pekko/pull/1724#issuecomment-2599474805 @pjfanning I took another look at vert.x, which is using reflection too, let's move fast and ship it as this, and then in 2.0.0, we can drop Java 8 completely, I'm doing this in my free time

Re: [PR] Enhance virtual thread support [pekko]

2025-01-17 Thread via GitHub
He-Pin commented on code in PR #1724: URL: https://github.com/apache/pekko/pull/1724#discussion_r1920924007 ## actor/src/main/scala/org/apache/pekko/dispatch/VirtualThreadSupportReflect.scala: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Enhance virtual thread support [pekko]

2025-01-17 Thread via GitHub
He-Pin commented on PR #1724: URL: https://github.com/apache/pekko/pull/1724#issuecomment-2599386793 I will split this pr to move faster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] Enhance virtual thread support [pekko]

2025-01-17 Thread via GitHub
He-Pin commented on PR #1724: URL: https://github.com/apache/pekko/pull/1724#issuecomment-2599363194 refs: https://github.com/apache/pekko/issues/1727 Still not know why -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] Enhance virtual thread support [pekko]

2025-01-17 Thread via GitHub
He-Pin commented on code in PR #1724: URL: https://github.com/apache/pekko/pull/1724#discussion_r1920848176 ## actor/src/main/scala/org/apache/pekko/dispatch/VirtualThreadSupportReflect.scala: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Enhance virtual thread support [pekko]

2025-01-17 Thread via GitHub
He-Pin commented on code in PR #1724: URL: https://github.com/apache/pekko/pull/1724#discussion_r1920845585 ## actor/src/main/scala/org/apache/pekko/dispatch/VirtualThreadSupportReflect.scala: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Enhance virtual thread support [pekko]

2025-01-17 Thread via GitHub
He-Pin commented on code in PR #1724: URL: https://github.com/apache/pekko/pull/1724#discussion_r1920793244 ## actor/src/main/scala/org/apache/pekko/dispatch/VirtualThreadSupportReflect.scala: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Enhance virtual thread support [pekko]

2025-01-17 Thread via GitHub
He-Pin commented on code in PR #1724: URL: https://github.com/apache/pekko/pull/1724#discussion_r1920793244 ## actor/src/main/scala/org/apache/pekko/dispatch/VirtualThreadSupportReflect.scala: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Enhance virtual thread support [pekko]

2025-01-17 Thread via GitHub
He-Pin commented on code in PR #1724: URL: https://github.com/apache/pekko/pull/1724#discussion_r1920789689 ## actor/src/main/scala/org/apache/pekko/dispatch/VirtualThreadSupportReflect.scala: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Enhance virtual thread support [pekko]

2025-01-17 Thread via GitHub
pjfanning commented on code in PR #1724: URL: https://github.com/apache/pekko/pull/1724#discussion_r1920780522 ## actor/src/main/scala/org/apache/pekko/dispatch/VirtualThreadSupportReflect.scala: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Enhance virtual thread support [pekko]

2025-01-17 Thread via GitHub
He-Pin commented on code in PR #1724: URL: https://github.com/apache/pekko/pull/1724#discussion_r1920708663 ## actor/src/main/scala/org/apache/pekko/dispatch/VirtualThreadSupportReflect.scala: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Enhance virtual thread support [pekko]

2025-01-17 Thread via GitHub
He-Pin commented on code in PR #1724: URL: https://github.com/apache/pekko/pull/1724#discussion_r1920700230 ## actor/src/main/scala/org/apache/pekko/dispatch/VirtualThreadSupportReflect.scala: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Enhance virtual thread support [pekko]

2025-01-17 Thread via GitHub
He-Pin commented on PR #1724: URL: https://github.com/apache/pekko/pull/1724#issuecomment-2599123257 `case ThreadPoolConfig` is nowhere. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Enhance virtual thread support [pekko]

2025-01-17 Thread via GitHub
pjfanning commented on code in PR #1724: URL: https://github.com/apache/pekko/pull/1724#discussion_r1920657670 ## actor/src/main/scala/org/apache/pekko/dispatch/VirtualThreadSupportReflect.scala: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Enhance virtual thread support [pekko]

2025-01-17 Thread via GitHub
pjfanning commented on code in PR #1724: URL: https://github.com/apache/pekko/pull/1724#discussion_r1920656483 ## actor/src/main/scala/org/apache/pekko/dispatch/VirtualThreadSupportReflect.scala: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Enhance virtual thread support [pekko]

2025-01-17 Thread via GitHub
He-Pin commented on code in PR #1724: URL: https://github.com/apache/pekko/pull/1724#discussion_r1920645294 ## actor/src/main/scala/org/apache/pekko/dispatch/VirtualThreadSupportReflect.scala: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Enhance virtual thread support [pekko]

2025-01-17 Thread via GitHub
pjfanning commented on code in PR #1724: URL: https://github.com/apache/pekko/pull/1724#discussion_r1920633117 ## actor/src/main/scala/org/apache/pekko/dispatch/VirtualThreadSupportReflect.scala: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Enhance virtual thread support [pekko]

2025-01-17 Thread via GitHub
He-Pin commented on code in PR #1724: URL: https://github.com/apache/pekko/pull/1724#discussion_r1920630777 ## project/JdkOptions.scala: ## @@ -49,6 +49,11 @@ object JdkOptions extends AutoPlugin { lazy val versionSpecificJavaOptions = if (isJdk17orHigher) { + //

Re: [PR] Enhance virtual thread support [pekko]

2025-01-17 Thread via GitHub
He-Pin commented on code in PR #1724: URL: https://github.com/apache/pekko/pull/1724#discussion_r1920631243 ## docs/src/main/paradox/dispatchers.md: ## @@ -42,6 +42,10 @@ allocated by the ForkJoinPool. It is a setting specifically talking about the nu threads the pool keep run

Re: [PR] Enhance virtual thread support [pekko]

2025-01-17 Thread via GitHub
He-Pin commented on code in PR #1724: URL: https://github.com/apache/pekko/pull/1724#discussion_r1920625671 ## docs/src/main/paradox/typed/dispatchers.md: ## @@ -127,13 +127,18 @@ allocated by the ForkJoinPool. It is a setting specifically talking about the nu threads the pool

Re: [PR] Enhance virtual thread support [pekko]

2025-01-17 Thread via GitHub
He-Pin commented on code in PR #1724: URL: https://github.com/apache/pekko/pull/1724#discussion_r1920624956 ## actor/src/main/scala/org/apache/pekko/dispatch/VirtualThreadSupportReflect.scala: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Enhance virtual thread support [pekko]

2025-01-17 Thread via GitHub
He-Pin commented on code in PR #1724: URL: https://github.com/apache/pekko/pull/1724#discussion_r1920624294 ## actor/src/main/resources/reference.conf: ## @@ -487,6 +487,12 @@ pekko { # This config is new in Pekko v1.1.0 and only has an effect if you are running with J

Re: [PR] Enhance virtual thread support [pekko]

2025-01-17 Thread via GitHub
He-Pin commented on code in PR #1724: URL: https://github.com/apache/pekko/pull/1724#discussion_r1920219797 ## actor/src/main/scala/org/apache/pekko/dispatch/VirtualThreadSupport.scala: ## @@ -33,20 +34,48 @@ private[dispatch] object VirtualThreadSupport { */ val isSuppor