pjfanning merged PR #223:
URL: https://github.com/apache/incubator-pekko-connectors/pull/223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
pjfanning commented on code in PR #223:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/223#discussion_r1516303694
##
slick/src/test/java/docs/javadsl/SlickTest.java:
##
Review Comment:
test timeouts reverted
--
This is an automated message from the Apac
pjfanning commented on code in PR #223:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/223#discussion_r1516167497
##
slick/src/main/scala/org/apache/pekko/stream/connectors/slick/javadsl/Slick.scala:
##
@@ -54,6 +51,7 @@ object Slick {
session: SlickSessi
mdedetrich commented on code in PR #223:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/223#discussion_r1516110691
##
slick/src/test/java/docs/javadsl/SlickTest.java:
##
Review Comment:
Can you try reverting the change in this file from `10` seconds to `5`
mdedetrich commented on code in PR #223:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/223#discussion_r1516109342
##
slick/src/main/scala/org/apache/pekko/stream/connectors/slick/javadsl/Slick.scala:
##
@@ -54,6 +51,7 @@ object Slick {
session: SlickSess
mdedetrich commented on PR #223:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/223#issuecomment-1959051742
Replied at
https://github.com/slick/slick/discussions/2891#discussioncomment-8554394
--
This is an automated message from the Apache Git Service.
To respond to the
mdedetrich commented on PR #223:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/223#issuecomment-1958997035
> Alternatively, would it be possible to set up our GitHub Actions so that
we can publish a snapshot built off a branch/PR?
I wanted to do this at some point I
pjfanning commented on PR #223:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/223#issuecomment-1958987553
I agree that it is too time consuming for us to do releases to test non-ASF
jars. If someone really wanted to test this, they could build
pekko-connectors-slick jars t
raboof commented on PR #223:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/223#issuecomment-1958975082
Ideally I think releases should not depend on snapshot/RC dependencies, and
the main branch should always be in a release-able state. I guess we can
deviate from that if
mdedetrich commented on PR #223:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/223#issuecomment-1958814213
Please don't merge this PR until we make a discussion about whether its
appropriate for us as a snapshot
--
This is an automated message from the Apache Git Service
mdedetrich commented on PR #223:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/223#issuecomment-1958782718
So it is being
[asked](https://github.com/slick/slick/discussions/2891#discussioncomment-8550269)
if we can publish these changes so that people can test Slick 3.5.0-
mdedetrich commented on PR #223:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/223#issuecomment-1925575038
@pjfanning I just cleaned up the branch which included some rebases so I
would just pull the latest changes ignoring the local ones.
Good news is that Slick 3.5
mdedetrich commented on PR #223:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/223#issuecomment-1822232666
@pjfanning There are MiMa related failures, although tbh we never agreed for
MiMa on this pekko module and Slick 3.5 is slated for 1.1.x anyways
--
This is an autom
13 matches
Mail list logo
