Re: [PR] remove compatibility test [incubator-pekko-grpc]

2024-02-20 Thread via GitHub
raboof commented on PR #229: URL: https://github.com/apache/incubator-pekko-grpc/pull/229#issuecomment-1955228675 superseded by #222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] remove compatibility test [incubator-pekko-grpc]

2024-02-20 Thread via GitHub
raboof closed pull request #229: remove compatibility test URL: https://github.com/apache/incubator-pekko-grpc/pull/229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] remove compatibility test [incubator-pekko-grpc]

2024-02-12 Thread via GitHub
raboof commented on PR #229: URL: https://github.com/apache/incubator-pekko-grpc/pull/229#issuecomment-1938340489 > #228 is there to remind us that we need to add this or an equivalent test back. TBH I'm not optimistic that that would actually happen when there's no pressing need an

Re: [PR] remove compatibility test [incubator-pekko-grpc]

2024-02-12 Thread via GitHub
pjfanning commented on PR #229: URL: https://github.com/apache/incubator-pekko-grpc/pull/229#issuecomment-1938286953 @raboof to flip the question - is it worth blocking the upgrade of the grpc and protobuf libs until someone works out how to fix this test? https://github.com/apache/incubat

Re: [PR] remove compatibility test [incubator-pekko-grpc]

2024-02-12 Thread via GitHub
raboof commented on PR #229: URL: https://github.com/apache/incubator-pekko-grpc/pull/229#issuecomment-1938272912 Looking at https://github.com/protocolbuffers/protobuf-javascript/issues/127#issuecomment-1542288860 are we sure it's impossible to make this work with newer versions of protob

[PR] remove compatibility test [incubator-pekko-grpc]

2024-02-11 Thread via GitHub
pjfanning opened a new pull request, #229: URL: https://github.com/apache/incubator-pekko-grpc/pull/229 this test blocks #222 and it isn't a core feature #228 is about writing a new test to replace this -- This is an automated message from the Apache Git Service. To respond to the m