Re: [PR] feat: Add flatmapConcat with parallelism support [pekko]

2025-03-12 Thread via GitHub
He-Pin commented on PR #1702: URL: https://github.com/apache/pekko/pull/1702#issuecomment-2719139551 It it not really related. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] feat: Add flatmapConcat with parallelism support [pekko]

2025-03-12 Thread via GitHub
He-Pin merged PR #1702: URL: https://github.com/apache/pekko/pull/1702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.a

Re: [PR] feat: Add flatmapConcat with parallelism support [pekko]

2025-03-11 Thread via GitHub
He-Pin commented on PR #1702: URL: https://github.com/apache/pekko/pull/1702#issuecomment-2716353183 @pjfanning Would you like to give this a lgtm? I rerun the test, it passed now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] feat: Add flatmapConcat with parallelism support [pekko]

2025-03-10 Thread via GitHub
He-Pin commented on PR #1702: URL: https://github.com/apache/pekko/pull/1702#issuecomment-2709996431 The failure was unrelated, record as https://github.com/apache/pekko/issues/1796 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] feat: Add flatmapConcat with parallelism support [pekko]

2025-03-09 Thread via GitHub
pjfanning commented on code in PR #1702: URL: https://github.com/apache/pekko/pull/1702#discussion_r1986300348 ## stream/src/main/scala/org/apache/pekko/stream/impl/fusing/FlattenConcat.scala: ## @@ -0,0 +1,347 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] feat: Add flatmapConcat with parallelism support [pekko]

2025-03-09 Thread via GitHub
pjfanning commented on code in PR #1702: URL: https://github.com/apache/pekko/pull/1702#discussion_r1986299040 ## stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/FlowFlatMapConcatParallelismSpec.scala: ## @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] feat: Add flatmapConcat with parallelism support [pekko]

2025-03-02 Thread via GitHub
He-Pin commented on PR #1702: URL: https://github.com/apache/pekko/pull/1702#issuecomment-2692649512 Would anyone like to review this, thanks :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] feat: Add flatmapConcat with parallelism support [pekko]

2025-02-16 Thread via GitHub
He-Pin commented on PR #1702: URL: https://github.com/apache/pekko/pull/1702#issuecomment-2661848940 Rebased on the current main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] feat: Add flatmapConcat with parallelism support [pekko]

2025-01-17 Thread via GitHub
He-Pin commented on PR #1702: URL: https://github.com/apache/pekko/pull/1702#issuecomment-2598168437 @pjfanning @raboof @jrudolph @mdedetrich Would you like to give this some care:) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] feat: Add flatmapConcat with parallelism support [pekko]

2025-01-13 Thread via GitHub
He-Pin commented on PR #1702: URL: https://github.com/apache/pekko/pull/1702#issuecomment-2586592226 @gael-ft would you take a look at this, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] feat: Add flatmapConcat with parallelism support [pekko]

2025-01-10 Thread via GitHub
He-Pin commented on PR #1702: URL: https://github.com/apache/pekko/pull/1702#issuecomment-2583027627 Yes, but I think it would be nice to have this out of box. otherwise will need a `mapAsync` and `prematerialize` and then `flatmapConcat`, and I think the current implementation will have be

Re: [PR] feat: Add flatmapConcat with parallelism support [pekko]

2025-01-10 Thread via GitHub
jrudolph commented on PR #1702: URL: https://github.com/apache/pekko/pull/1702#issuecomment-2582998628 I wonder if it is really necessary, wouldn't it be easier to just prematerialize to get the same effect? -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] feat: Add flatmapConcat with parallelism support [pekko]

2025-01-10 Thread via GitHub
He-Pin commented on PR #1702: URL: https://github.com/apache/pekko/pull/1702#issuecomment-2582790700 I hate 2.12.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub