Re: [PR] feat: Add Source#create method [pekko]

2025-07-06 Thread via GitHub
He-Pin merged PR #1823: URL: https://github.com/apache/pekko/pull/1823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.a

Re: [PR] feat: Add Source#create method [pekko]

2025-07-06 Thread via GitHub
He-Pin commented on PR #1823: URL: https://github.com/apache/pekko/pull/1823#issuecomment-3041407437 @mdedetrich Would you like to unblock this one, thanks./ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] feat: Add Source#create method [pekko]

2025-06-18 Thread via GitHub
He-Pin commented on PR #1823: URL: https://github.com/apache/pekko/pull/1823#issuecomment-2983070661 @mdedetrich @raboof @Roiocam Would you like to take a look at this? This one is currently blocked. -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] feat: Add Source#create method [pekko]

2025-06-12 Thread via GitHub
He-Pin commented on PR #1823: URL: https://github.com/apache/pekko/pull/1823#issuecomment-2965225408 @pjfanning @mdedetrich friendly ping, is there any more changes need me to adjust this ? -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] feat: Add Source#create method [pekko]

2025-06-12 Thread via GitHub
pjfanning commented on PR #1823: URL: https://github.com/apache/pekko/pull/1823#issuecomment-2966347947 @He-Pin this merge is blocked by @mdedetrich's request for a change. If he is not available to review this, then we'll need someone else to agree to removing the block. -- This is an a

Re: [PR] feat: Add Source#create method [pekko]

2025-05-28 Thread via GitHub
He-Pin commented on PR #1823: URL: https://github.com/apache/pekko/pull/1823#issuecomment-2918050369 @mdedetrich The other queue operator can support adding the overflow strategy, but there are some problems associated with that operator, where the messages can be buffered in the queue and

Re: [PR] feat: Add Source#create method [pekko]

2025-05-23 Thread via GitHub
He-Pin commented on PR #1823: URL: https://github.com/apache/pekko/pull/1823#issuecomment-2904792501 @mdedetrich @pjfanning busy days, what do you think about this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] feat: Add Source#create method [pekko]

2025-05-05 Thread via GitHub
mdedetrich commented on code in PR #1823: URL: https://github.com/apache/pekko/pull/1823#discussion_r2073413867 ## stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/BoundedSourceQueueSpec.scala: ## @@ -223,5 +223,19 @@ class BoundedSourceQueueSpec extends StreamSpec(

Re: [PR] feat: Add Source#create method [pekko]

2025-05-02 Thread via GitHub
pjfanning commented on code in PR #1823: URL: https://github.com/apache/pekko/pull/1823#discussion_r2071713844 ## stream/src/main/scala/org/apache/pekko/stream/javadsl/Source.scala: ## @@ -799,6 +799,38 @@ object Source { def queue[T](bufferSize: Int): Source[T, BoundedSource

Re: [PR] feat: Add Source#create method [pekko]

2025-04-21 Thread via GitHub
He-Pin commented on code in PR #1823: URL: https://github.com/apache/pekko/pull/1823#discussion_r2051926428 ## stream/src/main/scala/org/apache/pekko/stream/scaladsl/Source.scala: ## @@ -930,6 +931,47 @@ object Source { def queue[T](bufferSize: Int): Source[T, BoundedSourceQu

Re: [PR] feat: Add Source#create method [pekko]

2025-04-20 Thread via GitHub
He-Pin commented on code in PR #1823: URL: https://github.com/apache/pekko/pull/1823#discussion_r2051926428 ## stream/src/main/scala/org/apache/pekko/stream/scaladsl/Source.scala: ## @@ -930,6 +931,47 @@ object Source { def queue[T](bufferSize: Int): Source[T, BoundedSourceQu

Re: [PR] feat: Add Source#create method [pekko]

2025-04-20 Thread via GitHub
He-Pin commented on code in PR #1823: URL: https://github.com/apache/pekko/pull/1823#discussion_r2051745604 ## stream/src/main/scala/org/apache/pekko/stream/scaladsl/Source.scala: ## @@ -930,6 +931,47 @@ object Source { def queue[T](bufferSize: Int): Source[T, BoundedSourceQu

Re: [PR] feat: Add Source#create method [pekko]

2025-04-20 Thread via GitHub
jxnu-liguobin commented on code in PR #1823: URL: https://github.com/apache/pekko/pull/1823#discussion_r2051745078 ## stream/src/main/scala/org/apache/pekko/stream/scaladsl/Source.scala: ## @@ -930,6 +931,47 @@ object Source { def queue[T](bufferSize: Int): Source[T, BoundedS

Re: [PR] feat: Add Source#create method [pekko]

2025-04-20 Thread via GitHub
He-Pin closed pull request #1823: feat: Add Source#create method URL: https://github.com/apache/pekko/pull/1823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] feat: Add Source#create method [pekko]

2025-04-20 Thread via GitHub
He-Pin commented on code in PR #1823: URL: https://github.com/apache/pekko/pull/1823#discussion_r2051695422 ## stream/src/main/scala/org/apache/pekko/stream/scaladsl/Source.scala: ## @@ -930,6 +931,47 @@ object Source { def queue[T](bufferSize: Int): Source[T, BoundedSourceQu

[PR] feat: Add Source#create method [pekko]

2025-04-20 Thread via GitHub
He-Pin opened a new pull request, #1823: URL: https://github.com/apache/pekko/pull/1823 Motivation: refs: https://github.com/apache/pekko/issues/1626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] feat: Add Source#create method [pekko]

2025-04-20 Thread via GitHub
He-Pin commented on PR #1823: URL: https://github.com/apache/pekko/pull/1823#issuecomment-2817139367 ```scala MixedProtocolClusterSpec] within [20 seconds] [04-20 11:37:01.079] [info] -> / LocalActorRefProvider$$anon$3 class org.apache.pekko.actor.LocalActorRefProvider$Guardian status