He-Pin commented on PR #1050:
URL: https://github.com/apache/incubator-pekko/pull/1050#issuecomment-1913128086
@pjfanning I'm mean the file is been compiled in the doc. Check the JDK9+
classes generated is not a target of this PR. Why do you always like to block a
PR? you can just leave a c
He-Pin commented on PR #1050:
URL: https://github.com/apache/incubator-pekko/pull/1050#issuecomment-1913125468
It can now check the error code in Java 9 folder, and for Java 21 I will do
in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message,
He-Pin commented on PR #1050:
URL: https://github.com/apache/incubator-pekko/pull/1050#issuecomment-1913123773
--
This is an automated message from the Apache Git Service.
To respond
He-Pin commented on PR #1050:
URL: https://github.com/apache/incubator-pekko/pull/1050#issuecomment-1913022921
I verified both works @Roiocam
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
He-Pin commented on PR #1050:
URL: https://github.com/apache/incubator-pekko/pull/1050#issuecomment-1913010895
@Roiocam Let's me update the pr and check if that works on ci too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Roiocam commented on PR #1050:
URL: https://github.com/apache/incubator-pekko/pull/1050#issuecomment-1912497767
`clean;docs/test` works for me too, I think we need to figure out why
`validatePullRequest` rather than adding a CI check, what do you think? @He-Pin
```
[info] compilin
He-Pin commented on code in PR #1050:
URL: https://github.com/apache/incubator-pekko/pull/1050#discussion_r1467748098
##
docs/src/test/java-jdk9-only/jdocs/stream/operators/source/AsSubscriber.java:
##
@@ -20,7 +20,7 @@
import org.apache.pekko.NotUsed;
import org.apache.pekko.
He-Pin commented on PR #1050:
URL: https://github.com/apache/incubator-pekko/pull/1050#issuecomment-1912191799
@mdedetrich @pjfanning @Roiocam
I think this should be the simplest way.
With an explicit `TestJDK9 / test` as I chatted with @Roiocam on WeChat.
https://github.com/apache
He-Pin commented on PR #1050:
URL: https://github.com/apache/incubator-pekko/pull/1050#issuecomment-1911910562
@Roiocam I just checked, the paradox task still can't catch the compiling
error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
He-Pin opened a new pull request, #1050:
URL: https://github.com/apache/incubator-pekko/pull/1050
used for testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
10 matches
Mail list logo
