Re: [PR] chore: Make code compiles on JDK 23 [pekko]

2025-01-17 Thread via GitHub
WojciechMazur commented on PR #1726: URL: https://github.com/apache/pekko/pull/1726#issuecomment-2599367404 Correct, it was going to be announced on Monday, becouse we're waiting for tooling confirmation -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] chore: Make code compiles on JDK 23 [pekko]

2025-01-17 Thread via GitHub
He-Pin commented on PR #1726: URL: https://github.com/apache/pekko/pull/1726#issuecomment-2599339230 Is the 3.3.5-RC2 on the way, so next is 3.3.5-RC3? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] chore: Make code compiles on JDK 23 [pekko]

2025-01-17 Thread via GitHub
WojciechMazur commented on PR #1726: URL: https://github.com/apache/pekko/pull/1726#issuecomment-2599289182 @He-Pin Thank you for spotting this bug! The JDK 23 support was backported to 3.3.5-RC1, by mistake 1 single change that is no longer needed in Next was not applied in the LTS backpor

Re: [PR] chore: Make code compiles on JDK 23 [pekko]

2025-01-17 Thread via GitHub
He-Pin merged PR #1726: URL: https://github.com/apache/pekko/pull/1726 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.a

Re: [PR] chore: Make code compiles on JDK 23 [pekko]

2025-01-17 Thread via GitHub
He-Pin commented on PR #1726: URL: https://github.com/apache/pekko/pull/1726#issuecomment-2599246327 @WojciechMazur I tested it with 3.3.5-RC1, but still later get: ```scala [error] 23 is not a valid choice for -java-output-version [info] scalac -help gives more information ```

Re: [PR] chore: Make code compiles on JDK 23 [pekko]

2025-01-17 Thread via GitHub
He-Pin commented on PR #1726: URL: https://github.com/apache/pekko/pull/1726#issuecomment-2599244114 @pjfanning I tested it with https://github.com/scala/scala3/releases/tag/3.3.5-RC1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] chore: Make code compiles on JDK 23 [pekko]

2025-01-17 Thread via GitHub
He-Pin commented on PR #1726: URL: https://github.com/apache/pekko/pull/1726#issuecomment-2599233422 @pjfanning Maybe we need to wait for the Scala 3.3.5? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] chore: Make code compiles on JDK 23 [pekko]

2025-01-17 Thread via GitHub
pjfanning commented on PR #1726: URL: https://github.com/apache/pekko/pull/1726#issuecomment-2599183165 I got this in the java 23 with scala 3 build ``` [01-17 20:08:03.894] [info] compiling 1 Scala source to /home/runner/work/pekko/pekko/actor/target/scala-3.3.4/CompileJdk9-classe

[PR] chore: Make code compiles on JDK 23 [pekko]

2025-01-17 Thread via GitHub
He-Pin opened a new pull request, #1726: URL: https://github.com/apache/pekko/pull/1726 Motivation: Make code compiles on JDK 23 refs: https://github.com/apache/pekko/issues/1725 Modification: Add @nowarn("cat=deprecation") Result: Tested locally, it compiles now -