Re: [PR] chore: Code clean up in MapAsyncUnordered [pekko]

2024-12-31 Thread via GitHub
He-Pin closed pull request #1659: chore: Code clean up in MapAsyncUnordered URL: https://github.com/apache/pekko/pull/1659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] chore: Code clean up in MapAsyncUnordered [pekko]

2024-12-31 Thread via GitHub
He-Pin commented on code in PR #1659: URL: https://github.com/apache/pekko/pull/1659#discussion_r1900318510 ## stream/src/main/scala/org/apache/pekko/stream/impl/fusing/Ops.scala: ## @@ -1411,37 +1411,40 @@ private[stream] object Collect { override def preStart(): Unit =

Re: [PR] chore: Code clean up in MapAsyncUnordered [pekko]

2024-12-31 Thread via GitHub
He-Pin commented on code in PR #1659: URL: https://github.com/apache/pekko/pull/1659#discussion_r1900318434 ## stream/src/main/scala/org/apache/pekko/stream/impl/fusing/Ops.scala: ## @@ -1411,37 +1411,40 @@ private[stream] object Collect { override def preStart(): Unit =

[PR] chore: Code clean up in MapAsyncUnordered [pekko]

2024-12-31 Thread via GitHub
He-Pin opened a new pull request, #1659: URL: https://github.com/apache/pekko/pull/1659 Motivation: 1. Code clean up 2. tweak code more like mapasync 3. avoid double try pull when future is completed Modification: code clean up Result: easy to reason -- This i