pjfanning commented on PR #177:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/177#issuecomment-2508924528
Thanks. I merged this. We can do some tweaks in new PRs if anyone has any
issues with these changes.
--
This is an automated message from the Apache Git Service.
To res
pjfanning merged PR #177:
URL: https://github.com/apache/pekko-persistence-r2dbc/pull/177
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
ptrdom commented on code in PR #177:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/177#discussion_r1856836038
##
projection/src/main/scala/org/apache/pekko/projection/r2dbc/internal/mysql/MySQLR2dbcOffsetStore.scala:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apa
Roiocam commented on code in PR #177:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/177#discussion_r1855677696
##
projection/src/main/scala/org/apache/pekko/projection/r2dbc/internal/mysql/MySQLR2dbcOffsetStore.scala:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Ap
ptrdom commented on code in PR #177:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/177#discussion_r1855160442
##
projection/src/main/scala/org/apache/pekko/projection/r2dbc/R2dbcProjectionSettings.scala:
##
@@ -44,25 +46,149 @@ object R2dbcProjectionSettings {
pjfanning commented on PR #177:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/177#issuecomment-2488471552
I committed a fix for the merge conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
ptrdom commented on code in PR #177:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/177#discussion_r1848839523
##
projection/src/main/scala/org/apache/pekko/projection/r2dbc/R2dbcProjectionSettings.scala:
##
Review Comment:
@pjfanning Do you have a preferred s
pjfanning commented on code in PR #177:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/177#discussion_r1848847389
##
projection/src/main/scala/org/apache/pekko/projection/r2dbc/R2dbcProjectionSettings.scala:
##
Review Comment:
I see the TODO on the class - so
ptrdom commented on code in PR #177:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/177#discussion_r1846881840
##
projection/src/main/scala/org/apache/pekko/projection/r2dbc/R2dbcProjectionSettings.scala:
##
Review Comment:
Of course this class is different fr
ptrdom commented on code in PR #177:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/177#discussion_r1846870120
##
projection/src/main/scala/org/apache/pekko/projection/r2dbc/R2dbcProjectionSettings.scala:
##
Review Comment:
Since we are breaking backwards comp
ptrdom opened a new pull request, #177:
URL: https://github.com/apache/pekko-persistence-r2dbc/pull/177
Related to https://github.com/apache/pekko-persistence-r2dbc/issues/158.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
11 matches
Mail list logo
