Re: [PR] Implement EventsByTagQuery in PersistenceTestKitReadJournal [pekko]

2024-10-16 Thread via GitHub
pjfanning merged PR #1532: URL: https://github.com/apache/pekko/pull/1532 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekk

Re: [PR] Implement EventsByTagQuery in PersistenceTestKitReadJournal [pekko]

2024-10-16 Thread via GitHub
pjfanning commented on PR #1532: URL: https://github.com/apache/pekko/pull/1532#issuecomment-2416984076 @ptrdom I found your iCLA in the ASF foundation svn repo so that is enough to proceed. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Implement EventsByTagQuery in PersistenceTestKitReadJournal [pekko]

2024-10-16 Thread via GitHub
pjfanning commented on PR #1532: URL: https://github.com/apache/pekko/pull/1532#issuecomment-2416971757 > @pjfanning I got a message that my ICLA has been filed in the Apache Software Foundation records and that I need to contact a project to progress my application. And that I should let t

Re: [PR] Implement EventsByTagQuery in PersistenceTestKitReadJournal [pekko]

2024-10-16 Thread via GitHub
ptrdom commented on PR #1532: URL: https://github.com/apache/pekko/pull/1532#issuecomment-2416948507 @pjfanning I got a message that my ICLA has been filed in the Apache Software Foundation records and that I need to contact a project to progress my application. And that I should let the pr

Re: [PR] Implement EventsByTagQuery in PersistenceTestKitReadJournal [pekko]

2024-10-15 Thread via GitHub
pjfanning commented on PR #1532: URL: https://github.com/apache/pekko/pull/1532#issuecomment-2414812178 > Sure, cannot see a reason not to file. Thanks @ptrdom -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Implement EventsByTagQuery in PersistenceTestKitReadJournal [pekko]

2024-10-15 Thread via GitHub
ptrdom commented on PR #1532: URL: https://github.com/apache/pekko/pull/1532#issuecomment-2414804848 Sure, cannot see a reason not to file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Implement EventsByTagQuery in PersistenceTestKitReadJournal [pekko]

2024-10-15 Thread via GitHub
pjfanning commented on PR #1532: URL: https://github.com/apache/pekko/pull/1532#issuecomment-2414770217 @ptrdom would you consider filling in a CLA? https://www.apache.org/licenses/contributor-agreements.html -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Implement EventsByTagQuery in PersistenceTestKitReadJournal [pekko]

2024-10-14 Thread via GitHub
pjfanning commented on PR #1532: URL: https://github.com/apache/pekko/pull/1532#issuecomment-2411993979 Don't worry about the Link Validator. The changes look ok to me. I would like to let other people review this before it gets merged. I think this is safe for the v1.1.3 release but I want

Re: [PR] Implement EventsByTagQuery in PersistenceTestKitReadJournal [pekko]

2024-10-13 Thread via GitHub
ptrdom commented on PR #1532: URL: https://github.com/apache/pekko/pull/1532#issuecomment-2409082178 @pjfanning Seems like the only issue is with timeouts in link validator, IIUC it is a temporary failure. Is the PR otherwise fine? -- This is an automated message from the Apache Git Servi

Re: [PR] Implement EventsByTagQuery in PersistenceTestKitReadJournal [pekko]

2024-10-13 Thread via GitHub
ptrdom commented on PR #1532: URL: https://github.com/apache/pekko/pull/1532#issuecomment-2409043152 Aha, so tests have to compile on 2.12 too, will fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Implement EventsByTagQuery in PersistenceTestKitReadJournal [pekko]

2024-10-13 Thread via GitHub
ptrdom commented on PR #1532: URL: https://github.com/apache/pekko/pull/1532#issuecomment-2409027390 Seeing complication errors on 2.12, will fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] Implement EventsByTagQuery in PersistenceTestKitReadJournal [pekko]

2024-10-13 Thread via GitHub
ptrdom opened a new pull request, #1532: URL: https://github.com/apache/pekko/pull/1532 Resolves https://github.com/apache/pekko/issues/1527. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s