Re: [PR] Allow cluster formation with mixed protocols [pekko]

2024-12-16 Thread via GitHub
pjfanning commented on PR #1568: URL: https://github.com/apache/pekko/pull/1568#issuecomment-2546596882 reverted in #1568 1588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] Allow cluster formation with mixed protocols [pekko]

2024-12-16 Thread via GitHub
pjfanning commented on code in PR #1567: URL: https://github.com/apache/pekko/pull/1567#discussion_r1886929961 ## cluster/src/test/scala/org/apache/pekko/cluster/MixedProtocolClusterSpec.scala: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] Allow cluster formation with mixed protocols [pekko]

2024-12-16 Thread via GitHub
pjfanning commented on PR #1567: URL: https://github.com/apache/pekko/pull/1567#issuecomment-2545629156 I am going to revert this due to #1586 A build of #1587 with the nightly builds temporarily enabled shows that this PR is the cause. We can try to fix this issue again but w

Re: [PR] Allow cluster formation with mixed protocols [pekko]

2024-12-09 Thread via GitHub
sadekmunawar commented on PR #1567: URL: https://github.com/apache/pekko/pull/1567#issuecomment-2530072685 @pjfanning There two missing pieces left: 1. Deserialization of Akka cluster messages. I created the PR for this one #1578 2. Supporting Akka config for JoinConfigCompatChecker.

Re: [PR] Allow cluster formation with mixed protocols [pekko]

2024-12-09 Thread via GitHub
pjfanning commented on PR #1567: URL: https://github.com/apache/pekko/pull/1567#issuecomment-2528805963 @sadekmunawar any news on progress? If you don't have time to create a PR for the remaining issue, could you give us some pointers so someone else could create the PR instead? -- This

Re: [PR] Allow cluster formation with mixed protocols [pekko]

2024-11-27 Thread via GitHub
sadekmunawar commented on PR #1567: URL: https://github.com/apache/pekko/pull/1567#issuecomment-2503989078 > @sadekmunawar do you think doing a release with your changes is a good idea or are you in the middle of testing mixed clusters and feel like you might find more issues? @pjfan

Re: [PR] Allow cluster formation with mixed protocols [pekko]

2024-11-27 Thread via GitHub
raboof merged PR #1568: URL: https://github.com/apache/pekko/pull/1568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.a

Re: [PR] Allow cluster formation with mixed protocols [pekko]

2024-11-27 Thread via GitHub
pjfanning commented on PR #1567: URL: https://github.com/apache/pekko/pull/1567#issuecomment-2503483908 @sadekmunawar do you think doing a release with your changes is a good idea or are you in the middle of testing mixed clusters and feel like you might find more issues? -- This is an a

Re: [PR] Allow cluster formation with mixed protocols [pekko]

2024-11-27 Thread via GitHub
raboof commented on code in PR #1568: URL: https://github.com/apache/pekko/pull/1568#discussion_r1860412991 ## cluster/src/main/scala/org/apache/pekko/cluster/ClusterDaemon.scala: ## @@ -701,10 +703,10 @@ private[cluster] class ClusterCoreDaemon(publisher: ActorRef, joinConfigC

Re: [PR] Allow cluster formation with mixed protocols [pekko]

2024-11-27 Thread via GitHub
raboof commented on PR #1568: URL: https://github.com/apache/pekko/pull/1568#issuecomment-2503488179 (yes - 'well actually' I cherry-picked 33156d2 but that pretty much amounts to the same thing since we squash-and-merge in Pekko) -- This is an automated message from the Apache Git Servic

Re: [PR] Allow cluster formation with mixed protocols [pekko]

2024-11-27 Thread via GitHub
He-Pin commented on code in PR #1568: URL: https://github.com/apache/pekko/pull/1568#discussion_r1860406983 ## cluster/src/main/scala/org/apache/pekko/cluster/ClusterDaemon.scala: ## @@ -701,10 +703,10 @@ private[cluster] class ClusterCoreDaemon(publisher: ActorRef, joinConfigC

Re: [PR] Allow cluster formation with mixed protocols [pekko]

2024-11-27 Thread via GitHub
raboof commented on PR #1567: URL: https://github.com/apache/pekko/pull/1567#issuecomment-2503473666 (I'll backport) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] Allow cluster formation with mixed protocols [pekko]

2024-11-27 Thread via GitHub
pjfanning commented on PR #1568: URL: https://github.com/apache/pekko/pull/1568#issuecomment-2503485798 cherry pick e4fa6f5ea1366debec6c7571bd12de391bf0df1e -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] Allow cluster formation with mixed protocols [pekko]

2024-11-27 Thread via GitHub
raboof opened a new pull request, #1568: URL: https://github.com/apache/pekko/pull/1568 backport of #1567 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] Allow cluster formation with mixed protocols [pekko]

2024-11-27 Thread via GitHub
raboof merged PR #1567: URL: https://github.com/apache/pekko/pull/1567 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.a

[PR] Allow cluster formation with mixed protocols [pekko]

2024-11-26 Thread via GitHub
sadekmunawar opened a new pull request, #1567: URL: https://github.com/apache/pekko/pull/1567 Rolling upgrade from Akka to Pekko requires cluster formation with mixed protocol nodes. If the config `accept-protocol-names` contains both "akka" and "pekko", nodes using either protocol should b