Re: [PR] Add startup checks [pekko-management]

2024-08-27 Thread via GitHub
Roiocam commented on PR #293: URL: https://github.com/apache/pekko-management/pull/293#issuecomment-2314325529 if i remember correctly, Kubernetes recommend TCP probe rather than HTTP probe for startup, because efficiency reason. -- This is an automated message from the Apache Git Service

Re: [PR] Add startup checks [pekko-management]

2024-08-27 Thread via GitHub
Philippus commented on code in PR #293: URL: https://github.com/apache/pekko-management/pull/293#discussion_r1733826985 ## management/src/main/scala/org/apache/pekko/management/internal/HealthChecksImpl.scala: ## @@ -47,13 +48,29 @@ final private[pekko] class HealthChecksImpl(sy

Re: [PR] Add startup checks [pekko-management]

2024-08-27 Thread via GitHub
Philippus commented on code in PR #293: URL: https://github.com/apache/pekko-management/pull/293#discussion_r1733826985 ## management/src/main/scala/org/apache/pekko/management/internal/HealthChecksImpl.scala: ## @@ -47,13 +48,29 @@ final private[pekko] class HealthChecksImpl(sy

[GH] (pekko-persistence-cassandra): Workflow run "Run Tests with Pekko 1.0.x builds" failed!

2024-08-27 Thread GitBox
The GitHub Actions job "Run Tests with Pekko 1.0.x builds" on pekko-persistence-cassandra.git has failed. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 13cae031f871a835e269090ef501412c68394096 / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@user

[GH] (pekko-persistence-cassandra): Workflow run "Unit Tests" failed!

2024-08-27 Thread GitBox
The GitHub Actions job "Unit Tests" on pekko-persistence-cassandra.git has failed. Run started by GitHub user mdedetrich (triggered by mdedetrich). Head commit for run: 13cae031f871a835e269090ef501412c68394096 / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.noreply.github.com>

[GH] (pekko-management): Workflow run "Nightly Tests" is working again!

2024-08-27 Thread GitBox
The GitHub Actions job "Nightly Tests" on pekko-management.git has succeeded. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: f752c0bf6aa52dd68593531d2cd371a21086f2fb / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.noreply.github.com> Update

[GH] (pekko): Workflow run "Nightly Builds (1.0)" is working again!

2024-08-27 Thread GitBox
The GitHub Actions job "Nightly Builds (1.0)" on pekko.git has succeeded. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 6945a170ab3f2b17450a3a20006a668390e13758 / PJ Fanning update scaladoc for QueueOfferResult.scala (#1455) * update scaladoc for QueueOff

Re: [PR] Add startup checks [pekko-management]

2024-08-27 Thread via GitHub
pjfanning commented on PR #293: URL: https://github.com/apache/pekko-management/pull/293#issuecomment-2313888623 Conceptually, I think this is fine. Users would need to configure startup checks for the changes to have an effect. So I think we are fine to include these changes in pekk0-manag

Re: [PR] Add startup checks [pekko-management]

2024-08-27 Thread via GitHub
pjfanning commented on code in PR #293: URL: https://github.com/apache/pekko-management/pull/293#discussion_r1733738691 ## management/src/main/scala/org/apache/pekko/management/internal/HealthChecksImpl.scala: ## @@ -47,13 +48,29 @@ final private[pekko] class HealthChecksImpl(sy

[GH] (pekko-management): Workflow run "Unit Tests" failed!

2024-08-27 Thread GitBox
The GitHub Actions job "Unit Tests" on pekko-management.git has failed. Run started by GitHub user Philippus (triggered by pjfanning). Head commit for run: 4383445bfb4f39f0e59ee8137bc2ffe3bbc0f0a2 / philippus Add startup checks Report URL: https://github.com/apache/pekko-management/actions/run

[GH] (pekko-management): Workflow run "MiMa Check" failed!

2024-08-27 Thread GitBox
The GitHub Actions job "MiMa Check" on pekko-management.git has failed. Run started by GitHub user Philippus (triggered by pjfanning). Head commit for run: 4383445bfb4f39f0e59ee8137bc2ffe3bbc0f0a2 / philippus Add startup checks Report URL: https://github.com/apache/pekko-management/actions/run

Re: [PR] feat: streamlined approach for Behaviors #1444 [pekko]

2024-08-27 Thread via GitHub
Roiocam commented on PR #1445: URL: https://github.com/apache/pekko/pull/1445#issuecomment-2312957494 > @Roiocam if this is ready to merge, could I ask for one extra change? It is ready! > Could you add `@since 1.1.0` to the scaladoc on the new methods? done. Thanks

Re: [PR] update scaladoc for QueueOfferResult.scala [pekko]

2024-08-27 Thread via GitHub
pjfanning merged PR #1455: URL: https://github.com/apache/pekko/pull/1455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekk

Re: [PR] release notes for 1.1.0 [pekko]

2024-08-27 Thread via GitHub
pjfanning commented on PR #1456: URL: https://github.com/apache/pekko/pull/1456#issuecomment-2312252003 @mdedetrich does this style work for you? I've repurposed the v1.1.0-M1 docs to be for v1.1.0. I have marked some of the changes as only having arrived since the v1.1.0-M1 release.

Re: [PR] Update aeron-client, aeron-driver to 1.45.0 [pekko]

2024-08-27 Thread via GitHub
pjfanning merged PR #1452: URL: https://github.com/apache/pekko/pull/1452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekk

[GH] (pekko): Workflow run "Scalafmt" is working again!

2024-08-27 Thread GitBox
The GitHub Actions job "Scalafmt" on pekko.git has succeeded. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: ff2677a737a9bc200ab74532328bd2ea9c91a752 / PJ Fanning release notes for 1.1.0 Report URL: https://github.com/apache/pekko/actions/runs/10576427368

[PR] release notes for 1.1.0 [pekko]

2024-08-27 Thread via GitHub
pjfanning opened a new pull request, #1456: URL: https://github.com/apache/pekko/pull/1456 Still some items to add to this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GH] (pekko): Workflow run "Scalafmt" failed!

2024-08-27 Thread GitBox
The GitHub Actions job "Scalafmt" on pekko.git has failed. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 5e91f070447d4f27e6f966ef3a450da7dbd3d9d3 / PJ Fanning update scaladoc for QueueOfferResult.scala Report URL: https://github.com/apache/pekko/actions/r

[PR] update scaladoc for QueueOfferResult.scala [pekko]

2024-08-27 Thread via GitHub
pjfanning opened a new pull request, #1455: URL: https://github.com/apache/pekko/pull/1455 missing `@since` for #1377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] additional mailbox selector for typed props [pekko]

2024-08-27 Thread via GitHub
mdedetrich commented on PR #1096: URL: https://github.com/apache/pekko/pull/1096#issuecomment-2312138579 I will look at it tonight -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] additional mailbox selector for typed props [pekko]

2024-08-27 Thread via GitHub
pjfanning commented on PR #1096: URL: https://github.com/apache/pekko/pull/1096#issuecomment-2312098762 @mdedetrich would you have time to review this? I'm hoping to get the RC for v1.1.0 together in the next few days. -- This is an automated message from the Apache Git Service. To respon

Re: [PR] [DO NOT MERGE] Aeron experiment [pekko]

2024-08-27 Thread via GitHub
pjfanning closed pull request #1454: [DO NOT MERGE] Aeron experiment URL: https://github.com/apache/pekko/pull/1454 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] Add wiretap/wiretapContext to FlowWithContext/SourceWithContext [pekko]

2024-08-27 Thread via GitHub
mdedetrich merged PR #1446: URL: https://github.com/apache/pekko/pull/1446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pek

[PR] [DO NOT MERGE] Aeron experiment [pekko]

2024-08-27 Thread via GitHub
pjfanning opened a new pull request, #1454: URL: https://github.com/apache/pekko/pull/1454 related to #1452 - want to see if the dependency override is really needed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GH] (pekko): Workflow run "Generate doc check" is working again!

2024-08-27 Thread GitBox
The GitHub Actions job "Generate doc check" on pekko.git has succeeded. Run started by GitHub user mdedetrich (triggered by mdedetrich). Head commit for run: 1d42eff64992b565591cb6cf419a10353f69127c / Matthew de Detrich Add wiretap/wiretapContext to FlowWithContext/SourceWithContext Report UR

[GH] (pekko): Workflow run "Pull Requests" is working again!

2024-08-27 Thread GitBox
The GitHub Actions job "Pull Requests" on pekko.git has succeeded. Run started by GitHub user mdedetrich (triggered by mdedetrich). Head commit for run: 1d42eff64992b565591cb6cf419a10353f69127c / Matthew de Detrich Add wiretap/wiretapContext to FlowWithContext/SourceWithContext Report URL: ht

[GH] (pekko): Workflow run "Compile Pekko with Scala 3" is working again!

2024-08-27 Thread GitBox
The GitHub Actions job "Compile Pekko with Scala 3" on pekko.git has succeeded. Run started by GitHub user mdedetrich (triggered by mdedetrich). Head commit for run: 1d42eff64992b565591cb6cf419a10353f69127c / Matthew de Detrich Add wiretap/wiretapContext to FlowWithContext/SourceWithContext R

Re: [PR] Add wiretap/wiretapContext to FlowWithContext/SourceWithContext [pekko]

2024-08-27 Thread via GitHub
mdedetrich commented on code in PR #1446: URL: https://github.com/apache/pekko/pull/1446#discussion_r1732362774 ## docs/src/main/paradox/release-notes/releases-1.1.md: ## @@ -5,6 +5,11 @@ Release notes for Apache Pekko 1.1.0-M1. See [GitHub Milestone](https://github.com/apache

Re: [PR] Add wiretap/wiretapContext to FlowWithContext/SourceWithContext [pekko]

2024-08-27 Thread via GitHub
mdedetrich commented on code in PR #1446: URL: https://github.com/apache/pekko/pull/1446#discussion_r1732360163 ## docs/src/main/paradox/release-notes/releases-1.1.md: ## @@ -5,6 +5,11 @@ Release notes for Apache Pekko 1.1.0-M1. See [GitHub Milestone](https://github.com/apache

Re: [PR] Add wiretap/wiretapContext to FlowWithContext/SourceWithContext [pekko]

2024-08-27 Thread via GitHub
pjfanning commented on code in PR #1446: URL: https://github.com/apache/pekko/pull/1446#discussion_r1732350464 ## docs/src/main/paradox/release-notes/releases-1.1.md: ## @@ -5,6 +5,11 @@ Release notes for Apache Pekko 1.1.0-M1. See [GitHub Milestone](https://github.com/apache/

Re: [PR] Update aeron-client, aeron-driver to 1.46.0 [pekko]

2024-08-27 Thread via GitHub
pjfanning closed pull request #1448: Update aeron-client, aeron-driver to 1.46.0 URL: https://github.com/apache/pekko/pull/1448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Update aeron-client, aeron-driver to 1.46.0 [pekko]

2024-08-27 Thread via GitHub
pjfanning commented on PR #1448: URL: https://github.com/apache/pekko/pull/1448#issuecomment-2311840356 we've pinned to aeron 1.45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com