Re: [PR] Cache output of assembly [incubator-pekko]

2024-02-15 Thread via GitHub
mdedetrich commented on code in PR #1125: URL: https://github.com/apache/incubator-pekko/pull/1125#discussion_r1491966858 ## project/Protobuf.scala: ## @@ -38,7 +38,7 @@ object Protobuf { outputPaths := Seq((Compile / sourceDirectory).value, (Test / sourceDirectory).value)

Re: [PR] Cache output of assembly [incubator-pekko]

2024-02-15 Thread via GitHub
mdedetrich commented on PR #1125: URL: https://github.com/apache/incubator-pekko/pull/1125#issuecomment-1947769555 Thanks for the PR, @Roiocam fyi this is precisely what I was talking about earlier wrt sbt's inbuilt caching functionality -- This is an automated message from the Apache Git

[PR] [jms] close sessions when exceptions happen [incubator-pekko-connectors]

2024-02-15 Thread via GitHub
pjfanning opened a new pull request, #485: URL: https://github.com/apache/incubator-pekko-connectors/pull/485 relates to #484 not sure how straightforward this is to unit test - would probably involve opening up a lot of innards of the code -- This is an automated message from the

[PR] hardcode svg link [incubator-pekko-sbt-paradox]

2024-02-15 Thread via GitHub
pjfanning opened a new pull request, #101: URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/101 see https://github.com/apache/incubator-pekko-http/issues/482 hardcoding fixes the path issues in the github issue above -- This is an automated message from the Apache Git

[I] graphviz errors in scaladocs for 2.12 [incubator-pekko]

2024-02-15 Thread via GitHub
raboof opened a new issue, #1129: URL: https://github.com/apache/incubator-pekko/issues/1129 graphviz produces errors during the generation of embedded svgs in the 2.12 scaladocs. you can reproduce this with e.g. `sbt ++2.12 persistence-tck/doc`. diagnosing by adding `-diagrams

[PR] in TlsActor flush data to user only after handshake has finished [incubator-pekko]

2024-02-15 Thread via GitHub
pjfanning opened a new pull request, #1128: URL: https://github.com/apache/incubator-pekko/pull/1128 relates to https://github.com/apache/incubator-pekko-http/issues/485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use