Re: [PR] chore: Mention how long paradox will took. [incubator-pekko]

mdedetrich commented on code in PR #1007: URL: https://github.com/apache/incubator-pekko/pull/1007#discussion_r1460742661 ## project/PekkoBuild.scala: ## @@ -308,8 +308,8 @@ object PekkoBuild { UsefulTask("sortImports", "Sort the imports"), UsefulTask("mimaRepo

Re: [PR] Simply and cleanup MultiJvm, MultiNode, Copyright in sbt build [incubator-pekko]

mdedetrich commented on code in PR #1005: URL: https://github.com/apache/incubator-pekko/pull/1005#discussion_r1460742167 ## project/CopyrightHeader.scala: ## @@ -11,22 +11,18 @@ * Copyright (C) 2018-2022 Lightbend Inc. */ -import de.heikoseeber

Re: [PR] Simply and cleanup MultiJvm, MultiNode, Copyright in sbt build [incubator-pekko]

He-Pin commented on code in PR #1005: URL: https://github.com/apache/incubator-pekko/pull/1005#discussion_r1460742053 ## project/CopyrightHeader.scala: ## @@ -11,22 +11,18 @@ * Copyright (C) 2018-2022 Lightbend Inc. */ -import de.heikoseeberger.

Re: [PR] Simply and cleanup MultiJvm, MultiNode, Copyright in sbt build [incubator-pekko]

mdedetrich commented on code in PR #1005: URL: https://github.com/apache/incubator-pekko/pull/1005#discussion_r1460741995 ## build.sbt: ## @@ -35,8 +35,6 @@ enablePlugins( UnidocRoot, UnidocWithPrValidation, NoPublish, - CopyrightHeader, - CopyrightHeaderInPr, Scal

Re: [PR] Simply and cleanup MultiJvm, MultiNode, Copyright in sbt build [incubator-pekko]

He-Pin commented on code in PR #1005: URL: https://github.com/apache/incubator-pekko/pull/1005#discussion_r1460741500 ## build.sbt: ## @@ -35,8 +35,6 @@ enablePlugins( UnidocRoot, UnidocWithPrValidation, NoPublish, - CopyrightHeader, - CopyrightHeaderInPr, Scalafix

Re: [PR] Simply and cleanup MultiJvm, MultiNode, Copyright in sbt build [incubator-pekko]

He-Pin commented on PR #1005: URL: https://github.com/apache/incubator-pekko/pull/1005#issuecomment-1902541269 I'm verify it on gitpod, will report back. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] chore: Mention how long paradox will took. [incubator-pekko]

mdedetrich commented on code in PR #1007: URL: https://github.com/apache/incubator-pekko/pull/1007#discussion_r1460738675 ## project/PekkoBuild.scala: ## @@ -308,8 +308,8 @@ object PekkoBuild { UsefulTask("sortImports", "Sort the imports"), UsefulTask("mimaRepo

[PR] chore: Mention how long paradox will took. [incubator-pekko]

He-Pin opened a new pull request, #1007: URL: https://github.com/apache/incubator-pekko/pull/1007 Motivation: Add this because new contributors will know, a Chinese contributor just found this and report back. -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] feat: +Flow.exists & Sink.exists [incubator-pekko]

GreyPlane commented on code in PR #990: URL: https://github.com/apache/incubator-pekko/pull/990#discussion_r1460729901 ## stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/FlowExistsSpec.scala: ## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [I] in pom files, set name to have 'Apache Pekko ...' [incubator-pekko]

laglangyue commented on issue #1006: URL: https://github.com/apache/incubator-pekko/issues/1006#issuecomment-1902531165 > @laglangyue I would hold off a bit as we are trying to verify if we actually need to do this, @pjfanning Has more details. > > If we do end up needing to do this

Re: [I] in pom files, set name to have 'Apache Pekko ...' [incubator-pekko]

mdedetrich commented on issue #1006: URL: https://github.com/apache/incubator-pekko/issues/1006#issuecomment-1902530746 @laglangyue I would hold off a bit as we are trying to verify if we actually need to do this, @pjfanning Has more details. If we do end up needing to do this we wil

Re: [PR] Update sbt-jmh to 0.4.7 [incubator-pekko-http]

He-Pin commented on PR #411: URL: https://github.com/apache/incubator-pekko-http/pull/411#issuecomment-1902530644 @pjfanning I will take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [I] add `source.runPrintln` [incubator-pekko]

He-Pin commented on issue #998: URL: https://github.com/apache/incubator-pekko/issues/998#issuecomment-1902530500 There is a console logger，but you will need to remove it before production too. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [I] in pom files, set name to have 'Apache Pekko ...' [incubator-pekko]

laglangyue commented on issue #1006: URL: https://github.com/apache/incubator-pekko/issues/1006#issuecomment-1902528397 I just gave it a try for demo project, it's ok, I am preparing a PR for pekko ··· publishM2Configuration := publishM2Configuration.value .withOverwrite(t

Re: [I] add `source.runPrintln` [incubator-pekko]

laglangyue commented on issue #998: URL: https://github.com/apache/incubator-pekko/issues/998#issuecomment-1902510530 Due to the lack of agreement from the main members of the community, and scala3 developers can use extends methods. I will close this issue. -- This is an automated m

Re: [I] add `source.runPrintln` [incubator-pekko]

laglangyue closed issue #998: add `source.runPrintln` URL: https://github.com/apache/incubator-pekko/issues/998 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [I] Feature request:Add Sink/Flow.forall operator [incubator-pekko]

laglangyue commented on issue #972: URL: https://github.com/apache/incubator-pekko/issues/972#issuecomment-1902510196 >> could you consider filling in an Apache committee form? I had sended it to secret...@apache.org. it's my form ![image](https://github.com/apache/incubator-pekko

Re: [I] add `source.runPrintln` [incubator-pekko]

mdedetrich commented on issue #998: URL: https://github.com/apache/incubator-pekko/issues/998#issuecomment-1902496508 I an also not a fan of this addition. Printing using `println` is in general a pretty bad idea in production and `println` is hence typicly only used locally as a debugging

Re: [I] add `Source#runHead` , `Source#runLast`,`Source#runIgnore` [incubator-pekko]

laglangyue closed issue #996: add `Source#runHead` , `Source#runLast`,`Source#runIgnore` URL: https://github.com/apache/incubator-pekko/issues/996 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [DRAFT] use ByteString.toArrayUnsafe where it is safe to do so and improves performance [incubator-pekko-http]

laglangyue commented on code in PR #424: URL: https://github.com/apache/incubator-pekko-http/pull/424#discussion_r1460707989 ## http-core/src/main/scala/org/apache/pekko/http/impl/engine/http2/hpack/ByteStringInputStream.scala: ## @@ -28,7 +28,7 @@ private[http2] object ByteStr

Re: [I] add `source.runPrintln` [incubator-pekko]

laglangyue commented on issue #998: URL: https://github.com/apache/incubator-pekko/issues/998#issuecomment-1902483385 > I would like to say ,may be something like zoo's debug, where pekko now already has a .log operator. source.log, longger code than runWith ``` source.log("hel

Re: [PR] Update multi-jvm [incubator-pekko-http]

mdedetrich merged PR #427: URL: https://github.com/apache/incubator-pekko-http/pull/427 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-un

Re: [PR] Update multi-jvm [incubator-pekko-http]

mdedetrich commented on PR #427: URL: https://github.com/apache/incubator-pekko-http/pull/427#issuecomment-1902480347 Ill merge now so we can see a nightly tests run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Update sbt-jmh to 0.4.7 [incubator-pekko-http]

pjfanning commented on PR #411: URL: https://github.com/apache/incubator-pekko-http/pull/411#issuecomment-1902479342 @He-Pin the build here failed - and now the main branch builds will all fail this change breaks the link validator - the link validator conf needs to be updated now

Re: [PR] Update sbt-boilerplate to 0.7.0 [incubator-pekko-http]

He-Pin merged PR #426: URL: https://github.com/apache/incubator-pekko-http/pull/426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubs

Re: [PR] Update sbt-jmh to 0.4.7 [incubator-pekko-http]

He-Pin merged PR #411: URL: https://github.com/apache/incubator-pekko-http/pull/411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubs

Re: [PR] clear warnings in http-core [incubator-pekko-http]

He-Pin commented on PR #115: URL: https://github.com/apache/incubator-pekko-http/pull/115#issuecomment-1902478509 @jrudolph would you mind me merge your changes and push it，or you will do it sometime later? -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] Remove redundant setting of MultiJvm config [incubator-pekko]

mdedetrich commented on code in PR #1005: URL: https://github.com/apache/incubator-pekko/pull/1005#discussion_r1460703994 ## project/ValidatePullRequest.scala: ## @@ -85,7 +85,6 @@ object PekkoValidatePullRequest extends AutoPlugin { */ object MultiNodeWithPrValidation extend

Re: [PR] Update multi-jvm [incubator-pekko-http]

mdedetrich commented on code in PR #427: URL: https://github.com/apache/incubator-pekko-http/pull/427#discussion_r1460703867 ## project/MultiNode.scala: ## @@ -33,7 +33,7 @@ object MultiNode extends AutoPlugin { val multiTest = CliOptions.multiNode.ifTrue(MultiJvm / multiNo

Re: [PR] Remove redundant setting of MultiJvm config [incubator-pekko]

mdedetrich commented on code in PR #1005: URL: https://github.com/apache/incubator-pekko/pull/1005#discussion_r1460703494 ## project/CopyrightHeader.scala: ## @@ -133,5 +133,3 @@ trait CopyrightHeader extends AutoPlugin { } object CopyrightHeader extends CopyrightHeader - -o

Re: [PR] Remove redundant setting of MultiJvm config [incubator-pekko]

mdedetrich commented on code in PR #1005: URL: https://github.com/apache/incubator-pekko/pull/1005#discussion_r1460703494 ## project/CopyrightHeader.scala: ## @@ -133,5 +133,3 @@ trait CopyrightHeader extends AutoPlugin { } object CopyrightHeader extends CopyrightHeader - -o

Re: [PR] Update metrics-core, metrics-jvm to 4.2.24 [incubator-pekko]

He-Pin merged PR #1002: URL: https://github.com/apache/incubator-pekko/pull/1002 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

Re: [PR] Update sbt-boilerplate to 0.7.0 [incubator-pekko]

He-Pin merged PR #1004: URL: https://github.com/apache/incubator-pekko/pull/1004 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

Re: [PR] Update netty-handler, netty-transport to 4.1.106.Final [incubator-pekko]

He-Pin merged PR #1003: URL: https://github.com/apache/incubator-pekko/pull/1003 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

Re: [I] in pom files, set name to have 'Apache Pekko ...' [incubator-pekko]

pjfanning commented on issue #1006: URL: https://github.com/apache/incubator-pekko/issues/1006#issuecomment-1902467786 artifactId must stay as `pekko-stream_3` but the name should be `Apache Pekko Stream` -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] Update multi-jvm [incubator-pekko-http]

mdedetrich commented on code in PR #427: URL: https://github.com/apache/incubator-pekko-http/pull/427#discussion_r1460698610 ## project/MultiNode.scala: ## @@ -33,7 +33,7 @@ object MultiNode extends AutoPlugin { val multiTest = CliOptions.multiNode.ifTrue(MultiJvm / multiNo

Re: [I] in pom files, set name to have 'Apache Pekko ...' [incubator-pekko]

He-Pin commented on issue #1006: URL: https://github.com/apache/incubator-pekko/issues/1006#issuecomment-1902466758 Do you mean the `pekko-stream` should be `apache-pekko-stream`？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] Remove redundant setting of MultiJvm config [incubator-pekko]

mdedetrich commented on PR #1005: URL: https://github.com/apache/incubator-pekko/pull/1005#issuecomment-1902466594 > Lgtm, and will run the multi node sites locally later. When fixing this I came across some other problems, seems like the current sbt build was a bit brittle and the he

[I] in pom files, set name to have 'Apache Pekko ...' [incubator-pekko]

pjfanning opened a new issue, #1006: URL: https://github.com/apache/incubator-pekko/issues/1006 Our poms are generated by sbt and the name in the pom closely matches the artifactId https://repo1.maven.org/maven2/org/apache/pekko/pekko-stream_3/1.0.2/pekko-stream_3-1.0.2.pom S

Re: [PR] Update multi-jvm [incubator-pekko-http]

He-Pin commented on code in PR #427: URL: https://github.com/apache/incubator-pekko-http/pull/427#discussion_r1460697584 ## project/MultiNode.scala: ## @@ -33,7 +33,7 @@ object MultiNode extends AutoPlugin { val multiTest = CliOptions.multiNode.ifTrue(MultiJvm / multiNodeTe

Re: [PR] Update multi-jvm [incubator-pekko-http]

He-Pin commented on code in PR #427: URL: https://github.com/apache/incubator-pekko-http/pull/427#discussion_r1460697670 ## project/MultiNode.scala: ## @@ -33,7 +33,7 @@ object MultiNode extends AutoPlugin { val multiTest = CliOptions.multiNode.ifTrue(MultiJvm / multiNodeTe

Re: [PR] Update multi-jvm [incubator-pekko-http]

mdedetrich commented on code in PR #427: URL: https://github.com/apache/incubator-pekko-http/pull/427#discussion_r1460697161 ## project/MultiNode.scala: ## @@ -33,7 +33,7 @@ object MultiNode extends AutoPlugin { val multiTest = CliOptions.multiNode.ifTrue(MultiJvm / multiNo

Re: [PR] Update multi-jvm [incubator-pekko-http]

mdedetrich commented on code in PR #427: URL: https://github.com/apache/incubator-pekko-http/pull/427#discussion_r1460697161 ## project/MultiNode.scala: ## @@ -33,7 +33,7 @@ object MultiNode extends AutoPlugin { val multiTest = CliOptions.multiNode.ifTrue(MultiJvm / multiNo

Re: [PR] Update multi-jvm [incubator-pekko-http]

He-Pin commented on code in PR #427: URL: https://github.com/apache/incubator-pekko-http/pull/427#discussion_r1460697115 ## project/MultiNode.scala: ## @@ -33,7 +33,7 @@ object MultiNode extends AutoPlugin { val multiTest = CliOptions.multiNode.ifTrue(MultiJvm / multiNodeTe

Re: [PR] Update multi-jvm [incubator-pekko-http]

mdedetrich commented on code in PR #427: URL: https://github.com/apache/incubator-pekko-http/pull/427#discussion_r1460696568 ## project/MultiNode.scala: ## @@ -33,7 +33,7 @@ object MultiNode extends AutoPlugin { val multiTest = CliOptions.multiNode.ifTrue(MultiJvm / multiNo

[PR] Remove redundant setting of MultiJvm config [incubator-pekko]

mdedetrich opened a new pull request, #1005: URL: https://github.com/apache/incubator-pekko/pull/1005 The `.configs(MultiJvm)` is not necessary due to https://github.com/apache/incubator-pekko/blob/main/project/SbtMultiJvm.scala#L83, leaving in the `.configs(MultiJvm)` is likely an oversigh

Re: [PR] [DRAFT] use ByteString.toArrayUnsafe where it is safe to do so and improves performance [incubator-pekko-http]

He-Pin commented on PR #424: URL: https://github.com/apache/incubator-pekko-http/pull/424#issuecomment-1902460862 @pjfanning hah, my bad, I was thinking the `copyToArray`, it's good to go for me. -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] Update sbt-multi-jvm to 0.5.0 [incubator-pekko-http]

mdedetrich commented on PR #425: URL: https://github.com/apache/incubator-pekko-http/pull/425#issuecomment-1902460930 Closed in favour of https://github.com/apache/incubator-pekko-http/pull/427 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Update sbt-multi-jvm to 0.5.0 [incubator-pekko-http]

mdedetrich closed pull request #425: Update sbt-multi-jvm to 0.5.0 URL: https://github.com/apache/incubator-pekko-http/pull/425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Update multi-jvm [incubator-pekko-http]

mdedetrich commented on code in PR #427: URL: https://github.com/apache/incubator-pekko-http/pull/427#discussion_r1460695095 ## build.sbt: ## @@ -243,7 +243,6 @@ lazy val httpTests = project("http-tests") .enablePlugins(NoPublish) // don't release tests .enablePlugins(Mul

Re: [PR] Update multi-jvm [incubator-pekko-http]

mdedetrich commented on code in PR #427: URL: https://github.com/apache/incubator-pekko-http/pull/427#discussion_r1460695095 ## build.sbt: ## @@ -243,7 +243,6 @@ lazy val httpTests = project("http-tests") .enablePlugins(NoPublish) // don't release tests .enablePlugins(Mul

[PR] Update multi-jvm [incubator-pekko-http]

mdedetrich opened a new pull request, #427: URL: https://github.com/apache/incubator-pekko-http/pull/427 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[PR] Update sbt-boilerplate to 0.7.0 [incubator-pekko-http]

scala-steward-asf[bot] opened a new pull request, #426: URL: https://github.com/apache/incubator-pekko-http/pull/426 ## About this PR 📦 Updates io.spray:sbt-boilerplate from `0.6.1` to `0.7.0` ## Usage ✅ **Please merge!** I'll automatically update this PR to resolve confli

[PR] Update sbt-multi-jvm to 0.5.0 [incubator-pekko-http]

scala-steward-asf[bot] opened a new pull request, #425: URL: https://github.com/apache/incubator-pekko-http/pull/425 ## About this PR 📦 Updates com.typesafe.sbt:sbt-multi-jvm from `0.4.0` to `0.5.0` ## Usage ✅ **Please merge!** I'll automatically update this PR to resolve

[PR] Update sbt-boilerplate to 0.7.0 [incubator-pekko]

scala-steward-asf[bot] opened a new pull request, #1004: URL: https://github.com/apache/incubator-pekko/pull/1004 ## About this PR 📦 Updates io.spray:sbt-boilerplate from `0.6.1` to `0.7.0` ## Usage ✅ **Please merge!** I'll automatically update this PR to resolve conflicts

[PR] Update netty-handler, netty-transport to 4.1.106.Final [incubator-pekko]

scala-steward-asf[bot] opened a new pull request, #1003: URL: https://github.com/apache/incubator-pekko/pull/1003 ## About this PR 📦 Updates * [io.netty:netty-handler](https://github.com/netty/netty) * [io.netty:netty-transport](https://github.com/netty/netty) from `4.1.104.

[PR] Update metrics-core, metrics-jvm to 4.2.24 [incubator-pekko]

scala-steward-asf[bot] opened a new pull request, #1002: URL: https://github.com/apache/incubator-pekko/pull/1002 ## About this PR 📦 Updates * [io.dropwizard.metrics:metrics-core](https://github.com/dropwizard/metrics/) * [io.dropwizard.metrics:metrics-jvm](https://github.com/dropw

Re: [PR] [DRAFT] use ByteString.toArrayUnsafe where it is safe to do so and improves performance [incubator-pekko-http]

pjfanning commented on PR #424: URL: https://github.com/apache/incubator-pekko-http/pull/424#issuecomment-1902445465 > It will throw if the byteString is not a Bytestring1c/1 And another problem is when a slice changed the underling bytes, this will cause problem too. ![image](https://pri

Re: [PR] [DRAFT] use ByteString.toArrayUnsafe where it is safe to do so and improves performance [incubator-pekko-http]

He-Pin commented on PR #424: URL: https://github.com/apache/incubator-pekko-http/pull/424#issuecomment-1902439734 It will throw if the byteString is not a Bytestring1c/1  --

Re: [PR] add conf header (#999) [incubator-pekko]

He-Pin merged PR #1000: URL: https://github.com/apache/incubator-pekko/pull/1000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

Re: [I] what to do about file/src/test/resources/nested-sample.tar ? [incubator-pekko-connectors]

mdedetrich commented on issue #320: URL: https://github.com/apache/incubator-pekko-connectors/issues/320#issuecomment-1902380624 @Claudenw My memory is coming back now and I am fairly certain that this file was already reviewed with a fine tooth comb by @justinmclean some time ago and it h

Re: [PR] [DRAFT] use ByteString.toArrayUnsafe where it is safe to do so and improves performance [incubator-pekko-http]

mdedetrich commented on PR #424: URL: https://github.com/apache/incubator-pekko-http/pull/424#issuecomment-1902289640 > @mdedetrich what do you think? It seems to me like this is safe and to be honest, I'm a little surprised that it doesn't work this way already. I am also getting th

[PR] chore: Make use of System.arraycopy directly. [incubator-pekko]

He-Pin opened a new pull request, #1001: URL: https://github.com/apache/incubator-pekko/pull/1001 Motivation: As ByteString is only copy `Array[Byte]`, better to just use `System.arraycopy` Result: Better performance. -- This is an automated message from the Apache Git Servic

Re: [I] what to do about file/src/test/resources/nested-sample.tar ? [incubator-pekko-connectors]

pjfanning commented on issue #320: URL: https://github.com/apache/incubator-pekko-connectors/issues/320#issuecomment-1902276372 > Some of the items I listed can be fixed by adding headers, others I think can be addressed by adding README or other documentation in the directory tree where t

Re: [I] what to do about file/src/test/resources/nested-sample.tar ? [incubator-pekko-connectors]

Claudenw commented on issue #320: URL: https://github.com/apache/incubator-pekko-connectors/issues/320#issuecomment-1902273967 Some of the items I listed can be fixed by adding headers, others I think can be addressed by adding README or other documentation in the directory tree where

Re: [PR] [DRAFT] use ByteString.toArrayUnsafe where it is safe to do so and improves performance [incubator-pekko-http]

He-Pin commented on PR #424: URL: https://github.com/apache/incubator-pekko-http/pull/424#issuecomment-1902273870 @pjfanning If the raw data will not be changed and the endIndx - startIndx == length, seems fine,otherwise better to do a copy. -- This is an automated message from the Apa

Re: [PR] [DRAFT] use ByteString.toArrayUnsafe where it is safe to do so and improves performance [incubator-pekko-http]

pjfanning commented on PR #424: URL: https://github.com/apache/incubator-pekko-http/pull/424#issuecomment-1902271994 I can add a benchmark but first, I'd like to know whether the changes are valid. -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] [DRAFT] use ByteString.toArrayUnsafe where it is safe to do so and improves performance [incubator-pekko-http]

He-Pin commented on PR #424: URL: https://github.com/apache/incubator-pekko-http/pull/424#issuecomment-1902269072 How about with a jmh number? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] what to do about file/src/test/resources/nested-sample.tar ? [incubator-pekko-connectors]

mdedetrich commented on issue #320: URL: https://github.com/apache/incubator-pekko-connectors/issues/320#issuecomment-1902267437 Now I remember, it was a discussion about binary files and this tile was mentioned and we had to demonstrate it wasn't a binary file -- This is an automated me

Re: [PR] performance change to loadCertificates [incubator-pekko-management]

pjfanning merged PR #152: URL: https://github.com/apache/incubator-pekko-management/pull/152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [I] what to do about file/src/test/resources/nested-sample.tar ? [incubator-pekko-connectors]

pjfanning commented on issue #320: URL: https://github.com/apache/incubator-pekko-connectors/issues/320#issuecomment-1902265239 I can't find any previous discussions about this file. I think we have discussed other binary data files in other repos and I think generally, we've been able to

Re: [I] what to do about file/src/test/resources/nested-sample.tar ? [incubator-pekko-connectors]

mdedetrich commented on issue #320: URL: https://github.com/apache/incubator-pekko-connectors/issues/320#issuecomment-1902262943 I swear we had a discussion before about this file and it was resolved, no? -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] [DRAFT] use ByteString.toArrayUnsafe where it is safe to do so and improves performance [incubator-pekko-http]

pjfanning commented on PR #424: URL: https://github.com/apache/incubator-pekko-http/pull/424#issuecomment-1902261923 @mdedetrich what do you think? It seems to me like this is safe and to be honest, I'm a little surprised that it doesn't work this way already. -- This is an automated mes

[PR] add conf header (#999) [incubator-pekko]

pjfanning opened a new pull request, #1000: URL: https://github.com/apache/incubator-pekko/pull/1000 cherry pick 3c7921c66c13d99b01558224082040abb225bc48 #999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [I] add commons-io dependency or cherry pick some code (has more performant code in some cases than built-in java equivalents) [incubator-pekko]

pjfanning commented on issue #994: URL: https://github.com/apache/incubator-pekko/issues/994#issuecomment-1902259779 I have an experimental project where I have the basic classes that we need. https://github.com/pjfanning/io-experiment Still in Java but can theoretically be ported to

Re: [PR] add conf header [incubator-pekko]

pjfanning merged PR #999: URL: https://github.com/apache/incubator-pekko/pull/999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

Re: [I] add toInputStream to ByteString [incubator-pekko]

mdedetrich commented on issue #995: URL: https://github.com/apache/incubator-pekko/issues/995#issuecomment-1902258797 > One problem with adding toInputStream is that we won't be able to use it in pekko-http because we'll want pekko-http to still be able to use pekko-core 1.0.x - and presua

Re: [I] Bug: `java.util.zip.ZipException: duplicate entry: META-INF/MANIFEST.MF` in actor / osgiBundle [incubator-pekko]

He-Pin commented on issue #986: URL: https://github.com/apache/incubator-pekko/issues/986#issuecomment-1902249211 I think it may need `assemblyMergeStrategy` or something like that. @Roiocam I'm using Windows 11. -- This is an automated message from the Apache Git Service. To respond to

Re: [I] add `source.runPrintln` [incubator-pekko]

pjfanning commented on issue #998: URL: https://github.com/apache/incubator-pekko/issues/998#issuecomment-1902240237 I would definitely favour something that logs instead of something that writes directly to System.out. -- This is an automated message from the Apache Git Service. To resp

Re: [I] add commons-io dependency or cherry pick some code (has more performant code in some cases than built-in java equivalents) [incubator-pekko]

pjfanning commented on issue #994: URL: https://github.com/apache/incubator-pekko/issues/994#issuecomment-1902239903 We can't copy the JDK code (incompatible license) but the Spring class looks like a good one - simpler implementation but has the features we need. https://docs.spring.io/sp

Re: [I] add commons-io dependency or cherry pick some code (has more performant code in some cases than built-in java equivalents) [incubator-pekko]

He-Pin commented on issue #994: URL: https://github.com/apache/incubator-pekko/issues/994#issuecomment-1902223169 I have to sat, I was want to port Betty's buffer to pure scala too, so does the jctools. -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [I] add `source.runPrintln` [incubator-pekko]

He-Pin commented on issue #998: URL: https://github.com/apache/incubator-pekko/issues/998#issuecomment-1902214268 I would like to say ,may be something like zoo's debug, where pekko now already has a .log operator. -- This is an automated message from the Apache Git Service. To respond t

Re: [I] add commons-io dependency or cherry pick some code (has more performant code in some cases than built-in java equivalents) [incubator-pekko]

pjfanning commented on issue #994: URL: https://github.com/apache/incubator-pekko/issues/994#issuecomment-1902208410 I'm not against copying the code we need into Pekko. The latest commons-io code has major tentacles. The new builder brings in all sorts of other classes in commons-io. We m

[PR] performance change to loadCertificates [incubator-pekko-management]

pjfanning opened a new pull request, #152: URL: https://github.com/apache/incubator-pekko-management/pull/152 copy change from https://github.com/apache/incubator-pekko/pull/997 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] improve performance in PEM reader [incubator-pekko]

pjfanning merged PR #997: URL: https://github.com/apache/incubator-pekko/pull/997 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

Re: [PR] Unify modules and samples list in markdown source. [incubator-pekko-site]

pjfanning commented on PR #70: URL: https://github.com/apache/incubator-pekko-site/pull/70#issuecomment-1902179116 I don't know about merging this. It is not the same info. I think it is sensible to have 2 pages. I have links in some repo docs to the modules page so removing it will need a

[PR] Unify modules and samples list in markdown source. [incubator-pekko-site]

samueleresca opened a new pull request, #70: URL: https://github.com/apache/incubator-pekko-site/pull/70 Updating `modules.md` and `samples.md` to include the list of modules and samples from the `index.md` -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [I] what to do about file/src/test/resources/nested-sample.tar ? [incubator-pekko-connectors]

pjfanning commented on issue #320: URL: https://github.com/apache/incubator-pekko-connectors/issues/320#issuecomment-1902158920 @Claudenw there is a test that relies on nested-sample.tar. The tar file has a complicated structure and the test wants this. I've read https://www.apache.o

[I] what to do about file/src/test/resources/nested-sample.tar ? [incubator-pekko-connectors]

pjfanning opened a new issue, #320: URL: https://github.com/apache/incubator-pekko-connectors/issues/320 Used in a unit test. * remove the file but then need to rewrite the test to create a temp tar file * document what is in our repo and the source release to highlight that this i

[PR] add conf header [incubator-pekko]

pjfanning opened a new pull request, #999: URL: https://github.com/apache/incubator-pekko/pull/999 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] add warning to init.sh [incubator-pekko-connectors]

pjfanning merged PR #317: URL: https://github.com/apache/incubator-pekko-connectors/pull/317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] add ASF headers to old Alpakka files [incubator-pekko-connectors]

pjfanning merged PR #318: URL: https://github.com/apache/incubator-pekko-connectors/pull/318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] fix mima check [incubator-pekko-connectors]

pjfanning merged PR #319: URL: https://github.com/apache/incubator-pekko-connectors/pull/319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [I] add commons-io dependency or cherry pick some code (has more performant code in some cases than built-in java equivalents) [incubator-pekko]

samueleresca commented on issue #994: URL: https://github.com/apache/incubator-pekko/issues/994#issuecomment-1902131486 Some considerations: - `commons.io` looks great from a vulnerabilities perspective. It seems that the past ~10 releases don't have any vulnerability discovered.

Re: [PR] [pekko-streams] feat: add forall/forallAsync [incubator-pekko]

laglangyue commented on code in PR #989: URL: https://github.com/apache/incubator-pekko/pull/989#discussion_r1460483475 ## stream/src/main/scala/org/apache/pekko/stream/scaladsl/Flow.scala: ## @@ -1792,6 +1792,30 @@ trait FlowOps[+Out, +Mat] { */ def foldAsync[T](zero: T)

Re: [PR] improve performance in PEM reader [incubator-pekko]

pjfanning commented on PR #997: URL: https://github.com/apache/incubator-pekko/pull/997#issuecomment-1902118914 > LGTM，BTW，I took a look at the method above and it seems that it can also be optimized, `org.apache.pekko.remote.artery.tcp.ssl.PemManagersProvider#loadPrivateKey` can use `java

Re: [PR] improve performance in PEM reader [incubator-pekko]

laglangyue commented on PR #997: URL: https://github.com/apache/incubator-pekko/pull/997#issuecomment-1902118336 LGTM，BTW，I took a look at the method above and it seems that it can also be optimized, `org.apache.pekko.remote.artery.tcp.ssl.PemManagersProvider#loadPrivateKey` can use `j

[PR] fix mima check [incubator-pekko-connectors]

pjfanning opened a new pull request, #319: URL: https://github.com/apache/incubator-pekko-connectors/pull/319 broken because 1.0.2-RC1 is only in staging - this issue is probably going to affect us during every release cycle -- This is an automated message from the Apache Git Service. To

Re: [PR] add ASF headers to old Alpakka files [incubator-pekko-connectors]

laglangyue commented on PR #318: URL: https://github.com/apache/incubator-pekko-connectors/pull/318#issuecomment-1902115714 lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] add warning to init.sh [incubator-pekko-connectors]

pjfanning commented on PR #317: URL: https://github.com/apache/incubator-pekko-connectors/pull/317#issuecomment-1902115783 This is mergeable - the build failure is because mima check is broken because the 1.0.2-RC1 is not released - only in staging. -- This is an automated message from t

  1   2   >