Re: [PR] Deprecate facility in the favor of metro [libcloud]

2023-11-10 Thread via GitHub
aayushrangwala commented on code in PR #1971: URL: https://github.com/apache/libcloud/pull/1971#discussion_r1389206639 ## libcloud/compute/drivers/equinixmetal.py: ## @@ -238,7 +235,7 @@ def ex_list_nodes_for_project(self, ex_project_id, include="plan", page=1, per_p r

Re: [PR] Deprecate facility in the favor of metro [libcloud]

2023-11-10 Thread via GitHub
aayushrangwala commented on code in PR #1971: URL: https://github.com/apache/libcloud/pull/1971#discussion_r1389237371 ## libcloud/compute/drivers/equinixmetal.py: ## @@ -491,7 +493,7 @@ def _to_size(self, data): except KeyError: cpus = None region

Re: [PR] chore: Deprecate facility in the favor of metro [libcloud]

2023-11-10 Thread via GitHub
luss commented on PR #1971: URL: https://github.com/apache/libcloud/pull/1971#issuecomment-1806043153 nice i"ll puul this PR into my work area and make sure PR #1970 & PR #1971 are all thats needed to tqeak EqunixMetal back into prime shape. -- This is an automated message from the Apache

Re: [PR] chore: Deprecate facility in the favor of metro [libcloud]

2023-11-10 Thread via GitHub
luss commented on PR #1971: URL: https://github.com/apache/libcloud/pull/1971#issuecomment-1806047785 Also, I agree with @displague that it's cleaner, safer, & simpler to keep each PR small & doing a specifc thing. That's why I started this journey to update the EquinixMetal driver with t

[GH] (libcloud): Workflow run "CI" failed!

2023-11-10 Thread GitBox
The GitHub Actions job "CI" on libcloud.git has failed. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: dfbb5959739870313f4c47de499963a46a23010d / Tomaz Muraus Reformat code with black. Report URL: https://github.com/apache/libcloud/actions/runs/6831178236 With r