[GitHub] [ignite-3] rpuch commented on a diff in pull request #2264: IGNITE-19857 Default zone replica count is not listened by rebalance trigger

2023-06-29 Thread via GitHub
rpuch commented on code in PR #2264: URL: https://github.com/apache/ignite-3/pull/2264#discussion_r1246392370 ## modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/rebalance/DistributionZoneRebalanceEngineTest.java: ## @@ -393,6 +368,72 @@ void

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10798: IGNITE-19675 [IEP-104] Implement WALIterator over ByteBuffer

2023-06-29 Thread via GitHub
sonarcloud[bot] commented on PR #10798: URL: https://github.com/apache/ignite/pull/10798#issuecomment-1612739250 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10817: IGNITE-19878 Restrict possibility to create two caches with the same schemas and index names

2023-06-29 Thread via GitHub
sonarcloud[bot] commented on PR #10817: URL: https://github.com/apache/ignite/pull/10817#issuecomment-1612741955 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] rpuch commented on a diff in pull request #2264: IGNITE-19857 Default zone replica count is not listened by rebalance trigger

2023-06-29 Thread via GitHub
rpuch commented on code in PR #2264: URL: https://github.com/apache/ignite-3/pull/2264#discussion_r1246409461 ## modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/rebalance/DistributionZoneRebalanceEngineTest.java: ## @@ -393,6 +368,72 @@ void

[GitHub] [ignite-3] rpuch commented on a diff in pull request #2263: IGNITE-19843 Unify code that triggers rebalance

2023-06-29 Thread via GitHub
rpuch commented on code in PR #2263: URL: https://github.com/apache/ignite-3/pull/2263#discussion_r1246418299 ## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/DistributionZoneRebalanceEngine.java: ## @@ -153,80 +149,48 @@ public

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10798: IGNITE-19675 [IEP-104] Implement WALIterator over ByteBuffer

2023-06-29 Thread via GitHub
sonarcloud[bot] commented on PR #10798: URL: https://github.com/apache/ignite/pull/10798#issuecomment-1612782476 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2265: IGNITE-19775 Add index builder to TestBuilders

2023-06-29 Thread via GitHub
AMashenkov commented on code in PR #2265: URL: https://github.com/apache/ignite-3/pull/2265#discussion_r1246428850 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/TestClusterTest.java: ## @@ -45,6 +46,12 @@ public class TestClusterTest {

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10817: IGNITE-19878 Restrict possibility to create two caches with the same schemas and index names

2023-06-29 Thread via GitHub
sonarcloud[bot] commented on PR #10817: URL: https://github.com/apache/ignite/pull/10817#issuecomment-1612787732 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10817: IGNITE-19878 Restrict possibility to create two caches with the same schemas and index names

2023-06-29 Thread via GitHub
sonarcloud[bot] commented on PR #10817: URL: https://github.com/apache/ignite/pull/10817#issuecomment-1612805662 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] AMashenkov opened a new pull request, #2267: Enable Catalog feature.

2023-06-29 Thread via GitHub
AMashenkov opened a new pull request, #2267: URL: https://github.com/apache/ignite-3/pull/2267 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [ignite-3] AMashenkov merged pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-29 Thread via GitHub
AMashenkov merged PR #2199: URL: https://github.com/apache/ignite-3/pull/2199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10806: IGNITE-19846 IgniteTxAdapter initial cleanup

2023-06-29 Thread via GitHub
sonarcloud[bot] commented on PR #10806: URL: https://github.com/apache/ignite/pull/10806#issuecomment-1613047691 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite-3] ptupitsyn opened a new pull request, #2268: IGNITE-19826 .NET: Fix partition awareness node ids

2023-06-29 Thread via GitHub
ptupitsyn opened a new pull request, #2268: URL: https://github.com/apache/ignite-3/pull/2268 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10766: IGNITE-19661 Fixed CDC data records logging to WAL for in-memory caches when disabled.

2023-06-29 Thread via GitHub
sonarcloud[bot] commented on PR #10766: URL: https://github.com/apache/ignite/pull/10766#issuecomment-1613120247 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] alex-plekhanov commented on a diff in pull request #10814: IGNITE-19874 GridDhtTxLocal initial cleanup

2023-06-29 Thread via GitHub
alex-plekhanov commented on code in PR #10814: URL: https://github.com/apache/ignite/pull/10814#discussion_r1246578667 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxLocal.java: ## @@ -244,13 +244,6 @@ public void nearFutureId(

[GitHub] [ignite-3] AMashenkov closed pull request #2267: Enable Catalog feature.

2023-06-29 Thread via GitHub
AMashenkov closed pull request #2267: Enable Catalog feature. URL: https://github.com/apache/ignite-3/pull/2267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [ignite] alex-plekhanov commented on a diff in pull request #10814: IGNITE-19874 GridDhtTxLocal initial cleanup

2023-06-29 Thread via GitHub
alex-plekhanov commented on code in PR #10814: URL: https://github.com/apache/ignite/pull/10814#discussion_r1246593358 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxLocal.java: ## @@ -94,7 +94,7 @@ public class GridDhtTxLocal

[GitHub] [ignite-3] zstan commented on pull request #2241: IGNITE-19730 Sql. ExecutionServiceImplTest different tests failed

2023-06-29 Thread via GitHub
zstan commented on PR #2241: URL: https://github.com/apache/ignite-3/pull/2241#issuecomment-1613161296 @korlov42 return error handling, append test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [ignite] anton-vinogradov commented on a diff in pull request #10814: IGNITE-19874 GridDhtTxLocal initial cleanup

2023-06-29 Thread via GitHub
anton-vinogradov commented on code in PR #10814: URL: https://github.com/apache/ignite/pull/10814#discussion_r1246611542 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxLocal.java: ## @@ -244,13 +244,6 @@ public void nearFutureI

[GitHub] [ignite] anton-vinogradov commented on a diff in pull request #10814: IGNITE-19874 GridDhtTxLocal initial cleanup

2023-06-29 Thread via GitHub
anton-vinogradov commented on code in PR #10814: URL: https://github.com/apache/ignite/pull/10814#discussion_r1246612483 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxLocal.java: ## @@ -94,7 +94,7 @@ public class GridDhtTxLoca

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10798: IGNITE-19675 [IEP-104] Implement WALIterator over ByteBuffer

2023-06-29 Thread via GitHub
sonarcloud[bot] commented on PR #10798: URL: https://github.com/apache/ignite/pull/10798#issuecomment-1613192854 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10766: IGNITE-19661 Fixed CDC data records logging to WAL for in-memory caches when disabled.

2023-06-29 Thread via GitHub
sonarcloud[bot] commented on PR #10766: URL: https://github.com/apache/ignite/pull/10766#issuecomment-1613205104 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] lowka commented on pull request #2196: IGNITE-19615: Index is not used while performing SELECT over an indexed column.

2023-06-29 Thread via GitHub
lowka commented on PR #2196: URL: https://github.com/apache/ignite-3/pull/2196#issuecomment-1613217462 * Partially reverted changes, that were made in https://issues.apache.org/jira/browse/IGNITE-19128 and moved type cast checks to TypeUtils. * Added test cases with indexes to ImplicitCa

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10798: IGNITE-19675 [IEP-104] Implement WALIterator over ByteBuffer

2023-06-29 Thread via GitHub
sonarcloud[bot] commented on PR #10798: URL: https://github.com/apache/ignite/pull/10798#issuecomment-1613229822 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] rpuch commented on a diff in pull request #2264: IGNITE-19857 Default zone replica count is not listened by rebalance trigger

2023-06-29 Thread via GitHub
rpuch commented on code in PR #2264: URL: https://github.com/apache/ignite-3/pull/2264#discussion_r1246665166 ## modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/rebalance/DistributionZoneRebalanceEngineTest.java: ## @@ -393,6 +368,72 @@ void

[GitHub] [ignite-extensions] shishkovilja opened a new pull request, #219: IGNITE-18548 Fix AbstractReplicationTest#checkMetrics

2023-06-29 Thread via GitHub
shishkovilja opened a new pull request, #219: URL: https://github.com/apache/ignite-extensions/pull/219 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [ignite] alex-plekhanov commented on a diff in pull request #10814: IGNITE-19874 GridDhtTxLocal initial cleanup

2023-06-29 Thread via GitHub
alex-plekhanov commented on code in PR #10814: URL: https://github.com/apache/ignite/pull/10814#discussion_r1246690399 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxLocal.java: ## @@ -244,13 +244,6 @@ public void nearFutureId(

[GitHub] [ignite] alex-plekhanov commented on a diff in pull request #10814: IGNITE-19874 GridDhtTxLocal initial cleanup

2023-06-29 Thread via GitHub
alex-plekhanov commented on code in PR #10814: URL: https://github.com/apache/ignite/pull/10814#discussion_r1246690399 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxLocal.java: ## @@ -244,13 +244,6 @@ public void nearFutureId(

[GitHub] [ignite] alex-plekhanov commented on a diff in pull request #10814: IGNITE-19874 GridDhtTxLocal initial cleanup

2023-06-29 Thread via GitHub
alex-plekhanov commented on code in PR #10814: URL: https://github.com/apache/ignite/pull/10814#discussion_r1246703196 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxLocal.java: ## @@ -94,7 +94,7 @@ public class GridDhtTxLocal

[GitHub] [ignite-3] rpuch commented on a diff in pull request #2264: IGNITE-19857 Default zone replica count is not listened by rebalance trigger

2023-06-29 Thread via GitHub
rpuch commented on code in PR #2264: URL: https://github.com/apache/ignite-3/pull/2264#discussion_r1246713441 ## modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/rebalance/DistributionZoneRebalanceEngineTest.java: ## @@ -393,6 +368,72 @@ void

[GitHub] [ignite-3] ptupitsyn merged pull request #2268: IGNITE-19826 .NET: Fix partition awareness node ids

2023-06-29 Thread via GitHub
ptupitsyn merged PR #2268: URL: https://github.com/apache/ignite-3/pull/2268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite-3] ibessonov merged pull request #2263: IGNITE-19843 Unify code that triggers rebalance

2023-06-29 Thread via GitHub
ibessonov merged PR #2263: URL: https://github.com/apache/ignite-3/pull/2263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite] anton-vinogradov commented on a diff in pull request #10814: IGNITE-19874 GridDhtTxLocal initial cleanup

2023-06-29 Thread via GitHub
anton-vinogradov commented on code in PR #10814: URL: https://github.com/apache/ignite/pull/10814#discussion_r1246719559 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxLocal.java: ## @@ -244,13 +244,6 @@ public void nearFutureI

[GitHub] [ignite] anton-vinogradov commented on a diff in pull request #10814: IGNITE-19874 GridDhtTxLocal initial cleanup

2023-06-29 Thread via GitHub
anton-vinogradov commented on code in PR #10814: URL: https://github.com/apache/ignite/pull/10814#discussion_r1246719559 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxLocal.java: ## @@ -244,13 +244,6 @@ public void nearFutureI

[GitHub] [ignite] anton-vinogradov commented on a diff in pull request #10814: IGNITE-19874 GridDhtTxLocal initial cleanup

2023-06-29 Thread via GitHub
anton-vinogradov commented on code in PR #10814: URL: https://github.com/apache/ignite/pull/10814#discussion_r1246722538 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTxLocal.java: ## @@ -94,7 +94,7 @@ public class GridDhtTxLoca

[GitHub] [ignite-3] sergey-chugunov-1985 opened a new pull request, #2269: IGNITE-19883 Patch review general checklist added

2023-06-29 Thread via GitHub
sergey-chugunov-1985 opened a new pull request, #2269: URL: https://github.com/apache/ignite-3/pull/2269 https://issues.apache.org/jira/browse/IGNITE-19883 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [ignite-3] ibessonov merged pull request #2239: IGNITE-19199 Propagate safe time when Meta Storage is idle

2023-06-29 Thread via GitHub
ibessonov merged PR #2239: URL: https://github.com/apache/ignite-3/pull/2239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite] NSAmelchev opened a new pull request, #10818: IGNITE-19830 Added a description check if the command argument is enum type.

2023-06-29 Thread via GitHub
NSAmelchev opened a new pull request, #10818: URL: https://github.com/apache/ignite/pull/10818 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ###

[GitHub] [ignite-3] rpuch opened a new pull request, #2270: IGNITE-19885 Simplify handleChangeStableAssignmentEvent in TableManager

2023-06-29 Thread via GitHub
rpuch opened a new pull request, #2270: URL: https://github.com/apache/ignite-3/pull/2270 https://issues.apache.org/jira/browse/IGNITE-19885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10818: IGNITE-19830 Added a description check if the command argument is enum type.

2023-06-29 Thread via GitHub
sonarcloud[bot] commented on PR #10818: URL: https://github.com/apache/ignite/pull/10818#issuecomment-1613352651 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite] alex-plekhanov opened a new pull request, #10819: IGNITE-19814 SQL Calcite: Fix primary key inline size calculation

2023-06-29 Thread via GitHub
alex-plekhanov opened a new pull request, #10819: URL: https://github.com/apache/ignite/pull/10819 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10766: IGNITE-19661 Fixed CDC data records logging to WAL for in-memory caches when disabled.

2023-06-29 Thread via GitHub
sonarcloud[bot] commented on PR #10766: URL: https://github.com/apache/ignite/pull/10766#issuecomment-1613364771 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10819: IGNITE-19814 SQL Calcite: Fix primary key inline size calculation

2023-06-29 Thread via GitHub
sonarcloud[bot] commented on PR #10819: URL: https://github.com/apache/ignite/pull/10819#issuecomment-1613377357 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite] anton-vinogradov merged pull request #10814: IGNITE-19874 GridDhtTxLocal initial cleanup

2023-06-29 Thread via GitHub
anton-vinogradov merged PR #10814: URL: https://github.com/apache/ignite/pull/10814 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubs

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10817: IGNITE-19878 Restrict possibility to create two caches with the same schemas and index names

2023-06-29 Thread via GitHub
sonarcloud[bot] commented on PR #10817: URL: https://github.com/apache/ignite/pull/10817#issuecomment-1613420993 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10818: IGNITE-19830 Added a description check if the command argument is enum type.

2023-06-29 Thread via GitHub
sonarcloud[bot] commented on PR #10818: URL: https://github.com/apache/ignite/pull/10818#issuecomment-1613727486 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10766: IGNITE-19661 Fixed CDC data records logging to WAL for in-memory caches when disabled.

2023-06-29 Thread via GitHub
sonarcloud[bot] commented on PR #10766: URL: https://github.com/apache/ignite/pull/10766#issuecomment-1613814362 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] lowka opened a new pull request, #2271: IGNITE-19862: Revise error codes for SQL module [WIP]

2023-06-29 Thread via GitHub
lowka opened a new pull request, #2271: URL: https://github.com/apache/ignite-3/pull/2271 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2265: IGNITE-19775 Add index builder to TestBuilders

2023-06-29 Thread via GitHub
korlov42 commented on code in PR #2265: URL: https://github.com/apache/ignite-3/pull/2265#discussion_r1247476090 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/TestClusterTest.java: ## @@ -67,4 +74,19 @@ public void testSimpleQuery() {

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2265: IGNITE-19775 Add index builder to TestBuilders

2023-06-29 Thread via GitHub
korlov42 commented on code in PR #2265: URL: https://github.com/apache/ignite-3/pull/2265#discussion_r1247486745 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/TestClusterTest.java: ## @@ -45,6 +46,12 @@ public class TestClusterTest {

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2226: IGNITE-17765 Sql. Introduce cache for parsed statements

2023-06-29 Thread via GitHub
korlov42 commented on code in PR #2226: URL: https://github.com/apache/ignite-3/pull/2226#discussion_r1247496569 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/TestNode.java: ## @@ -203,7 +200,7 @@ public QueryPlan prepare(String query) {

[GitHub] [ignite-3] ibessonov merged pull request #2270: IGNITE-19885 Simplify handleChangeStableAssignmentEvent in TableManager

2023-06-29 Thread via GitHub
ibessonov merged PR #2270: URL: https://github.com/apache/ignite-3/pull/2270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite-3] sanpwc merged pull request #2264: IGNITE-19857 Default zone replica count is not listened by rebalance trigger

2023-06-29 Thread via GitHub
sanpwc merged PR #2264: URL: https://github.com/apache/ignite-3/pull/2264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@igni

[GitHub] [ignite-3] sashapolo opened a new pull request, #2272: IGNITE-19891 Fix Swagger-related compilation warnings

2023-06-29 Thread via GitHub
sashapolo opened a new pull request, #2272: URL: https://github.com/apache/ignite-3/pull/2272 https://issues.apache.org/jira/browse/IGNITE-19891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2241: IGNITE-19730 Sql. ExecutionServiceImplTest different tests failed

2023-06-29 Thread via GitHub
korlov42 commented on code in PR #2241: URL: https://github.com/apache/ignite-3/pull/2241#discussion_r1247506243 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java: ## @@ -838,33 +838,34 @@ private CompletableFuture close(boo

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2241: IGNITE-19730 Sql. ExecutionServiceImplTest different tests failed

2023-06-30 Thread via GitHub
korlov42 commented on code in PR #2241: URL: https://github.com/apache/ignite-3/pull/2241#discussion_r1247515629 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java: ## @@ -838,33 +838,34 @@ private CompletableFuture close(boo

[GitHub] [ignite-3] ibessonov merged pull request #2272: IGNITE-19891 Fix Swagger-related compilation warnings

2023-06-30 Thread via GitHub
ibessonov merged PR #2272: URL: https://github.com/apache/ignite-3/pull/2272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2196: IGNITE-19615: Index is not used while performing SELECT over an indexed column.

2023-06-30 Thread via GitHub
korlov42 commented on code in PR #2196: URL: https://github.com/apache/ignite-3/pull/2196#discussion_r1247545689 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/TypeUtils.java: ## @@ -533,6 +535,55 @@ public static NativeType columnType2NativeType(

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2196: IGNITE-19615: Index is not used while performing SELECT over an indexed column.

2023-06-30 Thread via GitHub
korlov42 commented on code in PR #2196: URL: https://github.com/apache/ignite-3/pull/2196#discussion_r1247547914 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/TypeUtils.java: ## @@ -533,6 +535,55 @@ public static NativeType columnType2NativeType(

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2196: IGNITE-19615: Index is not used while performing SELECT over an indexed column.

2023-06-30 Thread via GitHub
korlov42 commented on code in PR #2196: URL: https://github.com/apache/ignite-3/pull/2196#discussion_r1247553130 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/TypeUtils.java: ## @@ -533,6 +535,55 @@ public static NativeType columnType2NativeType(

[GitHub] [ignite-3] lowka commented on a diff in pull request #2196: IGNITE-19615: Index is not used while performing SELECT over an indexed column.

2023-06-30 Thread via GitHub
lowka commented on code in PR #2196: URL: https://github.com/apache/ignite-3/pull/2196#discussion_r1247555482 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/TypeUtils.java: ## @@ -533,6 +535,55 @@ public static NativeType columnType2NativeType(Col

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2196: IGNITE-19615: Index is not used while performing SELECT over an indexed column.

2023-06-30 Thread via GitHub
korlov42 commented on code in PR #2196: URL: https://github.com/apache/ignite-3/pull/2196#discussion_r1247560089 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/TypeUtils.java: ## @@ -533,6 +535,55 @@ public static NativeType columnType2NativeType(

[GitHub] [ignite-3] isapego commented on a diff in pull request #2256: IGNITE-19666 Remove nullmaps from binary tuples

2023-06-30 Thread via GitHub
isapego commented on code in PR #2256: URL: https://github.com/apache/ignite-3/pull/2256#discussion_r1247578481 ## modules/platforms/cpp/ignite/tuple/binary_tuple_builder.cpp: ## @@ -66,44 +66,39 @@ binary_tuple_builder::binary_tuple_builder(tuple_num_t element_count) noexcept

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2226: IGNITE-17765 Sql. Introduce cache for parsed statements

2023-06-30 Thread via GitHub
AMashenkov commented on code in PR #2226: URL: https://github.com/apache/ignite-3/pull/2226#discussion_r1247616907 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/TestNode.java: ## @@ -203,7 +200,7 @@ public QueryPlan prepare(String query) {

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2226: IGNITE-17765 Sql. Introduce cache for parsed statements

2023-06-30 Thread via GitHub
AMashenkov commented on code in PR #2226: URL: https://github.com/apache/ignite-3/pull/2226#discussion_r1247616907 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/TestNode.java: ## @@ -203,7 +200,7 @@ public QueryPlan prepare(String query) {

[GitHub] [ignite-3] ibessonov opened a new pull request, #2273: IGNITE-15568 Implement batch log updates for RAFT.

2023-06-30 Thread via GitHub
ibessonov opened a new pull request, #2273: URL: https://github.com/apache/ignite-3/pull/2273 https://issues.apache.org/jira/browse/IGNITE-15568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [ignite-3] AMashenkov opened a new pull request, #2274: IGNITE-19892 Fix catalog module dependencies

2023-06-30 Thread via GitHub
AMashenkov opened a new pull request, #2274: URL: https://github.com/apache/ignite-3/pull/2274 https://issues.apache.org/jira/browse/IGNITE-19892 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [ignite-3] lowka commented on a diff in pull request #2196: IGNITE-19615: Index is not used while performing SELECT over an indexed column.

2023-06-30 Thread via GitHub
lowka commented on code in PR #2196: URL: https://github.com/apache/ignite-3/pull/2196#discussion_r1247659288 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/TypeUtils.java: ## @@ -533,6 +535,55 @@ public static NativeType columnType2NativeType(Col

[GitHub] [ignite-3] AMashenkov commented on pull request #2274: IGNITE-19892 Fix catalog module dependencies

2023-06-30 Thread via GitHub
AMashenkov commented on PR #2274: URL: https://github.com/apache/ignite-3/pull/2274#issuecomment-1614390750 This refactoring is required to pass CatalogManager into various components, which should subscribe to catalog events. As for now, I've no clue how to resolve few weird dependen

[GitHub] [ignite-3] SammyVimes commented on a diff in pull request #2256: IGNITE-19666 Remove nullmaps from binary tuples

2023-06-30 Thread via GitHub
SammyVimes commented on code in PR #2256: URL: https://github.com/apache/ignite-3/pull/2256#discussion_r1247497159 ## modules/binary-tuple/src/main/java/org/apache/ignite/internal/binarytuple/BinaryTupleBuilder.java: ## @@ -754,8 +669,26 @@ private void putBytes(byte[] bytes) {

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10806: IGNITE-19846 IgniteTxAdapter initial cleanup

2023-06-30 Thread via GitHub
sonarcloud[bot] commented on PR #10806: URL: https://github.com/apache/ignite/pull/10806#issuecomment-1614477871 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite] anton-vinogradov merged pull request #10806: IGNITE-19846 IgniteTxAdapter initial cleanup

2023-06-30 Thread via GitHub
anton-vinogradov merged PR #10806: URL: https://github.com/apache/ignite/pull/10806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubs

[GitHub] [ignite-3] ademakov commented on a diff in pull request #2256: IGNITE-19666 Remove nullmaps from binary tuples

2023-06-30 Thread via GitHub
ademakov commented on code in PR #2256: URL: https://github.com/apache/ignite-3/pull/2256#discussion_r1247745262 ## modules/binary-tuple/src/main/java/org/apache/ignite/internal/binarytuple/BinaryTupleParser.java: ## @@ -551,7 +512,16 @@ private int getOffset(int index) { }

[GitHub] [ignite-3] ademakov commented on a diff in pull request #2256: IGNITE-19666 Remove nullmaps from binary tuples

2023-06-30 Thread via GitHub
ademakov commented on code in PR #2256: URL: https://github.com/apache/ignite-3/pull/2256#discussion_r1247754224 ## modules/binary-tuple/src/main/java/org/apache/ignite/internal/binarytuple/BinaryTupleBuilder.java: ## @@ -754,8 +669,26 @@ private void putBytes(byte[] bytes) {

[GitHub] [ignite-3] zstan opened a new pull request, #2275: IGNITE-19644 Change DROP|ADD COLUMN IF (NOT) EXISTS syntax

2023-06-30 Thread via GitHub
zstan opened a new pull request, #2275: URL: https://github.com/apache/ignite-3/pull/2275 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[GitHub] [ignite-3] AMashenkov closed pull request #2192: IGNITE-17765 Sql. Introduce cache for parsed statements

2023-06-30 Thread via GitHub
AMashenkov closed pull request #2192: IGNITE-17765 Sql. Introduce cache for parsed statements URL: https://github.com/apache/ignite-3/pull/2192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [ignite] anton-vinogradov merged pull request #10815: IGNITE-19875 GridDhtTxLocalAdapter initial cleanup

2023-06-30 Thread via GitHub
anton-vinogradov merged PR #10815: URL: https://github.com/apache/ignite/pull/10815 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubs

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10817: IGNITE-19878 Restrict possibility to create two caches with the same schemas and index names

2023-06-30 Thread via GitHub
sonarcloud[bot] commented on PR #10817: URL: https://github.com/apache/ignite/pull/10817#issuecomment-1614535495 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] xtern commented on a diff in pull request #10817: IGNITE-19878 Restrict possibility to create two caches with the same schemas and index names

2023-06-30 Thread via GitHub
xtern commented on code in PR #10817: URL: https://github.com/apache/ignite/pull/10817#discussion_r1247775581 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/ClusterCachesInfo.java: ## @@ -1086,33 +1088,42 @@ private boolean processStartNewCacheRequest(

[GitHub] [ignite-3] zstan commented on pull request #2275: IGNITE-19644 Change DROP|ADD COLUMN IF (NOT) EXISTS syntax

2023-06-30 Thread via GitHub
zstan commented on PR #2275: URL: https://github.com/apache/ignite-3/pull/2275#issuecomment-1614570347 @AMashenkov can u make a review plz ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10817: IGNITE-19878 Restrict possibility to create two caches with the same schemas and index names

2023-06-30 Thread via GitHub
sonarcloud[bot] commented on PR #10817: URL: https://github.com/apache/ignite/pull/10817#issuecomment-1614585344 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] anton-vinogradov merged pull request #10813: IGNITE-19873 GridNearTxLocal initial cleanup

2023-06-30 Thread via GitHub
anton-vinogradov merged PR #10813: URL: https://github.com/apache/ignite/pull/10813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubs

[GitHub] [ignite] alex-plekhanov commented on a diff in pull request #10788: IGNITE-19725 SQL Calclite: Implement local flag support

2023-06-30 Thread via GitHub
alex-plekhanov commented on code in PR #10788: URL: https://github.com/apache/ignite/pull/10788#discussion_r1247786319 ## modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/rule/LogicalScanConverterRule.java: ## @@ -125,7 +132,13 @@ public abstract

[GitHub] [ignite] yurinaryshkin commented on a diff in pull request #10812: IGNITE-19872 IgniteTxLocalAdapter initial cleanup

2023-06-30 Thread via GitHub
yurinaryshkin commented on code in PR #10812: URL: https://github.com/apache/ignite/pull/10812#discussion_r1247835354 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTxLocal.java: ## @@ -4493,8 +4493,14 @@ public IgniteInternal

[GitHub] [ignite] zstan commented on pull request #10817: IGNITE-19878 Restrict possibility to create two caches with the same schemas and index names

2023-06-30 Thread via GitHub
zstan commented on PR #10817: URL: https://github.com/apache/ignite/pull/10817#issuecomment-1614624001 @xtern thanks a lot ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [ignite] anton-vinogradov merged pull request #10812: IGNITE-19872 IgniteTxLocalAdapter initial cleanup

2023-06-30 Thread via GitHub
anton-vinogradov merged PR #10812: URL: https://github.com/apache/ignite/pull/10812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubs

[GitHub] [ignite-3] SammyVimes commented on a diff in pull request #2256: IGNITE-19666 Remove nullmaps from binary tuples

2023-06-30 Thread via GitHub
SammyVimes commented on code in PR #2256: URL: https://github.com/apache/ignite-3/pull/2256#discussion_r1247849982 ## modules/binary-tuple/src/main/java/org/apache/ignite/internal/binarytuple/BinaryTupleParser.java: ## @@ -551,7 +512,16 @@ private int getOffset(int index) {

[GitHub] [ignite-3] SammyVimes commented on a diff in pull request #2256: IGNITE-19666 Remove nullmaps from binary tuples

2023-06-30 Thread via GitHub
SammyVimes commented on code in PR #2256: URL: https://github.com/apache/ignite-3/pull/2256#discussion_r1247850508 ## modules/binary-tuple/src/main/java/org/apache/ignite/internal/binarytuple/BinaryTupleBuilder.java: ## @@ -754,8 +669,26 @@ private void putBytes(byte[] bytes) {

[GitHub] [ignite-3] SammyVimes merged pull request #2256: IGNITE-19666 Remove nullmaps from binary tuples

2023-06-30 Thread via GitHub
SammyVimes merged PR #2256: URL: https://github.com/apache/ignite-3/pull/2256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [ignite-extensions] sdarlington opened a new pull request, #220: IGNITE-19899 Use autoconfigure scheme for SpringBoot 2.7+

2023-06-30 Thread via GitHub
sdarlington opened a new pull request, #220: URL: https://github.com/apache/ignite-extensions/pull/220 SpringBoot 2.7 uses a different way of finding extensions. This leaves the old method intact but allows the autoconfigurer to work with versions 2.7 and 3.x. -- This is an automated mes

[GitHub] [ignite-3] lowka commented on a diff in pull request #2275: IGNITE-19644 Change DROP|ADD COLUMN IF (NOT) EXISTS syntax

2023-06-30 Thread via GitHub
lowka commented on code in PR #2275: URL: https://github.com/apache/ignite-3/pull/2275#discussion_r1248100317 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/internal/InternalSchemaTest.java: ## @@ -93,12 +92,23 @@ public void testDropColumns() {

[GitHub] [ignite] NSAmelchev opened a new pull request, #10820: IGNITE-19034 Added snapshot check status

2023-06-30 Thread via GitHub
NSAmelchev opened a new pull request, #10820: URL: https://github.com/apache/ignite/pull/10820 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ###

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10820: IGNITE-19034 Added snapshot check status

2023-06-30 Thread via GitHub
sonarcloud[bot] commented on PR #10820: URL: https://github.com/apache/ignite/pull/10820#issuecomment-1615096315 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10820: IGNITE-19034 Added snapshot check status

2023-06-30 Thread via GitHub
sonarcloud[bot] commented on PR #10820: URL: https://github.com/apache/ignite/pull/10820#issuecomment-1615162808 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10820: IGNITE-19034 Added snapshot check status

2023-07-01 Thread via GitHub
sonarcloud[bot] commented on PR #10820: URL: https://github.com/apache/ignite/pull/10820#issuecomment-1615901293 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10820: IGNITE-19034 Added snapshot check status

2023-07-01 Thread via GitHub
sonarcloud[bot] commented on PR #10820: URL: https://github.com/apache/ignite/pull/10820#issuecomment-1615952324 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] cristiano-belloni opened a new issue, #10821: Publish ignite-nodejs-thin-client at version 1.1.0 on npm

2023-07-01 Thread via GitHub
cristiano-belloni opened a new issue, #10821: URL: https://github.com/apache/ignite/issues/10821 It looks like ignite-nodejs-thin-client@1.1.0 supports Typescript but has never been published on npmjs.org, despite being 2 years old. Could you please do it so we can use Typescript support in

[GitHub] [ignite-3] ptupitsyn commented on pull request #2256: IGNITE-19666 Remove nullmaps from binary tuples

2023-07-02 Thread via GitHub
ptupitsyn commented on PR #2256: URL: https://github.com/apache/ignite-3/pull/2256#issuecomment-1617275595 @SammyVimes please make sure to include extended commit message details when merging PRs: 1. Copy the PR description (if there is anything meaningful). 2. Include `Co-authored-by:

[GitHub] [ignite-3] ptupitsyn opened a new pull request, #2276: IGNITE-19827 Java client: fix partition awareness node ids

2023-07-02 Thread via GitHub
ptupitsyn opened a new pull request, #2276: URL: https://github.com/apache/ignite-3/pull/2276 There was a confusion between *Local Node ID* (`protocolContext().clusterNode().id()`) and *Consistent Node ID* (which is the same as Node Name, comes from `protocolContext().clusterNode().name()`)

[GitHub] [ignite-3] ptupitsyn opened a new pull request, #2277: IGNITE-19808 .NET: Fix TestHandshakesFailedTimeout flakiness

2023-07-02 Thread via GitHub
ptupitsyn opened a new pull request, #2277: URL: https://github.com/apache/ignite-3/pull/2277 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

<    5   6   7   8   9   10   11   12   13   14   >