sonarcloud[bot] commented on PR #10775:
URL: https://github.com/apache/ignite/pull/10775#issuecomment-1607847782
SonarCloud Quality Gate failed. [ under
isapego merged PR #2257:
URL: https://github.com/apache/ignite-3/pull/2257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ign
tkalkirill commented on code in PR #2237:
URL: https://github.com/apache/ignite-3/pull/2237#discussion_r1243214953
##
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java:
##
@@ -170,6 +172,12 @@ public class Roc
sk0x50 commented on code in PR #2225:
URL: https://github.com/apache/ignite-3/pull/2225#discussion_r1243236656
##
modules/api/src/main/java/org/apache/ignite/lang/IgniteExceptionMapperUtil.java:
##
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
xtern commented on code in PR #2226:
URL: https://github.com/apache/ignite-3/pull/2226#discussion_r1241091906
##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/PrepareServiceImpl.java:
##
@@ -141,8 +164,59 @@ public void stop() throws Exception {
SammyVimes commented on code in PR #2237:
URL: https://github.com/apache/ignite-3/pull/2237#discussion_r1243268301
##
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java:
##
@@ -311,6 +318,12 @@ protected void c
SammyVimes commented on code in PR #2237:
URL: https://github.com/apache/ignite-3/pull/2237#discussion_r1243273689
##
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java:
##
@@ -170,6 +172,12 @@ public class Roc
vldpyatkov opened a new pull request, #2258:
URL: https://github.com/apache/ignite-3/pull/2258
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
sanpwc commented on code in PR #2225:
URL: https://github.com/apache/ignite-3/pull/2225#discussion_r1243283024
##
modules/api/src/main/java/org/apache/ignite/lang/IgniteExceptionMapperUtil.java:
##
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
alievmirza opened a new pull request, #2259:
URL: https://github.com/apache/ignite-3/pull/2259
https://issues.apache.org/jira/browse/IGNITE-19688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
xtern commented on code in PR #2226:
URL: https://github.com/apache/ignite-3/pull/2226#discussion_r1243296683
##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/PrepareService.java:
##
@@ -29,5 +29,5 @@ public interface PrepareService extends Lifec
xtern commented on code in PR #2226:
URL: https://github.com/apache/ignite-3/pull/2226#discussion_r1243298133
##
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/PrepareServiceSelfTest.java:
##
@@ -0,0 +1,273 @@
+/*
+ * Licensed to the Apache Softwa
tkalkirill opened a new pull request, #2260:
URL: https://github.com/apache/ignite-3/pull/2260
https://issues.apache.org/jira/browse/IGNITE-19801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
ibessonov commented on code in PR #2239:
URL: https://github.com/apache/ignite-3/pull/2239#discussion_r1243253962
##
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/time/ClusterTimeImpl.java:
##
@@ -119,48 +146,81 @@ public void updateSafeTime(Hyb
sk0x50 merged PR #2201:
URL: https://github.com/apache/ignite-3/pull/2201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@igni
tkalkirill opened a new pull request, #2261:
URL: https://github.com/apache/ignite-3/pull/2261
https://issues.apache.org/jira/browse/IGNITE-19851
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
ibessonov commented on code in PR #2261:
URL: https://github.com/apache/ignite-3/pull/2261#discussion_r1243365841
##
modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/MetaStorageManager.java:
##
@@ -216,4 +216,10 @@ public interface MetaStorageManager
PakhomovAlexander commented on code in PR #2238:
URL: https://github.com/apache/ignite-3/pull/2238#discussion_r124338
##
modules/code-deployment/src/main/java/org/apache/ignite/internal/deployunit/metastore/DeploymentUnitFailover.java:
##
@@ -113,12 +116,43 @@ private void p
PakhomovAlexander merged PR #2250:
URL: https://github.com/apache/ignite-3/pull/2250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsub
sonarcloud[bot] commented on PR #10762:
URL: https://github.com/apache/ignite/pull/10762#issuecomment-1609121571
SonarCloud Quality Gate failed. [ {
PakhomovAlexander merged PR #2238:
URL: https://github.com/apache/ignite-3/pull/2238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsub
SammyVimes commented on code in PR #2249:
URL: https://github.com/apache/ignite-3/pull/2249#discussion_r1243549222
##
modules/network/src/main/java/org/apache/ignite/internal/network/direct/stream/DirectByteBufferStreamImplV1.java:
##
@@ -188,7 +188,7 @@ public void setBuffer(By
vshipb opened a new pull request, #10808:
URL: https://github.com/apache/ignite/pull/10808
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
ibessonov commented on code in PR #2249:
URL: https://github.com/apache/ignite-3/pull/2249#discussion_r1243598564
##
modules/raft/src/main/java/org/apache/ignite/raft/jraft/entity/codec/v1/V1Decoder.java:
##
@@ -51,98 +52,127 @@ public LogEntry decode(final byte[] content) {
ibessonov commented on code in PR #2249:
URL: https://github.com/apache/ignite-3/pull/2249#discussion_r1243598274
##
modules/raft/src/main/java/org/apache/ignite/raft/jraft/entity/codec/v1/V1Decoder.java:
##
@@ -51,98 +52,127 @@ public LogEntry decode(final byte[] content) {
SammyVimes commented on code in PR #2249:
URL: https://github.com/apache/ignite-3/pull/2249#discussion_r1243605813
##
modules/raft/src/main/java/org/apache/ignite/raft/jraft/entity/codec/v1/V1Encoder.java:
##
@@ -46,130 +48,137 @@ public byte[] encode(final LogEntry log) {
tkalkirill commented on code in PR #2261:
URL: https://github.com/apache/ignite-3/pull/2261#discussion_r1243613403
##
modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/MetaStorageManager.java:
##
@@ -216,4 +216,10 @@ public interface MetaStorageManager
tkalkirill commented on code in PR #2261:
URL: https://github.com/apache/ignite-3/pull/2261#discussion_r1243613669
##
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/impl/MetaStorageManagerImpl.java:
##
@@ -671,7 +677,9 @@ private CompletableFuture
onRe
tkalkirill commented on code in PR #2261:
URL: https://github.com/apache/ignite-3/pull/2261#discussion_r1243614330
##
modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java:
##
@@ -454,7 +454,7 @@ public class IgniteImpl implements Ignite {
);
zstan commented on PR #2241:
URL: https://github.com/apache/ignite-3/pull/2241#issuecomment-1609355234
@korlov42 tests are not flaky any more, as for me code become a little bit
clear for understanding. can u make a review plz ?
--
This is an automated message from the Apache Git Service.
ibessonov commented on code in PR #2249:
URL: https://github.com/apache/ignite-3/pull/2249#discussion_r1243621688
##
modules/raft/src/main/java/org/apache/ignite/raft/jraft/entity/codec/v1/V1Encoder.java:
##
@@ -46,130 +48,137 @@ public byte[] encode(final LogEntry log) {
sonarcloud[bot] commented on PR #10808:
URL: https://github.com/apache/ignite/pull/10808#issuecomment-1609369964
Kudos, SonarCloud Quality Gate passed! [;
nizhikov merged PR #10808:
URL: https://github.com/apache/ignite/pull/10808
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ig
sonarcloud[bot] commented on PR #10797:
URL: https://github.com/apache/ignite/pull/10797#issuecomment-160937
SonarCloud Quality Gate failed. [ {
Indupa opened a new issue, #10810:
URL: https://github.com/apache/ignite/issues/10810
Hi ,
In our project , ignite is started using "Topshelf" command to run as
windows service by passing JAVA_HOME as one of the Argument.
when i tried to run Apche Ignite 2.15.0 with OpenJDK 17, Its
sanpwc commented on code in PR #2253:
URL: https://github.com/apache/ignite-3/pull/2253#discussion_r1244781559
##
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##
@@ -798,15 +787,81 @@ public CompletableFuture
ptupitsyn commented on issue #10810:
URL: https://github.com/apache/ignite/issues/10810#issuecomment-1610899797
Please do not create duplicate issues:
[10747](https://github.com/apache/ignite/issues/10747)
--
This is an automated message from the Apache Git Service.
To respond to the mess
ptupitsyn closed issue #10810: Apache Ignite 2.15 startup failure with JDK 17
on windows server
URL: https://github.com/apache/ignite/issues/10810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
zstan commented on code in PR #2241:
URL: https://github.com/apache/ignite-3/pull/2241#discussion_r1244802526
##
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItSqlAsynchronousApiTest.java:
##
@@ -690,7 +689,7 @@ public void closeSession() {
sanpwc commented on code in PR #2253:
URL: https://github.com/apache/ignite-3/pull/2253#discussion_r1244814330
##
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##
@@ -798,15 +787,85 @@ public CompletableFuture
alievmirza commented on code in PR #2253:
URL: https://github.com/apache/ignite-3/pull/2253#discussion_r1244830911
##
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##
@@ -798,15 +787,85 @@ public CompletableFu
alievmirza commented on code in PR #2253:
URL: https://github.com/apache/ignite-3/pull/2253#discussion_r1244831217
##
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##
@@ -854,7 +920,7 @@ private void removeTri
zstan commented on code in PR #2241:
URL: https://github.com/apache/ignite-3/pull/2241#discussion_r1244838075
##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java:
##
@@ -888,14 +903,6 @@ private CompletableFuture
awaitFragmen
zstan commented on code in PR #2241:
URL: https://github.com/apache/ignite-3/pull/2241#discussion_r1244838075
##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java:
##
@@ -888,14 +903,6 @@ private CompletableFuture
awaitFragmen
nizhikov merged PR #10809:
URL: https://github.com/apache/ignite/pull/10809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ig
rpuch commented on code in PR #2261:
URL: https://github.com/apache/ignite-3/pull/2261#discussion_r1244805715
##
modules/configuration/src/main/java/org/apache/ignite/internal/configuration/notifications/ConfigurationStorageRevisionListener.java:
##
@@ -24,6 +24,7 @@
*
* Sto
rpuch commented on code in PR #2261:
URL: https://github.com/apache/ignite-3/pull/2261#discussion_r1244842192
##
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/WatchProcessor.java:
##
@@ -158,7 +158,7 @@ private static CompletableFuture
notifyWa
korlov42 commented on code in PR #2241:
URL: https://github.com/apache/ignite-3/pull/2241#discussion_r1244846036
##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java:
##
@@ -888,14 +903,6 @@ private CompletableFuture
awaitFrag
ibessonov commented on code in PR #2261:
URL: https://github.com/apache/ignite-3/pull/2261#discussion_r1244848815
##
modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/MetaStorageManager.java:
##
@@ -222,4 +222,13 @@ public interface MetaStorageManager
ibessonov commented on code in PR #2261:
URL: https://github.com/apache/ignite-3/pull/2261#discussion_r1244852795
##
modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/RevisionUpdateListener.java:
##
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Softw
sonarcloud[bot] commented on PR #10797:
URL: https://github.com/apache/ignite/pull/10797#issuecomment-1610967408
SonarCloud Quality Gate failed. [