SammyVimes commented on code in PR #2266:
URL: https://github.com/apache/ignite-3/pull/2266#discussion_r1252822420
##
modules/runner/src/integrationTest/java/org/apache/ignite/internal/configuration/ItDistributedConfigurationPropertiesTest.java:
##
@@ -228,7 +228,7 @@ void start
zstan commented on code in PR #2279:
URL: https://github.com/apache/ignite-3/pull/2279#discussion_r1252833575
##
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItCommonApiTest.java:
##
@@ -232,7 +232,7 @@ public void testTxStateChangedOnErroneousOp()
asdfgh19 opened a new issue, #10823:
URL: https://github.com/apache/ignite/issues/10823
I created a cache like this IgniteCache. In order to
do upsert, I used EntryProcessor as follows.
EntryProcessor
```java
public class UpsertEntryProcessorV1
implements EntryProc
sanpwc commented on code in PR #2279:
URL: https://github.com/apache/ignite-3/pull/2279#discussion_r1252847240
##
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItCommonApiTest.java:
##
@@ -181,7 +181,7 @@ public void checkTimestampOperations() {
ptupitsyn commented on issue #10823:
URL: https://github.com/apache/ignite/issues/10823#issuecomment-1621472014
> invalid BinarySchema
It is not invalid. If a schema was used once, it has to be stored to
deserialize that object later.
You can try to minimize the number of uniqu
korlov42 merged PR #2280:
URL: https://github.com/apache/ignite-3/pull/2280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ig
yurinaryshkin commented on code in PR #10798:
URL: https://github.com/apache/ignite/pull/10798#discussion_r1252934244
##
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/io/SimpleFileInput.java:
##
@@ -133,8 +133,8 @@ private void clearBuffe
yurinaryshkin commented on code in PR #10798:
URL: https://github.com/apache/ignite/pull/10798#discussion_r1252941894
##
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/ByteBufferWalIterator.java:
##
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the
ptupitsyn opened a new pull request, #2290:
URL: https://github.com/apache/ignite-3/pull/2290
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
sonarcloud[bot] commented on PR #10798:
URL: https://github.com/apache/ignite/pull/10798#issuecomment-1621639854
SonarCloud Quality Gate failed. [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
sonarcloud[bot] commented on PR #10824:
URL: https://github.com/apache/ignite/pull/10824#issuecomment-1622006935
SonarCloud Quality Gate failed. [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
sonarcloud[bot] commented on PR #10824:
URL: https://github.com/apache/ignite/pull/10824#issuecomment-1622388115
SonarCloud Quality Gate failed. [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
AMashenkov commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1254127404
##
modules/core/src/main/java/org/apache/ignite/lang/ErrorGroups.java:
##
@@ -117,92 +117,35 @@ public static class Sql {
/** Session not found error. */
AMashenkov commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1254129402
##
modules/core/src/main/java/org/apache/ignite/lang/ErrorGroups.java:
##
@@ -117,92 +117,35 @@ public static class Sql {
/** Session not found error. */
ptupitsyn opened a new pull request, #2293:
URL: https://github.com/apache/ignite-3/pull/2293
* Make `ClientTableCommon.readTable` async to avoid blocking Netty threads
* Change `IgniteTablesInternal#assignments` to async too
--
This is an automated message from the Apache Git Service.
AMashenkov commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1254129402
##
modules/core/src/main/java/org/apache/ignite/lang/ErrorGroups.java:
##
@@ -117,92 +117,35 @@ public static class Sql {
/** Session not found error. */
AMashenkov commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1254135094
##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java:
##
@@ -311,11 +310,11 @@ private static RuntimeException
AMashenkov commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1254148000
##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/AbstractNode.java:
##
@@ -161,7 +161,7 @@ protected void checkState() throws Exce
AMashenkov commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1254148000
##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/AbstractNode.java:
##
@@ -161,7 +161,7 @@ protected void checkState() throws Exce
AMashenkov commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1254151215
##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/HashAggregateNode.java:
##
@@ -77,11 +75,9 @@ public HashAggregateNode(
AMashenkov commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1254155001
##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/Inbox.java:
##
@@ -365,7 +365,9 @@ private void onNodeLeft0(String nodeName) thro
AMashenkov commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1254155001
##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/Inbox.java:
##
@@ -365,7 +365,9 @@ private void onNodeLeft0(String nodeName) thro
AMashenkov commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1254161133
##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgnitePlanner.java:
##
@@ -264,7 +264,7 @@ public RelRoot expandView(
lowka commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1254162463
##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/HashAggregateNode.java:
##
@@ -77,11 +75,9 @@ public HashAggregateNode(
this.
lowka commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1254169795
##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/HashAggregateNode.java:
##
@@ -77,11 +75,9 @@ public HashAggregateNode(
this.
lowka commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1254169795
##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/HashAggregateNode.java:
##
@@ -77,11 +75,9 @@ public HashAggregateNode(
this.
ibessonov commented on code in PR #2266:
URL: https://github.com/apache/ignite-3/pull/2266#discussion_r1254197799
##
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/impl/MetaStorageManagerImpl.java:
##
@@ -824,19 +830,7 @@ private CompletableFuture
onRe
lowka commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1254221227
##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/Inbox.java:
##
@@ -365,7 +365,9 @@ private void onNodeLeft0(String nodeName) throws Ex
AMashenkov commented on code in PR #2282:
URL: https://github.com/apache/ignite-3/pull/2282#discussion_r1254228854
##
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItSecondaryIndexTest.java:
##
@@ -993,4 +993,60 @@ public void testSaturatedBoundsH
lowka commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1254233871
##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgnitePlanner.java:
##
@@ -264,7 +264,7 @@ public RelRoot expandView(
sqlN
lowka commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1254241840
##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/api/SessionImpl.java:
##
@@ -330,7 +329,13 @@ public Publisher executeBatchReactive(@Nullable
Transac
lowka commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1254250115
##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java:
##
@@ -311,11 +310,11 @@ private static RuntimeException
conve
lowka commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1254250115
##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java:
##
@@ -311,11 +310,11 @@ private static RuntimeException
conve
lowka commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1254251382
##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/AbstractNode.java:
##
@@ -161,7 +161,7 @@ protected void checkState() throws Exception
lowka commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1254253381
##
modules/core/src/main/java/org/apache/ignite/lang/ErrorGroups.java:
##
@@ -117,92 +117,35 @@ public static class Sql {
/** Session not found error. */
lowka commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1254257991
##
modules/core/src/main/java/org/apache/ignite/lang/ErrorGroups.java:
##
@@ -117,92 +117,35 @@ public static class Sql {
/** Session not found error. */
lowka commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1254260378
##
modules/core/src/main/java/org/apache/ignite/lang/ErrorGroups.java:
##
@@ -117,92 +117,35 @@ public static class Sql {
/** Session not found error. */
lowka opened a new pull request, #2294:
URL: https://github.com/apache/ignite-3/pull/2294
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
ptupitsyn merged PR #2293:
URL: https://github.com/apache/ignite-3/pull/2293
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@i
zstan commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1254286874
##
modules/client-handler/src/test/java/org/apache/ignite/client/handler/JdbcQueryEventHandlerImplTest.java:
##
@@ -299,4 +299,13 @@ private long acquireConnectionId() {
sashapolo opened a new pull request, #2295:
URL: https://github.com/apache/ignite-3/pull/2295
https://issues.apache.org/jira/browse/IGNITE-19810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
nizhikov closed pull request #10451: IGNITE-18312 Control script migration to
thin client
URL: https://github.com/apache/ignite/pull/10451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
nizhikov closed pull request #10475: IGNITE-18520 Support stopWarmup command in
thin client
URL: https://github.com/apache/ignite/pull/10475
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
vldpyatkov merged PR #2141:
URL: https://github.com/apache/ignite-3/pull/2141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
alievmirza commented on code in PR #2266:
URL: https://github.com/apache/ignite-3/pull/2266#discussion_r1254364235
##
modules/runner/src/integrationTest/java/org/apache/ignite/internal/distribution/zones/ItDistributionZonesFilterTest.java:
##
@@ -95,6 +96,7 @@ protected int init
alievmirza commented on code in PR #2266:
URL: https://github.com/apache/ignite-3/pull/2266#discussion_r1254364235
##
modules/runner/src/integrationTest/java/org/apache/ignite/internal/distribution/zones/ItDistributionZonesFilterTest.java:
##
@@ -95,6 +96,7 @@ protected int init
lowka commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1254416915
##
modules/client-handler/src/test/java/org/apache/ignite/client/handler/JdbcQueryEventHandlerImplTest.java:
##
@@ -299,4 +299,13 @@ private long acquireConnectionId() {
timoninmaxim opened a new pull request, #169:
URL: https://github.com/apache/ignite-website/pull/169
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
SammyVimes commented on code in PR #2266:
URL: https://github.com/apache/ignite-3/pull/2266#discussion_r1254451413
##
modules/runner/src/integrationTest/java/org/apache/ignite/internal/distribution/zones/ItDistributionZonesFilterTest.java:
##
@@ -95,6 +96,7 @@ protected int init
ptupitsyn commented on code in PR #169:
URL: https://github.com/apache/ignite-website/pull/169#discussion_r1254460274
##
releases/2.14.0/release_notes.html:
##
@@ -47,6 +47,11 @@ Apache Ignite 2.14.0
WARNINGS
+
+Java thin clients retrieves Binary
lowka commented on code in PR #2282:
URL: https://github.com/apache/ignite-3/pull/2282#discussion_r1254483739
##
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItSecondaryIndexTest.java:
##
@@ -993,4 +993,60 @@ public void testSaturatedBoundsHashIn
timoninmaxim opened a new pull request, #10826:
URL: https://github.com/apache/ignite/pull/10826
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
##
alievmirza commented on code in PR #2266:
URL: https://github.com/apache/ignite-3/pull/2266#discussion_r1254514488
##
modules/runner/src/integrationTest/java/org/apache/ignite/internal/distribution/zones/ItDistributionZonesFilterTest.java:
##
@@ -95,6 +96,7 @@ protected int init
timoninmaxim merged PR #169:
URL: https://github.com/apache/ignite-website/pull/169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubs
AMashenkov opened a new pull request, #2296:
URL: https://github.com/apache/ignite-3/pull/2296
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
sonarcloud[bot] commented on PR #10826:
URL: https://github.com/apache/ignite/pull/10826#issuecomment-1623779435
Kudos, SonarCloud Quality Gate passed! [